artes 1.2.26 → 1.2.28

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "artes",
-  "version": "1.2.26",
+  "version": "1.2.28",
   "description": "The simplest way to automate UI and API tests using Cucumber-style steps.",
   "main": "index.js",
   "scripts": {
@@ -23,9 +23,9 @@
     "@faker-js/faker": "9.8.0",
     "@types/node": "22.9.0",
     "ajv": "8.17.1",
-    "allure-commandline": "2.30.0",
-    "allure-cucumberjs": "3.0.5",
-    "allure-js-commons": "3.0.5",
+    "allure-commandline": "2.36.0",
+    "allure-cucumberjs": "3.4.5",
+    "allure-js-commons": "3.4.5",
     "archiver": "^7.0.1",
     "dayjs": "1.11.13",
     "deasync": "^0.1.31",

package/src/helper/controller/elementController.js

@@ -12,7 +12,7 @@ function addElements(newElements) {
 //   return locatorCount ==0 ? false : true;
 // }
 
-function selectorSeperator(element) {
+function selectorSeparator(element) {
   if (typeof element !== "string") return element;
 
   const selector = element?.split("=");
@@ -41,7 +41,7 @@ function selectorSeperator(element) {
 function getSelector(element) {
   const selector =
     elements?.[element]?.selector || elements?.[element] || element;
-  return resolveVariable(selectorSeperator(selector));
+  return resolveVariable(selectorSeparator(selector));
 }
 
 function getElement(element) {

package/src/helper/controller/pomCollector.js

@@ -1,25 +1,53 @@
 const { addElements } = require("./elementController");
 const cucumberConfig = require("../../../cucumber.config");
 const fs = require("fs");
+const path = require("path");
+
+const duplicateWarnings = [];
+const keyRegistry = {};
 
 function pomCollector() {
-  if (fs.existsSync(cucumberConfig.default.pomPath)) {
-    fs.readdir(`${cucumberConfig.default.pomPath}`, (err, files) => {
-      files.forEach((file) => {
-        fs.readFile(
-          `${cucumberConfig.default.pomPath}/${file}`,
-          "utf-8",
-          (err, content) => {
-            try {
-              addElements(JSON.parse(content));
-            } catch (error) {
-              console.log(`Error parsing POM file ${file}:`, error.message);
-            }
-          },
+  const pomPath = cucumberConfig.default.pomPath;
+
+  if (!fs.existsSync(pomPath)) return;
+
+  fs.readdirSync(pomPath).forEach((file) => {
+    const filePath = path.join(pomPath, file);
+
+    let parsed;
+    try {
+      parsed = JSON.parse(fs.readFileSync(filePath, "utf-8"));
+    } catch (error) {
+      console.log(`Error parsing POM file ${file}: ${error.message}`);
+      return;
+    }
+
+    Object.keys(parsed).forEach((key) => {
+      if (keyRegistry[key]) {
+        duplicateWarnings.push(
+          `${key} in ${file} has the same key with ${key} in ${keyRegistry[key]}`
         );
-      });
+      } else {
+        keyRegistry[key] = file;
+      }
     });
-  }
+
+    addElements(parsed);
+  });
+}
+
+function logPomWarnings() {
+  if (duplicateWarnings.length === 0) return;
+
+  console.warn(
+    "\n\x1b[33m[WARNING] POM DUPLICATE KEY WARNINGS:  This may break your tests or cause flaky behavior."
+  ); 
+  
+  duplicateWarnings.forEach((warning) => {
+    console.warn(`- ${warning}`);
+  });
+
+  console.log("\x1b[0m")
 }
 
-module.exports = { pomCollector };
+module.exports = { pomCollector, logPomWarnings };

package/src/hooks/hooks.js

@@ -11,12 +11,14 @@ const {
 const { spawnSync } = require("child_process");
 const { invokeBrowser } = require("../helper/contextManager/browserManager");
 const { invokeRequest } = require("../helper/contextManager/requestManager");
-const { pomCollector } = require("../helper/controller/pomCollector");
+const { pomCollector, logPomWarnings } = require("../helper/controller/pomCollector");
 const cucumberConfig = require("../../cucumber.config");
 const { context } = require("./context");
 const fs = require("fs");
 const path = require("path");
 const { moduleConfig } = require("artes/src/helper/imports/commons");
+require("allure-cucumberjs");
+const allure = require("allure-js-commons");
 
 const statusDir = path.join(process.cwd(), "testsStatus");
 const HTTP_METHODS = ["GET", "HEAD", "POST", "PUT", "PATCH", "DELETE"];
@@ -34,7 +36,7 @@ async function attachResponse(attachFn) {
         ? `${key}:\n${JSON.stringify(value, null, 2)}`
         : `${key}:\n${value}`;
 
-    await attachFn(text, "text/plain");
+    await attachFn(key, text, "text/plain");
   }
 }
 
@@ -132,7 +134,7 @@ AfterStep(async function ({ pickleStep }) {
   }
 
   if (HTTP_METHODS.some((method) => pickleStep.text.includes(method))) {
-    await attachResponse(this.attach);
+    await attachResponse(allure.attachment);
   }
 });
 
@@ -145,24 +147,19 @@ After(async function ({ pickle, result }) {
     cucumberConfig.default.successReport || result?.status !== Status.PASSED;
 
   if (shouldReport & (context.page.url() !== "about:blank")) {
-    const screenshotPath = path.join(
-      "test-results",
-      "visualReport",
-      pickle.name,
-      `${pickle.name}.png`,
+
+    const screenshotBuffer = await context.page.screenshot({ type: "png" });
+
+    await allure.attachment(
+      pickle.name.replaceAll(" ", "_"), 
+      screenshotBuffer,                             
+      "image/png"
     );
 
-    const img = await context.page.screenshot({
-      path: screenshotPath,
-      type: "png",
-    });
-    await this.attach(img, {
-      mediaType: "image/png",
-      fileName: `${pickle.name.replaceAll(" ", "_")}.png`,
-    });
   }
 
   saveTestStatus(result, pickle);
+
   if (cucumberConfig.default.reportWithTrace || cucumberConfig.default.trace) {
     var tracePath = path.join(
       moduleConfig.projectPath,
@@ -175,17 +172,14 @@ After(async function ({ pickle, result }) {
     shouldReport &&
     context.page.url() !== "about:blank"
   ) {
-    await context.browserContext.tracing.stop({
+
+     await context.browserContext.tracing.stop({
       path: tracePath,
     });
 
     if (cucumberConfig.default.reportWithTrace) {
-      const trace = fs.readFileSync(tracePath);
 
-      await this.attach(trace, {
-        mediaType: "application/zip",
-        fileName: `${pickle.name.replace(/\s+/g, "_")}_trace.zip`,
-      });
+      await allure.attachTrace("Trace", tracePath);
 
       if (!cucumberConfig.default.trace) {
         spawnSync(
@@ -202,11 +196,13 @@ After(async function ({ pickle, result }) {
           },
         );
       }
+      
     }
   }
 
-  await attachResponse(this.attach);
-
+  await attachResponse(allure.attachment);
+  context.response = await {}
+  
   await context.page?.close();
   await context.browserContext?.close();
   await context.browser?.close();
@@ -223,15 +219,13 @@ After(async function ({ pickle, result }) {
 
       await new Promise((resolve) => setTimeout(resolve, 1000));
 
-      if (fs.existsSync(videoPath)) {
+     if (fs.existsSync(videoPath)) {
         const webmBuffer = fs.readFileSync(videoPath);
-        await this.attach(webmBuffer, {
-          mediaType: "video/webm",
-          fileName: `${pickle.name.replaceAll(" ", "_")}.webm`,
-        });
+        await allure.attachment("Screenrecord", webmBuffer, "video/webm");
       }
     }
   }
+
 });
 
 AfterAll(async () => {
@@ -256,9 +250,8 @@ AfterAll(async () => {
     });
   }
 
-  if (cucumberConfig.default.testPercentage !== undefined) {
-    const meetsThreshold =
-      successPercentage >= cucumberConfig.default.testPercentage;
+  if (cucumberConfig.default.testPercentage>0) {
+    const meetsThreshold = successPercentage >= cucumberConfig.default.testPercentage;
 
     if (meetsThreshold) {
       console.log(