arkgate 4.6.5 → 4.6.7

package/bin/lib/team-parliament-io.mjs

@@ -34,10 +34,14 @@ export {
   suggestStewards,
 };
 
+/** Kill hung git instead of stalling CI. */
+export const SPAWN_TIMEOUT_MS = 8000;
+
 function runGit(cwd, args) {
   return spawnSync('git', ['-C', cwd, ...args], {
     encoding: 'utf8',
     stdio: ['ignore', 'pipe', 'pipe'],
+    timeout: SPAWN_TIMEOUT_MS,
   });
 }
 
@@ -203,11 +207,30 @@ export function teamCheckRequested(args, config) {
       args.against ||
       args.persona ||
       args.contractSession ||
+      args.updateBaseline ||
       (args.strictMerge && teamStewardsFromConfig(config).length > 0)
   );
 }
 
 export function runTeamPreflight({ root, args, config, policyDelta, teamBase }) {
+  const weakening =
+    policyDelta?.classification === 'weakening' ||
+    policyDelta?.classification === 'judgment-required';
+  if (weakening && !contractSessionFrom(args)) {
+    const message =
+      'Weakening the contract requires --contract-session (and --policy-ack bound to both hashes).';
+    const teamParliament = {
+      deny: true,
+      reasonId: 'steward-only-loosen',
+      message,
+      kinds: ['loosen'],
+    };
+    return {
+      halt: { exitCode: 1, message, teamParliament, fail: true },
+      teamParliament,
+      changedPaths: [],
+    };
+  }
   if (!teamCheckRequested(args, config)) {
     return { halt: null, teamParliament: null, changedPaths: [] };
   }
@@ -301,7 +324,24 @@ export function applyAgainstRatchet({
   };
 }
 
+/** Cheap doctor-path probe: skip git spawns on non-repos (hook-path bench tmpdirs). */
+function gitDirPresent(root) {
+  let dir = path.resolve(root);
+  for (let i = 0; i < 10; i += 1) {
+    try {
+      if (fs.existsSync(path.join(dir, '.git'))) return true;
+    } catch {
+      return false;
+    }
+    const parent = path.dirname(dir);
+    if (parent === dir) break;
+    dir = parent;
+  }
+  return false;
+}
+
 function gitAuthors(root) {
+  if (!gitDirPresent(root)) return [];
   const log = runGit(root, ['log', '--format=%aN<%aE>', '--max-count=300']);
   if (log.status !== 0) return [];
   const ids = [];
@@ -328,11 +368,35 @@ function readCodeowners(root) {
   return [];
 }
 
-/** Advisory only. Never flips a gate. Missing git is honest empty, not green. */
-export function collectStewardNudge(root, config) {
+function gitFirstAddIso(root, relPath) {
+  if (!gitDirPresent(root)) return null;
+  const log = runGit(root, ['log', '--diff-filter=A', '--follow', '--format=%cI', '--', relPath]);
+  if (log.status !== 0) return null;
+  const lines = log.stdout
+    .split('\n')
+    .map((line) => line.trim())
+    .filter(Boolean);
+  return lines.length > 0 ? lines[lines.length - 1] : null;
+}
+
+/** Tooling clock: git first-add of ark.config.json vs injected `now`. Domain never clocks. */
+export function adoptAgeDaysFromGit(root, relPath, now) {
+  const iso = gitFirstAddIso(root, relPath);
+  if (!iso) return { days: null, source: 'unavailable' };
+  const then = Date.parse(iso);
+  const nowMs = now instanceof Date ? now.getTime() : Number(now);
+  if (!Number.isFinite(then) || !Number.isFinite(nowMs)) return { days: null, source: 'unavailable' };
+  return { days: Math.floor((nowMs - then) / 86_400_000), source: 'git-first-add' };
+}
+
+/** Advisory residual. Never flips `valid` / `goal.met`. Missing git is unknown age, not green. */
+export function collectStewardNudge(root, config, options = {}) {
+  const now = options.now instanceof Date ? options.now : options.now != null ? new Date(options.now) : new Date();
+  const age = adoptAgeDaysFromGit(root, options.configRel || 'ark.config.json', now);
   return suggestStewards({
     existingStewards: teamStewardsFromConfig(config),
     gitAuthors: gitAuthors(root),
     codeowners: readCodeowners(root),
+    adoptAgeDays: age.days,
   });
 }

package/bin/lib/team-parliament.mjs

@@ -198,8 +198,9 @@ export function parseCodeownersHandles(text) {
 }
 /**
  * Empty list + several hands → propose owners.
+ * Empty list + grace elapsed or unknown age → unfinished residual (not a new operating mode).
  * Existing list + CODEOWNERS ahead or author count grew → show the gap.
- * Never a gate input. Propose GitHub handles or emails — never git display names. Never auto-remove.
+ * Never a layer / `valid` / `goal.met` input. Propose GitHub handles or emails — never git display names.
  */
 export function suggestStewards(input) {
     const existing = [
@@ -224,7 +225,9 @@ export function suggestStewards(input) {
     ];
     const authorCount = Math.max(uniqueGit.length, fromOwners.length);
     const multiHand = uniqueGit.length >= 2 || fromOwners.length >= 1;
-    const needsStewards = multiHand && existing.length === 0;
+    const age = input.adoptAgeDays;
+    const emptyStewardsPastGrace = existing.length === 0 && (age === null || (typeof age === 'number' && age >= 30));
+    const needsStewards = existing.length === 0 && (multiHand || emptyStewardsPastGrace);
     const missingFromList = fromOwners.filter((id) => !existing.includes(id));
     const teamGrew = existing.length > 0 &&
         fromOwners.length === 0 &&
@@ -238,24 +241,29 @@ export function suggestStewards(input) {
     const named = proposed.map((id) => formatStewardMention(id)).join(', ');
     const listed = existing.map((id) => formatStewardMention(id)).join(', ');
     let ask = '';
-    if (needsStewards) {
+    if (needsStewards && multiHand) {
         ask =
             proposed.length > 0
                 ? `This repo has several people and no stewards. Add ${named} as stewards so only they can loosen the law or grow the baseline? Say yes, or name the GitHub handles or emails.`
                 : 'This repo has several people and no stewards. Who owns ark.config.json? Name GitHub handles or emails for the stewards[] list.';
     }
+    else if (needsStewards) {
+        ask =
+            'No stewards listed. Name GitHub handles or emails for `stewards[]`, or this stays Adapt-or-nudge — not a finished Enforce. `/ark-adopt` asks; it does not invent names.';
+    }
     else if (missingFromList.length > 0) {
         ask = `CODEOWNERS is ahead of stewards[]: add ${missingFromList.map((id) => formatStewardMention(id)).join(', ')}? The current list stays unless you say yes or name the GitHub handles or emails.`;
     }
     else if (teamGrew) {
         ask = `This repo started with ${existing.length} steward(s) (${listed}) and now has ${uniqueGit.length} recent git authors. Who else owns the law? Name GitHub handles or emails, or say the list is still right.`;
     }
-    const shouldAct = needsStewards || drift;
+    const shouldAct = needsStewards || drift || emptyStewardsPastGrace;
     return {
         advisory: true,
         notAScore: true,
         multiHand,
         needsStewards,
+        emptyStewardsPastGrace,
         drift,
         authorCount,
         stewardCount: existing.length,
@@ -266,6 +274,7 @@ export function suggestStewards(input) {
         nextAction: shouldAct
             ? '/ark-adopt (ask, then update stewards[] — do not invent names)'
             : '',
+        adoptAgeDays: typeof age === 'number' ? age : null,
     };
 }
 export function personaCheckBudget(persona) {
@@ -310,7 +319,8 @@ export function isTeamPersona(value) {
 /**
  * Gate for a diff vs the merge base.
  * Contract session still forbids mixing law with product source.
- * Loosen / baseline-grow require a steward when the list is non-empty.
+ * Loosen / baseline-grow require --contract-session even when stewards is empty.
+ * A non-empty list additionally requires a matching listed author.
  */
 export function evaluateTeamGate(input) {
     const kinds = [];
@@ -338,6 +348,16 @@ export function evaluateTeamGate(input) {
     const stewards = input.stewards ?? [];
     const grow = (input.baselineGrowCount ?? 0) > 0;
     const loosen = input.policyKind === 'loosen';
+    if ((loosen || grow) && !input.contractSession) {
+        return {
+            deny: true,
+            reasonId: loosen ? 'steward-only-loosen' : 'steward-only-baseline-grow',
+            message: loosen
+                ? 'Weakening the contract requires --contract-session (and --policy-ack bound to both hashes).'
+                : 'Growing the baseline requires --contract-session. Freeze in a law-only PR.',
+            kinds,
+        };
+    }
     if (stewards.length > 0 && (loosen || grow) && !isSteward(input.author, stewards)) {
         return {
             deny: true,

package/bin/lib/unavailable-analysis.mjs

@@ -45,6 +45,7 @@ export function reportUnavailableAnalysis({
       configWalkedUp: args.configWalkedUp === true,
       parseHealth,
       completeness,
+      all: args.all === true,
     });
     process.exitCode = 2;
     return;