aria-ease 1.2.1 → 1.2.2

package/CONTRIBUTION-GUIDELINES.md

@@ -0,0 +1,21 @@
+# How You Can Contribute
+
+## For new contributors
+
+Create a new branch using format feature e.g add-support-for-input, clean-up-tab-event-listeners e.t.c. That'll be the branch where you can push commits to, and create pull requests from.
+
+## For returning contributors
+
+Open a new issue, as detailed as possible. Fix and test issue locally. Create a pull request to dev branch, and await review and/or merge.
+
+## Contribution Guidelines
+
+Write all functions in type-safe TypeScript.
+
+Test features vigorously, for keyboard and screen reader users.
+
+Algorithms must follow best software practices.
+
+All functions must be JSDoc documented.
+
+All commits must have either format; "fix: fixed event listener perfomance leak" for issues fixing or refactoring, or "build: added ... feature" for creating an entirely new feature that didn't exist before.

package/aria-ease.d.ts

@@ -22,9 +22,6 @@ declare module 'aria-ease' {
      * @param {string} ariaLabel The aria-label to be updated.
      */
     function updateMenuTriggerAriaAttributes(triggerId: string, ariaLabel: string): void;
-
-
-
   
     export { makeMenuAccessible, makeTabAccessible, updateMenuTriggerAriaAttributes };
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "aria-ease",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Out of the box utility accessibility package to develop production ready applications.",
   "main": "index.js",
   "scripts": {

package/src/menu/makeMenuAccessible.ts

@@ -27,6 +27,7 @@ export function makeMenuAccessible(menuId: string, menuItemClass: string): void
         switch(event.key) {
             case 'ArrowUp':
             case 'ArrowLeft':
+                event.preventDefault()
                 if (menuItemIndex === 0) {
                     menuItems.item(menuItems.length - 1).focus();
                 } else {
@@ -35,6 +36,7 @@ export function makeMenuAccessible(menuId: string, menuItemClass: string): void
                 break;
             case 'ArrowDown':
             case 'ArrowRight':
+                event.preventDefault()
                 if (menuItemIndex === menuItems.length - 1) {
                     menuItems.item(0).focus();
                 } else {
@@ -42,6 +44,7 @@ export function makeMenuAccessible(menuId: string, menuItemClass: string): void
                 }
                 break;
             case 'Escape':
+                event.preventDefault();
                 (getComputedStyle(menuDiv).display === 'block') ?
                     triggerButton.click() :
                     null
@@ -49,6 +52,7 @@ export function makeMenuAccessible(menuId: string, menuItemClass: string): void
                 break;
             case 'Enter':
             case ' ':
+                event.preventDefault()
                 if(menuItems.item(menuItemIndex).tagName === 'BUTTON') {
                     menuItems.item(menuItemIndex).click()
                     break;

package/src/tab/makeTabAccessible.ts

@@ -23,6 +23,7 @@ export function makeTabAccessible(tabId: string, tabItemClass: string): void {
         switch(event.key) {
             case 'ArrowUp':
             case 'ArrowLeft':
+                event.preventDefault()
                 if (tabItemIndex === 0) {
                     tabItems.item(tabItems.length - 1).focus();
                 } else {
@@ -31,6 +32,7 @@ export function makeTabAccessible(tabId: string, tabItemClass: string): void {
                 break;
             case 'ArrowDown':
             case 'ArrowRight':
+                event.preventDefault()
                 if (tabItemIndex === tabItems.length - 1) {
                     tabItems.item(0).focus();
                 } else {
@@ -39,6 +41,7 @@ export function makeTabAccessible(tabId: string, tabItemClass: string): void {
                 break;
             case 'Enter':
             case ' ':
+                event.preventDefault()
                 if (tabItems.item(tabItemIndex).type === 'radio') {
                     tabItems.item(tabItemIndex).checked = true
                     break;