argusqa-os 9.6.3 → 9.6.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "argusqa-os",
-  "version": "9.6.3",
+  "version": "9.6.5",
   "mcpName": "io.github.ironclawdevs27/argus",
   "description": "Argus — AI-powered automated dev-testing platform using Chrome DevTools MCP and Claude Code",
   "keywords": [

package/src/cli/pr-validate.js

@@ -123,6 +123,20 @@ export function writeStepSummary(markdown) {
   fs.appendFileSync(summaryPath, markdown);
 }
 
+// ── Preflight reachability check ──────────────────────────────────────────────
+
+async function checkTargetReachable(url) {
+  try {
+    // fetch throws only on network errors (ECONNREFUSED, ETIMEDOUT, DNS failure).
+    // HTTP error status codes (4xx/5xx) still mean the server is up — Argus should
+    // audit those pages, so we only gate on network-level failures.
+    await fetch(url, { method: 'HEAD', signal: AbortSignal.timeout(10000) });
+    return { ok: true };
+  } catch (err) {
+    return { ok: false, error: err.message };
+  }
+}
+
 // ── Route loader ──────────────────────────────────────────────────────────────
 
 async function loadRoutes() {
@@ -217,20 +231,38 @@ async function main() {
 
     console.log(`[argus] Auditing ${affected.length} route(s): ${affected.map(r => r.path).join(', ')}`);
 
-    // Step 3: Connect to Chrome via the chrome-devtools MCP client
+    // Step 3: Verify target is reachable before spending time on Chrome startup
+    console.log(`[argus] Verifying target is reachable: ${targetUrl}`);
+    const reachable = await checkTargetReachable(targetUrl);
+    if (!reachable.ok) {
+      throw new Error(`Target URL not reachable (${targetUrl}): ${reachable.error}. Make sure your app is running and accessible from the runner before this action fires.`);
+    }
+
+    // Step 4: Connect to Chrome via the chrome-devtools MCP client
     console.log('[argus] Connecting to Chrome on port 9222...');
     mcp = await createMcpClient();
     console.log('[argus] Chrome connected.');
 
-    const baseOrigin = new URL(targetUrl).origin;
+    // Step 5: Audit each affected route via crawlRouteCheap
+    // Preserve path prefix (e.g. /project/ in GitHub Pages) — .origin would strip it
+    const baseUrl = targetUrl.replace(/\/$/, '');
+
+    // Normalize route paths — crawlRouteCheap builds URLs via string concat (baseUrl + route.path)
+    // so paths without a leading slash produce malformed URLs like https://example.comlogin
+    const normalizedAffected = affected.map(r => {
+      if (!r.path.startsWith('/')) {
+        console.log(`::warning::Route path "${r.path}" has no leading slash — normalizing to "/${r.path}". Update argus.routes.json to use a leading slash.`);
+        return { ...r, path: `/${r.path}` };
+      }
+      return r;
+    });
 
-    // Step 4: Audit each affected route via crawlRouteCheap
-    for (const route of affected) {
-      const url = new URL(route.path, targetUrl).href;
+    for (const route of normalizedAffected) {
+      const url = `${baseUrl}${route.path}`;
       console.log(`[argus] → Auditing ${url}`);
 
       try {
-        const raw      = await crawlRouteCheap(route, baseOrigin, mcp);
+        const raw      = await crawlRouteCheap(route, baseUrl, mcp);
         const findings = Array.isArray(raw.errors) ? raw.errors : [];
         allFindings.push(...findings);
 
@@ -255,7 +287,19 @@ async function main() {
       }
     }
 
-    // Step 5: Compute aggregate summary and merge-block decision
+    // Guard: if every route failed with an exception, the app was unreachable after
+    // the preflight check (e.g. race condition where app died between check and crawl).
+    // Throwing here causes the step to exit 1, which correctly blocks the merge.
+    const routeFailCount = perRoute.filter(r => r.error).length;
+    if (routeFailCount > 0 && routeFailCount === perRoute.length) {
+      throw new Error(
+        `All ${perRoute.length} route audit(s) failed — Chrome could not reach the app. ` +
+        `Ensure TARGET_DEV_URL is accessible throughout the job. ` +
+        `First error: ${perRoute[0].error}`,
+      );
+    }
+
+    // Step 6: Compute aggregate summary and merge-block decision
     const summary = {
       critical: allFindings.filter(f => f.severity === 'critical').length,
       warning:  allFindings.filter(f => f.severity === 'warning').length,
@@ -267,14 +311,14 @@ async function main() {
       blockOn === 'warning'  ? summary.critical + summary.warning > 0 :
       false;
 
-    // Step 6: Write GitHub Actions outputs and step summary
-    writeGithubOutputs({ blocked, summary, affectedRoutes: affected });
-    writeStepSummary(buildStepSummary({ blocked, summary, affectedRoutes: affected, perRoute, findings: allFindings, changedFiles: files, blockOn }));
+    // Step 7: Write GitHub Actions outputs and step summary
+    writeGithubOutputs({ blocked, summary, affectedRoutes: normalizedAffected });
+    writeStepSummary(buildStepSummary({ blocked, summary, affectedRoutes: normalizedAffected, perRoute, findings: allFindings, changedFiles: files, blockOn }));
 
-    // Step 7: Emit JSON result to stdout for downstream pipeline steps
+    // Step 8: Emit JSON result to stdout for downstream pipeline steps
     const result = {
       prUrl, targetUrl,
-      affectedRoutes: affected.map(r => r.path),
+      affectedRoutes: normalizedAffected.map(r => r.path),
       changedFiles: files,
       findings: allFindings,
       perRoute,

package/src/mcp-server.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 /**
- * Argus MCP Server (v9.6.3)
+ * Argus MCP Server (v9.6.5)
  *
  * Exposes Argus as an MCP server so Claude (or any MCP client) can call
  * argus_audit, argus_audit_full, argus_compare, argus_last_report, and
@@ -447,7 +447,7 @@ async function handleLastReport() {
 // ── Server bootstrap ──────────────────────────────────────────────────────────
 
 const server = new Server(
-  { name: 'argus', version: '9.6.3' },
+  { name: 'argus', version: '9.6.5' },
   { capabilities: { tools: {} } },
 );
 

package/src/utils/mcp-client.js

@@ -133,6 +133,8 @@ export async function createMcpClient() {
     capabilities: {},
     clientInfo: { name: 'argus', version: '1.0.0' },
   });
+  // MCP 2024-11-05 spec: client MUST send this notification before any tool calls
+  proc.stdin.write(JSON.stringify({ jsonrpc: '2.0', method: 'notifications/initialized', params: {} }) + '\n');
 
   /**
    * Call an MCP tool by name with params.