argusqa-os 9.6.2 → 9.6.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "argusqa-os",
-  "version": "9.6.2",
+  "version": "9.6.4",
   "mcpName": "io.github.ironclawdevs27/argus",
   "description": "Argus — AI-powered automated dev-testing platform using Chrome DevTools MCP and Claude Code",
   "keywords": [

package/src/cli/pr-validate.js

@@ -123,6 +123,20 @@ export function writeStepSummary(markdown) {
   fs.appendFileSync(summaryPath, markdown);
 }
 
+// ── Preflight reachability check ──────────────────────────────────────────────
+
+async function checkTargetReachable(url) {
+  try {
+    // fetch throws only on network errors (ECONNREFUSED, ETIMEDOUT, DNS failure).
+    // HTTP error status codes (4xx/5xx) still mean the server is up — Argus should
+    // audit those pages, so we only gate on network-level failures.
+    await fetch(url, { method: 'HEAD', signal: AbortSignal.timeout(10000) });
+    return { ok: true };
+  } catch (err) {
+    return { ok: false, error: err.message };
+  }
+}
+
 // ── Route loader ──────────────────────────────────────────────────────────────
 
 async function loadRoutes() {
@@ -217,20 +231,27 @@ async function main() {
 
     console.log(`[argus] Auditing ${affected.length} route(s): ${affected.map(r => r.path).join(', ')}`);
 
-    // Step 3: Connect to Chrome via the chrome-devtools MCP client
+    // Step 3: Verify target is reachable before spending time on Chrome startup
+    console.log(`[argus] Verifying target is reachable: ${targetUrl}`);
+    const reachable = await checkTargetReachable(targetUrl);
+    if (!reachable.ok) {
+      throw new Error(`Target URL not reachable (${targetUrl}): ${reachable.error}. Make sure your app is running and accessible from the runner before this action fires.`);
+    }
+
+    // Step 4: Connect to Chrome via the chrome-devtools MCP client
     console.log('[argus] Connecting to Chrome on port 9222...');
     mcp = await createMcpClient();
     console.log('[argus] Chrome connected.');
 
-    const baseOrigin = new URL(targetUrl).origin;
-
-    // Step 4: Audit each affected route via crawlRouteCheap
+    // Step 5: Audit each affected route via crawlRouteCheap
+    // Preserve path prefix (e.g. /project/ in GitHub Pages) — .origin would strip it
+    const baseUrl = targetUrl.replace(/\/$/, '');
     for (const route of affected) {
       const url = new URL(route.path, targetUrl).href;
       console.log(`[argus] → Auditing ${url}`);
 
       try {
-        const raw      = await crawlRouteCheap(route, baseOrigin, mcp);
+        const raw      = await crawlRouteCheap(route, baseUrl, mcp);
         const findings = Array.isArray(raw.errors) ? raw.errors : [];
         allFindings.push(...findings);
 
@@ -255,7 +276,7 @@ async function main() {
       }
     }
 
-    // Step 5: Compute aggregate summary and merge-block decision
+    // Step 6: Compute aggregate summary and merge-block decision
     const summary = {
       critical: allFindings.filter(f => f.severity === 'critical').length,
       warning:  allFindings.filter(f => f.severity === 'warning').length,
@@ -267,11 +288,11 @@ async function main() {
       blockOn === 'warning'  ? summary.critical + summary.warning > 0 :
       false;
 
-    // Step 6: Write GitHub Actions outputs and step summary
+    // Step 7: Write GitHub Actions outputs and step summary
     writeGithubOutputs({ blocked, summary, affectedRoutes: affected });
     writeStepSummary(buildStepSummary({ blocked, summary, affectedRoutes: affected, perRoute, findings: allFindings, changedFiles: files, blockOn }));
 
-    // Step 7: Emit JSON result to stdout for downstream pipeline steps
+    // Step 8: Emit JSON result to stdout for downstream pipeline steps
     const result = {
       prUrl, targetUrl,
       affectedRoutes: affected.map(r => r.path),

package/src/mcp-server.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 /**
- * Argus MCP Server (v9.6.2)
+ * Argus MCP Server (v9.6.4)
  *
  * Exposes Argus as an MCP server so Claude (or any MCP client) can call
  * argus_audit, argus_audit_full, argus_compare, argus_last_report, and
@@ -447,7 +447,7 @@ async function handleLastReport() {
 // ── Server bootstrap ──────────────────────────────────────────────────────────
 
 const server = new Server(
-  { name: 'argus', version: '9.6.2' },
+  { name: 'argus', version: '9.6.4' },
   { capabilities: { tools: {} } },
 );
 

package/src/utils/mcp-client.js

@@ -57,7 +57,7 @@ const TOOL_TIMEOUT_MS = parseInt(process.env.MCP_TOOL_TIMEOUT_MS ?? '30000', 10)
 export async function createMcpClient() {
   // On Windows, npx is npx.cmd — shell:true resolves this cross-platform.
   const proc = spawn('npx', [
-    '-y', 'chrome-devtools-mcp@latest',
+    '-y', 'chrome-devtools-mcp@1.1.1',
     `--browser-url=${BROWSER_URL}`,
     '--headless=true',
     '--viewport=1920x1080',
@@ -133,6 +133,8 @@ export async function createMcpClient() {
     capabilities: {},
     clientInfo: { name: 'argus', version: '1.0.0' },
   });
+  // MCP 2024-11-05 spec: client MUST send this notification before any tool calls
+  proc.stdin.write(JSON.stringify({ jsonrpc: '2.0', method: 'notifications/initialized', params: {} }) + '\n');
 
   /**
    * Call an MCP tool by name with params.

package/src/utils/pr-diff-analyzer.js

@@ -36,8 +36,6 @@ export function parsePrUrl(prUrl) {
  */
 export async function fetchPrFiles(prUrl, githubToken) {
   const { owner, repo, prNumber } = parsePrUrl(prUrl);
-  const apiUrl =
-    `https://api.github.com/repos/${owner}/${repo}/pulls/${prNumber}/files?per_page=100`;
   const headers = {
     Accept: 'application/vnd.github+json',
     'X-GitHub-Api-Version': '2022-11-28',
@@ -45,15 +43,41 @@ export async function fetchPrFiles(prUrl, githubToken) {
     ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}),
   };
 
-  const res = await fetch(apiUrl, { headers });
-  if (!res.ok) {
-    const body = await res.text().catch(() => '');
-    throw new Error(`GitHub API ${res.status}: ${body || res.statusText}`);
+  const allFiles = [];
+  const MAX_PAGES = 3; // caps at 300 files; avoids runaway requests on mega-PRs
+
+  for (let page = 1; page <= MAX_PAGES; page++) {
+    const apiUrl = `https://api.github.com/repos/${owner}/${repo}/pulls/${prNumber}/files?per_page=100&page=${page}`;
+    const res = await fetch(apiUrl, { headers });
+    if (!res.ok) {
+      const body = await res.text().catch(() => '');
+      throw new Error(`GitHub API ${res.status}: ${body || res.statusText}`);
+    }
+    const files = await res.json();
+    allFiles.push(...files.map(f => f.filename));
+    if (files.length < 100) break; // last page reached
+  }
+
+  if (allFiles.length >= 300) {
+    console.log('::warning::PR has 300+ changed files — Argus analyzed the first 300. Routes affected by later files may be missed.');
   }
-  const files = await res.json();
-  return files.map(f => f.filename);
+
+  return allFiles;
 }
 
+/**
+ * Files that are never relevant to app routes — CI configs, docs, repo metadata.
+ * Changes to ONLY these files cause mapFilesToRoutes to return [] (skip audit).
+ */
+const EXCLUDED_PATTERNS = [
+  /^\.github\//i,
+  /^docs?\//i,
+  /\.md$/i,
+  /^(LICENSE|CHANGELOG|CONTRIBUTING|CODE_OF_CONDUCT|SECURITY)(\..*)?$/i,
+  /^\.gitignore$/i,
+  /^\.gitattributes$/i,
+];
+
 /**
  * Patterns that indicate an infrastructure-level file whose change can affect
  * every route — framework configs, root layouts, global stylesheets, package.json.
@@ -88,15 +112,22 @@ export function mapFilesToRoutes(changedFiles, routes) {
   if (!routes || routes.length === 0) return [];
   if (!changedFiles || changedFiles.length === 0) return routes;
 
+  // Strip files that are never app-route-relevant (CI configs, docs, repo metadata)
+  const appFiles = changedFiles.filter(
+    f => !EXCLUDED_PATTERNS.some(re => re.test(f)),
+  );
+
+  // README-only / CI-only PR — skip the audit entirely
+  if (appFiles.length === 0) return [];
+
   // Infrastructure change → full audit
-  if (changedFiles.some(f => INFRA_PATTERNS.some(re => re.test(f)))) {
+  if (appFiles.some(f => INFRA_PATTERNS.some(re => re.test(f)))) {
     return routes;
   }
 
-  // Build a flat set of lowercase slugs from every changed file path
+  // Build a flat set of lowercase slugs from app-relevant changed files
   const fileSlugs = new Set(
-    changedFiles.flatMap(f =>
-      // Strip extension, split on separators, keep non-trivial tokens
+    appFiles.flatMap(f =>
       f.toLowerCase()
         .replace(/\.[^./\\]+$/, '')
         .split(/[/\\._-]+/)