argsbarg 5.1.13 → 5.1.15

package/CHANGELOG.md

@@ -7,11 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [5.1.15] - 2026-07-06
+
+
+## [5.1.14] - 2026-07-06
+
+
 ## [5.1.13] - 2026-07-06
 
 ### Fixed
 
 - **`configure --remove-all`** — skill uninstall actions no longer reinstall skills after printing "Removing …".
+- **Interactive `configure`** — choosing `n` on an installed skill now removes the skill directory (same bug as `--remove-all`, different code path).
+- **Configure closing summary** — counts artifacts (not per-file paths) and uses Removed/Installed/Synced instead of always "Updated N file(s)."
 
 ### Changed
 
@@ -673,7 +681,9 @@ const cli = { ... } satisfies CliProgram;  // or : CliProgram
 - Migrate schemas: rename every `children` property to **`commands`**; move positional definitions to **`CliPositional`** objects on `positionals` and strip `positional` / `argMin` / `argMax` from flag definitions under `options` (flags only carry `name`, `description`, `kind`, and optional `shortName`).
 - Imports: use `CliPositional` where needed; replace `CliOptionDef` with `CliOption` or `CliPositional` as appropriate.
 
-[Unreleased]: https://github.com/bdombro/bun-argsbarg/compare/v5.1.13...HEAD
+[Unreleased]: https://github.com/bdombro/bun-argsbarg/compare/v5.1.15...HEAD
+[5.1.15]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.15
+[5.1.14]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.14
 [5.1.13]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.13
 [5.1.11]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.11
 [5.1.10]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "argsbarg",
-  "version": "5.1.13",
+  "version": "5.1.15",
   "type": "module",
   "engines": {
     "bun": ">=1.3"

package/src/configure/configure.test.ts

@@ -7,12 +7,19 @@ import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { appConfigFileExists } from "../config/file.ts";
-import { appConfigHasEntries, parseConfigureOpts, validateConfigureOpts } from "../configure/index.ts";
+import {
+  appConfigHasEntries,
+  formatConfigureMutationSummary,
+  parseConfigureOpts,
+  validateConfigureOpts,
+} from "../configure/index.ts";
 import { Cli } from "../index.ts";
 import { detectInstalledArtifacts } from "../install/detect-installed.ts";
 import { parseInstallOpts } from "../install/opts.ts";
 import { resolveClaudeDesktopMcpPath, resolveInstallPaths } from "../install/paths.ts";
 import { buildInstallPlan, buildUpdatePlan } from "../install/plan.ts";
+import { installTargetForKey } from "../install/target-registry.ts";
+import { buildDetectedSnapshot, buildTargetPlanContext } from "../install/target-scope.ts";
 import { buildUninstallPlan } from "../install/uninstall.ts";
 import type { CliProgram } from "../types.ts";
 
@@ -62,6 +69,45 @@ describe("configure opts", () => {
   });
 });
 
+describe("configure mutation summary", () => {
+  test("interactive uninstall reports removed artifacts not file count", () => {
+    const msg = formatConfigureMutationSummary(
+      { paths: ["~/.cursor/skills/testapp/"], installed: 0, removed: 1, configured: 0 },
+      {},
+    );
+    expect(msg).toBe("Removed 1 artifact.");
+  });
+
+  test("interactive install reports installed artifacts not file count", () => {
+    const msg = formatConfigureMutationSummary(
+      {
+        paths: ["~/.cursor/skills/testapp/SKILL.md", "~/.cursor/skills/testapp/reference.md"],
+        installed: 1,
+        removed: 0,
+        configured: 0,
+      },
+      {},
+    );
+    expect(msg).toBe("Installed 1 artifact.");
+  });
+
+  test("sync mode uses synced verb and artifact count", () => {
+    const msg = formatConfigureMutationSummary(
+      { paths: ["a", "b", "c"], installed: 3, removed: 0, configured: 0 },
+      { sync: true },
+    );
+    expect(msg).toBe("Synced 3 artifacts.");
+  });
+
+  test("remove-all uses removed verb", () => {
+    const msg = formatConfigureMutationSummary(
+      { paths: ["a"], installed: 0, removed: 2, configured: 0 },
+      { removeAll: true },
+    );
+    expect(msg).toBe("Removed 2 artifacts.");
+  });
+});
+
 /** Tests for install paths. */
 describe("install paths", () => {
   test("resolveInstallPaths includes skill and mcp paths", () => {
@@ -153,6 +199,29 @@ describe("remove plan", () => {
     expect(result.exitCode).toBe(0);
     expect(existsSync(paths.cursorSkillDir)).toBe(false);
   });
+
+  test("scoped skill uninstall action removes directory without global uninstall flag", () => {
+    const skillApp: CliProgram = {
+      ...fixture,
+      configure: { agentIntegration: "skill" },
+    };
+    const paths = resolveInstallPaths(skillApp);
+    mkdirSync(paths.cursorSkillDir, { recursive: true });
+    writeFileSync(join(paths.cursorSkillDir, "SKILL.md"), "# test\n", "utf8");
+
+    const detected = buildDetectedSnapshot(skillApp, paths);
+    const ctx = buildTargetPlanContext(skillApp, paths, {}, detected);
+    const target = installTargetForKey("cursorSkill");
+    expect(target).toBeDefined();
+    const actions = target!.planUninstall({
+      ...ctx,
+      mode: "uninstall-scoped",
+      include: (key) => key === "cursorSkill",
+    });
+    expect(actions).toHaveLength(1);
+    expect(actions[0]!.run().length).toBeGreaterThan(0);
+    expect(existsSync(paths.cursorSkillDir)).toBe(false);
+  });
 });
 
 /** Tests for app config wizard. */

package/src/configure/index.ts

@@ -105,43 +105,113 @@ function runSkillAction(root: CliProgram, kind: InstallActionKind, opts: Install
   });
 }
 
+/** Tallies configure mutations for the closing summary and `--json` output. */
+export interface ConfigureMutationSummary {
+  paths: string[];
+  installed: number;
+  removed: number;
+  configured: number;
+}
+
+function emptyMutationSummary(): ConfigureMutationSummary {
+  return { paths: [], installed: 0, removed: 0, configured: 0 };
+}
+
+function mergeMutationSummary(into: ConfigureMutationSummary, from: ConfigureMutationSummary): void {
+  into.paths.push(...from.paths);
+  into.installed += from.installed;
+  into.removed += from.removed;
+  into.configured += from.configured;
+}
+
+function recordArtifactMutation(
+  summary: ConfigureMutationSummary,
+  paths: string[],
+  kind: "installed" | "removed" | "configured",
+): void {
+  if (paths.length === 0) return;
+  summary.paths.push(...paths);
+  summary[kind]++;
+}
+
+/** Human-readable closing line for configure mutations. */
+export function formatConfigureMutationSummary(summary: ConfigureMutationSummary, opts: ConfigureOpts): string | null {
+  if (summary.paths.length === 0) return null;
+
+  if (opts.removeAll || opts.removeConfig) {
+    const n = summary.removed;
+    if (n === 0) return null;
+    return n === 1 ? "Removed 1 artifact." : `Removed ${n} artifacts.`;
+  }
+
+  if (opts.sync) {
+    const n = summary.installed;
+    if (n === 0) return null;
+    return n === 1 ? "Synced 1 artifact." : `Synced ${n} artifacts.`;
+  }
+
+  const parts: string[] = [];
+  if (summary.removed > 0) {
+    parts.push(summary.removed === 1 ? "Removed 1 artifact" : `Removed ${summary.removed} artifacts`);
+  }
+  if (summary.installed > 0) {
+    parts.push(summary.installed === 1 ? "Installed 1 artifact" : `Installed ${summary.installed} artifacts`);
+  }
+  if (summary.configured > 0) {
+    parts.push("Updated app config");
+  }
+  if (parts.length === 0) return null;
+  return `${parts.join("; ")}.`;
+}
+
+/** Runs one install/uninstall action and returns changed paths. */
+function runPlanAction(
+  root: CliProgram,
+  action: InstallAction | UninstallAction,
+  opts: InstallOpts,
+  paths: ReturnType<typeof resolveInstallPaths>,
+): string[] {
+  if ("kind" in action && action.kind) {
+    const skillTarget = skillTargetFromActionKind(action.kind);
+    if (skillTarget) {
+      const runResult = action.run();
+      if (runResult.length > 0) return runResult;
+      if (opts.uninstall) {
+        const skillDir = skillDirFromUninstallSummary(action.summary, paths);
+        return skillDir ? uninstallSkillDir(skillDir, !!opts.dry) : [];
+      }
+      return runSkillAction(root, action.kind as InstallActionKind, opts);
+    }
+  }
+  if (!("kind" in action) || !action.kind) {
+    const skillDir = skillDirFromUninstallSummary(action.summary, paths);
+    if (skillDir) return uninstallSkillDir(skillDir, !!opts.dry);
+  }
+  return action.run();
+}
+
 /** Runs install or uninstall actions and collects changed paths. */
 function executePlan(
   root: CliProgram,
   actions: Array<InstallAction | UninstallAction>,
   opts: InstallOpts,
   showProgress: boolean,
-): string[] {
-  const changed: string[] = [];
+): ConfigureMutationSummary {
+  const summary = emptyMutationSummary();
   const paths = resolveInstallPaths(root);
   for (const action of actions) {
     if (showProgress) {
       installInfo(action.message, opts);
     }
-    if ("kind" in action && action.kind) {
-      const skillTarget = skillTargetFromActionKind(action.kind);
-      if (skillTarget) {
-        if (opts.uninstall) {
-          const skillDir = skillDirFromUninstallSummary(action.summary, paths);
-          if (skillDir) {
-            changed.push(...uninstallSkillDir(skillDir, !!opts.dry));
-          }
-        } else {
-          changed.push(...runSkillAction(root, action.kind as InstallActionKind, opts));
-        }
-        continue;
-      }
-    }
-    if (!("kind" in action) || !action.kind) {
-      const skillDir = skillDirFromUninstallSummary(action.summary, paths);
-      if (skillDir) {
-        changed.push(...uninstallSkillDir(skillDir, !!opts.dry));
-        continue;
-      }
+    const changed = runPlanAction(root, action, opts, paths);
+    if (changed.length === 0) continue;
+    if (action.kind === "configure") {
+      recordArtifactMutation(summary, changed, opts.uninstall ? "removed" : "configured");
+    } else {
+      recordArtifactMutation(summary, changed, opts.uninstall ? "removed" : "installed");
     }
-    changed.push(...action.run());
   }
-  return changed;
+  return summary;
 }
 
 /** Builds plan context limited to a single artifact key. */
@@ -181,7 +251,7 @@ function actionsForTarget(
 }
 
 /** Walks enabled targets with per-target prompts (TTY required). */
-async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): Promise<string[]> {
+async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): Promise<ConfigureMutationSummary> {
   if (!process.stdin.isTTY) {
     throw new Error("Interactive configure requires a TTY. Use flags such as --sync --yes.");
   }
@@ -191,7 +261,7 @@ async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): P
   const detected = buildDetectedSnapshot(root, paths);
   const effective = resolveEffectiveInstallTargets(root.configure, root);
   const mutationOpts: InstallOpts = { dry: opts.dry, json: opts.json };
-  const changed: string[] = [];
+  const summary = emptyMutationSummary();
 
   for (const target of INSTALL_TARGETS) {
     if (target.key === "app") continue;
@@ -205,7 +275,7 @@ async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): P
       const result = runConfigure(root, { context: "standalone", showHeading: false });
       if (result.changed) {
         installOut(`Wrote config: ${displayAppConfigPath(root)}`, mutationOpts);
-        changed.push(displayAppConfigPath(root));
+        recordArtifactMutation(summary, [displayAppConfigPath(root)], "configured");
       }
       continue;
     }
@@ -228,29 +298,32 @@ async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): P
       runTargetPreflight(root, paths, mutationOpts, installActions);
     }
 
-    changed.push(...executePlan(root, actions, mutationOpts, true));
+    mergeMutationSummary(
+      summary,
+      executePlan(root, actions, { ...mutationOpts, uninstall: choice === "uninstall" }, true),
+    );
   }
 
-  return changed;
+  return summary;
 }
 
 /** Runs sync, remove, or status modes without per-target prompts. */
-async function runAutomatedConfigure(root: CliProgram, opts: ConfigureOpts): Promise<string[]> {
+async function runAutomatedConfigure(root: CliProgram, opts: ConfigureOpts): Promise<ConfigureMutationSummary> {
   const installOpts = configureToInstallOpts(opts);
   const paths = resolveInstallPaths(root);
 
   if (installOpts.status) {
     printInstallStatus(root, installOpts);
-    return [];
+    return emptyMutationSummary();
   }
 
-  const changed: string[] = [];
+  const summary = emptyMutationSummary();
 
   if (installOpts.reinstall && !installOpts.uninstall) {
     const bootstrapped = ensureAppConfigFile(root, !!installOpts.dry);
     if (bootstrapped) {
       const display = displayAppConfigPath(root);
-      changed.push(display);
+      recordArtifactMutation(summary, [display], "configured");
       installOut(`Initialized config: ${display}`, installOpts);
     }
   }
@@ -271,7 +344,8 @@ async function runAutomatedConfigure(root: CliProgram, opts: ConfigureOpts): Pro
     runTargetPreflight(root, paths, installOpts, installActions);
   }
 
-  return [...changed, ...executePlan(root, actions, installOpts, true)];
+  mergeMutationSummary(summary, executePlan(root, actions, installOpts, true));
+  return summary;
 }
 
 /** Main configure command orchestrator. */
@@ -285,22 +359,22 @@ export async function cliConfigure(root: CliProgram, rawOpts: Record<string, str
 
   const isInteractive = !opts.sync && !opts.removeAll && !opts.removeConfig && !opts.status;
 
-  let changed: string[] = [];
+  let summary = emptyMutationSummary();
   try {
-    changed = isInteractive ? await runInteractiveConfigure(root, opts) : await runAutomatedConfigure(root, opts);
+    summary = isInteractive ? await runInteractiveConfigure(root, opts) : await runAutomatedConfigure(root, opts);
   } catch (mutationErr) {
     installErr(mutationErr instanceof Error ? mutationErr.message : String(mutationErr));
     process.exit(1);
   }
 
   if (opts.json && !opts.status) {
-    process.stdout.write(`${JSON.stringify(changed, null, 2)}\n`);
+    process.stdout.write(`${JSON.stringify(summary.paths, null, 2)}\n`);
     process.exit(0);
   }
 
-  if (!opts.status && changed.length > 0) {
-    const verb = opts.removeAll || opts.removeConfig ? "Removed" : opts.sync ? "Synced" : "Updated";
-    installOut(`${verb} ${changed.length} file(s).`, configureToInstallOpts(opts));
+  const closing = formatConfigureMutationSummary(summary, opts);
+  if (!opts.status && closing) {
+    installOut(closing, configureToInstallOpts(opts));
   }
 
   process.exit(0);

package/src/install/target-skill.ts

@@ -12,6 +12,7 @@ import type {
   TargetPlanContext,
   UninstallAction,
 } from "./target-types.ts";
+import { uninstallSkillDir } from "./uninstall.ts";
 
 export interface SkillHostSpec {
   key: CliInstallArtifactKey;
@@ -97,7 +98,7 @@ export class SkillInstallTarget extends InstallTarget {
         kind: this.actionKind,
         summary: `${this.uninstallPrefix}: ${displayInstallPath(dir)}/`,
         message: `Removing ${this.spec.label} skill ${displayInstallPath(dir)}/`,
-        run: () => [],
+        run: () => uninstallSkillDir(dir, ctx.dry),
       },
     ];
   }