argsbarg 5.1.12 → 5.1.14

package/CHANGELOG.md

@@ -7,7 +7,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [5.1.12] - 2026-07-05
+## [5.1.14] - 2026-07-06
+
+
+## [5.1.13] - 2026-07-06
+
+### Fixed
+
+- **`configure --remove-all`** — skill uninstall actions no longer reinstall skills after printing "Removing …".
+- **Interactive `configure`** — choosing `n` on an installed skill now removes the skill directory (same bug as `--remove-all`, different code path).
+
+### Changed
+
+- **Homebrew formula `uninstall`** — generated formulae run `{key} configure --remove-all --yes` (skills, MCP, and app config).
 
 ### Changed
 
@@ -665,8 +677,9 @@ const cli = { ... } satisfies CliProgram;  // or : CliProgram
 - Migrate schemas: rename every `children` property to **`commands`**; move positional definitions to **`CliPositional`** objects on `positionals` and strip `positional` / `argMin` / `argMax` from flag definitions under `options` (flags only carry `name`, `description`, `kind`, and optional `shortName`).
 - Imports: use `CliPositional` where needed; replace `CliOptionDef` with `CliOption` or `CliPositional` as appropriate.
 
-[Unreleased]: https://github.com/bdombro/bun-argsbarg/compare/v5.1.12...HEAD
-[5.1.12]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.12
+[Unreleased]: https://github.com/bdombro/bun-argsbarg/compare/v5.1.14...HEAD
+[5.1.14]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.14
+[5.1.13]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.13
 [5.1.11]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.11
 [5.1.10]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.10
 [5.1.9]: https://github.com/bdombro/bun-argsbarg/releases/tag/v5.1.9

package/docs/configure.md

@@ -16,14 +16,15 @@ brew install <tap>/<key>
 
 Upgrade with `brew upgrade <key>`. Shell completions are installed by Homebrew during `brew install`. Users must configure their shell per [Homebrew Shell Completion](https://docs.brew.sh/Shell-Completion).
 
-**Uninstall the binary:** remove agent artifacts first (while the CLI is still on PATH), then `brew uninstall`:
+**Uninstall the binary:**
 
 ```bash
-<key> configure --remove-all --yes
 brew uninstall <tap>/<key>
 ```
 
-`brew uninstall` runs the formula `uninstall` hook, which removes app config (`configure --remove-config --yes`). Skills and MCP entries are not removed by Homebrew — use `--remove-all` before uninstall when you want those gone too.
+`brew uninstall` runs the formula `uninstall` hook (`configure --remove-all --yes`), which removes detected skills, MCP entries, and app config while the binary is still on PATH.
+
+To remove app config only (keep skills/MCP), run `configure --remove-config --yes` before uninstall.
 
 ## Developer install
 
@@ -177,11 +178,11 @@ Release formulae should run:
 
 ```ruby
 def uninstall
-  system bin/"myapp", "configure", "--remove-config", "--yes"
+  system bin/"myapp", "configure", "--remove-all", "--yes"
 end
 ```
 
-Homebrew calls this before removing the keg, so the binary is still on PATH. Safe no-op when app config was never created or `program.appConfig` is unset.
+Removes detected skills, MCP entries, and app config while the binary is still on PATH. Safe no-op when nothing was installed.
 
 ## Bootstrapping a new CLI
 

package/docs/distribution-homebrew.md

@@ -10,7 +10,7 @@ Argsbarg apps distribute the **binary and shell completions** through Homebrew,
 | Skills + MCP | Formula `post_install` → `{key} configure --sync --yes` |
 | App config file | Bootstrapped as `{}` on `post_install` via `--sync` (`~/.local/lib/<key>/config.json`) |
 | App config values | User opt-in: `{key} configure` (interactive wizard when `program.appConfig` has entries) |
-| App config cleanup | Formula `uninstall` → `{key} configure --remove-config --yes` |
+| App config cleanup | Formula `uninstall` → `{key} configure --remove-all --yes` |
 
 **Only tap-from-repo** — in-repo `Formula/` or GitHub tap. Not Homebrew core.
 
@@ -62,13 +62,13 @@ If `brew install` fails, run `bun scripts/dev-formula.ts reset` manually to rest
 
 | Recipe | Removes |
 | --- | --- |
-| `just uninstall` | Formula `{key}` + tap symlink + skills/MCP; app config via formula `uninstall` |
+| `just uninstall` | Formula `{key}` + tap symlink + skills/MCP + app config via formula `uninstall` |
 | `just uninstall-config` | App config file only (`configure --remove-config --yes`) |
-| `just uninstall-release` | Release formula from `{tap}` (keeps tap; app config via formula `uninstall`) |
-| `just uninstall-release-tap` | Release formula + `brew untap {tap}` (app config via formula `uninstall`) |
+| `just uninstall-release` | Release formula from `{tap}` (keeps tap; agent artifacts via formula `uninstall`) |
+| `just uninstall-release-tap` | Release formula + `brew untap {tap}` (agent artifacts via formula `uninstall`) |
 | `just test-release` | Install release formula and run formula test |
 
-End users: `<key> configure --remove-all --yes` then `brew uninstall <tap>/<key>`. `brew uninstall` also removes app config via the formula `uninstall` hook (skills/MCP are not removed automatically).
+End users: `brew uninstall <tap>/<key>`. The formula `uninstall` hook runs `configure --remove-all --yes` (skills, MCP, and app config).
 
 ## Formula pattern
 
@@ -83,7 +83,7 @@ def post_install
 end
 
 def uninstall
-  system bin/"{key}", "configure", "--remove-config", "--yes"
+  system bin/"{key}", "configure", "--remove-all", "--yes"
 end
 ```
 

package/docs/output-schema.md

@@ -43,7 +43,7 @@ Production CLIs with several JSON commands tend to use **codegen** so types, han
 
 ## Recommended pipeline (copy per repo)
 
-No shared npm package — each app copies the same **contract**. Reference implementations: **sqsp-qa-manager-poc**, **idp-trees**, **sqsp-i18n-tools-poc** (see each repo’s `docs/architecture.md` for which commands use which schema root).
+No shared npm package — each app copies the same **contract**. Reference implementations: **sqsp-qa-manager-poc**, **sqsp-workspaces**, **sqsp-i18n-tools-poc** (see each repo’s `docs/architecture.md` for which commands use which schema root).
 
 ```mermaid
 flowchart LR

package/examples/full-example/scripts/formula-shared.ts

@@ -24,7 +24,7 @@ export const formulaPostInstallRuby = `def post_install
   end`;
 
 export const formulaUninstallRuby = `def uninstall
-    system bin/"${key}", "configure", "--remove-config", "--yes"
+    system bin/"${key}", "configure", "--remove-all", "--yes"
   end`;
 
 export const formulaCaveatsRuby = `def caveats
@@ -80,7 +80,10 @@ export function selectStaleReleaseTags(releases: ReleaseTag[]): string[] {
 export const releaseRepoSlug = releaseRepo;
 
 /** Resolves private GitHub release assets via the API at download time. */
-export const githubPrivateReleaseDownloadStrategyRuby = `  class GitHubPrivateReleaseDownloadStrategy < CurlDownloadStrategy
+export const githubPrivateReleaseDownloadStrategyRuby = `  # Private/internal releases: default CurlDownloadStrategy cannot fetch non-public
+  # GitHub release assets. Resolve the asset via the API and authenticate with
+  # GitHub::API.credentials (set up via \`gh auth login\` or HOMEBREW_GITHUB_API_TOKEN).
+  class GitHubPrivateReleaseDownloadStrategy < CurlDownloadStrategy
     def initialize(url, name, version, **meta)
       super
       pattern = %r{https://github\\.com/([^/]+)/([^/]+)/releases/download/([^/]+)/(\\S+)}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "argsbarg",
-  "version": "5.1.12",
+  "version": "5.1.14",
   "type": "module",
   "engines": {
     "bun": ">=1.3"

package/src/builtins/configure-copy.ts

@@ -68,11 +68,10 @@ export function configureCommandNotes(program: CliProgram, _caps: CliCapabilitie
     "See what is installed:",
     `  ${app} configure --status`,
     "",
-    "Remove agent artifacts before brew uninstall:",
-    `  ${app} configure --remove-all --yes`,
+    "Uninstall:",
     `  brew uninstall <tap>/${app}`,
     "",
-    "App config is removed automatically by the formula uninstall hook during brew uninstall.",
+    "The formula uninstall hook runs `configure --remove-all --yes` (skills, MCP, and app config).",
     "",
   ];
   if (program.appConfig) {

package/src/configure/configure.test.ts

@@ -3,7 +3,7 @@ Tests for configure/configure module behavior.
 */
 
 import { afterEach, beforeEach, describe, expect, test } from "bun:test";
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { appConfigFileExists } from "../config/file.ts";
@@ -13,6 +13,8 @@ import { detectInstalledArtifacts } from "../install/detect-installed.ts";
 import { parseInstallOpts } from "../install/opts.ts";
 import { resolveClaudeDesktopMcpPath, resolveInstallPaths } from "../install/paths.ts";
 import { buildInstallPlan, buildUpdatePlan } from "../install/plan.ts";
+import { installTargetForKey } from "../install/target-registry.ts";
+import { buildDetectedSnapshot, buildTargetPlanContext } from "../install/target-scope.ts";
 import { buildUninstallPlan } from "../install/uninstall.ts";
 import type { CliProgram } from "../types.ts";
 
@@ -137,6 +139,45 @@ describe("remove plan", () => {
     const plan = buildUninstallPlan(fixture, paths, parseInstallOpts({ uninstall: "1", all: "1" }));
     expect(plan.length).toBe(0);
   });
+
+  test("configure --remove-all removes installed cursor skill", async () => {
+    const skillApp: CliProgram = {
+      ...fixture,
+      configure: { agentIntegration: "skill" },
+    };
+    const paths = resolveInstallPaths(skillApp);
+    mkdirSync(paths.cursorSkillDir, { recursive: true });
+    writeFileSync(join(paths.cursorSkillDir, "SKILL.md"), "# test\n", "utf8");
+
+    expect(detectInstalledArtifacts(paths, skillApp).cursorSkill).toBe(true);
+
+    const result = await new Cli(skillApp).invoke(["configure", "--remove-all", "--yes"]);
+    expect(result.exitCode).toBe(0);
+    expect(existsSync(paths.cursorSkillDir)).toBe(false);
+  });
+
+  test("scoped skill uninstall action removes directory without global uninstall flag", () => {
+    const skillApp: CliProgram = {
+      ...fixture,
+      configure: { agentIntegration: "skill" },
+    };
+    const paths = resolveInstallPaths(skillApp);
+    mkdirSync(paths.cursorSkillDir, { recursive: true });
+    writeFileSync(join(paths.cursorSkillDir, "SKILL.md"), "# test\n", "utf8");
+
+    const detected = buildDetectedSnapshot(skillApp, paths);
+    const ctx = buildTargetPlanContext(skillApp, paths, {}, detected);
+    const target = installTargetForKey("cursorSkill");
+    expect(target).toBeDefined();
+    const actions = target!.planUninstall({
+      ...ctx,
+      mode: "uninstall-scoped",
+      include: (key) => key === "cursorSkill",
+    });
+    expect(actions).toHaveLength(1);
+    expect(actions[0]!.run().length).toBeGreaterThan(0);
+    expect(existsSync(paths.cursorSkillDir)).toBe(false);
+  });
 });
 
 /** Tests for app config wizard. */

package/src/configure/index.ts

@@ -121,7 +121,17 @@ function executePlan(
     if ("kind" in action && action.kind) {
       const skillTarget = skillTargetFromActionKind(action.kind);
       if (skillTarget) {
-        changed.push(...runSkillAction(root, action.kind as InstallActionKind, opts));
+        const runResult = action.run();
+        if (runResult.length > 0) {
+          changed.push(...runResult);
+        } else if (opts.uninstall) {
+          const skillDir = skillDirFromUninstallSummary(action.summary, paths);
+          if (skillDir) {
+            changed.push(...uninstallSkillDir(skillDir, !!opts.dry));
+          }
+        } else {
+          changed.push(...runSkillAction(root, action.kind as InstallActionKind, opts));
+        }
         continue;
       }
     }
@@ -221,7 +231,7 @@ async function runInteractiveConfigure(root: CliProgram, opts: ConfigureOpts): P
       runTargetPreflight(root, paths, mutationOpts, installActions);
     }
 
-    changed.push(...executePlan(root, actions, mutationOpts, true));
+    changed.push(...executePlan(root, actions, { ...mutationOpts, uninstall: choice === "uninstall" }, true));
   }
 
   return changed;

package/src/install/target-skill.ts

@@ -12,6 +12,7 @@ import type {
   TargetPlanContext,
   UninstallAction,
 } from "./target-types.ts";
+import { uninstallSkillDir } from "./uninstall.ts";
 
 export interface SkillHostSpec {
   key: CliInstallArtifactKey;
@@ -97,7 +98,7 @@ export class SkillInstallTarget extends InstallTarget {
         kind: this.actionKind,
         summary: `${this.uninstallPrefix}: ${displayInstallPath(dir)}/`,
         message: `Removing ${this.spec.label} skill ${displayInstallPath(dir)}/`,
-        run: () => [],
+        run: () => uninstallSkillDir(dir, ctx.dry),
       },
     ];
   }