argent-grid 0.2.0 → 0.3.0

package/src/lib/rendering/canvas-renderer.spec.ts

@@ -297,6 +297,7 @@ describe('CanvasRenderer', () => {
       width: 50,
       visible: true,
       pinned: 'left',
+      checkboxSelection: true,
     } as any;
 
     const mockRowNode = {
@@ -312,22 +313,167 @@ describe('CanvasRenderer', () => {
     } as any;
 
     vi.spyOn(mockApi, 'getAllColumns').mockReturnValue([mockColumn]);
+    vi.spyOn(mockApi, 'getColumnDefs').mockReturnValue([mockColumn]);
     vi.spyOn(mockApi, 'getDisplayedRowAtIndex').mockReturnValue(mockRowNode);
     vi.spyOn(mockApi, 'getDisplayedRowCount').mockReturnValue(1);
 
-    // Force a render
+    // Mark dirty so doRender doesn't skip, then force a synchronous render
+    renderer.invalidateAll();
     renderer.renderFrame();
 
     // Verify strokeRect was called (for checkbox border)
     expect(mockCanvasContext.strokeRect).toHaveBeenCalled();
   });
 
+  // ============================================================================
+  // REGRESSION TESTS — Canvas Renderer architectural invariants
+  // These tests guard against the performance / feedback-loop bugs fixed in
+  // Phase VII.  Do NOT remove them.
+  // ============================================================================
+
+  describe('Damage gate — scheduleRender() must not queue rAF when nothing is dirty', () => {
+    it('does not call requestAnimationFrame when damage tracker has no damage', () => {
+      const rafSpy = vi.spyOn(globalThis, 'requestAnimationFrame').mockImplementation(() => 0);
+
+      // Brand-new renderer has no pending damage after construction — call
+      // scheduleRender indirectly through the private accessor by calling
+      // render() and then draining the dirty state first.
+      // Start clean: call renderFrame() to drain any initial dirty state.
+      renderer.renderFrame();
+
+      // Reset the spy AFTER the initial frame so we only measure new calls.
+      rafSpy.mockClear();
+
+      // scheduleRender() with no damage should be a no-op.
+      (renderer as any).scheduleRender();
+      expect(rafSpy).not.toHaveBeenCalled();
+
+      rafSpy.mockRestore();
+    });
+
+    it('calls requestAnimationFrame when damage is present', () => {
+      let rafCalled = false;
+      const rafSpy = vi.spyOn(globalThis, 'requestAnimationFrame').mockImplementation((cb) => {
+        rafCalled = true;
+        return 0;
+      });
+
+      // Mark dirty then schedule.
+      renderer.render(); // internally calls markAllDirty() + scheduleRender()
+      expect(rafCalled).toBe(true);
+
+      rafSpy.mockRestore();
+    });
+  });
+
+  describe('nextRenderPending coalescing — concurrent scheduleRender calls must not drop renders', () => {
+    it('sets nextRenderPending when a frame is already in-flight', () => {
+      let _capturedCb: FrameRequestCallback | null = null;
+      const rafSpy = vi
+        .spyOn(globalThis, 'requestAnimationFrame')
+        .mockImplementation((cb: FrameRequestCallback) => {
+          _capturedCb = cb;
+          return 1;
+        });
+
+      // First call — starts the rAF.
+      renderer.render();
+      expect((renderer as any).animationFrameId).not.toBeNull();
+      expect((renderer as any).nextRenderPending).toBe(false);
+
+      // Second call while frame is still in-flight.
+      renderer.render();
+      expect((renderer as any).nextRenderPending).toBe(true);
+
+      rafSpy.mockRestore();
+    });
+
+    it('schedules a follow-up render after the first frame completes if damage arrives mid-render', () => {
+      const frames: FrameRequestCallback[] = [];
+      const rafSpy = vi
+        .spyOn(globalThis, 'requestAnimationFrame')
+        .mockImplementation((cb: FrameRequestCallback) => {
+          frames.push(cb);
+          return frames.length;
+        });
+
+      // Patch doRender to mark dirty again mid-render (simulates data arriving during a frame).
+      const originalDoRender = (renderer as any).doRender.bind(renderer);
+      vi.spyOn(renderer as any, 'doRender').mockImplementationOnce(() => {
+        originalDoRender();
+        // Simulate new data arriving while the frame is being painted.
+        renderer.render(); // marks dirty + sets nextRenderPending (animationFrameId still set)
+      });
+
+      renderer.render(); // queues frame[0]
+      expect(frames.length).toBe(1);
+
+      // Fire the first frame — mid-render, render() is called again marking dirty.
+      frames[0](0);
+      // A second rAF should have been scheduled for the newly dirty state.
+      expect(frames.length).toBe(2);
+
+      rafSpy.mockRestore();
+    });
+  });
+
+  describe('updateCanvasSize — must NEVER touch canvas.style.width or canvas.style.height', () => {
+    it('does not set canvas.style.width after setViewportDimensions', () => {
+      mockCanvas.style.width = ''; // clear before test
+      renderer.setViewportDimensions(640, 480);
+      expect(mockCanvas.style.width).toBe('');
+    });
+
+    it('does not set canvas.style.height after setViewportDimensions', () => {
+      mockCanvas.style.height = ''; // clear before test
+      renderer.setViewportDimensions(640, 480);
+      expect(mockCanvas.style.height).toBe('');
+    });
+
+    it('does set canvas.width (pixel buffer) after setViewportDimensions', () => {
+      renderer.setViewportDimensions(640, 480);
+      const dpr = window.devicePixelRatio || 1;
+      expect(mockCanvas.width).toBe(640 * dpr);
+    });
+
+    it('does set canvas.height (pixel buffer) after setViewportDimensions', () => {
+      renderer.setViewportDimensions(640, 480);
+      const dpr = window.devicePixelRatio || 1;
+      expect(mockCanvas.height).toBe(480 * dpr);
+    });
+  });
+
+  describe('blit infrastructure — removed dead code', () => {
+    it('does not have a blitState field (BlitState removed as dead code)', () => {
+      expect((renderer as any).blitState).toBeUndefined();
+    });
+
+    it('does not have a columnPositions field (dead map removed)', () => {
+      expect((renderer as any).columnPositions).toBeUndefined();
+    });
+
+    it('does not have a renderPending field (redundant with animationFrameId)', () => {
+      expect('renderPending' in renderer).toBe(false);
+    });
+  });
+
+  describe('renderThrottleMs — setRenderThrottle must not exist (removed in Phase VII)', () => {
+    it('does not expose a setRenderThrottle method', () => {
+      expect(typeof (renderer as any).setRenderThrottle).toBe('undefined');
+    });
+
+    it('does not have a renderThrottleMs property', () => {
+      expect('renderThrottleMs' in renderer).toBe(false);
+    });
+  });
+
   it('should toggle row selection when clicking dedicated selection column', () => {
     const mockColumn = {
       colId: 'ag-Grid-SelectionColumn',
       width: 50,
       visible: true,
       pinned: 'left',
+      checkboxSelection: true,
     } as any;
 
     const mockRowNode = {
@@ -346,6 +492,7 @@ describe('CanvasRenderer', () => {
     } as any;
 
     vi.spyOn(mockApi, 'getAllColumns').mockReturnValue([mockColumn]);
+    vi.spyOn(mockApi, 'getColumnDefs').mockReturnValue([mockColumn]);
     vi.spyOn(mockApi, 'getDisplayedRowAtIndex').mockReturnValue(mockRowNode);
     vi.spyOn(mockApi, 'getDisplayedRowCount').mockReturnValue(1);