arcvision 0.2.28 → 0.2.29

package/src/index.js

@@ -93,6 +93,16 @@ function analyzeBlastRadius(architectureMap) {
   };
 }
 
+/**
+ * Print the PASS 5 Architecture Intelligence Summary to the terminal.
+ * All values are derived from actual graph computation in pass5_intelligence.js.
+ * This is NOT a template — it reads real data from map.intelligence.
+ *
+ * @param {Object} map - Full context object with intelligence block attached
+ * @param {Object} chalkInstance - chalk instance for colors
+ */
+
+
 function saveToken(token) {
   try {
     // Validate token format before saving
@@ -497,87 +507,103 @@ program
   .description('Scan the current directory and generate architecture map')
   .argument('[directory]', 'Directory to scan', '.')
   .option('-u, --upload', 'Upload to database')
+  .option('-o, --output <file>', 'Save context to a specific file')
+  .option('--raw', 'Show verbose pass output and structural analysis details')
+  .option('--debug', 'Show all internal logs (preflight, plugins, ownership resolution, etc.)')
   .action(async (directory, options) => {
     const targetDir = path.resolve(directory);
 
+    // Wire verbosity flags to global so scanner.js can check them
+    process.env.ARCVISION_RAW = options.raw ? '1' : '';
+    process.env.ARCVISION_DEBUG = options.debug ? '1' : '';
+
     try {
-      // Pre-flight validation
-      await cliValidator.preFlightValidation('scan', {
-        directory: targetDir
-      });
+      // Pre-flight validation (silenced in default mode)
+      if (options.raw || options.debug) {
+        await cliValidator.preFlightValidation('scan', { directory: targetDir });
+      } else {
+        // Run validation silently — capture console temporarily
+        const origLog = console.log;
+        const origWarn = console.warn;
+        console.log = () => { };
+        console.warn = () => { };
+        try { await cliValidator.preFlightValidation('scan', { directory: targetDir }); } catch (e) { /* rethrow after restoring */ console.log = origLog; console.warn = origWarn; throw e; }
+        console.log = origLog;
+        console.warn = origWarn;
+      }
 
       // Initialize Artifact Manager
       const { ArtifactManager } = require('./core/artifact-manager');
       const artifactManager = new ArtifactManager(targetDir);
-
-      // Ensure all required artifacts exist
       artifactManager.ensureArtifacts();
 
-      console.log(chalk.blue(`Scanning directory: ${targetDir}`));
-
-      const map = await scanner.scan(targetDir);
-      console.log(chalk.green('Scan complete!'));
-
-      // Analyze and print blast radius insight
-      const blastRadiusAnalysis = analyzeBlastRadius(map);
-      if (blastRadiusAnalysis && blastRadiusAnalysis.topFiles && blastRadiusAnalysis.topFiles.length > 0) {
-        console.log('\n🔍 STRUCTURAL ANALYSIS RESULTS:\n');
-
-        blastRadiusAnalysis.topFiles.forEach((item, index) => {
-          let warningMessage = '';
-          if (index === 0) {
-            warningMessage = 'Changes here may silently propagate across the system.';
-          } else if (index === 1) {
-            warningMessage = 'Acts as a coordination layer between components.';
-          } else {
-            warningMessage = 'Modifications can cause widespread inconsistencies.';
-          }
+      if (options.raw || options.debug) {
+        console.log(chalk.blue(`\nScanning directory: ${targetDir}`));
+      }
 
-          console.log(`${index + 1}. 📁 ${item.file}`);
-          console.log(`   🎯 Blast Radius: ${item.blastRadius} files (${item.percentOfGraph}%)`);
-          console.log(`   ⚠️  Risk: ${warningMessage}\n`);
-        });
+      // Run the full 5-pass engine
+      // In default mode, suppress the noisy pass-level console output from scanner.js
+      let map;
+      if (options.raw || options.debug) {
+        map = await scanner.scan(targetDir);
       } else {
-        console.log('\n✅ No high-impact structural hubs detected in this codebase.');
+        // Capture ALL console.log/warn during scan — show only our curated summary
+        const origLog = console.log;
+        const origWarn = console.warn;
+        const origError = console.error;
+        const capturedLogs = [];
+        console.log = (...args) => capturedLogs.push(args.join(' '));
+        console.warn = (...args) => capturedLogs.push('[WARN] ' + args.join(' '));
+        // Keep errors visible even in default mode (failures matter)
+        try {
+          map = await scanner.scan(targetDir);
+        } finally {
+          console.log = origLog;
+          console.warn = origWarn;
+          console.error = origError;
+        }
       }
 
-      // Validate the map before saving or uploading
-      const { validateContext } = require('./engine/context_validator');
-      const validation = validateContext(map);
-
-      if (!validation.valid) {
-        console.warn('⚠️  VALIDATION ISSUES FOUND:');
-        validation.errors.forEach(e => console.warn(' -', e));
-        console.warn('⚠️  Proceeding with output despite validation issues to see results');
+      // ── PASS 5: ARCHITECTURE INTELLIGENCE SUMMARY (always printed) ──
+      printIntelligenceSummary(map, chalk);
+
+      // ── STRUCTURAL ANALYSIS (blast radius) — only in --raw mode ──
+      if (options.raw) {
+        const blastRadiusAnalysis = analyzeBlastRadius(map);
+        if (blastRadiusAnalysis && blastRadiusAnalysis.topFiles && blastRadiusAnalysis.topFiles.length > 0) {
+          console.log(chalk.dim('\n── Blast Radius Analysis ──'));
+          blastRadiusAnalysis.topFiles.forEach((item, index) => {
+            const messages = [
+              'Changes here may silently propagate across the system.',
+              'Acts as a coordination layer between components.',
+              'Modifications can cause widespread inconsistencies.'
+            ];
+            console.log(`${index + 1}. 📁 ${item.file}`);
+            console.log(`   🎯 Blast Radius: ${item.blastRadius} files (${item.percentOfGraph}%)`);
+            console.log(`   ⚠️  Risk: ${messages[index] || ''}\n`);
+          });
+        }
       }
 
-      // Create dedicated arcvision_context directory
+      // ── SAVE / UPLOAD ──
       const arcvisionDir = path.join(targetDir, 'arcvision_context');
       if (!fs.existsSync(arcvisionDir)) {
         fs.mkdirSync(arcvisionDir, { recursive: true });
-        console.log(chalk.green(`📁 Created arcvision_context directory: ${arcvisionDir}`));
       }
 
-      // Upload to database if requested
+      const { generateReadme } = require('./core/readme-generator');
+
       if (options.upload) {
         await uploadToDatabase(map, arcvisionDir);
-
-        // Generate README for system context when uploading
-        const { generateReadme } = require('./core/readme-generator');
-        generateReadme(arcvisionDir, version, blastRadiusAnalysis);
+        generateReadme(arcvisionDir, version, analyzeBlastRadius(map), map.intelligence);
       } else {
-        // Save to file with validation in dedicated directory
-        const fs = require('fs');
-        const outputFileName = path.join(arcvisionDir, 'arcvision.context.json');
+        const outputFileName = options.output ? path.resolve(options.output) : path.join(arcvisionDir, 'arcvision.context.json');
         fs.writeFileSync(outputFileName, JSON.stringify(map, null, 2));
-        console.log(chalk.green(`✅ Structural context saved to ${outputFileName}`));
-
-        // Generate README for system context in dedicated directory
-        const { generateReadme } = require('./core/readme-generator');
-        generateReadme(arcvisionDir, version, blastRadiusAnalysis);
-
-        console.log(chalk.dim('\nUse --upload to send to dashboard.'));
+        console.log(chalk.green(`\n✅  Context saved → ${outputFileName}`));
+        generateReadme(arcvisionDir, version, analyzeBlastRadius(map), map.intelligence);
+        console.log(chalk.dim('Use --upload to send to dashboard.'));
       }
+
     } catch (error) {
       cliErrorHandler.handleFatalError(error, {
         operation: 'scan',
@@ -592,7 +618,8 @@ program
   .description('Compare two context artifacts and generate diff summary')
   .argument('<old-file>', 'Path to the old context artifact')
   .argument('<new-file>', 'Path to the new context artifact')
-  .action(async (oldFile, newFile) => {
+  .option('-o, --output <file>', 'Save diff summary to a specific file')
+  .action(async (oldFile, newFile, options) => {
     try {
       // Pre-flight validation
       await cliValidator.preFlightValidation('diff', {
@@ -619,7 +646,7 @@ program
       if (!fs.existsSync(arcvisionDir)) {
         fs.mkdirSync(arcvisionDir, { recursive: true });
       }
-      const outputFileName = path.join(arcvisionDir, 'arcvision.context.diff.json');
+      const outputFileName = options.output ? path.resolve(options.output) : path.join(arcvisionDir, 'arcvision.context.diff.json');
       fs.writeFileSync(outputFileName, JSON.stringify(newContext, null, 2));
 
       console.log(chalk.green('✅ Structural diff completed!'));
@@ -977,4 +1004,70 @@ program
     }
   });
 
+/**
+ * Print the Architecture Intelligence Summary from Pass 5
+ * @param {Object} context - The structural context result
+ * @param {Object} chalk - Chalk instance for formatting
+ */
+function printIntelligenceSummary(context, chalk) {
+  if (!context || !context.intelligence) return;
+
+  const intel = context.intelligence;
+  const sep = '═'.repeat(60);
+
+  console.log(`\n${chalk.bold.cyan('🧠 ARCHITECTURE INTELLIGENCE SUMMARY (Pass 5)')}`);
+  console.log(chalk.cyan(sep));
+
+  // 1. Archetype Classification
+  if (intel.architectural_classification) {
+    const arch = intel.architectural_classification;
+    console.log(`\n${chalk.bold('Architectural Archetype:')}`);
+    console.log(`  ${chalk.magenta(arch.type.toUpperCase().replace(/_/g, ' '))}`);
+    console.log(`  → ${chalk.dim(arch.description)}`);
+  }
+  // 1. Risk Score
+  const riskColor = intel.risk_assessment.risk_level === 'high' ? chalk.red :
+    intel.risk_assessment.risk_level === 'medium' ? chalk.yellow : chalk.green;
+  console.log(`\n${chalk.bold('Risk Score:')} ${riskColor(intel.risk_assessment.risk_score + '/10')} (${intel.risk_assessment.risk_level.toUpperCase()})`);
+
+  // 1.a Architectural Entropy
+  if (intel.entropy) {
+    const entropyColor = intel.entropy.level === 'critical' ? chalk.red :
+      intel.entropy.level === 'high' ? chalk.red :
+        intel.entropy.level === 'medium' ? chalk.yellow : chalk.green;
+    console.log(`${chalk.bold('Architectural Entropy:')} ${entropyColor(intel.entropy.score)} [${intel.entropy.level.toUpperCase()}]`);
+  }
+
+  // 2. Structural Hotspots
+  console.log(`\n${chalk.bold('Structural Hotspots:')}`);
+  console.log(`  • ${chalk.yellow(intel.hotspots.total_cycles)} circular dependency cycles detected`);
+  console.log(`  • ${chalk.yellow(intel.hotspots.clusters.length)} dense coupling clusters identified`);
+  if (intel.hotspots.boundary_violations && intel.hotspots.boundary_violations.length > 0) {
+    console.log(`  • ${chalk.red(intel.hotspots.boundary_violations.length)} architectural boundary violations detected`);
+  }
+
+  // 3. Architectural Gravity (Centrality)
+  console.log(`\n${chalk.bold('Most Central File (Gravity Hub):')}`);
+  console.log(`  • ${chalk.magenta(intel.centrality.most_central || 'None identified')}`);
+
+  // 4. Critical Fragility
+  const highFragility = (intel.fragility.top_fragile_files || []).filter(f => f.score > 2);
+  if (highFragility.length > 0) {
+    console.log(`\n${chalk.bold('Highly Fragile Components:')}`);
+    highFragility.slice(0, 3).forEach(f => {
+      console.log(`  • ${chalk.red(f.file)} (fragility: ${f.score})`);
+    });
+  }
+
+  // 5. Recommendations
+  if (intel.recommendations && intel.recommendations.length > 0) {
+    console.log(`\n${chalk.bold.green('AI Recommendations:')}`);
+    intel.recommendations.forEach((rec, idx) => {
+      console.log(`  ${idx + 1}. ${rec}`);
+    });
+  }
+
+  console.log(`\n${chalk.cyan('='.repeat(45))}\n`);
+}
+
 program.parse();