arcvision 0.2.27 → 0.2.29

package/src/core/artifact-manager.js

@@ -33,9 +33,22 @@ class ArtifactManager {
   createDirectories() {
     this.requiredDirs.forEach(dir => {
       const fullPath = path.join(this.projectRoot, dir);
-      if (!fs.existsSync(fullPath)) {
-        fs.mkdirSync(fullPath, { recursive: true });
-        this.logCreation(dir);
+      try {
+        if (!fs.existsSync(fullPath)) {
+          fs.mkdirSync(fullPath, { recursive: true });
+          this.logCreation(dir);
+          // Verify directory was created
+          if (fs.existsSync(fullPath)) {
+            console.log(`✅ Verified directory creation: ${fullPath}`);
+          } else {
+            console.warn(`⚠️  Directory may not have been created: ${fullPath}`);
+          }
+        } else {
+          console.log(`✅ Directory already exists: ${fullPath}`);
+        }
+      } catch (error) {
+        console.error(`❌ Failed to create directory ${fullPath}: ${error.message}`);
+        throw error;
       }
     });
   }
@@ -46,16 +59,32 @@ class ArtifactManager {
   createMissingFiles() {
     // Create default ledger if missing
     const ledgerPath = path.join(this.projectRoot, this.requiredFiles.ledger);
-    if (!fs.existsSync(ledgerPath)) {
-      const defaultLedger = {
-        schema_version: '1.0',
-        system_id: path.basename(this.projectRoot),
-        created_at: new Date().toISOString(),
-        ledger: []
-      };
-      
-      fs.writeFileSync(ledgerPath, JSON.stringify(defaultLedger, null, 2));
-      this.logCreation(this.requiredFiles.ledger);
+    try {
+      if (!fs.existsSync(ledgerPath)) {
+        console.log(`🔍 Creating ledger file: ${ledgerPath}`);
+        const defaultLedger = {
+          schema_version: '1.0',
+          system_id: path.basename(this.projectRoot),
+          created_at: new Date().toISOString(),
+          ledger: []
+        };
+        
+        fs.writeFileSync(ledgerPath, JSON.stringify(defaultLedger, null, 2));
+        this.logCreation(this.requiredFiles.ledger);
+        
+        // Verify file was created
+        if (fs.existsSync(ledgerPath)) {
+          const stats = fs.statSync(ledgerPath);
+          console.log(`✅ Verified ledger file creation: ${ledgerPath} (${stats.size} bytes)`);
+        } else {
+          console.warn(`⚠️  Ledger file may not have been created: ${ledgerPath}`);
+        }
+      } else {
+        console.log(`✅ Ledger file already exists: ${ledgerPath}`);
+      }
+    } catch (error) {
+      console.error(`❌ Failed to create ledger file ${ledgerPath}: ${error.message}`);
+      throw error;
     }
   }
 

package/src/core/call-resolver.js

@@ -71,19 +71,21 @@ class CallResolver {
                                 // Better: SymbolIndexer ensure 'default' is the name for default exports.
                             }
                             
-                            // Additional attempts for common patterns
-                            // Attempt 3: Try with common function prefixes
-                            const commonPatterns = [
-                                `${targetFileId}::use${targetSymbolName.charAt(0).toUpperCase() + targetSymbolName.slice(1)}`,
-                                `${targetFileId}::get${targetSymbolName.charAt(0).toUpperCase() + targetSymbolName.slice(1)}`,
-                                `${targetFileId}::create${targetSymbolName.charAt(0).toUpperCase() + targetSymbolName.slice(1)}`,
-                                `${targetFileId}::_${targetSymbolName}`, // underscore prefix
-                                `${targetFileId}::${targetSymbolName}Impl`, // implementation suffix
-                                `${targetFileId}::${targetSymbolName}Handler` // handler suffix
-                            ];
-                            
-                            for (const patternId of commonPatterns) {
-                                if (this.symbolIndex.has(patternId)) return patternId;
+                            // Additional attempts for common function-prefix patterns
+                            // Guard: skip if targetSymbolName is falsy (e.g. undefined from a star import)
+                            if (targetSymbolName && typeof targetSymbolName === 'string' && targetSymbolName.length > 0) {
+                                const cap = targetSymbolName.charAt(0).toUpperCase() + targetSymbolName.slice(1);
+                                const commonPatterns = [
+                                    `${targetFileId}::use${cap}`,
+                                    `${targetFileId}::get${cap}`,
+                                    `${targetFileId}::create${cap}`,
+                                    `${targetFileId}::_${targetSymbolName}`,
+                                    `${targetFileId}::${targetSymbolName}Impl`,
+                                    `${targetFileId}::${targetSymbolName}Handler`
+                                ];
+                                for (const patternId of commonPatterns) {
+                                    if (this.symbolIndex.has(patternId)) return patternId;
+                                }
                             }
                         }
                     }
@@ -97,17 +99,20 @@ class CallResolver {
             }
             
             // Additional local patterns
-            const localPatterns = [
-                `${fileId}::use${symbolName.charAt(0).toUpperCase() + symbolName.slice(1)}`,
-                `${fileId}::get${symbolName.charAt(0).toUpperCase() + symbolName.slice(1)}`,
-                `${fileId}::create${symbolName.charAt(0).toUpperCase() + symbolName.slice(1)}`,
-                `${fileId}::_${symbolName}`, // underscore prefix
-                `${fileId}::${symbolName}Impl`, // implementation suffix
-                `${fileId}::${symbolName}Handler` // handler suffix
-            ];
-            
-            for (const patternId of localPatterns) {
-                if (this.symbolIndex.has(patternId)) return patternId;
+            // Guard: skip if symbolName is falsy
+            if (symbolName && typeof symbolName === 'string' && symbolName.length > 0) {
+                const cap = symbolName.charAt(0).toUpperCase() + symbolName.slice(1);
+                const localPatterns = [
+                    `${fileId}::use${cap}`,
+                    `${fileId}::get${cap}`,
+                    `${fileId}::create${cap}`,
+                    `${fileId}::_${symbolName}`,
+                    `${fileId}::${symbolName}Impl`,
+                    `${fileId}::${symbolName}Handler`
+                ];
+                for (const patternId of localPatterns) {
+                    if (this.symbolIndex.has(patternId)) return patternId;
+                }
             }
 
             return null;

package/src/core/context_builder.js

@@ -2,6 +2,7 @@ const path = require('path');
 const { spawnSync } = require('child_process');
 const crypto = require('crypto');
 const { stableId } = require('../engine/id-generator');
+const { emptyIntelligenceBlock } = require('../engine/pass5_intelligence');
 
 /**
  * Build the context object that conforms to the Arcvision schema
@@ -40,7 +41,7 @@ function buildContext(fileNodes, edges, symbols, options = {}) {
         if (file.intelligence && file.intelligence.connections) {
             file.intelligence.connections.forEach(c => addDep(c.target));
         }
-        
+
         // Add dependencies from metadata if intelligence is not available
         if (!file.intelligence && file.metadata && file.metadata.imports) {
             file.metadata.imports.forEach(imp => {
@@ -191,14 +192,17 @@ function buildContext(fileNodes, edges, symbols, options = {}) {
         architectural_boundaries: options.architecturalBoundaries || {},
         structural_invariants: options.structuralInvariants || [],
         // Include detected invariants from the current scan - these should conform to the schema specification
-        invariants: Array.isArray(options.autoDetectedInvariants) && options.autoDetectedInvariants.length > 0 ? options.autoDetectedInvariants : 
-                   Array.isArray(options.detectedInvariants) && options.detectedInvariants.length > 0 ? options.detectedInvariants : 
-                   [],
+        invariants: Array.isArray(options.autoDetectedInvariants) && options.autoDetectedInvariants.length > 0 ? options.autoDetectedInvariants :
+            Array.isArray(options.detectedInvariants) && options.detectedInvariants.length > 0 ? options.detectedInvariants :
+                [],
         // Include invariant analysis results
         invariant_analysis: options.invariantAnalysis || null,
         // Include architectural health assessment
         architectural_health: options.architecturalHealth || null,
-        authoritative_context: options.authoritativeContext || null
+        authoritative_context: options.authoritativeContext || null,
+        // Intelligence block — always populated, never null
+        // This is the canonical architecture intelligence layer from Pass 5.
+        intelligence: options.intelligence || emptyIntelligenceBlock()
     };
 
     // Phase 2 requirement: Artifact Hash (Trust Anchor)
@@ -206,7 +210,7 @@ function buildContext(fileNodes, edges, symbols, options = {}) {
     const contextWithoutIntegrity = { ...context };
     delete contextWithoutIntegrity.integrity;
     const hash = crypto.createHash('sha256').update(JSON.stringify(contextWithoutIntegrity)).digest('hex');
-    
+
     // Now add the integrity field
     context.integrity = {
         sha256: hash
@@ -226,7 +230,7 @@ function getGitInfo() {
         const originResult = spawnSync('git', ['remote', 'get-url', 'origin'], {
             stdio: ['pipe', 'pipe', 'pipe']
         });
-        
+
         let repoUrl = 'unknown';
         if (originResult.status === 0) {
             let url = originResult.stdout.toString().trim();
@@ -239,17 +243,17 @@ function getGitInfo() {
             }
             repoUrl = url;
         }
-        
+
         // Get the current commit hash
         const commitResult = spawnSync('git', ['rev-parse', 'HEAD'], {
             stdio: ['pipe', 'pipe', 'pipe']
         });
-        
+
         let commitHash = 'unknown';
         if (commitResult.status === 0) {
             commitHash = commitResult.stdout.toString().trim();
         }
-        
+
         return {
             repo: repoUrl,
             commit: commitHash
@@ -274,7 +278,7 @@ function calculateIntegrityHash(obj) {
         if (objCopy.integrity) {
             delete objCopy.integrity;
         }
-        
+
         const jsonString = JSON.stringify(objCopy);
         return crypto.createHash('sha256').update(jsonString).digest('hex');
     } catch (error) {
@@ -323,35 +327,35 @@ function generateStructuralLayers() {
 function generateAdaptiveStructuralLayers(directory) {
     const fs = require('fs');
     const path = require('path');
-    
+
     // Analyze project characteristics to determine adaptive layers
     const hasPackageJson = fs.existsSync(path.join(directory, 'package.json'));
-    const hasConfigFiles = fs.existsSync(path.join(directory, 'tsconfig.json')) || 
-                          fs.existsSync(path.join(directory, 'config')) ||
-                          fs.existsSync(path.join(directory, 'webpack.config.js'));
+    const hasConfigFiles = fs.existsSync(path.join(directory, 'tsconfig.json')) ||
+        fs.existsSync(path.join(directory, 'config')) ||
+        fs.existsSync(path.join(directory, 'webpack.config.js'));
     const hasSrcDir = fs.existsSync(path.join(directory, 'src'));
     const hasTestDir = fs.existsSync(path.join(directory, 'test')) || fs.existsSync(path.join(directory, 'tests'));
     const hasDocsDir = fs.existsSync(path.join(directory, 'docs'));
-    
+
     // Count different file types to determine project size and type
     let totalFiles = 0;
     let jsFiles = 0;
     let tsFiles = 0;
     let luaFiles = 0;
     let configFiles = 0;
-    
+
     function walk(dir, depth = 0) {
         if (depth > 3) return; // Limit depth to avoid performance issues
-        
+
         if (!fs.existsSync(dir)) return;
-        
+
         const items = fs.readdirSync(dir, { withFileTypes: true });
-        
+
         for (const item of items) {
             const fullPath = path.join(dir, item.name);
-            
+
             if (item.isDirectory()) {
-                if (!item.name.startsWith('.') && item.name !== 'node_modules' && 
+                if (!item.name.startsWith('.') && item.name !== 'node_modules' &&
                     item.name !== 'dist' && item.name !== 'build' && item.name !== '.git') {
                     walk(fullPath, depth + 1);
                 }
@@ -360,20 +364,20 @@ function generateAdaptiveStructuralLayers(directory) {
                 if (item.name.endsWith('.js')) jsFiles++;
                 if (item.name.endsWith('.ts')) tsFiles++;
                 if (item.name.endsWith('.lua')) luaFiles++;
-                if (['.json', '.yaml', '.yml', '.toml', '.config.js', '.config.ts', '.rc'].some(ext => 
+                if (['.json', '.yaml', '.yml', '.toml', '.config.js', '.config.ts', '.rc'].some(ext =>
                     item.name.endsWith(ext))) configFiles++;
             }
         }
     }
-    
+
     walk(directory);
-    
+
     // Determine if this is a Lua-heavy project (like BullMQ)
     const isLuaProject = luaFiles > 0 && (luaFiles / totalFiles) > 0.1; // More than 10% Lua files
-    
+
     // Determine project size
     const isLargeProject = totalFiles > 1000;
-    
+
     // Adjust structural layers based on project characteristics
     const layers = {
         "runtime_code": {
@@ -413,7 +417,7 @@ function generateAdaptiveStructuralLayers(directory) {
             "description": "Static assets with no effect on execution semantics"
         }
     };
-    
+
     // Add project-specific metadata
     layers.project_metadata = {
         "size_category": isLargeProject ? "large" : (totalFiles > 100 ? "medium" : "small"),
@@ -429,7 +433,7 @@ function generateAdaptiveStructuralLayers(directory) {
         "has_tests": hasTestDir,
         "is_lua_intensive": isLuaProject
     };
-    
+
     return layers;
 }
 
@@ -441,13 +445,13 @@ function generateAdaptiveStructuralLayers(directory) {
 function generateProjectEnvelope(directory) {
     const fs = require('fs');
     const path = require('path');
-    
+
     const envelope = {
         configuration_files: [],
         documentation: [],
         build_tools: []
     };
-    
+
     // Common configuration files
     const configFiles = [
         'package.json',
@@ -497,7 +501,7 @@ function generateProjectEnvelope(directory) {
         'remix.config.js',
         'remix.config.ts'
     ];
-    
+
     // Common documentation files
     const docFiles = [
         'README.md',
@@ -521,7 +525,7 @@ function generateProjectEnvelope(directory) {
         'CITATION.cff',
         'CITATION.bib'
     ];
-    
+
     // Common build tool files
     const buildToolFiles = [
         'typedoc.config.cjs',
@@ -537,18 +541,18 @@ function generateProjectEnvelope(directory) {
         'compodoc.json',
         'documentation.yml'
     ];
-    
+
     // Function to find files recursively
     function findFilesRecursively(dir, fileNames, results, maxDepth = 3, currentDepth = 0) {
         if (currentDepth > maxDepth) return;
-        
+
         if (!fs.existsSync(dir)) return;
-        
+
         const items = fs.readdirSync(dir, { withFileTypes: true });
-        
+
         for (const item of items) {
             const fullPath = path.join(dir, item.name);
-            
+
             if (item.isDirectory()) {
                 if (!item.name.startsWith('.') && item.name !== 'node_modules' && item.name !== 'dist' && item.name !== 'build') {
                     findFilesRecursively(fullPath, fileNames, results, maxDepth, currentDepth + 1);
@@ -564,53 +568,53 @@ function generateProjectEnvelope(directory) {
             }
         }
     }
-    
+
     // Find all configuration files
     const foundConfigFiles = [];
     findFilesRecursively(directory, configFiles, foundConfigFiles);
-    
+
     foundConfigFiles.forEach(fileObj => {
         envelope.configuration_files.push({
             path: fileObj.path,
             role: getRoleForConfigFile(fileObj.name)
         });
     });
-    
+
     // Find all documentation files
     const foundDocFiles = [];
     findFilesRecursively(directory, docFiles, foundDocFiles);
-    
+
     foundDocFiles.forEach(fileObj => {
         envelope.documentation.push({
             path: fileObj.path,
             role: getRoleForDocFile(fileObj.name)
         });
     });
-    
+
     // Find all build tool files
     const foundBuildToolFiles = [];
     findFilesRecursively(directory, buildToolFiles, foundBuildToolFiles);
-    
+
     foundBuildToolFiles.forEach(fileObj => {
         envelope.build_tools.push({
             path: fileObj.path,
             role: getRoleForBuildToolFile(fileObj.name)
         });
     });
-    
+
     // Remove duplicates based on path
     envelope.configuration_files = envelope.configuration_files.filter((file, index, self) =>
         index === self.findIndex(f => f.path === file.path)
     );
-    
+
     envelope.documentation = envelope.documentation.filter((file, index, self) =>
         index === self.findIndex(f => f.path === file.path)
     );
-    
+
     envelope.build_tools = envelope.build_tools.filter((file, index, self) =>
         index === self.findIndex(f => f.path === file.path)
     );
-    
+
     return envelope;
 }
 

package/src/core/failure-mode-synthesizer.js

@@ -68,21 +68,35 @@ class FailureModeSynthesizer {
   }
 
   /**
-   * Get default symptom for an invariant
+   * Get default symptom for an invariant based on its statement
    */
   getDefaultSymptom(invariant) {
-    if (invariant.statement.toLowerCase().includes('availability')) {
-      return 'UI does not update';
-    } else if (invariant.statement.toLowerCase().includes('state')) {
-      return 'Stale data presented to user';
-    } else if (invariant.statement.toLowerCase().includes('sync') || 
-               invariant.statement.toLowerCase().includes('synchronize')) {
+    if (!invariant) {
+      return 'System behavior deviates from expected requirements';
+    }
+    
+    // Handle cases where invariant might have description but no statement
+    const statementText = invariant.statement || invariant.description || invariant.id || '';
+    if (!statementText) {
+      return 'System behavior deviates from expected requirements';
+    }
+
+    // Ensure we have a string before calling toLowerCase
+    const statementStr = String(statementText);
+    const statement = statementStr.toLowerCase();
+
+    if (statement.includes('availability')) {
+      return 'UI does not update or service unreachable';
+    } else if (statement.includes('state')) {
+      return 'Stale or inconsistent data presented to user';
+    } else if (statement.includes('sync') || statement.includes('synchronize')) {
       return 'Data inconsistency between components';
-    } else if (invariant.statement.toLowerCase().includes('permission') ||
-               invariant.statement.toLowerCase().includes('auth')) {
+    } else if (statement.includes('permission') || statement.includes('auth')) {
       return 'Unauthorized access or denied permissions';
+    } else if (statement.includes('performance') || statement.includes('latency')) {
+      return 'System response time exceeds threshold';
     } else {
-      return 'Unexpected behavior or incorrect output';
+      return 'Unexpected behavior or incorrect logical output';
     }
   }
 
@@ -90,17 +104,34 @@ class FailureModeSynthesizer {
    * Get blast radius for an invariant based on related nodes
    */
   getInvariantBlastRadius(invariant, architectureMap) {
+    if (!invariant) {
+      return ['unknown'];
+    }
+    
+    // Handle cases where invariant might have description but no statement
+    const statementText = invariant.statement || invariant.description || invariant.id || '';
+    if (!statementText) {
+      return ['unknown'];
+    }
+    
     const { nodes } = architectureMap;
     const blastRadius = [];
+    // Ensure we have a string before calling toLowerCase
+    const statementStr = String(statementText);
+    const statement = statementStr.toLowerCase();
 
     // Look for nodes that are related to the invariant
     for (const node of nodes) {
-      if (node.path && invariant.statement.toLowerCase().includes(node.path.toLowerCase())) {
-        blastRadius.push(node.path);
-      }
-      
-      if (node.id && invariant.statement.toLowerCase().includes(node.id.toLowerCase())) {
-        blastRadius.push(node.id);
+      try {
+        if (node.path && statement.includes(node.path.toLowerCase())) {
+          blastRadius.push(node.path);
+        }
+
+        if (node.id && statement.includes(node.id.toLowerCase())) {
+          blastRadius.push(node.id);
+        }
+      } catch (e) {
+        // Ignore errors
       }
     }
 
@@ -229,16 +260,19 @@ class FailureModeSynthesizer {
    */
   isRelevantToInvariant(source, invariant) {
     // Check if the source location is mentioned in the invariant
-    if (invariant.owner && source.location && 
-        invariant.owner.toLowerCase().includes(source.location.toLowerCase())) {
+    if (invariant.owner && source.location &&
+      invariant.owner.toLowerCase().includes(source.location.toLowerCase())) {
       return true;
     }
 
-    // Check if the invariant statement mentions similar concepts
-    if (invariant.statement && source.location) {
-      const invariantWords = invariant.statement.toLowerCase().split(/\W+/);
+    // Check if the invariant statement/description mentions similar concepts
+    const statementText = invariant.statement || invariant.description || invariant.id || '';
+    if (statementText && source.location) {
+      // Ensure we have a string before calling toLowerCase
+      const statementStr = String(statementText);
+      const invariantWords = statementStr.toLowerCase().split(/\W+/);
       const locationWords = source.location.toLowerCase().split(/[\/\\.-_]+/);
-      
+
       // Check for overlapping terms
       for (const word of invariantWords) {
         if (word.length > 3 && locationWords.includes(word)) {
@@ -254,16 +288,25 @@ class FailureModeSynthesizer {
    * Predict symptoms based on invariant and trigger
    */
   predictSymptom(invariant, trigger) {
+    // Handle cases where invariant might have description but no statement
+    const statementText = invariant.statement || invariant.description || invariant.id || '';
+    if (!statementText) {
+      return 'Unexpected behavior or incorrect output';
+    }
+    
+    // Ensure we have a string before calling toLowerCase
+    const statementStr = String(statementText);
+    
     // Default symptom prediction based on invariant type
-    if (invariant.statement.toLowerCase().includes('availability')) {
+    if (statementStr.toLowerCase().includes('availability')) {
       return 'UI does not update';
-    } else if (invariant.statement.toLowerCase().includes('state')) {
+    } else if (statementStr.toLowerCase().includes('state')) {
       return 'Stale data presented to user';
-    } else if (invariant.statement.toLowerCase().includes('sync') || 
-               invariant.statement.toLowerCase().includes('synchronize')) {
+    } else if (statementStr.toLowerCase().includes('sync') ||
+      statementStr.toLowerCase().includes('synchronize')) {
       return 'Data inconsistency between components';
-    } else if (invariant.statement.toLowerCase().includes('permission') ||
-               invariant.statement.toLowerCase().includes('auth')) {
+    } else if (statementStr.toLowerCase().includes('permission') ||
+      statementStr.toLowerCase().includes('auth')) {
       return 'Unauthorized access or denied permissions';
     } else {
       return 'Unexpected behavior or incorrect output';
@@ -325,16 +368,16 @@ class FailureModeSynthesizer {
    */
   containsMutationPattern(func) {
     if (!func.name) return false;
-    
+
     const name = func.name.toLowerCase();
-    return name.includes('set') || 
-           name.includes('update') || 
-           name.includes('modify') || 
-           name.includes('change') || 
-           name.includes('mutate') ||
-           name.includes('assign') ||
-           name.includes('put') ||
-           name.includes('post');
+    return name.includes('set') ||
+      name.includes('update') ||
+      name.includes('modify') ||
+      name.includes('change') ||
+      name.includes('mutate') ||
+      name.includes('assign') ||
+      name.includes('put') ||
+      name.includes('post');
   }
 }