arcvision 0.2.25 → 0.2.27

package/src/core/cli-validator.js

@@ -16,7 +16,7 @@ class CLIValidator {
         if (!fs.existsSync(filePath)) return { valid: false, error: `File not found: ${filePath}` };
         return { valid: true };
       },
-      
+
       fileReadable: (filePath) => {
         try {
           fs.accessSync(filePath, fs.constants.R_OK);
@@ -25,7 +25,7 @@ class CLIValidator {
           return { valid: false, error: `Permission denied: Cannot read ${filePath}` };
         }
       },
-      
+
       fileWritable: (filePath) => {
         try {
           const dir = path.dirname(filePath);
@@ -35,7 +35,7 @@ class CLIValidator {
           return { valid: false, error: `Permission denied: Cannot write to ${filePath}` };
         }
       },
-      
+
       // JSON validations
       validJSON: (content, source = 'input') => {
         try {
@@ -45,7 +45,7 @@ class CLIValidator {
           return { valid: false, error: `Invalid JSON in ${source}: ${error.message}` };
         }
       },
-      
+
       // Directory validations
       directoryExists: (dirPath) => {
         if (!dirPath) return { valid: false, error: 'Directory path is required' };
@@ -59,11 +59,11 @@ class CLIValidator {
           return { valid: false, error: `Directory not accessible: ${dirPath}` };
         }
       },
-      
+
       // Context structure validations
       validContextStructure: (context) => {
         const errors = [];
-        
+
         // Required top-level fields
         const requiredFields = ['nodes', 'edges', 'system'];
         requiredFields.forEach(field => {
@@ -71,17 +71,17 @@ class CLIValidator {
             errors.push(`Missing required field: ${field}`);
           }
         });
-        
+
         // Validate nodes array
         if (context.nodes && !Array.isArray(context.nodes)) {
           errors.push('nodes must be an array');
         }
-        
+
         // Validate edges array
         if (context.edges && !Array.isArray(context.edges)) {
           errors.push('edges must be an array');
         }
-        
+
         // Validate system object structure
         if (context.system) {
           if (typeof context.system !== 'object' || context.system === null) {
@@ -96,19 +96,19 @@ class CLIValidator {
             });
           }
         }
-        
+
         return {
           valid: errors.length === 0,
           errors
         };
       },
-      
+
       // Invariant validations
       validInvariants: (invariants) => {
         if (!Array.isArray(invariants)) {
           return { valid: false, error: 'Invariants must be an array' };
         }
-        
+
         const errors = [];
         invariants.forEach((invariant, index) => {
           if (!invariant.id) {
@@ -130,7 +130,7 @@ class CLIValidator {
             errors.push(`Invariant ${invariant.id || index}: Missing required 'rule' field`);
           }
         });
-        
+
         return {
           valid: errors.length === 0,
           errors
@@ -138,14 +138,14 @@ class CLIValidator {
       }
     };
   }
-  
+
   /**
    * Comprehensive validation for CLI operations
    */
   validateOperation(operation, params) {
     const errors = [];
     const warnings = [];
-    
+
     switch (operation) {
       case 'scan':
         this.validateScan(params, errors, warnings);
@@ -162,7 +162,7 @@ class CLIValidator {
       default:
         errors.push(`Unknown operation: ${operation}`);
     }
-    
+
     return {
       valid: errors.length === 0,
       errors,
@@ -170,33 +170,33 @@ class CLIValidator {
       isValid: errors.length === 0
     };
   }
-  
+
   validateScan(params, errors, warnings) {
     const { directory } = params;
-    
+
     // Validate directory
     const dirValidation = this.validationRules.directoryExists(directory);
     if (!dirValidation.valid) {
       errors.push(dirValidation.error);
       return; // No point continuing if directory doesn't exist
     }
-    
+
     // Check for common issues
     const commonIssues = this.checkCommonScanIssues(directory);
     warnings.push(...commonIssues.warnings);
     errors.push(...commonIssues.errors);
   }
-  
+
   validateEvaluate(params, errors, warnings) {
     const { contextFile, invariantsFile, directory } = params;
-    
+
     // Validate directory
     const dirValidation = this.validationRules.directoryExists(directory);
     if (!dirValidation.valid) {
       errors.push(dirValidation.error);
       return;
     }
-    
+
     // Validate context file
     if (contextFile) {
       const ctxFileValidation = this.validationRules.fileExists(contextFile);
@@ -224,13 +224,11 @@ class CLIValidator {
         }
       }
     }
-    
+
     // Validate invariants file if provided
     if (invariantsFile) {
       const invFileValidation = this.validationRules.fileExists(invariantsFile);
-      if (!invFileValidation.valid) {
-        warnings.push(`Invariants file not found: ${invariantsFile} (will use defaults)`);
-      } else {
+      if (invFileValidation.valid) {
         const readable = this.validationRules.fileReadable(invariantsFile);
         if (!readable.valid) {
           warnings.push(`Cannot read invariants file: ${readable.error} (will use defaults)`);
@@ -254,17 +252,17 @@ class CLIValidator {
       }
     }
   }
-  
+
   validateUpload(params, errors, warnings) {
     const { contextData, token } = params;
-    
+
     // Validate token
     if (!token) {
       errors.push('Upload token is required. Run `arcvision link <TOKEN>` first.');
     } else if (typeof token !== 'string' || token.length < 10) {
       warnings.push('Upload token appears to be invalid or malformed.');
     }
-    
+
     // Validate context data
     if (!contextData) {
       errors.push('Context data is required for upload');
@@ -273,7 +271,7 @@ class CLIValidator {
       if (!structureValidation.valid) {
         errors.push(...structureValidation.errors.map(e => `Context validation: ${e}`));
       }
-      
+
       // Check data size
       try {
         const dataSize = Buffer.byteLength(JSON.stringify(contextData));
@@ -286,26 +284,26 @@ class CLIValidator {
       }
     }
   }
-  
+
   validateDiff(params, errors, warnings) {
     const { oldFile, newFile } = params;
-    
+
     // Validate both files exist and are readable
     [oldFile, newFile].forEach((file, index) => {
       const label = index === 0 ? 'Old file' : 'New file';
-      
+
       const fileValidation = this.validationRules.fileExists(file);
       if (!fileValidation.valid) {
         errors.push(`${label}: ${fileValidation.error}`);
         return;
       }
-      
+
       const readable = this.validationRules.fileReadable(file);
       if (!readable.valid) {
         errors.push(`${label}: ${readable.error}`);
         return;
       }
-      
+
       try {
         const content = fs.readFileSync(file, 'utf8');
         const jsonValidation = this.validationRules.validJSON(content, file);
@@ -321,13 +319,13 @@ class CLIValidator {
         errors.push(`${label}: Failed to read file - ${error.message}`);
       }
     });
-    
+
     // Check if files are different
     if (oldFile === newFile) {
       warnings.push('Both files are the same. Diff will show no changes.');
     }
   }
-  
+
   /**
    * Extract invariants from various JSON structures
    */
@@ -335,15 +333,15 @@ class CLIValidator {
     if (Array.isArray(data)) {
       return data;
     }
-    
+
     if (data.project_specific_invariants && Array.isArray(data.project_specific_invariants)) {
       return data.project_specific_invariants;
     }
-    
+
     if (data.invariants && Array.isArray(data.invariants)) {
       return data.invariants;
     }
-    
+
     // Try to find invariants in any property
     const keys = Object.keys(data);
     for (const key of keys) {
@@ -351,54 +349,54 @@ class CLIValidator {
         return data[key];
       }
     }
-    
+
     return [];
   }
-  
+
   /**
    * Check for common scan issues
    */
   checkCommonScanIssues(directory) {
     const warnings = [];
     const errors = [];
-    
+
     try {
       // Check for node_modules
       const nodeModulesPath = path.join(directory, 'node_modules');
       if (fs.existsSync(nodeModulesPath)) {
         warnings.push('Found node_modules directory. Consider adding it to ignore patterns for better performance.');
       }
-      
+
       // Check for large directories
       const entries = fs.readdirSync(directory, { withFileTypes: true });
       const fileCount = entries.filter(entry => entry.isFile()).length;
       const dirCount = entries.filter(entry => entry.isDirectory()).length;
-      
+
       if (fileCount > 1000) {
         warnings.push(`Large number of files detected (${fileCount}). Scan may take longer than usual.`);
       }
-      
+
       if (dirCount > 100) {
         warnings.push(`Large number of directories detected (${dirCount}). Consider specifying a subdirectory.`);
       }
-      
+
       // Check for common problematic files
       const problematicExtensions = ['.log', '.tmp', '.cache'];
-      const hasProblematicFiles = entries.some(entry => 
+      const hasProblematicFiles = entries.some(entry =>
         entry.isFile() && problematicExtensions.some(ext => entry.name.endsWith(ext))
       );
-      
+
       if (hasProblematicFiles) {
         warnings.push('Found potentially problematic files (.log, .tmp, .cache). These will be skipped during scan.');
       }
-      
+
     } catch (error) {
       errors.push(`Could not analyze directory structure: ${error.message}`);
     }
-    
+
     return { warnings, errors };
   }
-  
+
   /**
    * Format validation results for display
    */
@@ -406,40 +404,40 @@ class CLIValidator {
     if (results.isValid) {
       return chalk.green('✅ All validations passed');
     }
-    
+
     let output = '';
-    
+
     if (results.errors.length > 0) {
       output += chalk.red('❌ Validation Errors:\n');
       results.errors.forEach(error => {
         output += `  • ${error}\n`;
       });
     }
-    
+
     if (results.warnings.length > 0) {
       output += chalk.yellow('\n⚠️  Validation Warnings:\n');
       results.warnings.forEach(warning => {
         output += `  • ${warning}\n`;
       });
     }
-    
+
     return output;
   }
-  
+
   /**
    * Perform comprehensive pre-flight validation
    */
   async preFlightValidation(operation, params) {
     console.log(chalk.blue(`🔍 Pre-flight validation for ${operation} operation...`));
-    
+
     const validation = this.validateOperation(operation, params);
-    
+
     if (!validation.isValid) {
       console.error(chalk.red('\n❌ Pre-flight validation failed:'));
       console.error(this.formatValidationResults(validation));
       process.exit(1);
     }
-    
+
     if (validation.warnings.length > 0) {
       console.warn(chalk.yellow('\n⚠️  Validation warnings:'));
       validation.warnings.forEach(warning => {
@@ -447,7 +445,7 @@ class CLIValidator {
       });
       console.log(); // Add spacing
     }
-    
+
     console.log(chalk.green('✅ Pre-flight validation passed\n'));
     return true;
   }