architwin 1.19.0 → 1.19.2

package/lib/atwinui/components/toolbar/i18n.js

@@ -290,6 +290,7 @@ i18n
                 "SuccessUpdatedFloorLevel": "Updated the partition's floor level",
                 "DuplicatePartitionName": "This partition name is already used in this room. Please choose a different name.",
                 "PleaseOnPolygonVisibility": "Action cannot be done, please turn on room visibility.",
+                "IoTType": "IoT Type",
                 "ImportMTagHeader": "Import Mattertags",
                 "ImportMTButton": "Import",
                 "ImportMTagInfo": "Importing the same tags more than once from your Matterport Space will cause duplicates",
@@ -582,13 +583,14 @@ i18n
                 "SuccessUpdatedFloorLevel": "区画のフロアオフセット値が更新されました",
                 "DuplicatePartitionName": "このパーティション名は既にこの部屋で使用されています。別の名前を選択してください。",
                 "PleaseOnPolygonVisibility": "操作を行う前に、部屋の表示をオンにしてください。",
-                "ImportMTagHeader": "Mattertagsをインポートする",
-                "ImportMTButton": "輸入",
-                "ImportMTagInfo": "Matterport Spaceから同じタグを複数回インポートすると、重複が発生します。",
-                "ImportResultPartial": "{{errorCount}}件のタグのインポートに失敗しました。",
-                "ImportResultNone": "タグのインポートに失敗しました。",
-                "ImportResultSuccess": "{{count}}件のタグをインポートしました。",
-                "NothingToImport": "インポートするものがありません。"
+                "IoTType": "IoTタイプ",
+                "ImportMTagHeader": "Mattertagsインポート",
+                "ImportMTButton": "インポート",
+                "ImportMTagInfo": "Matterportから複数回インポートすると、タグの重複が発生します。",
+                "ImportResultPartial": "{{errorCount}}個のタグのインポートに失敗しました",
+                "ImportResultNone": "タグのインポートに失敗しました",
+                "ImportResultSuccess": "{{count}}個のタグのインポートに成功しました",
+                "NothingToImport": "インポートするタグがありませんでした"
             }
         }
     },

package/lib/atwinui/components/toolbar/tagFormPane.d.ts

@@ -1,4 +1,4 @@
-import { FORM_MODE, ITagCategory } from "../../../types";
+import { FORM_MODE, ITagCategory, ITag } from "../../../types";
 export declare let tagFormMode: FORM_MODE;
 export declare let selectedTag: any;
 export declare let originalTagBackup: any;
@@ -14,6 +14,8 @@ export declare function getTagFormData(): {
 export declare function setTagCategoriesOption(): void;
 export declare function toggleDropdown(elementId: string): void;
 export declare function clearInnerHTML(elementId: string): void;
+export declare function hideTagsFromSpace(tags?: ITag[]): Promise<void>;
+export declare function renderTagsInSpace(tags: ITag[], _withIcon?: boolean, iframeId?: string): Promise<void>;
 export declare function renderCategoryDropdownOptions(elementId: string, items: Array<ITagCategory>, toggleId?: string): void;
 export declare function renderSubcategoryDropdownOptions(elementId: string, items: Array<ITagCategory>): void;
 export declare function clearTagFormDropdown(): void;

package/lib/atwinui/components/toolbar/tagFormPane.js

@@ -7,11 +7,14 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         step((generator = generator.apply(thisArg, _arguments || [])).next());
     });
 };
-import { _atwin, _tagCategories, _tags, editTagColor, getMpTags } from "../../../architwin";
-import { convertToCssRgb, stringContains } from "../../../utils";
+import { _atwin, _atwinConnections, _tagCategories, _tags, editTagColor, attachSandbox, disposeTags, getIoTDeviceTagIcons, getMpTags, renderTag, setTagIcon } from "../../../architwin";
+import { convertToCssRgb, stringContains, useHexToRgb } from "../../../utils";
 import { TAG_TYPE } from "../../../types";
 import { renderTags, setSelectedCategoryFilter, setSelectedSubcategoryFilter, filterTagList, getAllSubcategories, selectedCategoryFilterId, sortTags, selectedTagSortOption } from './tagListPane';
 import i18n from './i18n';
+import log from "loglevel";
+import ShortUniqueId from "short-unique-id";
+import * as _tag from './../../../tag';
 let mode = 'adding';
 let tagNameInput, tagDescriptionInput, tagEmbedInput, tagCategoryDropdown, tagSubcategoryDropdown;
 let selectedCategoryId = undefined;
@@ -177,7 +180,8 @@ export function getTagFormData() {
     }
     if (tagNameInput) {
         const tagName = tagNameInput.value;
-        const tagDescription = tagDescriptionInput.value.split('\n')[0];
+        const tagDescription = tagDescriptionInput.value;
+        //const tagDescription = tagDescriptionInput.value.split('\n')[0]
         const tagEmbed = tagEmbedInput.value;
         const formData = {
             tagName: tagName,
@@ -269,6 +273,7 @@ export function clearInnerHTML(elementId) {
     targetElement.innerHTML = ``;
 }
 function selectOption(option, elementId, skipToggle = false) {
+    var _a;
     return __awaiter(this, void 0, void 0, function* () {
         console.log("selectOption()");
         //const dropdownToggle = document.querySelector('.at_dropdown_toggle');
@@ -295,6 +300,12 @@ function selectOption(option, elementId, skipToggle = false) {
                 const tags = getMpTags();
                 const filteredTags = filterTagList(tags);
                 const sortedTags = sortTags(filteredTags, { by: 'label', order: 'asc' });
+                const removeTags = tags.filter(tag => !filteredTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.MP);
+                // remove tags that is not part in the sorted Tags
+                yield hideTagsFromSpace(removeTags);
+                // show filtered tags only
+                yield renderTagsInSpace(sortedTags, true);
+                log.info("sortedTags", sortedTags);
                 renderTags(sortedTags);
             }
             else if (categoryType == 'subcategory' && isFilterDropdown == false) {
@@ -314,6 +325,11 @@ function selectOption(option, elementId, skipToggle = false) {
                 const tags = getMpTags();
                 const filteredTags = filterTagList(tags);
                 const sortedTags = sortTags(filteredTags, { by: 'label', order: 'asc' });
+                const removeTags = tags.filter(tag => !filteredTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.MP);
+                // remove tags that is not part in the sorted Tags
+                yield hideTagsFromSpace(removeTags);
+                // show filtered tags only
+                yield renderTagsInSpace(filteredTags, true);
                 renderTags(filteredTags);
             }
             //Populate subcategory dropdown
@@ -362,8 +378,15 @@ function selectOption(option, elementId, skipToggle = false) {
                 clearInnerHTML(elementId);
             }
             let tags = getMpTags().filter(tag => !tag.tag_type || tag.tag_type !== TAG_TYPE.IOT);
-            const filteredTags = filterTagList(tags);
-            const sortedTags = sortTags(filteredTags ? filteredTags : tags, selectedTagSortOption);
+            const filteredTags = (_a = filterTagList(tags)) !== null && _a !== void 0 ? _a : [];
+            const sortedTags = sortTags(filteredTags.length ? filteredTags : tags, selectedTagSortOption);
+            const removeTags = tags.filter(tag => !filteredTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.MP);
+            if (filteredTags.length > 0) {
+                // remove tags that is not part in the sorted Tags
+                yield hideTagsFromSpace(removeTags);
+            }
+            // show filtered tags only
+            yield renderTagsInSpace(sortedTags, true);
             renderTags(sortedTags);
         }
         let toggleId = '';
@@ -384,6 +407,104 @@ function selectOption(option, elementId, skipToggle = false) {
         }
     });
 }
+export function hideTagsFromSpace(tags = null) {
+    return __awaiter(this, void 0, void 0, function* () {
+        log.info('hideTagsFromSpace', tags);
+        if (tags != null) {
+            tags.map((tag) => __awaiter(this, void 0, void 0, function* () {
+                yield _tag.disposeTag({ tagId: tag.json_data.id, sdk: _atwin, tags: _tags });
+            }));
+        }
+        else {
+            disposeTags();
+        }
+    });
+}
+// render tags to space
+export function renderTagsInSpace(tags, _withIcon = false, iframeId = undefined) {
+    var _a;
+    return __awaiter(this, void 0, void 0, function* () {
+        log.info('renderTagsInSpace', tags);
+        let renderedTagIds = [];
+        const sdk = iframeId ? _atwinConnections[iframeId] : _atwin;
+        for (let tag of tags) {
+            log.info('tag', tag);
+            const isDuplicate = renderedTagIds.includes(tag.json_data.id);
+            const rsid = new ShortUniqueId({ length: 10 });
+            if (isDuplicate) {
+                //assign a different unique id if the existing tag id is a duplicate
+                tag.json_data.id = rsid.rnd();
+            }
+            renderedTagIds.push(tag.json_data.id);
+            try {
+                const renderedTag = yield renderTag({ tag: tag.json_data }, false, iframeId);
+            }
+            catch (error) {
+                log.info("Tag is already rendered in space");
+                continue;
+            }
+            // check if tag needs tag icon display
+            if (_withIcon && tag.tag_icon_base64 !== '') {
+                // set tag icon
+                log.info("__@ showTags: ", tags);
+                yield setTagIcon({ tag: tag.json_data, iconName: tag.tag_icon_name, iconUrl: tag.tag_icon_base64, color: tag.json_data.color, iframeId });
+            }
+            if (tag.media_url && tag.media_url !== '') {
+                try {
+                    const attachments = [tag.media_url];
+                    yield _tag.attachTagMedia({ sdk, tag: tag.json_data, attachments });
+                }
+                catch (error) {
+                    log.warn(error);
+                }
+            }
+            if (tag.sandboxId) {
+                try {
+                    yield attachSandbox({ sandboxId: tag.sandboxId, tagIds: [tag.json_data.id] });
+                }
+                catch (error) {
+                    log.error("Attach sandbox error ", error);
+                }
+            }
+            if (tag.tag_type === TAG_TYPE.IOT) {
+                const icons = getIoTDeviceTagIcons();
+                let iconUrl = icons.normal;
+                let iconName = "normal.png";
+                let color = { r: 0.3, g: 0.5, b: 1.0 }; // default soft royal blue
+                for (const device of tag.iot_tag.linked_devices) {
+                    if (!device)
+                        continue;
+                    const { quality, status } = device;
+                    // If any device is offline, override color to gray and stop checking further
+                    if (status === "offline") {
+                        iconUrl = icons.normal;
+                        iconName = "normal.png";
+                        color = useHexToRgb("667c89"); // gray
+                        break;
+                    }
+                    // If any device is alert (highest priority), set red and stop
+                    if (quality === 2) {
+                        iconUrl = icons.alert;
+                        iconName = "alert.png";
+                        color = { r: 1, g: 0, b: 0 }; // red
+                        break;
+                    }
+                    // If any device is attention, set orange but keep checking in case of alert
+                    if (quality === 3) {
+                        iconUrl = icons.alert;
+                        iconName = "normal.png";
+                        color = useHexToRgb("ffae42"); // orange
+                        // continue loop to see if alert is present
+                    }
+                }
+                tag.tag_icon_url = iconUrl;
+                tag.tag_icon_name = iconName;
+                tag.json_data.color = color;
+                yield setTagIcon({ tag: tag.json_data, iconName: (_a = tag.tag_icon_base64) !== null && _a !== void 0 ? _a : '', iconUrl: tag.tag_icon_url, color: tag.json_data.color });
+            }
+        }
+    });
+}
 function createOptionElement(item, dropdownType) {
     console.log("createOptionElement");
     const option = document.createElement('div');

package/lib/atwinui/components/toolbar/tagIotFormPane.js

@@ -51,7 +51,7 @@ export function renderTagIOTFormPane() {
           </div>
         </div>
 
-        <label for="">${i18n.t('Category')}</label>
+        <label for="">${i18n.t('IoTType')}</label>
         <div id="at-iot-category-dropdown" data-cy="at-iot-category-dropdown">
           <div id="at-iot-cat-filter-dropdown" class="at_dropdown at_flex at_flex_row at_space_between">    
             <div class="at_dropdown_toggle" id="at-iot-selected-cat" data-cy="at-iot-selected-cat">${i18n.t(selectedIoTCatOption)}</div>

package/lib/atwinui/components/toolbar/tagListPane.d.ts

@@ -32,6 +32,6 @@ export declare function initializeTagVisibility(): void;
 export declare function updateShowAllButton(): void;
 export declare function clearTagVisibilityStorage(): void;
 export declare function setIotCategoryFilterOptions(): void;
-export declare function filterIotTagByCategory(tags: ITag[]): void;
+export declare function filterIotTagByCategory(tags: ITag[]): Promise<void>;
 export declare function setSelectedIoTCategoryFilter(payload: ITagIOTCategory): void;
 export declare function renderIotCategoryDropdownFilterOptions(elementId: string, items: Array<ITagIOTCategory>): void;

package/lib/atwinui/components/toolbar/tagListPane.js

@@ -11,7 +11,7 @@ import { SPACE_EVENTS, sortTagOptions, TAG_TYPE } from "../../../types";
 import { batchAddEventListenerByClassName, toggleDisplayPane, batchAddEventListenerByDataAttribute } from "../../events";
 import { convertToCssRgb, getBundleVersion, stringContains } from "../../../utils";
 import { gotoTag, disposeTag, dispatchSpaceEvent, _tags, getUserAssignedCategories, _mpConfig, moveTag, getAtwinSdk, toggleVisibilityTag, _tagIotCategoryTypes } from "../../../architwin";
-import { initFormData, toggleDropdown } from "./tagFormPane";
+import { hideTagsFromSpace, initFormData, renderTagsInSpace, toggleDropdown } from "./tagFormPane";
 import { toggleModal, setModalAction } from "./modal";
 import { initIoTFormData, setIoTFormMode } from './tagIotFormPane';
 import { Notyf } from 'notyf';
@@ -121,7 +121,7 @@ export function renderTagListPane() {
             </div>
 
             <div class="at_field at_flex_column" id="at-custom-iot-category-filter-dropdown-container">
-                <label for="">${i18n.t('Category')}</label>
+                <label for="">${i18n.t('IoTType')}</label>
                 <div id="at-custom-iot-category-filter-dropdown" data-cy="at-custom-iot-category-filterdropdown">
                 <div id="at-custom-iot-cat-filter-dropdown" class="at_dropdown at_flex at_flex_row at_space_between">    
                     <div class="at_dropdown_toggle" id="at-custom-iot-selected-filter-category" data-cy="at-custom-iot-selected-filter-category">${i18n.t('NoSelection')}</div>
@@ -277,7 +277,7 @@ export function renderTags(tags, showOwnTagsOnly = false) {
                     const payload = { tag: targetTag };
                     dispatchSpaceEvent(SPACE_EVENTS.TAG_DISPOSED, payload);
                     toggleModal(false);
-                    notify.success(i18n.t('Successfully deleted tag'));
+                    notify.success(i18n.t('SuccessDeleteTag'));
                 }
                 else {
                     toggleModal(false);
@@ -489,7 +489,7 @@ export function addClickEventToTagRow(tag) {
                     yield disposeTag({ tagId: tagId });
                     const tagRow = document.getElementById(`at-tag-row-${tagId}`);
                     tagRow.remove();
-                    notify.success(i18n.t('Successfully deleted tag'));
+                    notify.success(i18n.t('SuccessDeleteTag'));
                 }
                 else {
                     notify.error("Tag id not found!");
@@ -851,7 +851,7 @@ export function setIotCategoryFilterOptions() {
     log.info('setIotCategoryOptions()');
     if (_tagIotCategoryTypes) {
         renderIotCategoryDropdownFilterOptions('at-iot-category-filter-options', _tagIotCategoryTypes);
-        batchAddEventListenerByClassName('at_iot_cat_filter_option', (event) => {
+        batchAddEventListenerByClassName('at_iot_cat_filter_option', (event) => __awaiter(this, void 0, void 0, function* () {
             log.info("category filter clicked");
             //@ts-ignore
             const selectedCat = event.target;
@@ -861,6 +861,7 @@ export function setIotCategoryFilterOptions() {
                 // no selection selected
                 selectedIoTCategoryFilter = { uuid: '', name: 'NoSelection' };
                 setSelectedIoTCategoryFilter(selectedIoTCategoryFilter);
+                yield renderTagsInSpace(iotTags, true);
                 renderTags(iotTags);
             }
             const getCatName = _tagIotCategoryTypes.find(cat => cat.uuid === catUUID);
@@ -871,13 +872,18 @@ export function setIotCategoryFilterOptions() {
                 filterIotTagByCategory(iotTags);
             }
             toggleDropdown('at-iot-category-filter-options');
-        });
+        }));
     }
 }
 export function filterIotTagByCategory(tags) {
-    log.info("selectedIoTCategoryFilter", selectedIoTCategoryFilter, _tags);
-    const filteredTags = tags.filter(tag => tag.iot_tag.iot_category == selectedIoTCategoryFilter.name);
-    renderTags(filteredTags);
+    return __awaiter(this, void 0, void 0, function* () {
+        log.info("selectedIoTCategoryFilter", selectedIoTCategoryFilter, _tags);
+        const filteredTags = tags.filter(tag => tag.iot_tag.iot_category == selectedIoTCategoryFilter.name);
+        const removeTags = tags.filter(tag => !filteredTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.IOT);
+        yield hideTagsFromSpace(removeTags);
+        yield renderTagsInSpace(filteredTags, true);
+        renderTags(filteredTags);
+    });
 }
 // displays selected Category in the dropdown
 export function setSelectedIoTCategoryFilter(payload) {

package/lib/atwinui/events.js

@@ -14,7 +14,7 @@ import { getTargetPosition, addMediaScreen, _3DXObjects, selectedObject, setTran
 import { Notyf } from 'notyf';
 import 'notyf/notyf.min.css';
 import { SPACE_EVENTS, COORDINATE_SYSTEM, UNITS, DEGREE, MAP_OPTIONS, sortTagOptions, sortObjectOptions, CUSTOM_MAP_MODE, TAG_TYPE } from "../types";
-import { clearSelectedTag, initFormData, setSelectedTag, setTagFormMode } from "./components/toolbar/tagFormPane";
+import { clearSelectedTag, initFormData, setSelectedTag, hideTagsFromSpace, renderTagsInSpace, setTagFormMode } from "./components/toolbar/tagFormPane";
 import { renderObjectList, resetSelectedObjectSortOption, selectedObjectSortOption, sortShowcaseObjects, updateSelectedObjectSortOption } from "./components/toolbar/objectListPane";
 import { renderLibraryList } from "./components/toolbar/libraryPane";
 import { renderObjectCard } from "./components/toolbar/card";
@@ -347,7 +347,8 @@ function renderTagPaneContent() {
             setTagPaneActive(true);
             setCurrentTagPaneMode(TAG_TYPE.MP);
             resetSelectedTagSortOption();
-            const sortedTagsToDisplay = sortTags(tags, selectedTagSortOption);
+            const mpTags = tags.filter(tag => !tag.tag_type || tag.tag_type === TAG_TYPE.MP);
+            const sortedTagsToDisplay = sortTags(mpTags, selectedTagSortOption);
             renderTags(sortedTagsToDisplay, true);
         }
         else if (!isTagPaneActive) {
@@ -846,7 +847,9 @@ function handlePlaceTag() {
                             const row = renderTagRow(iTag, '');
                             tagContainer.appendChild(row);
                             addClickEventToTagRow(iTag);
-                            yield attachTagMedia({ sdk: _atwin, tag: iTag, attachments: iTag.attachments });
+                            if (iTag.attachments && iTag.attachments.length > 0) {
+                                yield attachTagMedia({ sdk: _atwin, tag: iTag, attachments: iTag.attachments });
+                            }
                             // toggleDisplayPane('at-cancel-tag-form-btn')
                             notyf.success(`${i18n.t('SuccessAddTagToSpace')}`);
                             const tags = getMpTags();
@@ -1074,6 +1077,7 @@ function handleSaveTag() {
                     currentTag.media_url = tagFormPayload.tagEmbed;
                     currentTag.json_data.label = tagFormPayload.tagName;
                     currentTag.json_data.description = tagFormPayload.tagDescription;
+                    currentTag.tag_type = TAG_TYPE.MP;
                     // Add tag icon data
                     const targetCategory = _tagCategories.find(cat => cat.uuid === tagFormPayload.tagCategoryId);
                     if (targetCategory) {
@@ -3326,37 +3330,35 @@ function handleClearSearchTagName() {
     log.info('handleClearSearchTagName()');
     const searchTagName = document.getElementById('at-clear-search-tag-name');
     if (searchTagName) {
-        searchTagName.addEventListener('click', () => {
+        searchTagName.addEventListener('click', () => __awaiter(this, void 0, void 0, function* () {
             searchClearfield();
             // commented out due to iot Dummy Data
             // const tags = getMpTags()
             const tags = [..._tags];
-            const filteredTags = filterTagList(tags);
             if (selectedCategoryFilterId || selectedSubCategoryFilterId && isTagPaneActive) {
-                const filteredTags = filterTagList(tags);
+                const filteredTags = filterTagList(tags).filter(tag => tag.tag_type === TAG_TYPE.MP);
+                // show filtered tags only
+                yield renderTagsInSpace(filteredTags, true);
                 renderTags(filteredTags);
             }
             else if (tags.length > 0 && isTagPaneActive) {
-                renderTags(tags, true);
+                const filteredMPTags = tags.filter(tag => tag.tag_type === TAG_TYPE.MP);
+                yield renderTagsInSpace(filteredMPTags, true);
+                renderTags(filteredMPTags, true);
             }
             else if (!isTagPaneActive) {
                 const filteredIotTags = filterIotTagList(tags);
+                yield renderTagsInSpace(filteredIotTags, true);
                 renderTags(filteredIotTags);
-                // if (selectedCategoryFilterId || selectedSubCategoryFilterId) {
-                //     const sortedTags = sortTags(filteredTags, {by: 'label', order: 'asc'})
-                //     renderTags(sortedTags)                
-                // } else if (tags.length > 0) {
-                //     const sortedTags = sortTags(tags, {by: 'label', order: 'asc'})
-                //     renderTags(sortedTags,true)
             }
-        });
+        }));
     }
 }
 function handleSearchFromTagListButton() {
     log.info('handleSearchFromTagListButton()');
     const searchTagNameButton = document.getElementById('at-search-tag-button');
     if (searchTagNameButton) {
-        searchTagNameButton.addEventListener('click', () => {
+        searchTagNameButton.addEventListener('click', () => __awaiter(this, void 0, void 0, function* () {
             const tags = getMpTags();
             const tagSearch = getSearchTagTerm();
             if (tagSearch) {
@@ -3366,18 +3368,36 @@ function handleSearchFromTagListButton() {
                 if (foundTag) {
                     if (selectedCategoryFilterId || selectedSubCategoryFilterId && isTagPaneActive) {
                         const filteredTags = filterTagList(foundTag);
+                        const removeTags = tags.filter(tag => !filteredTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.MP);
+                        log.info("removeTags", removeTags);
+                        // remove tags that is not part in the sorted Tags
+                        yield hideTagsFromSpace(removeTags);
+                        // show filtered tags only
+                        yield renderTagsInSpace(filteredTags, true);
                         renderTags(filteredTags);
                     }
                     else if (foundTag.length > 0 && isTagPaneActive) {
+                        const removeTags = tags.filter(tag => !foundTag.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.MP);
+                        log.info("removeTags", removeTags);
+                        // remove tags that is not part in the sorted Tags
+                        yield hideTagsFromSpace(removeTags);
+                        // show filtered tags only
+                        yield renderTagsInSpace(foundTag, true);
                         renderTags(foundTag, true);
                     }
                     else if (!isTagPaneActive) {
                         const filteredIotTags = filterIotTagList(foundTag);
+                        const removeTags = tags.filter(tag => !filteredIotTags.some(ft => ft.id === tag.id) && tag.tag_type === TAG_TYPE.IOT);
+                        log.info("removeTags", removeTags);
+                        // remove tags that is not part in the sorted Tags
+                        yield hideTagsFromSpace(removeTags);
+                        // show filtered tags only
+                        yield renderTagsInSpace(filteredIotTags, true);
                         renderTags(filteredIotTags);
                     }
                 }
             }
-        });
+        }));
     }
 }
 function handleCustomMapFloorImageUploaded(payload) {

package/lib/tag.js

@@ -138,13 +138,14 @@ function attachTagMedia(payload) {
     return __awaiter(this, void 0, void 0, function* () {
         log.info('__@ attachTagContent()', payload);
         // log.info('attachTagContent()', payload)
-        if (!payload.attachments || payload.attachments.length === 0) {
+        const validAttachments = (payload.attachments || []).filter(url => !!url);
+        if (validAttachments.length === 0) {
             log.error('__@ No Attachments');
             return;
         }
         payload.tag.attachments = [];
-        for (let i in payload.attachments) {
-            const [attachmentId] = yield payload.sdk.Tag.registerAttachment(payload.attachments[i]);
+        for (let i in validAttachments) {
+            const [attachmentId] = yield payload.sdk.Tag.registerAttachment(validAttachments[i]);
             log.info("media attachmentId ", attachmentId);
             payload.tag.attachments.push(attachmentId);
         }
@@ -445,7 +446,8 @@ function toggleTagVisibility(payload) {
     payload.sdk.Tag.editOpacity(payload.tagId, payload.visibility ? 1 : 0);
     payload.sdk.Tag.allowAction(payload.tagId, {
         opening: payload.visibility,
-        navigating: true
+        navigating: true,
+        docking: payload.visibility,
     });
 }
 export { renderTag, disposeTag, moveTag, attachTagMediaById, attachTagMedia, detachTagMedia, setTagIcon, editBillboard, editStem, editColor, saveTagDb, deleteTag, getTagColorCodeID, getEmbedlyData, cancelMoveTag, handleTagPlacerCreated, attachSandbox, registerSandbox, toggleTagVisibility };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "architwin",
-  "version": "1.19.0",
+  "version": "1.19.2",
   "description": "ArchiTwin Library for Matterport",
   "main": "./lib/architwin.js",
   "types": "./lib/architwin.d.ts",