archgen-skill 0.0.3 → 0.0.5

package/vendor/skills/archgen/scripts/doc-index.mjs

@@ -0,0 +1,457 @@
+#!/usr/bin/env node
+// doc-index.mjs — deterministic markdown-artifact lens over `.archgen/<slug>/`:
+// overview tree, backlink queries, reference-integrity gate, freshness audit,
+// Mermaid inventory.
+// Usage:
+//   node doc-index.mjs <slug-dir>                        overview JSON
+//   node doc-index.mjs <slug-dir> --refs-to <token>      backlink JSON
+//   node doc-index.mjs <slug-dir> --validate             integrity JSON (exit 1 when broken)
+//   node doc-index.mjs <slug-dir> --stale                freshness JSON
+//   node doc-index.mjs <slug-dir> --diagrams             Mermaid inventory JSON
+// Any mode accepts `--file <path>` (repo-root-relative or slug-relative) to
+// scope it to one document. Paths in output are repo-root-relative and
+// slash-normalized; identical input yields byte-identical stdout.
+// Scope-hardened: refuses any input outside .archgen/<slug>/ (see lib/scope.mjs).
+// Exit codes: 0 ok · 1 broken references (--validate) · 2 structurally invalid
+// tasks.yaml during --validate (duplicate task id / dangling depends_on, via
+// GraphError) · 4 invalid input/flags.
+//
+// DEDUP GUARANTEES (stateless idempotency): identical input yields byte-
+// identical output AND zero duplicated entities inside one output. The file
+// inventory dedups by fs.realpathSync — a symlinked doc aliasing another
+// tracked doc, case-colliding spellings on case-insensitive filesystems, and
+// `/./` path noise all collapse to ONE entry; the canonical repo-root-relative
+// spelling kept is the non-symlink one when the group contains it, else the
+// lexicographically first (overview reports how many via `duplicatesSkipped`).
+// --validate counts UNIQUE refs in `checked.*` and lists each broken ref ONCE,
+// at its first occurrence line; duplicate FR-id DEFINITIONS inside docs/prd.md
+// are their own broken kind 'dup-definition' (ambiguity is surfaced, never
+// silently resolved). By deliberate contrast, --refs-to backlinks list EVERY
+// occurrence line — that mode is a "where is this mentioned" lens, not a gate.
+//
+// SCALE GUARDS: all traversals are iterative (explicit stack — no recursion on
+// tree depth); overview returns at most the first 100 files, sorted, with
+// `truncated:true` above that (totalFiles still reports the true deduped
+// count) so agents are never silently surprised by deterministic truncation;
+// fence pairing follows CommonMark (an info-carrying ``` inside an open fence
+// is content, not an opener), which keeps nested-fence blocks from producing
+// phantom diagram entries or false titles.
+import { existsSync, readFileSync, readdirSync, realpathSync, statSync } from 'node:fs';
+import { basename, dirname, join, relative, resolve, sep } from 'node:path';
+import { parseYaml } from './lib/yaml.mjs';
+import { buildGraph, GraphError } from './lib/graph.mjs';
+import { resolveSlugInput, ScopeError } from './lib/scope.mjs';
+
+const USAGE = 'usage: doc-index.mjs <slug-dir> [--refs-to <token>] [--validate] [--stale] [--diagrams] [--file <path>]';
+// Overview emits at most this many files (sorted); above it, truncated:true.
+const OVERVIEW_MAX_FILES = 100;
+function die(msg, code = 4) { console.error(msg); process.exit(code); }
+
+// --- argument parsing -------------------------------------------------------
+const argv = process.argv.slice(2);
+const opts = { input: null, refsTo: null, validate: false, stale: false, diagrams: false, file: null };
+for (let i = 0; i < argv.length; i++) {
+  const a = argv[i];
+  if (a === '--refs-to') opts.refsTo = argv[++i];
+  else if (a === '--validate') opts.validate = true;
+  else if (a === '--stale') opts.stale = true;
+  else if (a === '--diagrams') opts.diagrams = true;
+  else if (a === '--file') opts.file = argv[++i];
+  else if (a.startsWith('--')) die(`${USAGE} — unknown option '${a}'`);
+  else if (opts.input === null) opts.input = a;
+  else die(`${USAGE} — unexpected extra argument '${a}'`);
+}
+if (!opts.input) die(USAGE);
+if (opts.refsTo === undefined || opts.file === undefined) die(`${USAGE} — --refs-to/--file require a value`);
+if (opts.refsTo === '') die(`${USAGE} — --refs-to requires a non-empty token`);
+const modes = [opts.refsTo !== null, opts.validate, opts.stale, opts.diagrams].filter(Boolean).length;
+if (modes > 1) die(`${USAGE} — --refs-to/--validate/--stale/--diagrams are mutually exclusive`);
+
+// --- input resolution -------------------------------------------------------
+// The scope gate is the ONLY way in: the slug dir must be an immediate child of
+// a `.archgen` segment (symlinks judged by their real target); everything below
+// runs off the resolved absolute root.
+let scoped;
+try {
+  scoped = resolveSlugInput(opts.input);
+} catch (e) {
+  if (e instanceof ScopeError) die(`doc-index: ${e.message}`);
+  die(`cannot read ${opts.input} (missing or not a directory)`);
+}
+const slugDir = scoped.root;
+const repoRoot = dirname(slugDir); // the `.archgen` directory — output vocabulary stays root-relative
+const slug = scoped.slug;
+
+/** Repo-root-relative, slash-normalized path (never absolute in output). */
+const relFromRoot = (abs) => relative(repoRoot, abs).split(sep).join('/');
+const relFromSlug = (abs) => relative(slugDir, abs).split(sep).join('/');
+
+// Optional --file scoping: accept repo-root-relative (the output vocabulary) or
+// slug-relative paths; anything resolving outside the slug directory is refused.
+// The hit is judged by real path so a symlink inside the slug cannot smuggle in
+// out-of-scope content either.
+let fileScope = null; // slug-relative posix path or null
+if (opts.file !== null) {
+  const candidates = [join(repoRoot, opts.file), join(slugDir, opts.file)];
+  const hit = candidates.find((p) => { try { return statSync(p).isFile(); } catch { return false; } });
+  if (!hit) die(`cannot read --file ${opts.file} (missing or not a file)`);
+  let hitReal;
+  try { hitReal = realpathSync(hit); } catch { hitReal = resolve(hit); }
+  if (!hitReal.startsWith(slugDir + sep)) die(`--file ${opts.file} is outside ${opts.input}`);
+  fileScope = relFromSlug(hit);
+}
+
+// --- shared engine ----------------------------------------------------------
+const MD_RE = /\.md$/i;
+const YAML_RE = /\.ya?ml$/i;
+
+/** Read text as UTF-8 with BOM stripped and CRLF/CR normalized to LF. */
+function readText(abs) {
+  let t;
+  try { t = readFileSync(abs, 'utf8'); } catch { return null; }
+  if (t.charCodeAt(0) === 0xfeff) t = t.slice(1);
+  return t.replace(/\r\n?/g, '\n');
+}
+
+/** Depth-first collect of files matching `filter`, dot-directories skipped,
+ * DEDUPLICATED by real path, sorted lexicographically by slug-relative path —
+ * the determinism backbone.
+ *
+ * Dedup contract (A3): every tracked document is indexed/emitted exactly once
+ * regardless of how many directory entries reach it. Candidates are keyed by
+ * fs.realpathSync, which collapses symlink aliases (a doc symlinked inside the
+ * slug pointing at another tracked doc) and case-colliding spellings on
+ * case-insensitive filesystems; `/./` noise never survives realpath either.
+ * The canonical spelling kept per group is the non-symlink entry when one
+ * exists (the file's own name beats an alias), else the lexicographically
+ * first candidate — deterministic under identical input, always.
+ * Dangling symlinks (realpath throws) are kept and keyed by their spelled
+ * path: they alias nothing, so they cannot be duplicates of anything.
+ */
+function walkFiles(filter) {
+  const candidates = [];
+  const stack = [''];
+  while (stack.length) {
+    const rel = stack.pop();
+    for (const e of readdirSync(rel ? join(slugDir, rel) : slugDir, { withFileTypes: true })) {
+      if (e.name.startsWith('.')) continue;
+      const r = rel ? `${rel}/${e.name}` : e.name;
+      if (e.isDirectory()) stack.push(r);
+      else if (filter.test(e.name)) candidates.push(r);
+    }
+  }
+  const chosen = new Map(); // real key -> { rel, isLink }
+  let duplicatesSkipped = 0;
+  for (const r of candidates.sort()) {
+    const abs = join(slugDir, r);
+    let key;
+    let isLink;
+    try {
+      key = realpathSync(abs);
+      isLink = key !== join(slugDir, r); // slugDir is already fully resolved (scope gate)
+    } catch {
+      key = resolve(abs); // dangling symlink: keep, keyed by spelled path
+      isLink = false;
+    }
+    const prev = chosen.get(key);
+    if (!prev) { chosen.set(key, { rel: r, isLink }); continue; }
+    duplicatesSkipped++;
+    if (prev.isLink && !isLink) chosen.set(key, { rel: r, isLink }); // real spelling wins over alias
+  }
+  return { files: [...chosen.values()].map((v) => v.rel).sort(), duplicatesSkipped };
+}
+
+// Whole-word token matcher: a hit must not be glued to word characters on
+// either side, but path punctuation (`/`, `.`, `-`) may border it — so
+// "0001" finds "decisions/0001-postgres-over-mongo.md" while "TASK-05"
+// still refuses to match "TASK-055" or "XTASK-05".
+function wholeWordSource(token) {
+  const esc = token.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  return `(?<![A-Za-z0-9_])${esc}(?![A-Za-z0-9_])`;
+}
+const TASK_ID_SOURCE = '(?<![A-Za-z0-9_])TASK-\\d+(?![A-Za-z0-9_])';
+const FR_ID_SOURCE = '(?<![A-Za-z0-9_])FR-[A-Z0-9]+-\\d+(?![A-Za-z0-9_])';
+
+// Artifact-relative cross-references (artifact-templates.md rule 5): a slash-
+// carrying path ending in a doc/yaml extension, e.g. `../architecture.yaml`.
+// Bare same-dir names are only trusted inside explicit markdown links
+// (`](c4-container.md)`) — prose mentions like "tasks.yaml" resolve
+// file-relatively and would be false positives.
+const ARTIFACT_PATH_RE = /(?<![A-Za-z0-9_./-])((?:\.\.?\/)?[A-Za-z0-9_.-]+(?:\/[A-Za-z0-9_.-]+)+\.(?:md|markdown|ya?ml))(?![A-Za-z0-9_/-])/g;
+const MD_LINK_RE = /\]\(([^)\s]+)(?:\s+"[^"]*")?\)/g;
+const GENERATED_AT_RE = /generated_at:\s*(\S+)/;
+
+/**
+ * Parse one markdown document: ATX headings (H1-H3 reported, any level kept
+ * for diagram titles), fence bookkeeping, and artifact-path references.
+ * Headings and links ignore fenced code; line numbers are 1-based post-CRLF
+ * normalization.
+ */
+function parseMarkdown(text) {
+  const lines = text.split('\n');
+  const headings = [];
+  const allHeadings = [];
+  const fences = [];
+  const links = [];
+  let inFence = false;
+  for (let i = 0; i < lines.length; i++) {
+    const line = lines[i];
+    if (/^ {0,3}```/.test(line)) {
+      const info = line.replace(/^ {0,3}```/, '').trim();
+      // CommonMark pairing (nested-fence guard): inside an open fence only a
+      // BARE ``` closes it — an info-carrying ``` (e.g. a ```mermaid example
+      // quoted inside a ```text block) is CONTENT, never an opener. This keeps
+      // nested fences from producing phantom diagram entries or false titles.
+      if (inFence) {
+        if (info === '') { fences.push({ line: i + 1, info: null }); inFence = false; }
+      } else {
+        fences.push({ line: i + 1, info });
+        inFence = true;
+      }
+      continue;
+    }
+    if (inFence) continue;
+    const h = /^(#{1,6})\s+(.+?)\s*$/.exec(line);
+    if (h) {
+      const entry = { level: h[1].length, text: h[2], line: i + 1 };
+      allHeadings.push(entry);
+      if (entry.level <= 3) headings.push(entry);
+      continue;
+    }
+    ARTIFACT_PATH_RE.lastIndex = 0;
+    let m;
+    while ((m = ARTIFACT_PATH_RE.exec(line)) !== null) links.push({ line: i + 1, target: m[1] });
+    MD_LINK_RE.lastIndex = 0;
+    let lm;
+    while ((lm = MD_LINK_RE.exec(line)) !== null) {
+      const t = lm[1];
+      if (/^[a-z][a-z0-9+.-]*:/i.test(t) || t.startsWith('#')) continue; // scheme'd or pure anchor
+      if (/\.(md|markdown|ya?ml)$/i.test(t.split('#')[0])) links.push({ line: i + 1, target: t });
+    }
+  }
+  // A target reachable by both extractors counts once.
+  const seen = new Set();
+  const uniqueLinks = links.filter((l) => {
+    const k = `${l.line}\u0000${l.target}`;
+    if (seen.has(k)) return false;
+    seen.add(k);
+    return true;
+  });
+  return { lines, headings, allHeadings, fences, links: uniqueLinks, balanced: fences.length % 2 === 0 };
+}
+
+/** Every markdown doc under the slug (or just the --file scope), pre-parsed.
+ * Returns { docs, duplicatesSkipped } so overview can report collapsed aliases. */
+function collectDocs() {
+  const { files, duplicatesSkipped } = walkFiles(MD_RE);
+  const docs = files
+    .filter((r) => fileScope === null || r === fileScope)
+    .map((r) => {
+      const abs = join(slugDir, r);
+      const text = readText(abs) ?? '';
+      return { rel: r, abs, ...parseMarkdown(text) };
+    });
+  return { docs, duplicatesSkipped };
+}
+
+const wordCount = (lines) => lines.join(' ').split(/\s+/).filter(Boolean).length;
+
+// --- modes ------------------------------------------------------------------
+if (opts.validate || opts.stale) {
+  // Both gated modes need tasks.yaml: validate cross-checks its ids, stale
+  // derives the freshness threshold from it. Absent/unparseable = bad input.
+  const tasksRel = 'tasks.yaml';
+  const tasksAbs = join(slugDir, tasksRel);
+  let raw;
+  try { raw = readFileSync(tasksAbs, 'utf8'); } catch { die(`cannot read ${tasksRel} in ${opts.input} (missing or unreadable)`); }
+  let taskIds = new Set();
+  let tasks = null; // hoisted: the validate branch's structural gate needs it
+  if (opts.validate) {
+    let data;
+    try { ({ data } = parseYaml(raw, { filename: tasksRel })); } catch (e) {
+      die(`${tasksRel}: unparseable YAML (${String(e?.message ?? e).replace(/^[^:]*:\d+:\s*/, '')})`);
+    }
+    tasks = data?.tasks;
+    if (!Array.isArray(tasks)) die(`${tasksRel}: missing 'tasks:' sequence`);
+    taskIds = new Set(tasks.map((t) => String(t?.id)));
+  }
+
+  if (opts.stale) {
+    // Freshness stamp: the file's `generated_at:` provenance comment when
+    // present, else its filesystem mtime. Threshold = max(tasks.yaml
+    // generated_at, tasks.yaml mtime) — the newest claim tasks.yaml makes.
+    const stampOf = (abs) => {
+      const text = readText(abs);
+      if (text) {
+        for (const line of text.split('\n')) {
+          const m = GENERATED_AT_RE.exec(line);
+          if (m && Number.isFinite(Date.parse(m[1]))) return m[1];
+        }
+      }
+      return new Date(statSync(abs).mtimeMs).toISOString();
+    };
+    const threshold = Math.max(
+      (() => { const m = GENERATED_AT_RE.exec(raw); const t = m ? Date.parse(m[1]) : NaN; return Number.isFinite(t) ? t : -Infinity; })(),
+      statSync(tasksAbs).mtimeMs,
+    );
+    const stale = walkFiles(/\.md$|\.ya?ml$/i)
+      .files
+      .filter((r) => r !== tasksRel && (fileScope === null || r === fileScope))
+      .map((r) => ({ file: relFromRoot(join(slugDir, r)), generatedAt: stampOf(join(slugDir, r)) }))
+      .filter((e) => Date.parse(e.generatedAt) < threshold);
+    console.log(JSON.stringify({ newestSource: 'tasks.yaml', stale }, null, 2));
+  } else {
+    // Structural gate first: a tasks.yaml with duplicate task ids or dangling
+    // depends_on is unexecutable — surface it as exit 2 (GraphError class),
+    // naming the offending id, before any reference scanning.
+    try {
+      buildGraph(tasks);
+    } catch (e) {
+      if (e instanceof GraphError) die(e.message, 2);
+      throw e;
+    }
+    // --validate: five broken classes — unknown TASK-nn, unresolved FR-id,
+    // dangling artifact link, unbalanced (odd) mermaid/code fences, and
+    // 'dup-definition' (the same FR id defined on 2+ lines inside prd.md is
+    // ambiguity, and highest-quality data forbids silently picking one).
+    // Plus non-fatal `warnings` (heading-level sanity) that never move `ok`
+    // or the exit code — only the verifier owns pass/fail.
+    //
+    // Counting semantics: `checked.*` counts UNIQUE refs; every entry in
+    // `broken[]` appears exactly ONCE, at its first occurrence line. (--refs-to
+    // intentionally lists EVERY occurrence line instead — lens vs gate.)
+    const { docs } = collectDocs();
+    const broken = [];
+    const warnings = [];
+    const checked = { taskRefs: 0, frRefs: 0, links: 0, mermaidFences: 0 };
+
+    // ref -> { n, first } : occurrence COUNT plus FIRST site (docs arrive
+    // path-sorted and lines ascend, so `first` is deterministic).
+    const taskOcc = new Map();
+    const frDefOcc = new Map(); // occurrences inside docs/prd.md define
+    const frRefOcc = new Map(); // everywhere else references
+    const PRD_REL = 'docs/prd.md';
+    for (const doc of docs) {
+      const isPrd = doc.rel === PRD_REL;
+      const bump = (sink, ref, at) => {
+        const e = sink.get(ref);
+        if (e) e.n++;
+        else sink.set(ref, { n: 1, first: at });
+      };
+      const scan = (source, sink) => {
+        const re = new RegExp(source, 'g');
+        for (let i = 0; i < doc.lines.length; i++) {
+          re.lastIndex = 0;
+          let m;
+          while ((m = re.exec(doc.lines[i])) !== null) bump(sink, m[0], { file: relFromRoot(doc.abs), line: i + 1 });
+        }
+      };
+      scan(TASK_ID_SOURCE, taskOcc);
+      scan(FR_ID_SOURCE, isPrd ? frDefOcc : frRefOcc);
+      checked.taskRefs = taskOcc.size;
+      checked.frRefs = frRefOcc.size;
+
+      // Links: dedup by (file, target) — the same link repeated in one file is
+      // ONE ref: counted once in checked.links, reported once if broken.
+      const linkSeen = new Set();
+      for (const link of doc.links) {
+        const lkey = `${doc.rel}\u0000${link.target}`;
+        if (linkSeen.has(lkey)) continue;
+        linkSeen.add(lkey);
+        checked.links++;
+        const target = link.target.split('#')[0];
+        if (target && !existsSync(resolve(dirname(doc.abs), target))) {
+          broken.push({ kind: 'link', ref: link.target, file: relFromRoot(doc.abs), line: link.line });
+        }
+      }
+
+      checked.mermaidFences += doc.fences.length;
+      if (!doc.balanced) {
+        broken.push({
+          kind: 'mermaid',
+          ref: `unbalanced fences (${doc.fences.length})`,
+          file: relFromRoot(doc.abs),
+          line: doc.fences[doc.fences.length - 1].line,
+        });
+      }
+
+      // Cheap heading-level sanity: an H3 with no preceding H2 in the same
+      // file signals a skipped structural level (H1 titles don't count as
+      // section context). Warning only — never fatal.
+      let seenH2 = false;
+      for (const h of doc.headings) {
+        if (h.level === 2) seenH2 = true;
+        else if (h.level === 3 && !seenH2) warnings.push({ kind: 'heading-skip', file: relFromRoot(doc.abs), line: h.line });
+      }
+    }
+    for (const [ref, occ] of taskOcc) if (!taskIds.has(ref)) broken.push({ kind: 'task', ref, ...occ.first });
+    for (const [ref, occ] of frRefOcc) if (!frDefOcc.has(ref)) broken.push({ kind: 'fr', ref, ...occ.first });
+    for (const [ref, occ] of frDefOcc) if (occ.n > 1) broken.push({ kind: 'dup-definition', ref, ...occ.first });
+    broken.sort((a, b) => (a.file < b.file ? -1 : a.file > b.file ? 1 : a.line - b.line || (a.kind < b.kind ? -1 : a.kind > b.kind ? 1 : a.ref < b.ref ? -1 : 1)));
+    warnings.sort((a, b) => (a.file < b.file ? -1 : a.file > b.file ? 1 : a.line - b.line));
+    const ok = broken.length === 0;
+    console.log(JSON.stringify({ ok, checked, broken, warnings }, null, 2));
+    process.exit(ok ? 0 : 1);
+  }
+} else if (opts.refsTo !== null) {
+  // Backlink query: any line in any markdown artifact containing the token as
+  // a whole word — TASK-nn, FR-<MODULE>-nn, ADR NNNN[-slug], or a relative
+  // artifact path alike; the matcher is uniform by design.
+  // INTENTIONAL asymmetry vs --validate: this lens lists EVERY occurrence
+  // line (a "where is this mentioned" report), while --validate reports each
+  // unique broken ref once at its first occurrence. Do not "dedup" this mode.
+  const re = new RegExp(wholeWordSource(opts.refsTo));
+  const matches = [];
+  for (const doc of collectDocs().docs) {
+    for (let i = 0; i < doc.lines.length; i++) {
+      if (re.test(doc.lines[i])) matches.push({ file: relFromRoot(doc.abs), line: i + 1, text: doc.lines[i].trim() });
+    }
+  }
+  console.log(JSON.stringify({ ref: opts.refsTo, matches }, null, 2));
+} else if (opts.diagrams) {
+  const diagrams = [];
+  for (const doc of collectDocs().docs) {
+    for (let k = 0; k < doc.fences.length; k++) {
+      const f = doc.fences[k];
+      if (f.info !== 'mermaid') continue;
+      const closer = doc.fences[k + 1]; // fence toggling pairs opens with closes
+      const endLine = closer ? closer.line : doc.lines.length + 1;
+      const body = doc.lines.slice(f.line, endLine - 1);
+      const comment = body.map((l) => /^\s*%%\s?(.*)$/.exec(l)).find(Boolean);
+      const heading = [...doc.allHeadings].reverse().find((h) => h.line < f.line);
+      diagrams.push({
+        file: relFromRoot(doc.abs),
+        startLine: f.line,
+        title: heading ? heading.text : comment ? comment[1].trim() : null,
+        nodeCount: body.filter((l) => /^\s*[A-Za-z0-9_]+[[{(]/.test(l)).length,
+        balanced: Boolean(closer),
+      });
+    }
+  }
+  console.log(JSON.stringify({ diagrams }, null, 2));
+} else {
+  // Overview (scale guard): the deduped inventory is always computed in full
+  // and sorted, but only the FIRST 100 files are emitted — with
+  // `truncated:true` whenever anything was cut — so agents reading the JSON
+  // are never silently surprised by deterministic truncation. totalFiles
+  // reports the true post-dedup count either way.
+  const { docs, duplicatesSkipped } = collectDocs();
+  const allFiles = docs.map((doc) => ({
+    path: relFromRoot(doc.abs),
+    title: doc.headings.find((h) => h.level === 1)?.text ?? basename(doc.rel),
+    headings: doc.headings,
+    wordCount: wordCount(doc.lines),
+  }));
+  const truncated = allFiles.length > OVERVIEW_MAX_FILES;
+  const files = truncated ? allFiles.slice(0, OVERVIEW_MAX_FILES) : allFiles;
+  console.log(JSON.stringify({ slug, files, totalFiles: allFiles.length, duplicatesSkipped, truncated }, null, 2));
+}
+
+// ---------------------------------------------------------------------------
+// WHY doc-index.mjs EXISTS: the codegraph-family indexers our users already run
+// verifiably do not cover this ground — audited 8 tools, Aug 2026: none extract
+// markdown headings or YAML task semantics (installed codegraph v1.0.1 indexes
+// neither .md nor .yaml), so everything archgen writes into .archgen/<slug>/ is
+// invisible to every symbol graph. This script is archgen's deterministic
+// markdown layer: zero dependencies, byte-stable JSON, safe to gate CI on.
+// ---------------------------------------------------------------------------

package/vendor/skills/archgen/scripts/impact.mjs

@@ -8,7 +8,20 @@ import { parseYaml } from './lib/yaml.mjs';
 const [, , file, target] = process.argv;
 if (!file || !target) { console.error('usage: impact.mjs <tasks.yaml> <taskId-or-artifactPath>'); process.exit(4); }
 
-const { data } = parseYaml(readFileSync(file, 'utf8'), { filename: file });
+let raw;
+try {
+  raw = readFileSync(file, 'utf8');
+} catch {
+  console.error(`cannot read ${file} (missing or unreadable)`);
+  process.exit(4);
+}
+let data;
+try {
+  ({ data } = parseYaml(raw, { filename: file }));
+} catch (e) {
+  console.error(`${file}: unparseable YAML (${String(e?.message ?? e).replace(/^[^:]*:\d+:\s*/, '')})`);
+  process.exit(4);
+}
 const tasks = data?.tasks;
 if (!Array.isArray(tasks)) { console.error(`${file}: missing 'tasks:' sequence`); process.exit(4); }
 

package/vendor/skills/archgen/scripts/lib/graph.mjs

@@ -2,16 +2,26 @@
 // WHY a lib: validate.mjs, next-tasks.mjs and verify-plan.mjs must agree on
 // cycle detection and wave semantics; three copies would drift (Metis finding).
 
+/** True iff `t` is a mapping object (not null, not an array, not a scalar). */
+function isTaskMapping(t) {
+  return t !== null && typeof t === 'object' && !Array.isArray(t);
+}
+
 /** Build adjacency (prerequisite → dependents) + reverse maps from tasks.
  * Normative semantics: depends_on lists PREREQUISITE ids; a task is ready iff
- * every prerequisite is done; wave 1 = empty depends_on. */
+ * every prerequisite is done; wave 1 = empty depends_on.
+ * Entries must be mappings with a non-empty string id — anything else is a
+ * GraphError naming the index, so consumers exit with a clean contract code
+ * instead of an uncaught TypeError on malformed tasks.yaml shapes. */
 export function buildGraph(tasks) {
   /** @type {Map<string, string[]>} prereq -> [dependent ids] */
   const dependents = new Map();
   /** @type {Map<string, string[]>} id -> prerequisite ids */
   const prerequisites = new Map();
   const byId = new Map();
-  for (const t of tasks) {
+  for (const [i, t] of tasks.entries()) {
+    if (!isTaskMapping(t)) throw new GraphError(`tasks[${i}]: not a mapping (task entries must be 'key: value' mappings)`);
+    if (typeof t.id !== 'string' || t.id.length === 0) throw new GraphError(`tasks[${i}]: missing string 'id' (every task needs a non-empty string id)`);
     if (byId.has(t.id)) throw new GraphError(`duplicate task id: ${t.id}`);
     byId.set(t.id, t);
     prerequisites.set(t.id, Array.isArray(t.depends_on) ? t.depends_on : []);
@@ -113,16 +123,100 @@ export function computeWaves(byId, prerequisites) {
 }
 
 /** First ownership conflict inside a single wave, or null.
- * Ownership globs are treated as opaque strings for equality here — two tasks
- * in the same wave must not claim the SAME literal glob (conservative rule that
- * needs no glob-engine dependency). */
+ * Two rules, both conservative:
+ *  1. Literal equality — two tasks must never claim the SAME glob string.
+ *  2. Glob intersection — when a '**' is involved, patterns whose non-glob
+ *     prefix segments overlap compatibly are flagged (e.g. "src/**" vs a
+ *     TypeScript-scoped variant of it). When segment comparison is uncertain
+ *     (wildcards), the pair IS flagged: false positives merely force a rename;
+ *     false negatives let parallel workers corrupt each other's files.
+ */
 export function findOwnershipConflict(wave) {
   const seen = new Map();
+  const claimed = [];
   for (const t of wave) {
     for (const g of t.file_ownership ?? []) {
       if (seen.has(g)) return { glob: g, a: seen.get(g), b: t.id };
+      for (const prev of claimed) {
+        if (globsMayOverlap(prev.glob, g)) return { glob: g, a: prev.id, b: t.id };
+      }
       seen.set(g, t.id);
+      claimed.push({ glob: g, id: t.id });
     }
   }
   return null;
 }
+
+/** Conservative may-intersect test for two ownership globs. */
+function globsMayOverlap(a, b) {
+  if (a === b) return true;
+  // Deepen the check only when a recursive '**' is involved; plain literal
+  // globs keep the cheap equality rule above.
+  if (!a.includes('**') && !b.includes('**')) return false;
+  const as = a.split('/');
+  const bs = b.split('/');
+  const n = Math.min(as.length, bs.length);
+  for (let i = 0; i < n; i++) {
+    const x = as[i];
+    const y = bs[i];
+    if (x === y) continue;
+    if (x === '**' || y === '**') return true; // '**' swallows any divergence below it
+    if (x.includes('*') || y.includes('*') || x.includes('?') || y.includes('?')) return true; // uncertain -> flag
+    return false; // both segments literal and different: paths diverge here
+  }
+  return true; // one pattern is a segment-prefix of the other
+}
+
+// --- additive (hardening pass): dedup normalization + quality surfacing -----
+
+/** Collapse redundant depends_on entries BEFORE graph construction so no
+ * downstream consumer can ever see the same edge twice (idempotency: identical
+ * input ⇒ byte-identical output with zero duplicated entities).
+ * First occurrence wins; order otherwise preserved. Tasks without an array
+ * depends_on pass through untouched.
+ * @param {Array<any>} tasks
+ * @returns {{tasks: Array<any>, duplicatesCollapsed: number}} */
+export function dedupeDependencies(tasks) {
+  let duplicatesCollapsed = 0;
+  const normalized = tasks.map((t) => {
+    // Malformed entries pass through untouched; buildGraph owns reporting them
+    // (touching t.depends_on here would throw before the contract check runs).
+    if (!isTaskMapping(t) || !Array.isArray(t.depends_on)) return t;
+    const seen = new Set();
+    const deps = [];
+    for (const d of t.depends_on) {
+      if (seen.has(d)) { duplicatesCollapsed++; continue; }
+      seen.add(d);
+      deps.push(d);
+    }
+    return deps.length === t.depends_on.length ? t : { ...t, depends_on: deps };
+  });
+  return { tasks: normalized, duplicatesCollapsed };
+}
+
+/** Data-quality facts computed from parsed data WITHOUT judging them — the
+ * verifier owns pass/fail; indexers only surface facts deterministically.
+ *  - selfDeps: tasks whose depends_on includes their own id (note: such a task
+ *    is also a 1-node cycle, so the CLI cycle gate normally exits 2 first;
+ *    the field keeps the shape uniform for lib-level consumers).
+ *  - emptyOwnership: missing or empty file_ownership (parallel workers would
+ *    have no disjointness contract).
+ *  - blankAcceptance: missing or empty acceptance (no objective done-criteria).
+ * @param {Array<any>} tasks
+ * @returns {{selfDeps: number, emptyOwnership: number, blankAcceptance: number}} */
+export function computeQualityStats(tasks) {
+  let selfDeps = 0;
+  let emptyOwnership = 0;
+  let blankAcceptance = 0;
+  for (const t of tasks) {
+    // Malformed entries are buildGraph's to report; counting them here would
+    // throw on property access before any consumer sees a contract error.
+    if (!isTaskMapping(t)) continue;
+    if (Array.isArray(t.depends_on) && t.depends_on.includes(t.id)) selfDeps++;
+    const own = t.file_ownership;
+    if (!Array.isArray(own) || own.length === 0) emptyOwnership++;
+    const acc = t.acceptance;
+    if (!Array.isArray(acc) || acc.length === 0) blankAcceptance++;
+  }
+  return { selfDeps, emptyOwnership, blankAcceptance };
+}