archgen-skill 0.0.2 → 0.0.4

package/vendor/skills/archgen/scripts/validate.mjs

@@ -11,10 +11,18 @@ import { buildGraph, findCycle, GraphError } from './lib/graph.mjs';
 const STATUSES = ['pending', 'ready', 'running', 'blocked', 'done', 'failed'];
 const REQUIRED = ['id', 'title', 'file_ownership'];
 const KNOWN_KEYS = new Set(['id', 'title', 'status', 'depends_on', 'parallel_group', 'file_ownership', 'artifacts', 'acceptance']);
+// Mirrors schemas/tasks.schema.json `id.pattern` — ids are strings, never
+// numeric-coerced scalars, or set-status/next-tasks cannot address the task.
+const ID_PATTERN = /^[A-Za-z0-9][A-Za-z0-9._-]*$/;
 
 const [, , file, ...rest] = process.argv;
 if (!file) { console.error('usage: validate.mjs <tasks.yaml> [--plan <dir>]'); process.exit(1); }
 const planDirIdx = rest.indexOf('--plan');
+if (planDirIdx >= 0 && rest[planDirIdx + 1] === undefined) {
+  // '--plan' with no value must never silently skip coverage checks.
+  console.error('usage: validate.mjs <tasks.yaml> [--plan <dir>] (--plan requires a directory value)');
+  process.exit(2);
+}
 const planDir = planDirIdx >= 0 ? rest[planDirIdx + 1] : null;
 
 /** @type {string[]} errors */ const errors = [];
@@ -42,7 +50,16 @@ for (const [i, t] of tasks.entries()) {
   const where = `tasks[${i}] (${t?.id ?? '<no-id>'})`;
   if (t === null || typeof t !== 'object' || Array.isArray(t)) { errors.push(`${where}: not a mapping`); continue; }
   for (const k of Object.keys(t)) if (!KNOWN_KEYS.has(k)) warnings.push(`${where}: unknown key '${k}' (ignored)`);
-  for (const r of REQUIRED) if (t[r] === undefined) errors.push(`${where}: missing required field '${r}'`);
+  // Required means present AND non-empty: `id:` parses to null, which is not
+  // undefined — an explicit empty value must fail, not bypass the check.
+  for (const r of REQUIRED) {
+    const v = t[r];
+    if (v === undefined) errors.push(`${where}: missing required field '${r}'`);
+    else if (v === null || (typeof v === 'string' && v.trim() === '')) errors.push(`${where}: required field '${r}' is empty`);
+  }
+  if (t.id !== undefined && t.id !== null && (typeof t.id !== 'string' || !ID_PATTERN.test(t.id))) {
+    errors.push(`${where}: invalid id '${t.id}' (must be a string matching ^[A-Za-z0-9][A-Za-z0-9._-]*$)`);
+  }
   if (t.status !== undefined && !STATUSES.includes(t.status)) errors.push(`${where}: invalid status '${t.status}' (allowed: ${STATUSES.join('|')})`);
   if (Array.isArray(t.file_ownership) && t.file_ownership.length === 0) errors.push(`${where}: file_ownership must be non-empty`);
   if (t.depends_on !== undefined && !Array.isArray(t.depends_on)) errors.push(`${where}: depends_on must be a list`);

package/vendor/skills/archgen/scripts/verify-plan.mjs

@@ -11,7 +11,7 @@ import { checkPlanCoverage } from './lib/plan-coverage.mjs';
 
 const [, , file, ...rest] = process.argv;
 const planIdx = rest.indexOf('--plan');
-if (!file || planIdx < 0) {
+if (!file || planIdx < 0 || !rest[planIdx + 1]) {
   console.error('usage: verify-plan.mjs <tasks.yaml> --plan <plans-dir>');
   process.exit(2);
 }
@@ -35,10 +35,13 @@ if (issues.length === 0) {
     if (cycle.length) issues.push(`dependency cycle: ${cycle.join(' -> ')}`);
 
     // Every task must carry acceptance criteria — the verifier refuses work
-    // that cannot be objectively checked later.
+    // that cannot be objectively checked later. Entries must be non-blank
+    // strings: whitespace-only or empty entries are placeholders, not criteria.
     for (const t of tasks) {
       if (!Array.isArray(t.acceptance) || t.acceptance.length === 0) {
         issues.push(`task '${t.id}' has no acceptance criteria`);
+      } else if (t.acceptance.some((a) => typeof a !== 'string' || a.trim() === '')) {
+        issues.push(`task '${t.id}' has empty or whitespace-only acceptance criteria`);
       }
       if (!Array.isArray(t.file_ownership) || t.file_ownership.length === 0) {
         issues.push(`task '${t.id}' has empty file_ownership`);
@@ -55,8 +58,10 @@ if (issues.length === 0) {
 
     issues.push(...checkPlanCoverage(planDir, tasks));
   } catch (e) {
+    // Exotic inputs must surface as a clean ISSUES verdict, never a raw stack:
+    // the verifier is a gate, and gates report findings, not crashes.
     if (e instanceof GraphError) issues.push(e.message);
-    else throw e;
+    else issues.push(`internal check failure: ${e?.message ?? String(e)}`);
   }
 }