arc-1 0.9.2 → 0.9.3

package/dist/handlers/intent.d.ts

@@ -63,6 +63,26 @@ export declare function handleToolCall(client: AdtClient, config: ServerConfig,
  */
 export declare function warnCdsReservedKeywords(source: string): string | undefined;
 export declare function buildCreateXml(type: string, name: string, pkg: string, description: string, properties?: Record<string, unknown>): string;
+/**
+ * Strip SAPGUI-style function-module parameter comment blocks from an FM source body.
+ *
+ * SAP rejects PUT-to-source/main with parameter comment blocks (verified live on a4h
+ * S/4HANA 2023 — issue #250):
+ *   HTTP 400 / com.sap.adt.sedi / ExceptionResourceScanDuringSaveFailure
+ *   "Parameter comment blocks are not allowed" (T100KEY FUNC_ADT028)
+ *
+ * The signature is metadata, not source. LLMs frequently emit the SAPGUI block out
+ * of muscle memory (every released FM ships with one). This helper strips lines whose
+ * first non-whitespace tokens are `*"` so the PUT succeeds, and reports back whether
+ * stripping occurred so the caller can append a warning to the response.
+ *
+ * Only `*"…` lines are stripped — single `*` ABAP comments and inline `"` comments
+ * are preserved. Exported for unit tests.
+ */
+export declare function stripFmParamCommentBlock(source: string): {
+    source: string;
+    wasStripped: boolean;
+};
 export declare const SLASH_TYPE_MAP: Record<string, string>;
 /**
  * Citation guard companion for SLASH_TYPE_MAP. Keys MUST stay key-equal to

package/dist/handlers/intent.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"intent.d.ts","sourceRoot":"","sources":["../../src/handlers/intent.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,gDAAgD,CAAC;AAC/E,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,2CAA2C,CAAC;AAqBxE,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAC;AAmHpE,OAAO,KAAK,EAKV,gBAAgB,EACjB,MAAM,iBAAiB,CAAC;AAGzB,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,2BAA2B,CAAC;AAc9D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAKvD,2BAA2B;AAC3B,MAAM,WAAW,UAAU;IACzB,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC/C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AAiBD;;;GAGG;AACH,eAAO,MAAM,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAe9C,CAAC;AAEF;;GAEG;AACH,wBAAgB,gBAAgB,CAAC,QAAQ,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,GAAG,OAAO,CAKnF;AAqFD;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,MAAM,GAAG;IAAE,UAAU,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,OAAO,CAAA;CAAE,CAe1F;AAED;;;;GAIG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,MAAM,GAAG,OAAO,CASzD;AAkqBD;;;;;;;GAOG;AACH,wBAAsB,cAAc,CAClC,MAAM,EAAE,SAAS,EACjB,MAAM,EAAE,YAAY,EACpB,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAC7B,QAAQ,CAAC,EAAE,QAAQ,EACnB,OAAO,CAAC,EAAE,MAAM,EAChB,YAAY,CAAC,EAAE,YAAY,EAC3B,eAAe,CAAC,EAAE,OAAO,GACxB,OAAO,CAAC,UAAU,CAAC,CA+MrB;AAwjCD;;;GAGG;AACH,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAyB1E;AAED,wBAAgB,cAAc,CAC5B,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,MAAM,EACZ,GAAG,EAAE,MAAM,EACX,WAAW,EAAE,MAAM,EACnB,UAAU,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GACnC,MAAM,CA6NR;AAuBD,eAAO,MAAM,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAyCjD,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,mBAAmB,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAuBtD,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,gBAAgB,aAqB3B,CAAC;AAEH,2EAA2E;AAC3E,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAIxD;AA+ED;;;GAGG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAuGnD;AAsjGD,0CAA0C;AAC1C,wBAAgB,mBAAmB,IAAI,IAAI,CAG1C;AAED,gEAAgE;AAChE,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,gBAAgB,GAAG,SAAS,GAAG,IAAI,CAE9E;AAED,2DAA2D;AAC3D,wBAAgB,iBAAiB,IAAI,gBAAgB,GAAG,SAAS,CAEhE;AAED,iDAAiD;AACjD,wBAAgB,kBAAkB,CAAC,GAAG,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,GAAG,IAAI,CAEnE;AAED,iDAAiD;AACjD,wBAAgB,kBAAkB,IAAI,GAAG,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,CAE1D"}
+{"version":3,"file":"intent.d.ts","sourceRoot":"","sources":["../../src/handlers/intent.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,gDAAgD,CAAC;AAC/E,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,2CAA2C,CAAC;AAqBxE,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAC;AAmHpE,OAAO,KAAK,EAKV,gBAAgB,EACjB,MAAM,iBAAiB,CAAC;AAGzB,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,2BAA2B,CAAC;AAc9D,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAKvD,2BAA2B;AAC3B,MAAM,WAAW,UAAU;IACzB,OAAO,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,MAAM,CAAC;QAAC,IAAI,EAAE,MAAM,CAAA;KAAE,CAAC,CAAC;IAC/C,OAAO,CAAC,EAAE,OAAO,CAAC;CACnB;AAiBD;;;GAGG;AACH,eAAO,MAAM,WAAW,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAe9C,CAAC;AAEF;;GAEG;AACH,wBAAgB,gBAAgB,CAAC,QAAQ,EAAE,QAAQ,EAAE,aAAa,EAAE,MAAM,GAAG,OAAO,CAKnF;AAqFD;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,MAAM,GAAG;IAAE,UAAU,EAAE,MAAM,CAAC;IAAC,OAAO,EAAE,OAAO,CAAA;CAAE,CAe1F;AAED;;;;GAIG;AACH,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,MAAM,GAAG,OAAO,CASzD;AAkqBD;;;;;;;GAOG;AACH,wBAAsB,cAAc,CAClC,MAAM,EAAE,SAAS,EACjB,MAAM,EAAE,YAAY,EACpB,QAAQ,EAAE,MAAM,EAChB,IAAI,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EAC7B,QAAQ,CAAC,EAAE,QAAQ,EACnB,OAAO,CAAC,EAAE,MAAM,EAChB,YAAY,CAAC,EAAE,YAAY,EAC3B,eAAe,CAAC,EAAE,OAAO,GACxB,OAAO,CAAC,UAAU,CAAC,CA+MrB;AA2kCD;;;GAGG;AACH,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,MAAM,GAAG,MAAM,GAAG,SAAS,CAyB1E;AAED,wBAAgB,cAAc,CAC5B,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,MAAM,EACZ,GAAG,EAAE,MAAM,EACX,WAAW,EAAE,MAAM,EACnB,UAAU,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GACnC,MAAM,CAuPR;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,wBAAwB,CAAC,MAAM,EAAE,MAAM,GAAG;IAAE,MAAM,EAAE,MAAM,CAAC;IAAC,WAAW,EAAE,OAAO,CAAA;CAAE,CAIjG;AAuBD,eAAO,MAAM,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAyCjD,CAAC;AAEF;;;;;GAKG;AACH,eAAO,MAAM,mBAAmB,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAuBtD,CAAC;AAEF;;;;;;GAMG;AACH,eAAO,MAAM,gBAAgB,aAqB3B,CAAC;AAEH,2EAA2E;AAC3E,wBAAgB,mBAAmB,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAIxD;AA+ED;;;GAGG;AACH,wBAAgB,cAAc,CAAC,IAAI,EAAE,MAAM,GAAG,MAAM,CAuGnD;AA+pGD,0CAA0C;AAC1C,wBAAgB,mBAAmB,IAAI,IAAI,CAG1C;AAED,gEAAgE;AAChE,wBAAgB,iBAAiB,CAAC,QAAQ,EAAE,gBAAgB,GAAG,SAAS,GAAG,IAAI,CAE9E;AAED,2DAA2D;AAC3D,wBAAgB,iBAAiB,IAAI,gBAAgB,GAAG,SAAS,CAEhE;AAED,iDAAiD;AACjD,wBAAgB,kBAAkB,CAAC,GAAG,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,GAAG,IAAI,CAEnE;AAED,iDAAiD;AACjD,wBAAgB,kBAAkB,IAAI,GAAG,CAAC,MAAM,EAAE,MAAM,EAAE,CAAC,CAE1D"}

package/dist/handlers/intent.js

@@ -1590,12 +1590,22 @@ const SERVICEBINDING_V2_CONTENT_TYPE = 'application/vnd.sap.adt.businessservices
 const BDEF_CONTENT_TYPE = 'application/vnd.sap.adt.blues.v1+xml';
 const MESSAGECLASS_CONTENT_TYPE = 'application/vnd.sap.adt.mc.messageclass+xml';
 const SKTD_V2_CONTENT_TYPE = 'application/vnd.sap.adt.sktdv2+xml';
+// Function group + function module content types — verified live on a4h S/4HANA 2023
+// (issue #250). FUGR uses the v3 group envelope; FUNC uses the unversioned fmodule envelope.
+const FUNCTION_GROUP_CONTENT_TYPE = 'application/vnd.sap.adt.functions.groups.v3+xml';
+const FUNCTION_MODULE_CONTENT_TYPE = 'application/vnd.sap.adt.functions.fmodules+xml';
 function isMetadataWriteType(type) {
     return type === 'DOMA' || type === 'DTEL' || type === 'MSAG' || type === 'SRVB';
 }
 /** Types that require a specific vendor content type for creation (not application/*) */
 function needsVendorContentType(type) {
-    return type === 'DOMA' || type === 'DTEL' || type === 'BDEF' || type === 'MSAG' || type === 'SKTD';
+    return (type === 'DOMA' ||
+        type === 'DTEL' ||
+        type === 'BDEF' ||
+        type === 'MSAG' ||
+        type === 'SKTD' ||
+        type === 'FUGR' ||
+        type === 'FUNC');
 }
 /** Content type used for create POST */
 function createContentTypeForType(type) {
@@ -1634,6 +1644,10 @@ function vendorContentTypeForType(type) {
             return MESSAGECLASS_CONTENT_TYPE;
         case 'SKTD':
             return SKTD_V2_CONTENT_TYPE;
+        case 'FUGR':
+            return FUNCTION_GROUP_CONTENT_TYPE;
+        case 'FUNC':
+            return FUNCTION_MODULE_CONTENT_TYPE;
         default:
             // Wildcard lets the SAP server resolve the correct handler.
             // Sending 'application/xml' causes 415 on DDL-based endpoints
@@ -1684,6 +1698,9 @@ function getMetadataWriteProperties(input) {
         category: input.category,
         version: input.version,
         odataVersion: input.odataVersion,
+        // Function-module create needs the parent function-group name for the
+        // <adtcore:containerRef> in the create payload (issue #250).
+        group: input.group,
     };
     return props;
 }
@@ -2082,6 +2099,30 @@ export function buildCreateXml(type, name, pkg, description, properties) {
             };
             return buildMessageClassXml(params);
         }
+        case 'FUGR':
+            // Function group create envelope. POSTed to /sap/bc/adt/functions/groups
+            // with Content-Type: application/vnd.sap.adt.functions.groups.v3+xml.
+            // Verified live on a4h S/4HANA 2023 (issue #250).
+            return `<?xml version="1.0" encoding="UTF-8"?>
+<group:abapFunctionGroup xmlns:group="http://www.sap.com/adt/functions/groups" xmlns:adtcore="http://www.sap.com/adt/core" adtcore:description="${escapeXml(description)}" adtcore:language="EN" adtcore:name="${escapeXml(name)}" adtcore:type="FUGR/F" adtcore:masterLanguage="EN">
+  <adtcore:packageRef adtcore:name="${escapeXml(pkg)}"/>
+</group:abapFunctionGroup>`;
+        case 'FUNC': {
+            // Function module create envelope. POSTed to
+            // /sap/bc/adt/functions/groups/{group_lc}/fmodules with
+            // Content-Type: application/vnd.sap.adt.functions.fmodules+xml.
+            // No <adtcore:packageRef> — FM inherits package from the parent FUGR.
+            // adtcore:uri must be lowercase (verified live on a4h).
+            const group = String(properties?.group ?? '').trim();
+            if (!group) {
+                throw new Error('FUNC create requires "group" property — pass it via SAPWrite args (the parent function group must already exist).');
+            }
+            const groupLc = encodeURIComponent(group.toLowerCase());
+            return `<?xml version="1.0" encoding="UTF-8"?>
+<fmodule:abapFunctionModule xmlns:fmodule="http://www.sap.com/adt/functions/fmodules" xmlns:adtcore="http://www.sap.com/adt/core" adtcore:description="${escapeXml(description)}" adtcore:name="${escapeXml(name)}" adtcore:type="FUGR/FF">
+  <adtcore:containerRef adtcore:name="${escapeXml(group)}" adtcore:type="FUGR/F" adtcore:uri="/sap/bc/adt/functions/groups/${groupLc}"/>
+</fmodule:abapFunctionModule>`;
+        }
         default:
             // Fallback — generic objectReferences using the correct URL for the type
             return `<?xml version="1.0" encoding="UTF-8"?>
@@ -2090,6 +2131,27 @@ export function buildCreateXml(type, name, pkg, description, properties) {
 </adtcore:objectReferences>`;
     }
 }
+/**
+ * Strip SAPGUI-style function-module parameter comment blocks from an FM source body.
+ *
+ * SAP rejects PUT-to-source/main with parameter comment blocks (verified live on a4h
+ * S/4HANA 2023 — issue #250):
+ *   HTTP 400 / com.sap.adt.sedi / ExceptionResourceScanDuringSaveFailure
+ *   "Parameter comment blocks are not allowed" (T100KEY FUNC_ADT028)
+ *
+ * The signature is metadata, not source. LLMs frequently emit the SAPGUI block out
+ * of muscle memory (every released FM ships with one). This helper strips lines whose
+ * first non-whitespace tokens are `*"` so the PUT succeeds, and reports back whether
+ * stripping occurred so the caller can append a warning to the response.
+ *
+ * Only `*"…` lines are stripped — single `*` ABAP comments and inline `"` comments
+ * are preserved. Exported for unit tests.
+ */
+export function stripFmParamCommentBlock(source) {
+    const lines = source.split('\n');
+    const kept = lines.filter((line) => !/^\s*\*"/.test(line));
+    return { source: kept.join('\n'), wasStripped: kept.length !== lines.length };
+}
 /** Escape special characters for XML attribute values */
 function escapeXml(s) {
     return s
@@ -2453,12 +2515,42 @@ async function handleSAPWrite(client, args, config, cachingLayer) {
     // (transparent) or /structures/ (DDIC structure). Resolve once via the client's
     // cached URL probe. For 'create' the default /tables/ URL is correct (we only
     // create transparent tables today; structure creation is out of scope).
+    //
+    // For FUNC, the URL has the parent function group baked into the path:
+    //   /sap/bc/adt/functions/groups/{group_lc}/fmodules/{name_lc}
+    // `objectBasePath('FUNC')` deliberately throws (PR #223 — generic URL builders
+    // must fail loudly for FM since they can't know the parent group). Issue #250:
+    // we pre-resolve the URL here from `args.group` (required for create; auto-
+    // resolved via search for update/delete) so the action switch downstream uses
+    // the correct URL. We also mirror the resolved group back onto args so
+    // `buildCreateXml('FUNC', …, properties)` finds it.
     let objectUrl;
     let srcUrl;
     if (type === 'TABL' && action !== 'create' && action !== 'batch_create') {
         objectUrl = await client.resolveTablObjectUrl(name);
         srcUrl = `${objectUrl}/source/main`;
     }
+    else if (type === 'FUNC') {
+        let group = String(args.group ?? '').trim();
+        if (!group) {
+            if (action === 'create') {
+                return errorResult('"group" is required to create a FUNC. Create the parent function group first (SAPWrite type=FUGR) or pass group explicitly.');
+            }
+            // For update/delete try to auto-resolve the group via search
+            const resolved = cachingLayer
+                ? await cachingLayer.resolveFuncGroup(client, name)
+                : await client.resolveFunctionGroup(name);
+            if (!resolved) {
+                return errorResult(`Cannot resolve function group for FM "${name}". Provide the "group" parameter explicitly, or use SAPSearch to find the parent group.`);
+            }
+            group = resolved;
+        }
+        const groupLc = encodeURIComponent(group.toLowerCase());
+        objectUrl = `/sap/bc/adt/functions/groups/${groupLc}/fmodules/${encodeURIComponent(name.toLowerCase())}`;
+        srcUrl = `${objectUrl}/source/main`;
+        // Pass the resolved group through to buildCreateXml via args.group
+        args.group = group;
+    }
     else {
         objectUrl = objectUrlForType(type, name);
         srcUrl = sourceUrlForType(type, name);
@@ -2514,19 +2606,34 @@ async function handleSAPWrite(client, args, config, cachingLayer) {
             const cdsGuardUpdate = guardCdsSyntax(type, source, cachedFeatures);
             if (cdsGuardUpdate)
                 return cdsGuardUpdate;
-            // Pre-write lint validation
-            const lintWarnings = runPreWriteLint(source, type, name, config, lintOverride);
+            // FUNC-source sanitization: strip SAPGUI-style parameter comment blocks.
+            // SAP rejects PUT-to-source/main with these blocks (HTTP 400 / FUNC_ADT028
+            // "Parameter comment blocks are not allowed" — verified live a4h S/4HANA 2023,
+            // issue #250). LLMs frequently emit them out of muscle memory because every
+            // released FM has one. Strip and warn rather than fail.
+            let effectiveSource = source;
+            let fmParamStripWarning;
+            if (type === 'FUNC') {
+                const stripped = stripFmParamCommentBlock(source);
+                effectiveSource = stripped.source;
+                if (stripped.wasStripped) {
+                    fmParamStripWarning =
+                        'Stripped *"…IMPORTING/EXPORTING…*" parameter comment blocks (SAP rejects them on PUT — manage FM parameters via SAPGUI/Eclipse).';
+                }
+            }
+            // Pre-write lint validation (uses sanitized source for FUNC)
+            const lintWarnings = runPreWriteLint(effectiveSource, type, name, config, lintOverride);
             if (lintWarnings.blocked)
                 return lintWarnings.result;
             // Pre-write server-side syntax check (opt-in; never blocks — warnings only).
-            const checkNotes = await runPreWriteSyntaxCheck(client, type, source, objectUrl, config, checkOverride);
+            const checkNotes = await runPreWriteSyntaxCheck(client, type, effectiveSource, objectUrl, config, checkOverride);
             // If safeUpdateSource throws (lock conflict, network error, etc.), checkNotes
             // is intentionally discarded — pre-check warnings only matter when the write succeeded.
-            await safeUpdateSource(client.http, client.safety, objectUrl, srcUrl, source, transport, cachedFeatures?.abapRelease);
+            await safeUpdateSource(client.http, client.safety, objectUrl, srcUrl, effectiveSource, transport, cachedFeatures?.abapRelease);
             invalidateWrittenObject(type, name);
             const msg = `Successfully updated ${type} ${name}.`;
             const cdsUpdateHint = type === 'DDLS' ? await buildCdsUpdateCrudHint(client, name, objectUrl) : undefined;
-            const warnings = mergePreWriteWarnings(preflightWarnings.warnings, lintWarnings.warnings, checkNotes, cdsUpdateHint);
+            const warnings = mergePreWriteWarnings(preflightWarnings.warnings, lintWarnings.warnings, checkNotes, cdsUpdateHint, fmParamStripWarning);
             return warnings ? textResult(`${msg}\n\n${warnings}`) : textResult(msg);
         }
         case 'create': {
@@ -2697,15 +2804,26 @@ async function handleSAPWrite(client, args, config, cachingLayer) {
             }
             // Step 2: Write source code if provided
             if (source) {
+                // FUNC: strip SAPGUI parameter comment blocks (see update path for rationale).
+                let createSource = source;
+                let fmParamStripWarning;
+                if (type === 'FUNC') {
+                    const stripped = stripFmParamCommentBlock(source);
+                    createSource = stripped.source;
+                    if (stripped.wasStripped) {
+                        fmParamStripWarning =
+                            'Stripped *"…IMPORTING/EXPORTING…*" parameter comment blocks (manage FM parameters via SAPGUI/Eclipse).';
+                    }
+                }
                 // Pre-write lint validation
-                const lintWarnings = runPreWriteLint(source, type, name, config, lintOverride);
+                const lintWarnings = runPreWriteLint(createSource, type, name, config, lintOverride);
                 if (lintWarnings.blocked) {
                     return textResult(`Created ${type} ${name} in package ${pkg}, but source was rejected by lint:\n${lintWarnings.result.content[0].text}`);
                 }
-                await safeUpdateSource(client.http, client.safety, objectUrl, srcUrl, source, effectiveTransport, cachedFeatures?.abapRelease);
+                await safeUpdateSource(client.http, client.safety, objectUrl, srcUrl, createSource, effectiveTransport, cachedFeatures?.abapRelease);
                 invalidateWrittenObject(type, name);
                 const msg = `Created ${type} ${name} in package ${pkg} and wrote source code.`;
-                const warnings = mergePreWriteWarnings(preflightWarnings.warnings, lintWarnings.warnings);
+                const warnings = mergePreWriteWarnings(preflightWarnings.warnings, lintWarnings.warnings, fmParamStripWarning);
                 return warnings ? textResult(`${msg}\n\n${warnings}`) : textResult(msg);
             }
             return textResult(`Created ${type} ${name} in package ${pkg}.\n${result}`);
@@ -3421,10 +3539,33 @@ async function handleSAPActivate(client, args, cachingLayer) {
         // Resolve URLs sequentially. For TABL we await the URL resolver so DDIC
         // structures (which live at /sap/bc/adt/ddic/structures/) are addressed
         // correctly; the resolver short-circuits on its in-memory cache.
+        // For FUNC the URL needs the parent function-group baked into the path
+        // (issue #250); each batch entry must carry `group` or be auto-resolvable
+        // by name.
         const objects = await Promise.all(rawObjects.map(async (o) => {
             const objType = normalizeObjectType(String(o.type ?? type));
             const objName = String(o.name ?? '');
-            const url = objType === 'TABL' ? await client.resolveTablObjectUrl(objName) : objectUrlForType(objType, objName);
+            let url;
+            if (objType === 'TABL') {
+                url = await client.resolveTablObjectUrl(objName);
+            }
+            else if (objType === 'FUNC') {
+                let group = String(o.group ?? args.group ?? '').trim();
+                if (!group) {
+                    const resolved = cachingLayer
+                        ? await cachingLayer.resolveFuncGroup(client, objName)
+                        : await client.resolveFunctionGroup(objName);
+                    if (!resolved) {
+                        throw new Error(`Cannot resolve function group for FM "${objName}" in batch activate. Provide "group" on each FUNC entry.`);
+                    }
+                    group = resolved;
+                }
+                const groupLc = encodeURIComponent(group.toLowerCase());
+                url = `/sap/bc/adt/functions/groups/${groupLc}/fmodules/${encodeURIComponent(objName.toLowerCase())}`;
+            }
+            else {
+                url = objectUrlForType(objType, objName);
+            }
             return { type: objType, name: objName, url };
         }));
         const result = await activateBatch(client.http, client.safety, objects, activateOpts);
@@ -3451,7 +3592,30 @@ async function handleSAPActivate(client, args, cachingLayer) {
     // Single activation (existing behavior). For TABL we resolve the URL because
     // the existing object may live at /tables/ (transparent) or /structures/
     // (DDIC structure); using the wrong one would produce a confusing 404.
-    const objectUrl = type === 'TABL' ? await client.resolveTablObjectUrl(name) : objectUrlForType(type, name);
+    // For FUNC the URL needs the parent function group baked into the path
+    // (issue #250) — `objectBasePath('FUNC')` deliberately throws so generic
+    // builders fail loudly. Auto-resolve the group when omitted.
+    let objectUrl;
+    if (type === 'TABL') {
+        objectUrl = await client.resolveTablObjectUrl(name);
+    }
+    else if (type === 'FUNC') {
+        let group = String(args.group ?? '').trim();
+        if (!group) {
+            const resolved = cachingLayer
+                ? await cachingLayer.resolveFuncGroup(client, name)
+                : await client.resolveFunctionGroup(name);
+            if (!resolved) {
+                return errorResult(`Cannot resolve function group for FM "${name}". Provide the "group" parameter explicitly.`);
+            }
+            group = resolved;
+        }
+        const groupLc = encodeURIComponent(group.toLowerCase());
+        objectUrl = `/sap/bc/adt/functions/groups/${groupLc}/fmodules/${encodeURIComponent(name.toLowerCase())}`;
+    }
+    else {
+        objectUrl = objectUrlForType(type, name);
+    }
     const result = await activate(client.http, client.safety, objectUrl, { ...activateOpts, name });
     if (result.success) {
         cachingLayer?.invalidate(type, name, 'all');