arc-1 0.6.5 → 0.6.7

package/dist/handlers/intent.js

@@ -14,7 +14,7 @@ import { createObject, deleteObject, lockObject, safeUpdateObject, safeUpdateSou
 import { buildDataElementXml, buildDomainXml, buildMessageClassXml, buildPackageXml, buildServiceBindingXml, } from '../adt/ddic-xml.js';
 import { activate, activateBatch, applyFixProposal, getFixProposals, publishServiceBinding, runAtcCheck, runUnitTests, syntaxCheck, unpublishServiceBinding, } from '../adt/devtools.js';
 import { getDump, getTraceDbAccesses, getTraceHitlist, getTraceStatements, listDumps, listTraces, } from '../adt/diagnostics.js';
-import { AdtApiError, AdtNetworkError, AdtSafetyError, isNotFoundError } from '../adt/errors.js';
+import { AdtApiError, AdtNetworkError, AdtSafetyError, classifySapDomainError, isNotFoundError, } from '../adt/errors.js';
 import { classifyTextSearchError, mapSapReleaseToAbaplintVersion, probeFeatures } from '../adt/features.js';
 import { addTileToGroup, createCatalog, createGroup, createTile, deleteCatalog, listCatalogs, listGroups, listTiles, } from '../adt/flp.js';
 import { checkOperation, checkPackage, isOperationAllowed, OperationType } from '../adt/safety.js';
@@ -77,8 +77,8 @@ function textResult(text) {
 function errorResult(message) {
     return { content: [{ type: 'text', text: message }], isError: true };
 }
-const DDIC_SAVE_HINT_TYPES = new Set(['TABL', 'DDLS', 'BDEF', 'SRVD', 'SRVB', 'DDLX', 'DOMA', 'DTEL']);
-const DDIC_POST_SAVE_CHECK_TYPES = new Set(['TABL', 'DDLS', 'BDEF', 'SRVD', 'SRVB', 'DDLX']);
+const DDIC_SAVE_HINT_TYPES = new Set(['TABL', 'DDLS', 'DCLS', 'BDEF', 'SRVD', 'SRVB', 'DDLX', 'DOMA', 'DTEL']);
+const DDIC_POST_SAVE_CHECK_TYPES = new Set(['TABL', 'DDLS', 'DCLS', 'BDEF', 'SRVD', 'SRVB', 'DDLX']);
 // ─── Search Helpers ─────────────────────────────────────────────────
 /**
  * Transliterate non-ASCII characters in search queries.
@@ -125,6 +125,11 @@ function formatErrorForLLM(err, message, _tool, args) {
         // Append additional SAP messages (line numbers, secondary errors) if available
         const enriched = enrichWithSapDetails(err, message);
         const argType = String(args.type ?? '').toUpperCase();
+        const classification = classifySapDomainError(err.statusCode, err.responseBody);
+        if (classification) {
+            const transactionLine = classification.transaction ? `\nSAP Transaction: ${classification.transaction}` : '';
+            return `${enriched}\n\nHint: ${classification.hint}${transactionLine}`;
+        }
         if (err.isNotFound) {
             const name = String(args.name ?? '');
             const type = String(args.type ?? '');
@@ -144,6 +149,12 @@ function formatErrorForLLM(err, message, _tool, args) {
         }
         // Server errors (500, 502, 503, etc.)
         if (err.isServerError) {
+            // Detect syntax errors in dependent objects (e.g., BDEF syntax errors blocking SRVB activation)
+            const syntaxMatch = err.message.match(/[Ss]yntax error in program (\S+)/);
+            if (syntaxMatch) {
+                const program = syntaxMatch[1].replace(/=+\w*$/, ''); // Strip "====BD" padding
+                return `${enriched}\n\nHint: A dependent object has syntax errors that block this operation. The program "${program}" has syntax errors — fix those first, then retry. Use SAPRead to inspect the object, or SAPDiagnose(action="dumps") for details.`;
+            }
             return `${enriched}\n\nHint: SAP application server error (${err.statusCode}). This is often transient — wait 10-30 seconds and retry. If the error persists, check SAPDiagnose(action="dumps") for short dumps, or verify the SAP system is responding via SAPRead(type="SYSTEM").`;
         }
         return enriched;
@@ -242,8 +253,10 @@ function getTransportHint(err) {
     return undefined;
 }
 function classifyError(err) {
-    if (err instanceof AdtApiError)
-        return 'AdtApiError';
+    if (err instanceof AdtApiError) {
+        const classification = classifySapDomainError(err.statusCode, err.responseBody);
+        return classification ? `AdtApiError:${classification.category}` : 'AdtApiError';
+    }
     if (err instanceof AdtNetworkError)
         return 'AdtNetworkError';
     if (err instanceof AdtSafetyError)
@@ -550,6 +563,10 @@ async function handleSAPRead(client, args, cachingLayer) {
             }
             return cachedTextResult(ddlSource, cacheHit);
         }
+        case 'DCLS': {
+            const { source, cacheHit } = await cachedGet('DCLS', name, () => client.getDcl(name));
+            return cachedTextResult(source, cacheHit);
+        }
         case 'BDEF': {
             const { source, cacheHit } = await cachedGet('BDEF', name, () => client.getBdef(name));
             return cachedTextResult(source, cacheHit);
@@ -616,7 +633,7 @@ async function handleSAPRead(client, args, cachingLayer) {
             const explicitType = normalizeObjectType(String(args.objectType ?? ''));
             const inferredType = explicitType || inferObjectType(name);
             if (!inferredType) {
-                return errorResult(`Cannot infer object type from name "${name}". Please specify objectType explicitly (e.g., objectType="CLAS", "INTF", "PROG", "TABL", "DDLS", "FUGR", "DOMA", "DTEL", "SRVD", "SRVB", "BDEF").`);
+                return errorResult(`Cannot infer object type from name "${name}". Please specify objectType explicitly (e.g., objectType="CLAS", "INTF", "PROG", "TABL", "DDLS", "DCLS", "FUGR", "DOMA", "DTEL", "SRVD", "SRVB", "BDEF").`);
             }
             // Use raw URI (no name encoding) — getApiReleaseState encodes the full URI as a single path segment
             const objectUri = objectUrlForTypeRaw(inferredType, name);
@@ -730,8 +747,8 @@ async function handleSAPRead(client, args, cachingLayer) {
             }
         }
         default:
-            return errorResult(`Unknown SAPRead type: "${type}". Supported types: PROG, CLAS, INTF, FUNC, FUGR, INCL, DDLS, DDLX, BDEF, SRVD, SRVB, TABL, VIEW, STRU, DOMA, DTEL, TRAN, TABLE_CONTENTS, DEVC, SOBJ, SYSTEM, COMPONENTS, MESSAGES, TEXT_ELEMENTS, VARIANTS, BSP, BSP_DEPLOY, API_STATE, INACTIVE_OBJECTS. ` +
-                'Tip: Type aliases are auto-normalized (e.g., DDLS/DF → DDLS, CLAS/OC → CLAS, PROG/P → PROG). ' +
+            return errorResult(`Unknown SAPRead type: "${type}". Supported types: PROG, CLAS, INTF, FUNC, FUGR, INCL, DDLS, DCLS, DDLX, BDEF, SRVD, SRVB, TABL, VIEW, STRU, DOMA, DTEL, TRAN, TABLE_CONTENTS, DEVC, SOBJ, SYSTEM, COMPONENTS, MESSAGES, TEXT_ELEMENTS, VARIANTS, BSP, BSP_DEPLOY, API_STATE, INACTIVE_OBJECTS. ` +
+                'Tip: Type aliases are auto-normalized (e.g., DDLS/DF → DDLS, DCLS/DL → DCLS, CLAS/OC → CLAS, PROG/P → PROG). ' +
                 'Do not pass a URI — use the "type" and "name" parameters instead.');
     }
 }
@@ -1228,6 +1245,18 @@ export function buildCreateXml(type, name, pkg, description, properties) {
                  adtcore:responsible="DEVELOPER">
   <adtcore:packageRef adtcore:name="${escapeXml(pkg)}"/>
 </ddl:ddlSource>`;
+        case 'DCLS':
+            return `<?xml version="1.0" encoding="UTF-8"?>
+<dcl:dclSource xmlns:dcl="http://www.sap.com/adt/acm/dclsources"
+               xmlns:adtcore="http://www.sap.com/adt/core"
+               adtcore:description="${escapeXml(description)}"
+               adtcore:name="${escapeXml(name)}"
+               adtcore:type="DCLS/DL"
+               adtcore:masterLanguage="EN"
+               adtcore:masterSystem="H00"
+               adtcore:responsible="DEVELOPER">
+  <adtcore:packageRef adtcore:name="${escapeXml(pkg)}"/>
+</dcl:dclSource>`;
         case 'TABL':
             // TABL creation also uses SAP's "blue" framework envelope, then source is written via /source/main.
             return `<?xml version="1.0" encoding="UTF-8"?>
@@ -1393,6 +1422,7 @@ const SLASH_TYPE_MAP = {
     'FUGR/F': 'FUGR',
     'FUGR/FF': 'FUGR',
     'DDLS/DF': 'DDLS',
+    'DCLS/DL': 'DCLS',
     'BDEF/BDO': 'BDEF',
     'SRVD/SRV': 'SRVD',
     'SRVB/SVB': 'SRVB',
@@ -1491,6 +1521,8 @@ function objectBasePath(type) {
             return '/sap/bc/adt/functions/groups/';
         case 'DDLS':
             return '/sap/bc/adt/ddic/ddl/sources/';
+        case 'DCLS':
+            return '/sap/bc/adt/acm/dcl/sources/';
         case 'BDEF':
             return '/sap/bc/adt/bo/behaviordefinitions/';
         case 'SRVD':
@@ -1998,12 +2030,30 @@ async function handleSAPActivate(client, args) {
     const action = String(args.action ?? 'activate');
     const name = String(args.name ?? '');
     const version = String(args.version ?? '0001');
+    const explicitServiceType = args.service_type;
+    // Resolve the OData service type for publish/unpublish endpoints.
+    // Explicit service_type parameter takes precedence; otherwise auto-detect from SRVB metadata.
+    async function resolveServiceType() {
+        if (explicitServiceType === 'odatav4' || explicitServiceType === 'odatav2')
+            return explicitServiceType;
+        try {
+            const srvbJson = await client.getSrvb(name);
+            const srvb = JSON.parse(srvbJson);
+            if (srvb.odataVersion === 'V4')
+                return 'odatav4';
+        }
+        catch {
+            // If readback fails, fall back to odatav2 (legacy default)
+        }
+        return 'odatav2';
+    }
     // Publish service binding
     if (action === 'publish_srvb') {
         if (!name) {
             return errorResult('Missing required "name" parameter for publish_srvb action.');
         }
-        const result = await publishServiceBinding(client.http, client.safety, name, version);
+        const serviceType = await resolveServiceType();
+        const result = await publishServiceBinding(client.http, client.safety, name, version, serviceType);
         if (result.severity === 'ERROR') {
             return errorResult(`Failed to publish service binding ${name}: ${result.shortText}${result.longText ? ` — ${result.longText}` : ''}`);
         }
@@ -2037,7 +2087,8 @@ async function handleSAPActivate(client, args) {
         if (!name) {
             return errorResult('Missing required "name" parameter for unpublish_srvb action.');
         }
-        const result = await unpublishServiceBinding(client.http, client.safety, name, version);
+        const serviceType = await resolveServiceType();
+        const result = await unpublishServiceBinding(client.http, client.safety, name, version, serviceType);
         if (result.severity === 'ERROR') {
             return errorResult(`Failed to unpublish service binding ${name}: ${result.shortText}${result.longText ? ` — ${result.longText}` : ''}`);
         }
@@ -2567,6 +2618,7 @@ async function handleSAPContext(client, args, cachingLayer) {
 // ─── SAPManage Handler ────────────────────────────────────────────────
 /** Cached feature status — populated on first probe */
 let cachedFeatures;
+let cachedDiscovery = new Map();
 async function handleSAPManage(client, config, args, cachingLayer, isPerUserClient) {
     const action = String(args.action ?? '');
     const flpUnavailableMessage = 'FLP customization service (PAGE_BUILDER_CUST) is not available on this system. Check ICF service activation in SICF.';
@@ -2831,6 +2883,7 @@ async function handleSAPManage(client, config, args, cachingLayer, isPerUserClie
 /** Reset cached features (for testing) */
 export function resetCachedFeatures() {
     cachedFeatures = undefined;
+    cachedDiscovery = new Map();
 }
 /** Set cached features directly (for testing BTP mode, etc.) */
 export function setCachedFeatures(features) {
@@ -2840,4 +2893,12 @@ export function setCachedFeatures(features) {
 export function getCachedFeatures() {
     return cachedFeatures;
 }
+/** Set startup-cached ADT discovery MIME map. */
+export function setCachedDiscovery(map) {
+    cachedDiscovery = map;
+}
+/** Get startup-cached ADT discovery MIME map. */
+export function getCachedDiscovery() {
+    return cachedDiscovery;
+}
 //# sourceMappingURL=intent.js.map