arboris-cli 1.0.0 → 1.1.1

package/prisma/skills/defi-amm-security/SKILL.md

@@ -0,0 +1,167 @@
+---
+name: defi-amm-security
+description: Security checklist for Solidity AMM contracts, liquidity pools, and swap flows. Covers reentrancy, CEI ordering, donation or inflation attacks, oracle manipulation, slippage, admin controls, and integer math.
+metadata:
+  origin: ECC direct-port adaptation
+version: "1.0.0"
+---
+
+# DeFi AMM Security
+
+Critical vulnerability patterns and hardened implementations for Solidity AMM contracts, LP vaults, and swap functions.
+
+## When to Use
+
+- Writing or auditing a Solidity AMM or liquidity-pool contract
+- Implementing swap, deposit, withdraw, mint, or burn flows that hold token balances
+- Reviewing any contract that uses `token.balanceOf(address(this))` in share or reserve math
+- Adding fee setters, pausers, oracle updates, or other admin functions to a DeFi protocol
+
+## How It Works
+
+Use this as a checklist-plus-pattern library. Review every user entrypoint against the categories below and prefer the hardened examples over hand-rolled variants.
+
+## Execution Safety
+
+The shell commands in this skill are local audit examples. Run them only in a trusted checkout or disposable sandbox, and do not splice untrusted contract names, paths, RPC URLs, private keys, or user-supplied flags into shell commands. Ask before installing tools or running long fuzzing/static-analysis jobs that may consume significant local or paid resources.
+
+Never include secrets, private keys, seed phrases, API tokens, or mainnet signing credentials in command examples, logs, or reports.
+
+## Examples
+
+### Reentrancy: enforce CEI order
+
+Vulnerable:
+
+```solidity
+function withdraw(uint256 amount) external {
+    require(balances[msg.sender] >= amount);
+    token.transfer(msg.sender, amount);
+    balances[msg.sender] -= amount;
+}
+```
+
+Safe:
+
+```solidity
+import {ReentrancyGuard} from "@openzeppelin/contracts/utils/ReentrancyGuard.sol";
+import {SafeERC20} from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
+
+using SafeERC20 for IERC20;
+
+function withdraw(uint256 amount) external nonReentrant {
+    require(balances[msg.sender] >= amount, "Insufficient");
+    balances[msg.sender] -= amount;
+    token.safeTransfer(msg.sender, amount);
+}
+```
+
+Do not write your own guard when a hardened library exists.
+
+### Donation or inflation attacks
+
+Using `token.balanceOf(address(this))` directly for share math lets attackers manipulate the denominator by sending tokens to the contract outside the intended path.
+
+```solidity
+// Vulnerable
+function deposit(uint256 assets) external returns (uint256 shares) {
+    shares = (assets * totalShares) / token.balanceOf(address(this));
+}
+```
+
+```solidity
+// Safe
+uint256 private _totalAssets;
+
+function deposit(uint256 assets) external nonReentrant returns (uint256 shares) {
+    uint256 balBefore = token.balanceOf(address(this));
+    token.safeTransferFrom(msg.sender, address(this), assets);
+    uint256 received = token.balanceOf(address(this)) - balBefore;
+
+    shares = totalShares == 0 ? received : (received * totalShares) / _totalAssets;
+    _totalAssets += received;
+    totalShares += shares;
+}
+```
+
+Track internal accounting and measure actual tokens received.
+
+### Oracle manipulation
+
+Spot prices are flash-loan manipulable. Prefer TWAP.
+
+```solidity
+uint32[] memory secondsAgos = new uint32[](2);
+secondsAgos[0] = 1800;
+secondsAgos[1] = 0;
+(int56[] memory tickCumulatives,) = IUniswapV3Pool(pool).observe(secondsAgos);
+int24 twapTick = int24(
+    (tickCumulatives[1] - tickCumulatives[0]) / int56(uint56(30 minutes))
+);
+uint160 sqrtPriceX96 = TickMath.getSqrtRatioAtTick(twapTick);
+```
+
+### Slippage protection
+
+Every swap path needs caller-provided slippage and a deadline.
+
+```solidity
+function swap(
+    uint256 amountIn,
+    uint256 amountOutMin,
+    uint256 deadline
+) external returns (uint256 amountOut) {
+    require(block.timestamp <= deadline, "Expired");
+    amountOut = _calculateOut(amountIn);
+    require(amountOut >= amountOutMin, "Slippage exceeded");
+    _executeSwap(amountIn, amountOut);
+}
+```
+
+### Safe reserve math
+
+```solidity
+import {FullMath} from "@uniswap/v3-core/contracts/libraries/FullMath.sol";
+
+uint256 result = FullMath.mulDiv(a, b, c);
+```
+
+For large reserve math, avoid naive `a * b / c` when overflow risk exists.
+
+### Admin controls
+
+```solidity
+import {Ownable2Step} from "@openzeppelin/contracts/access/Ownable2Step.sol";
+
+contract MyAMM is Ownable2Step {
+    function setFee(uint256 fee) external onlyOwner { ... }
+    function pause() external onlyOwner { ... }
+}
+```
+
+Prefer explicit acceptance for ownership transfer and gate every privileged path.
+
+## Security Checklist
+
+- Reentrancy-exposed entrypoints use `nonReentrant`
+- CEI ordering is respected
+- Share math does not depend on raw `balanceOf(address(this))`
+- ERC-20 transfers use `SafeERC20`
+- Deposits measure actual tokens received
+- Oracle reads use TWAP or another manipulation-resistant source
+- Swaps require `amountOutMin` and `deadline`
+- Overflow-sensitive reserve math uses safe primitives like `mulDiv`
+- Admin functions are access-controlled
+- Emergency pause exists and is tested
+- Static analysis and fuzzing are run before production
+
+## Audit Tools
+
+```bash
+pip install slither-analyzer
+slither . --exclude-dependencies
+
+echidna-test . --contract YourAMM --config echidna.yaml
+
+forge test --fuzz-runs 10000
+```

package/prisma/skills/delivery-gate/SKILL.md

@@ -0,0 +1,126 @@
+---
+name: delivery-gate
+description: Stop hook that blocks Claude from finishing until quality checks pass. Detects rationalization patterns (surface text heuristics), stale learning logs (filesystem mtime), and low disk space. Complements self-audit by mechanically enforcing learning capture habits.
+version: 1.1.1
+metadata:
+  origin: ECC
+---
+
+# Delivery Gate — Mechanical Quality Gate for Claude Code
+
+A **Stop hook** that checks three things before Claude can finish a session, using only **deterministic checks** — file modification timestamps, disk usage, and regex patterns on the transcript text. No AI inference.
+
+This is distinct from reasoning gates (like `self-audit`): delivery-gate checks machine-verifiable facts; self-audit checks output quality across four reasoning dimensions. Together they form defense in depth:
+- **delivery-gate**: "Was the learning library touched today? Is disk space safe?"
+- **self-audit**: "Is the file content correct, complete, and honest?"
+
+This is the same pattern as CI pipeline gates — automated, deterministic checks that verify machine-readable facts rather than trusting self-reported status.
+
+## What It Checks
+
+| Check | Mechanism | On Hit |
+|-------|-----------|--------|
+| Rationalization patterns | Regex on transcript tail | **Warning only** (never blocks) |
+| Stale learning libraries | mtime on 5 configurable paths | Warning if some stale; **Block** if >=3 stale OR growth-log stale + complex task |
+| Disk space < 50GB | `shutil.disk_usage` | Warning |
+| Disk space < 15GB | `shutil.disk_usage` | **Block** (exit 2) |
+
+Rationalization detection warns about patterns like "skip tests for now" and "pre-existing bug" — surface signals that thinking may have been cut short. It never blocks on its own, because regex heuristics can false-positive. The blocking conditions are: disk critical, `>=3 learning libs stale`, OR `growth-log` specifically stale (all require complex task >=3 edits).
+
+## Why
+
+Claude Code's built-in checks cover code quality (build → type → lint → test). But there's a different failure mode: the agent produces working code while the **session hygiene was neglected** — learning not captured, rationalized shortcuts, disk running out silently.
+
+Over many sessions of "ship and forget," the human hasn't grown. This hook enforces the habit: complex task → must touch learning libraries.
+
+## Install
+
+```bash
+cp quality-gate.py ~/.claude/scripts/
+```
+
+Add to `~/.claude/settings.json`:
+```json
+{
+  "hooks": {
+    "Stop": [{
+      "hooks": [{
+        "type": "command",
+        "command": "python3 ~/.claude/scripts/quality-gate.py",
+        "timeout": 5000
+      }]
+    }]
+  }
+}
+```
+
+## Learning Libraries
+
+Create these files in your project's memory directory. The hook checks if at least one was updated today:
+
+```
+memory/
+├── growth-log/          # Daily learning entries (directory)
+├── decisions/log.md     # Decision log
+├── output-index.md      # Index of session outputs
+├── ratings-tracker.md   # Skill ratings over time
+└── tooling_capabilities.md  # Known tools inventory
+```
+
+Customize the `LIBS` dict to match your own file structure.
+
+## Configuration
+
+Edit `quality-gate.py`:
+
+| Variable | Default | Purpose |
+|----------|---------|---------|
+| `RATIONALIZE` | 4 patterns | Regex patterns for rationalization detection |
+| `LIBS` | 5 libraries | Files/dirs to check for today's updates |
+| `COMPLEX_THRESHOLD` | 3 | Edit/Write calls to classify as complex |
+| `DISK_WARN_GB` | 50 | Warn below this |
+| `DISK_CRIT_GB` | 15 | Block below this |
+
+## Examples
+
+**Simple session — allowed:**
+```
+edit_count=1 (< 3, not complex) → exit 0
+```
+
+**Complex task, learning captured — allowed:**
+```
+edit_count=5 (complex) → checks LIBS → growth-log updated today → exit 0
+```
+
+**Complex task, no learning — BLOCKED:**
+```
+edit_count=4 (complex) → checks LIBS → all 5 stale → exit 2
+stderr: "Blocked: complex task completed but no learning captured today."
+```
+
+**Low disk space — BLOCKED:**
+```
+disk_free=12GB < 15GB critical → exit 2
+stderr: "Blocked: disk space at 12GB (threshold: 15GB)."
+```
+
+## Limitations
+
+The hook enforces the **habit** of touching learning libraries, not the **quality** of what was recorded. If `output-index.md` is updated but `growth-log` is skipped, the hook passes (1 of 5 libraries touched). This is by design: mechanical gates check machine-verifiable facts. For content quality verification, pair with `self-audit`.
+
+## Compatibility
+
+- Python 3.8+ (uses `from __future__ import annotations`)
+- Cross-platform: Windows, macOS, Linux
+- Zero dependencies beyond stdlib
+
+## Quality
+
+This code went through 4 rounds of automated code review (CodeRabbit + Greptile) with 9 real bugs found and fixed.
+
+## See Also
+
+- `self-audit` — Reasoning quality gate (completeness/consistency/groundedness/honesty)
+- `verification-loop` — Code quality checks (build/type/lint/test)
+- `gateguard` — PreToolUse safety gate

package/prisma/skills/delivery-gate/hooks/quality-gate.py

@@ -0,0 +1,220 @@
+#!/usr/bin/env python3
+"""
+Stop hook: quality gate with delivery check.
+Detects incomplete work, stale learning logs, and low disk space.
+Blocks Claude from stopping when a complex task completed without learning capture.
+
+Install: cp this file to ~/.claude/scripts/quality-gate.py
+Configure: Add to settings.json hooks.Stop
+"""
+from __future__ import annotations
+
+import sys
+import os
+import re
+import json
+import datetime
+import shutil
+import logging
+from typing import Optional
+
+# ---- Configuration ----
+RATIONALIZE = [
+    r'(?:this|that)\s+is\s+a\s+pre[- ]existing\s+(?:issue|bug)\b(?!\s+(?:that|which|and))',
+    r'skipping\s+(?:tests?|lint|coverage|type[- ]check)\s+for\s+now',
+    r'(?:tests?|coverage)\s+(?:are|is)\s+(?:failing|broken)\s+but\s+(?:I|we)\s+(?:\'ll|can|will)\s+(?:fix|address|resolve|handle)',
+    r'(?:not\s+addressing|won\'t\s+fix|leaving)\s+the\s+(?:failing|broken)\s+(?:tests?|builds?|integration\s+tests?)',
+]
+
+LIBS = {
+    'ratings-tracker': 'ratings-tracker.md',
+    'decisions-log': 'decisions/log.md',
+    'growth-log': 'growth-log/',
+    'output-index': 'output-index.md',
+    'tooling-capabilities': 'tooling_capabilities.md',
+}
+
+MIN_CHARS = 40
+COMPLEX_THRESHOLD = 3
+DISK_REMIND_GB = 50
+DISK_WARN_GB = 30
+DISK_CRIT_GB = 15
+# ---- End Configuration ----
+
+logging.basicConfig(
+    stream=sys.stderr,
+    format='%(levelname)s: %(message)s',
+    level=logging.INFO,
+)
+log = logging.getLogger('quality-gate')
+
+
+def get_project_memory_dir() -> Optional[str]:
+    """Find the current project's memory directory.
+
+    Returns None if no memory directory exists for this project.
+    Does NOT fall back to other projects (privacy boundary)."""
+    cwd = os.environ.get('CLAUDE_PROJECT_DIR', os.getcwd())
+    safe = cwd.replace(':', '-').replace('\\', '-').replace('/', '-')
+    mem = os.path.expanduser(f'~/.claude/projects/{safe}/memory')
+    log.info('Looking for memory dir: cwd=%s -> %s', cwd, mem)
+    if os.path.isdir(mem):
+        return mem
+    return None
+
+
+def check_disk() -> Optional[int]:
+    """Check free space on the disk containing the home directory.
+
+    Works cross-platform: macOS, Linux, Windows.
+    Returns free GB, or None if the home directory is unavailable."""
+    try:
+        home = os.path.expanduser('~')
+        free_gb = shutil.disk_usage(home).free // (2**30)
+        return free_gb
+    except (FileNotFoundError, PermissionError, OSError):
+        log.warning('cannot check disk space (home dir inaccessible)')
+        return None
+
+
+def check_stale_libs(mem_dir: str) -> list[str]:
+    """Return list of library names not updated today.
+
+    Per-file OSError handling: individual unreadable files are skipped,
+    but the scan continues for remaining libraries."""
+    today = datetime.date.today()
+    stale: list[str] = []
+    for name, path in LIBS.items():
+        full = os.path.join(mem_dir, path)
+        try:
+            if os.path.isdir(full):
+                has_today = False
+                for dirpath, _dirnames, filenames in os.walk(full):
+                    for f in filenames:
+                        fp = os.path.join(dirpath, f)
+                        try:
+                            mt = datetime.datetime.fromtimestamp(os.path.getmtime(fp)).date()
+                            if mt == today:
+                                has_today = True
+                                break
+                        except OSError:
+                            continue
+                    if has_today:
+                        break
+                if not has_today:
+                    stale.append(name)
+            elif os.path.exists(full):
+                try:
+                    mt = datetime.datetime.fromtimestamp(os.path.getmtime(full)).date()
+                    if mt != today:
+                        stale.append(name)
+                except OSError:
+                    stale.append(name)
+            else:
+                stale.append(name)
+        except OSError as e:
+            log.warning('cannot access lib %s: %s', name, e)
+            stale.append(name)
+    return stale
+
+
+def count_edits(text: str) -> int:
+    """Count Edit/Write tool invocations in the full transcript.
+
+    Matches structured tool-call JSON patterns to avoid false-positives
+    from ordinary English prose. Scans entire transcript."""
+    return len(re.findall(r'"name":\s*"(?:Edit|Write)"', text))
+
+
+def main() -> None:
+    raw = sys.stdin.read()
+    # Stop hooks write feedback to stderr, not stdout.
+    # Claude Code reads stderr as the hook's response message.
+    # Do NOT echo raw JSON to stdout — it would overwrite the blocking reason.
+
+    # Resolve transcript: Stop hooks may receive raw text OR JSON with transcript_path.
+    transcript = raw
+    try:
+        payload = json.loads(raw)
+        if isinstance(payload, dict) and 'transcript_path' in payload:
+            tp = os.path.expanduser(payload['transcript_path'])
+            if os.path.exists(tp):
+                with open(tp, 'r', encoding='utf-8') as f:
+                    transcript = f.read()
+            else:
+                log.warning('transcript_path %s not found, falling back to raw stdin', tp)
+    except (json.JSONDecodeError, TypeError, OSError):
+        pass
+
+    # 1. Disk check — three-level: remind / warn / block
+    disk_free = check_disk()
+    if disk_free is not None:
+        if disk_free < DISK_CRIT_GB:
+            log.warning('Blocked: disk space at %dGB (<%dGB). Free space before continuing.',
+                        disk_free, DISK_CRIT_GB)
+            sys.exit(2)
+        if disk_free < DISK_WARN_GB:
+            log.warning('WARN: disk space at %dGB (<%dGB)', disk_free, DISK_WARN_GB)
+        elif disk_free < DISK_REMIND_GB:
+            log.info('Reminder: disk space at %dGB (<%dGB)', disk_free, DISK_REMIND_GB)
+
+    # 2. Short session — skip remaining checks
+    if len(transcript) < MIN_CHARS:
+        sys.exit(0)
+
+    tail = transcript[-8000:]
+
+    # 3. Rationalization pattern detection
+    hits = []
+    for p in RATIONALIZE:
+        m = re.search(p, tail, re.IGNORECASE)
+        if m:
+            hits.append(m.group(0)[:80])
+    if hits:
+        log.warning('quality-gate: rationalization detected — %s', hits)
+
+    # 4. Learning capture check
+    mem_dir = get_project_memory_dir()
+    edit_count = count_edits(transcript)
+    is_complex = edit_count >= COMPLEX_THRESHOLD
+
+    if mem_dir:
+        stale = check_stale_libs(mem_dir)
+    else:
+        # No memory dir — setup incomplete.
+        # Warn but DO NOT block: blocking here deadlocks new users
+        # who haven't created the memory directory yet.
+        if is_complex:
+            log.warning('No project memory directory found — cannot verify learning capture.')
+            log.warning('Set up memory/ per delivery-gate SKILL.md to enable enforcement.')
+        stale = []
+
+    parts = []
+    if is_complex:
+        status_icons = ['X' if s in stale else 'O' for s in LIBS]
+        parts.append(
+            f'\n  Complex task ({edit_count} edits). '
+            f'Check: [{"][".join(f"{k}:{v}" for k,v in zip(LIBS.keys(), status_icons))}]'
+        )
+    if stale:
+        parts.append(f'  Stale ({len(stale)}): {", ".join(stale)}')
+
+    if parts:
+        log.warning('\n'.join(parts))
+
+    # 5. Block if complex task completed without learning capture
+    if is_complex:
+        if len(stale) >= 3:
+            log.warning('Blocked: complex task but >=3 learning libs stale.')
+            log.warning(f'Stale: {", ".join(stale)}. Update before stopping.')
+            sys.exit(2)
+        if 'growth-log' in stale:
+            log.warning('Blocked: code changes made but no growth-log update.')
+            log.warning('Write growth-log before stopping (even if "no new learnings").')
+            sys.exit(2)
+
+    sys.exit(0)
+
+
+if __name__ == '__main__':
+    main()