aqualink 2.2.0 → 2.3.0

package/README.md

@@ -24,38 +24,35 @@ This code is based in riffy, but its an 100% Rewrite made from scratch...
   - https://github.com/DuncteBot/java-timed-lyrics (RECOMMENDED)
 
 
-# Tralalero Tralala 2.2.0 Released
+# Tralalero Tralala 2.3.0 Released
 ---
-- Improved the `AQUA` module
-  - Added  Fast path in getRequestNode (     Reduces unnecessary type checks    )
-  - Early return in handleNoMatches (	Avoids unnecessary Spotify requests     )
-  - Rewrite to use manual loops on constructResponse (      faster than Array.prototype.map, makes the playlists and tracks load way faster and less recourses     )
-  - Pre-allocated arrays (	Avoids dynamic resizing   )
-  - Also fixed it sending double requests to lavalink.
 
+- now is ~21% more lightweight, reduced disk space
 
-- Remade the `Player` module
-  - More efficient track addition, void Array re-call
-  - faster event handling with direct states
-  - Faster autoplay system and more efficient by map()
-  - Reduced Object Creation
-  - Rewrite destroy() method
-  - Also improved Resource Cleanup
-  - Now emit TrackEnd and queueEnd correctly
-
-- Rewrite the `autoplay` system
-  - Added redirect handling
-  - More efficient regex processing
-  - Set for unique URLs to avoid duplicate
-  - Use array chunks for better performance
-  - About ~30%-40% faster for resolving now.
-
-- Rewrite the Filter system
-  - Uses Direct Assigments
-  - Avoid recreating objects on each update
-  - Property reuse in updateFilters()
-  - Uses traditional for loop
+- Improved the `AQUA` module
+  - 3x better cleanup system
+  - Fixed some memory leaks
+  - Improved long process support
+  - Faster node caching
 
+- Remade the `Player` module
+  - Added circular buffer for previousTracks (way more memory efficient)
+  - Reorganized the event handlings
+  - Way better Memory management
+
+- Rewrite the `Node` system
+  - Fixed an memory leak in connections
+  - Improved the overal speed
+  - Improved code readbility / modules
+  - improved cleanup System
+  - Better long runtime
+  - Rewrite the Filter system
+
+- Improved `Rest` code
+  - Fixed lyrics (both search and get)
+  - Better chunks system for more performance
+
+- Improved `fetchImage` speed and recourses
 
 # Docs (Wiki)
 - https://toddythenoobdud.github.io/aqualink.github.io/

package/build/handlers/fetchImage.js

@@ -1,10 +1,11 @@
-const http2 = require('http2');
+const https = require('https');
 const sourceHandlers = new Map([
     ['spotify', uri => fetchThumbnail(`https://open.spotify.com/oembed?url=${uri}`)],
     ['youtube', identifier => fetchYouTubeThumbnail(identifier)]
 ]);
 const YOUTUBE_URL_TEMPLATE = (quality) => (id) => `https://img.youtube.com/vi/${id}/${quality}.jpg`;
 const YOUTUBE_QUALITIES = ['maxresdefault', 'hqdefault', 'mqdefault', 'default'].map(YOUTUBE_URL_TEMPLATE);
+
 async function getImageUrl(info) {
     if (!info?.sourceName || !info?.uri) return null;
     const handler = sourceHandlers.get(info.sourceName.toLowerCase());
@@ -16,42 +17,34 @@ async function getImageUrl(info) {
         return null;
     }
 }
+
 function fetchThumbnail(url) {
     return new Promise((resolve, reject) => {
-        const client = http2.connect(url);
-        
-        const req = client.request({ ':path': '/' });
-        
-        let data = '';
-        
-        req.on('response', (headers, flags) => {
-            if (headers[':status'] !== 200) {
-                return reject(`Failed to fetch: ${headers[':status']}`);
+        https.get(url, (res) => {
+            if (res.statusCode !== 200) {
+                res.resume();
+                return reject(`Failed to fetch: ${res.statusCode}`);
             }
-        });
-        req.on('data', chunk => {
-            data += chunk;
-        });
-        req.on('end', () => {
-            try {
-                const json = JSON.parse(data);
-                resolve(json.thumbnail_url || null);
-            } catch (error) {
-                reject(`JSON parse error: ${error.message}`);
-            } finally {
-                client.close();
-            }
-        });
-        req.on('error', (error) => {
+            let data = '';
+            res.on('data', chunk => data += chunk);
+            res.on('end', () => {
+                try {
+                    const json = JSON.parse(data);
+                    resolve(json.thumbnail_url || null);
+                } catch (error) {
+                    reject(`JSON parse error: ${error.message}`);
+                }
+            });
+        }).on('error', (error) => {
             reject(`Request error: ${error.message}`);
-            client.close();
         });
-        req.end();
     });
 }
+
 async function fetchYouTubeThumbnail(identifier) {
     const promises = YOUTUBE_QUALITIES.map(urlFunc => fetchThumbnail(urlFunc(identifier)));
-    const results = await Promise.race(promises);
-    return results || null;
+    const firstResult = await Promise.race(promises);
+    return firstResult || null;
 }
-module.exports = { getImageUrl };
+
+module.exports = { getImageUrl };