appstore-precheck 1.1.0 → 1.1.1

package/CHANGELOG.md

@@ -3,6 +3,39 @@
 All notable changes to this project are documented here. Versioning follows
 [SemVer](https://semver.org/). Released as git tags.
 
+## [1.1.1] - 2026-06-30
+
+### Changed
+- **Pierre now speaks in a trilingual block.** The verdict opens with his native **French** line,
+  then an **English** rendering, then a rendering in the **user's conversation language** — each an
+  idiomatic, in-character re-expression in that language's own rhythm, not a literal translation.
+  Collapses to two lines when the user already converses in French or English. The block stays
+  flavor only; the FAIL/WARN list, `file:line` references, and fixes below it remain plain and
+  machine-faithful. Updated the output contract, Phase 4 step 3, and the behavioral eval
+  assertions accordingly.
+
+### Fixed
+- **Pierre no longer treats local-only files as Apple submission evidence.** The Phase 3 prompt
+  now scopes reject-risk evidence to Apple-facing artifacts (fastlane metadata, paywall Swift,
+  String Catalog, Info.plist, PrivacyInfo.xcprivacy). Internal/local files (`.planning/` notes,
+  `reviewPrepNotes` drafts, build scripts) and Google Play / non-Apple sections are out of scope —
+  cited at most as a WARN labeled "internal draft — not submitted to Apple", never REJECT-RISK. A
+  REJECT risk now requires a contradiction *within* submission-facing artifacts, not an internal
+  doc disagreeing with metadata. An eligibility-gated/conditional offer paired with metadata that
+  mentions it is WARN at most (unless the metadata promises it unconditionally). Prevents the
+  false REJECT-RISK overreach seen when dogfooding an already-approved build.
+- **2.3.7 locale check no longer hard-FAILs on a config/disk mismatch.** A locale listed in
+  `.appstore-precheck.json` `locales` but with no metadata folder on disk is now a WARN (with an
+  actionable "add it or remove it from the config" message), not a FAIL — that locale was simply
+  never submitted, so it must not turn an approved set RED. A missing *file* inside a present
+  locale folder is still a FAIL.
+- **2.1 placeholder check no longer false-fires on words containing "changeme".** The `changeme`
+  pattern is now word-bounded (`\bchangeme\b`) in both the metadata-URL and store-copy scans, so
+  legitimate copy such as the French "changement" ("change") is not flagged as unfinished.
+- Added regression coverage in `tests/test-config.sh` for both fixes.
+- CI: bumped `actions/checkout@v4 -> v7` and `actions/setup-node@v4 -> v6` to clear the
+  GitHub Actions Node.js 20 deprecation warning (both now run natively on Node 24).
+
 ## [1.1.0] - 2026-06-28
 
 ### Added

package/README.md

@@ -66,6 +66,17 @@ plain and surgical.
 
 Paywall checks are skipped automatically when no in-app-purchase signals are present.
 
+### Supported app types
+
+Every check that reads store metadata, the privacy manifest, screenshots, or the export-compliance
+key works on **any iOS app**. The code-level checks read Swift source, so their coverage depends on
+how the app is built:
+
+| App type | Coverage |
+|----------|----------|
+| 🟢 **Native Swift / SwiftUI** | **Full.** All 20 vectors apply. |
+| 🟡 **React Native / Flutter** | Metadata, privacy manifest, screenshots, and export compliance apply in full. The Swift-source checks (ATT, paywall links, private API, SDK detection, navigation) **under-detect rather than misfire**: that logic lives in JS/Dart, so they stay quiet instead of blocking. |
+
 ## Quick start
 
 **Claude Code**: install as a plugin:
@@ -102,12 +113,15 @@ bash skills/appstore-precheck/scripts/scan.sh
 job on a RED verdict; set `fail-on: YELLOW` to be stricter:
 
 ```yaml
-- uses: berkayturk/appstore-precheck@v1.0.0
+- uses: berkayturk/appstore-precheck@v1.1.0
   with:
-    working-directory: .   # optional
-    fail-on: RED           # optional (RED | YELLOW)
+    working-directory: .   # optional, default: . (repo root)
+    fail-on: RED           # optional, default: RED (RED | YELLOW)
 ```
 
+Both inputs are optional: with none set, the action scans the repo root and fails the job only on
+a RED verdict. No App Store Connect credentials are needed; the action runs the static scan only.
+
 ## How it works
 
 | Phase | Step |
@@ -177,8 +191,13 @@ App Store apps (DuckDuckGo, Pocket Casts, Wikipedia).
 
 ## Requirements
 
-`bash`, `git`, `grep`, `find` · `jq` (config + String Catalog checks) · `python3` (exact Unicode
-length counts) · `fastlane` + an App Store Connect API key for Phase 2 only.
+`bash`, `git`, `grep`, `find` are all the static scan, `npx appstore-precheck`, and the GitHub
+Action need, and they run with **zero credentials and no network**. `jq` (config + String Catalog
+checks) and `python3` (exact Unicode length counts) are optional and sharpen a few checks.
+
+Only the **optional Phase 2** (`fastlane precheck`) needs `fastlane` and an
+[App Store Connect API key](https://developer.apple.com/documentation/appstoreconnectapi/creating-api-keys-for-app-store-connect-api).
+Everything else works without one.
 
 **Secrets**: the ASC API key is read from your environment at runtime and deleted immediately after
 `fastlane precheck`. Never commit it; `.gitignore` blocks `*asc-key*.json` and `.env`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appstore-precheck",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Read-only iOS App Store pre-submission check, packaged as a portable Agent Skill / Claude Code plugin and an npx CLI.",
   "license": "MIT",
   "author": "Berkay Turk (https://github.com/berkayturk)",

package/skills/appstore-precheck/SKILL.md

@@ -4,7 +4,7 @@ description: Read-only pre-submission check for an iOS app before App Store revi
 license: MIT
 metadata:
   author: Berkay Turk
-  version: 1.1.0
+  version: 1.1.1
 allowed-tools: Bash Read Grep Glob WebFetch
 ---
 
@@ -47,11 +47,15 @@ The skill reaches one of three terminal states:
 | **YELLOW** | No FAIL but 3+ WARN | Not written | Guard blocks; ask for explicit confirmation |
 | **RED** | At least 1 FAIL | Removed | Guard blocks; show the FAIL list |
 
-When you present the verdict to the user, open with a **single in-character line from Pierre**
-(the French App Review critic, see Phase 3), then drop straight into the plain, surgical
-breakdown. The voice is a thin wrapper. The data underneath, the FAIL/WARN list, `file:line`
-references, and fixes, stays clean and machine-faithful. **Never rewrite or paraphrase
-`scan.sh` output**, and keep Pierre to one line.
+When you present the verdict to the user, open with Pierre's verdict (the French App Review
+critic, see Phase 3) as a short **trilingual block**: his native **French** line first, then an
+**English** rendering, then the **user's conversation language** rendering. Each is an
+*idiomatic, in-character* re-expression in that language's own rhythm — his deadpan French-critic
+register carried across, never a flat word-for-word translation. Collapse to two lines if the
+user already converses in French or English (no duplicate line). Then drop straight into the
+plain, surgical breakdown. The voice is a thin wrapper. The data underneath, the FAIL/WARN list,
+`file:line` references, and fixes, stays clean and machine-faithful. **Never rewrite or paraphrase
+`scan.sh` output**, and keep the Pierre block to these short one-per-language lines.
 
 ## Flow (5 phases: 0–4)
 
@@ -125,7 +129,17 @@ palate of a French critic. Use this prompt verbatim, filling in the app's specif
 > one 4.x, one 5.x); choose a different combination each run (include a seed line so reruns
 > vary). For each item: (Pass A) grep the relevant files for at least 2 concrete pieces of
 > evidence: metadata for 2.3.x; the paywall view + String Catalog for 3.1.x; Core/navigation
-> for 4.x; Info.plist + PrivacyInfo for 5.1.x. (Pass B) ask "as a reviewer, on what basis would
+> for 4.x; Info.plist + PrivacyInfo for 5.1.x. **Scope of evidence:** only Apple-facing
+> submission artifacts count toward a reject risk — fastlane metadata, the paywall Swift, the
+> String Catalog, Info.plist, and PrivacyInfo.xcprivacy. Internal or local-only files (anything
+> under `.planning/`, design notes, build scripts, and `reviewPrepNotes` drafts — which are *not*
+> auto-submitted to App Store Connect) and any Google Play / non-Apple sections are **out of
+> scope**: cite them at most as a WARN labeled "internal draft — not submitted to Apple", never as
+> REJECT-CERTAIN/REJECT-RISK. A REJECT risk requires a contradiction *within* submission-facing
+> artifacts (e.g. metadata vs the paywall), not an internal doc disagreeing with metadata. An
+> eligibility-gated / conditional offer (e.g. a free trial shown only to eligible users) paired
+> with metadata that mentions the offer is **WARN at most**, unless the metadata promises it
+> unconditionally to all users. (Pass B) ask "as a reviewer, on what basis would
 > I flag this?" (Pass C) write a rejection draft in Apple's real voice (Guideline X.Y.Z –
 > Category / We noticed… / Specifically… / Next Steps… / Resources…). Assign each item a risk:
 > REJECT-CERTAIN / REJECT-RISK / WARN / PASS. End with a submit recommendation (HOLD / SUBMIT
@@ -149,15 +163,21 @@ narrative; verdict.sh just pins the threshold arithmetic.
 
 1. Gather Phase 0–3 output; tally FAIL + WARN + PASS into the output-contract table.
 2. For each FAIL, give a `file:line` reference and a suggested fix.
-3. Open the verdict with **one** line in Pierre's voice (vary the wording each run; keep it short
-   and in his deadpan French-critic register), then drop into the plain breakdown. Decide:
-   - **GREEN:** Pierre, grudgingly: *"Hmf. I find nothing. Acceptable. Do not make me regret this."*
+3. Open the verdict with Pierre's **trilingual block** — French, then English, then the user's
+   conversation language — then drop into the plain breakdown. Each line is an idiomatic,
+   in-character rendering (not a literal translation), carrying his deadpan French-critic register
+   into that language's own rhythm. Collapse to two lines if the user already converses in French
+   or English. Vary the wording each run; keep each line short. Decide:
+   - **GREEN:** e.g. FR *"Hmf. Je ne trouve rien. Acceptable. Ne me faites pas regretter."* /
+     EN *"Hmf. I find nothing. Acceptable. Do not make me regret this."* / + the user-language line,
      then `date +%s > .precheck-pass && echo "token written"` (valid 60 min).
-   - **YELLOW:** Pierre: *"A few small uglinesses. I would not reject, but I noticed."* List the
-     WARNs plainly, ask the user "confirm and submit anyway?", write the token only on confirmation.
-   - **RED:** Pierre: *"Non. {n} faults. Apple would have found fewer. Suivant."* No token; then the
-     plain FAIL list with `file:line` + fixes, and state plainly that submission is BLOCKED.
-   The Pierre line is flavor only. The FAIL/WARN list, `file:line`, and fixes below it stay plain
+   - **YELLOW:** e.g. FR *"Quelques petites laideurs. Je ne rejette pas, mais j'ai remarqué."* /
+     EN *"A few small uglinesses. I would not reject, but I noticed."* / + the user-language line.
+     List the WARNs plainly, ask the user "confirm and submit anyway?", write the token only on confirmation.
+   - **RED:** e.g. FR *"Non. {n} fautes. Apple en aurait trouvé moins. Suivant."* /
+     EN *"No. {n} faults. Apple would have found fewer. Next."* / + the user-language line.
+     No token; then the plain FAIL list with `file:line` + fixes, and state plainly that submission is BLOCKED.
+   The Pierre block is flavor only. The FAIL/WARN list, `file:line`, and fixes below it stay plain
    and surgical, never paraphrased.
 4. Print the final manual checklist (see
    [`references/methodology.md`](references/methodology.md#pre-submit-manual-checklist)).
@@ -178,7 +198,10 @@ narrative; verdict.sh just pins the threshold arithmetic.
   URLs and placeholder copy). The export-compliance key is flagged when absent, but the actual
   encryption answer still belongs in App Store Connect.
 - The adversarial reviewer is a heuristic simulation, not a guarantee of Apple's decision.
-- iOS only. Android / Play Console is out of scope.
+- Most accurate for native Swift / SwiftUI. The metadata, privacy-manifest, screenshots, and
+  export-compliance checks apply to any iOS app, but the code-level checks read Swift source, so on
+  React Native (JavaScript) or Flutter (Dart) they under-detect rather than false-fire.
+- iOS only.
 - Phase 0 detects only **structural** drift (added/removed section numbers); see the reference for why.
 
 ## Optional: upload guard hook

package/skills/appstore-precheck/evals/evals.json

@@ -22,7 +22,7 @@
         "The .precheck-pass token is NOT written (it is removed/withheld)",
         "Flags Guideline 2.3.10: the 'Android' / 'Google Play' reference in the metadata description",
         "Flags Guideline 3.1.2: missing Restore Purchases, Terms of Use, and Privacy Policy on the paywall",
-        "The response opens with exactly one in-character Pierre line, then plain output",
+        "The response opens with Pierre's trilingual block (French, English, then the user's conversation language; two lines if the user already speaks French or English), then plain output",
         "The scan's FAIL lines are shown verbatim (machine-faithful), not paraphrased or invented"
       ]
     },
@@ -46,7 +46,7 @@
         "The .precheck-pass token is written",
         "Confirms Restore Purchases, Terms of Use, and Privacy Policy are present on the paywall",
         "Reports zero FAIL lines",
-        "The response opens with exactly one in-character Pierre line"
+        "The response opens with Pierre's trilingual block (French, English, then the user's conversation language; two lines if the user already speaks French or English)"
       ]
     },
     {

package/skills/appstore-precheck/references/methodology.md

@@ -83,6 +83,12 @@ Vectors 8–10 only run when in-app-purchase signals are detected (StoreKit / Re
 or a paywall view). Otherwise the scanner emits a single PASS and skips them. Vectors 16–20 are
 signal-gated advisory WARNs: each emits nothing unless its triggering signal is present.
 
+**Scope by app type.** The metadata, privacy-manifest, screenshots, and export-compliance checks
+apply to any iOS app regardless of how it is built. The code-level checks grep the app's Swift
+source (`*.swift`, plus `*.m`/`*.h` and `*.entitlements` where relevant), so they are most accurate
+for native Swift / SwiftUI. On React Native (JavaScript) or Flutter (Dart) apps that logic is not in
+Swift, so the code-level checks under-detect rather than misfire. iOS only.
+
 ---
 
 ## Auto-detection rules

package/skills/appstore-precheck/scripts/scan.sh

@@ -134,7 +134,9 @@ fi
 
 # Locales: explicit config array, else the directory names under metadata/.
 declare -a LOCALES=()
+LOCALES_FROM_CONFIG=""
 if [[ -f "$CONFIG" ]] && have_jq && [[ "$(jq -r '.locales | type' "$CONFIG" 2>/dev/null)" == "array" ]]; then
+  LOCALES_FROM_CONFIG=1
   while IFS= read -r l; do LOCALES+=("$l"); done < <(jq -r '.locales[]' "$CONFIG" 2>/dev/null)
 elif [[ -d "$META_DIR" ]]; then
   while IFS= read -r d; do
@@ -266,7 +268,18 @@ if (( ${#LOCALES[@]} > 0 )); then
   expected_files=(name.txt subtitle.txt description.txt keywords.txt)
   for loc in "${LOCALES[@]+"${LOCALES[@]}"}"; do
     d="$META_DIR/$loc"
-    if [[ ! -d "$d" ]]; then fail "2.3.7 Locale missing — $d does not exist"; continue; fi
+    if [[ ! -d "$d" ]]; then
+      # A locale listed in .appstore-precheck.json but absent on disk is a
+      # config/reality mismatch, not a build fault: the locale was simply never
+      # submitted. Warn (don't block) so an approved set isn't falsely RED.
+      # Auto-detected locales always exist, so this only fires in config mode.
+      if [[ -n "$LOCALES_FROM_CONFIG" ]]; then
+        warn "2.3.7 Locale '$loc' is in .appstore-precheck.json but has no metadata folder ($d) — add it or remove '$loc' from the config 'locales' list"
+      else
+        fail "2.3.7 Locale missing — $d does not exist"
+      fi
+      continue
+    fi
     for f in "${expected_files[@]}"; do
       [[ -s "$d/$f" ]] || fail "2.3.7 Metadata missing — $d/$f is empty or absent"
     done
@@ -463,7 +476,7 @@ if [[ -d "$META_DIR" ]]; then
     [[ -z "$support_found" ]] && warn "2.3 Support URL — no non-empty support_url.txt in any locale under fastlane metadata; Apple requires a working support URL"
     [[ -z "$privacy_found" ]] && warn "2.3 Privacy URL — no non-empty privacy_url.txt in any locale under fastlane metadata; required for apps with accounts or in-app purchases"
   fi
-  url_ph=$(grep -rEnI 'example\.com|localhost|\bTODO\b|changeme' "$META_DIR" --include='*_url.txt' 2>/dev/null | grep -v "^Binary file" | head -10)
+  url_ph=$(grep -rEnI 'example\.com|localhost|\bTODO\b|\bchangeme\b' "$META_DIR" --include='*_url.txt' 2>/dev/null | grep -v "^Binary file" | head -10)
   if [[ -n "$url_ph" ]]; then
     warn "2.3 Metadata URL — placeholder URL in fastlane metadata (replace before submitting):"
     echo "$url_ph" | sed 's/^/      /'
@@ -502,7 +515,7 @@ fi
 # avoid flagging legitimate words. Overlaps the Phase 2 precheck "No placeholder
 # text" rule, but this one is local and runs before any network call.
 if [[ -d "$META_DIR" ]]; then
-  ph_re='lorem ipsum|Lorem ipsum|\bTODO\b|\bFIXME\b|example\.com|placeholder|insert .* here|changeme'
+  ph_re='lorem ipsum|Lorem ipsum|\bTODO\b|\bFIXME\b|example\.com|placeholder|insert .* here|\bchangeme\b'
   ph_hits=$(grep -rEnI "$ph_re" "$META_DIR" 2>/dev/null | grep -v "^Binary file" | head -20)
   if [[ -n "$ph_hits" ]]; then
     warn "2.1 Metadata content — placeholder/dummy text in store metadata (looks unfinished; rejected under 2.1):"