apple-tools-mcp 3.0.4 → 3.0.5

package/index.js

@@ -32,6 +32,7 @@ import {
   isWriteTool,
   dispatchWriteTool,
   executeWriteToolLocally,
+  loggedBridgeHandler,
   mcpWriteResult
 } from "./lib/writeTools.js";
 import { startWriteBridgeServer, defaultSocketPath } from "./lib/writeBridge.js";
@@ -112,7 +113,7 @@ async function startWriteBridge() {
   try {
     writeBridge = await startWriteBridgeServer({
       socketPath: WRITE_SOCKET_PATH,
-      handler: (tool, args) => executeWriteToolLocally(tool, args),
+      handler: loggedBridgeHandler((tool, args) => executeWriteToolLocally(tool, args), (msg) => console.error(msg)),
       log: (msg) => console.error(msg)
     });
     ensureEventKitSession({ helpers: EVENTKIT_JXA_HELPERS });

package/lib/writeTools.js

@@ -385,6 +385,46 @@ export function executeWriteToolLocally(name, args = {}) {
  * @param {object} [deps] - injected for tests
  * @returns {Promise<{ ok: boolean, message: string }>}
  */
+/**
+ * One-word reason for a failed write, for logs. Never includes addresses,
+ * subjects, or bodies (write results echo the recipient and subject).
+ */
+export function classifyWriteFailure(message) {
+  const t = String(message || "");
+  if (/GUI scripting is unavailable/i.test(t)) return "gui_scripting_unavailable";
+  if (/denied Accessibility|assistive access|-25211/i.test(t)) return "accessibility_denied";
+  if (/display is asleep|screen saver/i.test(t)) return "display_asleep_or_screen_saver";
+  if (/focus proof failed|caret|Keyboard focus/i.test(t)) return "compose_focus";
+  if (/timed out|ETIMEDOUT|-1712/i.test(t)) return "timeout";
+  if (/-1743|-10004|not authorized to send Apple events/i.test(t)) return "automation_denied";
+  if (/unconfirmed/i.test(t)) return "unconfirmed";
+  return "other";
+}
+
+/**
+ * Wrap the indexer's bridge handler so every bridged write leaves one
+ * timestamped line: tool, outcome, reason class, duration. The indexer log
+ * otherwise has no record of why an overnight send failed.
+ */
+export function loggedBridgeHandler(run, log, now = () => Date.now()) {
+  return async (tool, args) => {
+    const started = now();
+    let result;
+    try {
+      result = await run(tool, args);
+    } catch (e) {
+      log(`${new Date(started).toISOString()} write bridge: ${tool} threw after ${now() - started}ms (${classifyWriteFailure(e && e.message)})`);
+      throw e;
+    }
+    const ok = Boolean(result && result.ok);
+    // Dry runs and confirm-gated previews come back ok:false with planned:true — nothing failed.
+    const planned = !ok && Boolean(result && result.planned);
+    const why = ok || planned ? "" : ` (${classifyWriteFailure(result && result.message)}${result && result.unsupported ? ", unsupported" : ""})`;
+    log(`${new Date(started).toISOString()} write bridge: ${tool} ${ok ? "ok" : planned ? "planned (dry run / needs confirm)" : "failed"} in ${now() - started}ms${why}`);
+    return result;
+  };
+}
+
 export async function dispatchWriteTool(name, args = {}, deps = {}) {
   const {
     indexerMode = false,
@@ -406,16 +446,30 @@ export async function dispatchWriteTool(name, args = {}, deps = {}) {
 
   const route = planWriteRoute({ indexerMode, bridgeAvailable, toolName: name });
 
+  let declined = null;
   if (route.target === "daemon") {
     const { delivered, response, error } = await request({ socketPath, tool: name, args });
     const { fallbackLocal } = planAfterDelegation({ delivered, response });
     if (!fallbackLocal) {
       return response;
     }
-    log(`Write bridge unavailable for ${name} (${error || "no response"}); running locally.`);
+    if (delivered && response && typeof response === "object") {
+      // The daemon answered but couldn't do it (e.g. it couldn't drive Mail's
+      // compose window). Its reason is the real one: it holds the grants.
+      declined = response;
+      log(`Write bridge declined ${name} (${classifyWriteFailure(response.message)}); running locally.`);
+    } else {
+      log(`Write bridge unavailable for ${name} (${error || "no response"}); running locally.`);
+    }
   }
 
   const result = runLocally(name, args);
+  if (declined && result && result.ok === false && declined.message) {
+    return {
+      ...result,
+      message: `${declined.message} (Reported by the indexer daemon, which holds the Automation/Accessibility grants. The local fallback in this process also failed: ${classifyWriteFailure(result.message)}.)`
+    };
+  }
   if (
     result &&
     result.ok === false &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "apple-tools-mcp",
-  "version": "3.0.4",
+  "version": "3.0.5",
   "description": "MCP server for semantic search and write actions across Apple Mail, Messages, Calendar, and Contacts. Speaks stdio (local) or bearer-token-authenticated Streamable HTTP (LAN / Tailscale).",
   "type": "module",
   "main": "index.js",