apple-notes-mcp 2.8.40 → 2.8.42

package/README.md

@@ -1602,7 +1602,7 @@ Saves a note attachment to disk.
 |-----------|------|----------|-------------|
 | `noteId` | string | Yes | CoreData note ID (from `search-notes`/`list-notes`) |
 | `attachmentId` | string | Yes | Attachment ID (from `list-attachments`) |
-| `savePath` | string | Yes | Absolute destination file path. Must be under your home directory, a temp directory, or `/Volumes` |
+| `savePath` | string | Yes | Absolute destination file path. Must be under your home directory, a temp directory, or `/Volumes`, and never inside the Notes data folder (`~/Library/Group Containers/group.com.apple.notes`), however it is reached (symlink or different letter case) |
 
 **Returns:** Confirmation with the saved path, name, and content type (also in `structuredContent`).
 

package/build/index.js

@@ -39615,6 +39615,22 @@ import { createHash } from "node:crypto";
 import { homedir as homedir2 } from "node:os";
 import { join as join2 } from "node:path";
 import { gunzipSync as gunzipSync2 } from "node:zlib";
+
+// src/utils/uniqueById.ts
+function uniqueById(items) {
+  const seen = /* @__PURE__ */ new Set();
+  const result = [];
+  for (const item of items) {
+    if (item.id) {
+      if (seen.has(item.id)) continue;
+      seen.add(item.id);
+    }
+    result.push(item);
+  }
+  return result;
+}
+
+// src/utils/noteRichText.ts
 var HTML_LOSSY_ORDER = [
   "superscript",
   "subscript",
@@ -39706,14 +39722,15 @@ function parseRichNote(data, nativeTags = []) {
     hasNativeObjects ||= Boolean(getField(fields, 12));
     const attachment = embeddedMessage(getField(fields, 12));
     const attachmentId = attachment && stringValue(getField(attachment, 1));
-    if (attachmentId) nativeObjectIds.push(attachmentId);
-    if (attachmentId)
+    if (attachment && attachmentId && !nativeObjectIds.includes(attachmentId)) {
+      nativeObjectIds.push(attachmentId);
       objects.push({
         id: attachmentId,
         type: stringValue(getField(attachment, 2)) || "unknown",
         start: position,
         length
       });
+    }
     hasChecklist ||= Boolean(paragraph && varintValue(getField(paragraph, 1)) === 103);
     if (paragraph && varintValue(getField(paragraph, 1)) === 103) {
       const checklist = embeddedMessage(getField(paragraph, 5));
@@ -39771,7 +39788,9 @@ function readRichNote(id2) {
     (row) => !row || typeof row.id !== "string" || !Number.isInteger(row.pk) || typeof row.mergeable !== "string" || !/^[0-9a-f]*$/i.test(row.mergeable)
   ))
     throw new Error("Invalid native object metadata");
-  rich.objectData = objectData.filter((row) => rich.nativeObjectIds.includes(row.id)).sort((a, b) => a.id.localeCompare(b.id));
+  rich.objectData = uniqueById(
+    objectData.filter((row) => rich.nativeObjectIds.includes(row.id)).sort((a, b) => a.id.localeCompare(b.id))
+  );
   rich.revision = createHash("sha256").update(rich.revision).update(JSON.stringify(rich.objectData)).digest("hex");
   rich.nativeTagObjectIds = {};
   for (const id3 of rich.nativeObjectIds)
@@ -40942,6 +40961,9 @@ function allowedSaveRoots() {
     "/private/tmp"
   ];
 }
+function deniedSaveRoots() {
+  return [join6(homedir6(), "Library/Group Containers/group.com.apple.notes")];
+}
 function canonicalize(path9) {
   return realpathSync.native(path9);
 }
@@ -40983,11 +41005,11 @@ function deepestExistingAncestor(abs) {
     current = parent;
   }
 }
-function ensureParentDir(abs, roots = allowedSaveRoots()) {
-  assertSafeSavePath(abs, roots);
+function ensureParentDir(abs, roots = allowedSaveRoots(), denied = deniedSaveRoots()) {
+  assertSafeSavePath(abs, roots, denied);
   mkdirSync(dirname(abs), { recursive: true });
 }
-function assertSafeSavePath(p, roots = allowedSaveRoots()) {
+function assertSafeSavePath(p, roots = allowedSaveRoots(), denied = deniedSaveRoots()) {
   if (!p || !p.trim()) throw new Error("A destination path is required.");
   if (!isAbsolute(p)) throw new Error(`Destination path must be absolute: "${p}"`);
   const abs = resolve(p);
@@ -41015,6 +41037,12 @@ function assertSafeSavePath(p, roots = allowedSaveRoots()) {
       `Refusing to write outside allowed locations (home, temp, /Volumes): "${abs}" resolves to "${canonicalDest}" through a symbolic link.`
     );
   }
+  const deniedForms = [
+    .../* @__PURE__ */ new Set([...denied.map((d) => resolve(d)), ...canonicalRoots(denied)])
+  ].map((d) => d.toLowerCase());
+  if ([abs, canonicalDest].some((form) => isWithinRoots(form.toLowerCase(), deniedForms))) {
+    throw new Error(`Refusing to write inside the Notes library container: "${abs}"`);
+  }
   return abs;
 }
 var DEFAULT_MAX_ATTACHMENT_BYTES = 25 * 1024 * 1024;
@@ -43237,7 +43265,7 @@ var AppleNotesManager = class {
         }
       }
     }
-    return sharedNotes;
+    return uniqueById(sharedNotes);
   }
   // ===========================================================================
   // Folder Operations
@@ -44076,7 +44104,7 @@ var AppleNotesManager = class {
         });
       }
     }
-    return attachments;
+    return uniqueById(attachments);
   }
   /**
    * Lists attachments for a note by its title.
@@ -44163,7 +44191,7 @@ var AppleNotesManager = class {
         });
       }
     }
-    return attachments;
+    return uniqueById(attachments);
   }
   /**
    * Saves a single attachment of a note (identified by attachment id) to a file
@@ -52745,13 +52773,15 @@ registerTool(
 registerTool(
   "save-attachment",
   {
-    description: "Use when: writing one note attachment to a file on disk.\nReturns: the saved path.\nDo not use when: you want the bytes in-memory as base64 (fetch-attachment).\nSafety: writes a file; savePath must be absolute and under the home directory, a temp dir, or /Volumes. Get the ids from list-attachments first.",
+    description: "Use when: writing one note attachment to a file on disk.\nReturns: the saved path.\nDo not use when: you want the bytes in-memory as base64 (fetch-attachment).\nSafety: writes a file; savePath must be absolute and under the home directory, a temp dir, or /Volumes, and not inside the Notes data folder. Get the ids from list-attachments first.",
     inputSchema: {
       noteId: looseNoteId(external_exports.string().min(1, "noteId is required")).describe(
         `Note id (from search/list): ${NOTE_ID_FORMS}`
       ),
       attachmentId: external_exports.string().min(1, "attachmentId is required").max(MAX.ATTACHMENT_ID).describe("Attachment id (from list-attachments)"),
-      savePath: external_exports.string().min(1, "savePath is required").max(MAX.SAVE_PATH).describe("Absolute destination file path (must be under home, temp, or /Volumes)")
+      savePath: external_exports.string().min(1, "savePath is required").max(MAX.SAVE_PATH).describe(
+        "Absolute destination file path (must be under home, temp, or /Volumes; never inside the Notes data folder)"
+      )
     },
     outputSchema: {
       savedPath: external_exports.string().optional(),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "apple-notes-mcp",
-  "version": "2.8.40",
+  "version": "2.8.42",
   "description": "MCP server for Apple Notes - create, search, update, and manage notes via Claude and other AI assistants",
   "type": "module",
   "main": "build/index.js",