appium 2.2.2 → 2.3.0

package/lib/main.js

@@ -7,7 +7,7 @@ import {
   server as baseServer,
   normalizeBasePath,
 } from '@appium/base-driver';
-import {logger as logFactory, util, env, fs} from '@appium/support';
+import {logger as logFactory, util, env} from '@appium/support';
 import {asyncify} from 'asyncbox';
 import _ from 'lodash';
 import {AppiumDriver} from './appium';
@@ -20,15 +20,13 @@ import {
   getNonDefaultServerArgs,
   showConfig,
   showBuildInfo,
-  validateTmpDir,
-  warnNodeDeprecations,
-  checkNpmOk,
+  requireDir,
 } from './config';
 import {readConfigFile} from './config-file';
 import {loadExtensions, getActivePlugins, getActiveDrivers} from './extension';
 import {SERVER_SUBCOMMAND, LONG_STACKTRACE_LIMIT} from './constants';
 import registerNode from './grid-register';
-import {getDefaultsForSchema, validate} from './schema/schema';
+import {getDefaultsForSchema, validate as validateSchema} from './schema/schema';
 import {
   inspect,
   adjustNodePath,
@@ -40,7 +38,6 @@ import {
   V4_BROADCAST_IP,
   V6_BROADCAST_IP,
 } from './utils';
-import os from 'node:os';
 import net from 'node:net';
 
 const {resolveAppiumHome} = env;
@@ -53,7 +50,6 @@ const {resolveAppiumHome} = env;
 async function preflightChecks(args, throwInsteadOfExit = false) {
   try {
     checkNodeOk();
-    await checkNpmOk();
     if (args.longStacktrace) {
       Error.stackTraceLimit = LONG_STACKTRACE_LIMIT;
     }
@@ -61,12 +57,11 @@ async function preflightChecks(args, throwInsteadOfExit = false) {
       await showBuildInfo();
       process.exit(0);
     }
-    warnNodeDeprecations();
 
-    validate(args);
+    validateSchema(args);
 
     if (args.tmpDir) {
-      await validateTmpDir(args.tmpDir);
+      await requireDir(args.tmpDir, !args.noPermsCheck, 'tmpDir argument value');
     }
   } catch (err) {
     logger.error(err.message.red);
@@ -149,48 +144,16 @@ function getExtraMethodMap(driverClasses, pluginClasses) {
 }
 
 /**
- * Prepares and validates appium home path folder
- *
- * @param {string} name The name of the appium home source (needed for error messages)
- * @param {string} appiumHome The actual value to be verified
- * @returns {Promise<string>} Same appiumHome value
- * @throws {Error} If the validation has failed
+ * @param {string?} [appiumHomeFromArgs] - Appium home value retrieved from progrmmatic server args
+ * @returns {string}
  */
-async function prepareAppiumHome(name, appiumHome) {
-  let stat;
-  try {
-    stat = await fs.stat(appiumHome);
-  } catch (e) {
-    let err = e;
-    if (e.code === 'ENOENT') {
-      try {
-        await fs.mkdir(appiumHome, {recursive: true});
-        return appiumHome;
-      } catch (e1) {
-        err = e1;
-      }
-    }
-    throw new Error(
-      `The path '${appiumHome}' provided in the ${name} must point ` +
-        `to a valid folder writeable for the current user account '${os.userInfo().username}'. ` +
-        `Original error: ${err.message}`,
-    );
-  }
-  if (!stat.isDirectory()) {
-    throw new Error(
-      `The path '${appiumHome}' provided in the ${name} must point to a valid folder`,
-    );
-  }
-  try {
-    await fs.access(appiumHome, fs.constants.W_OK);
-  } catch (e) {
-    throw new Error(
-      `The folder path '${appiumHome}' provided in the ${name} must be ` +
-        `writeable for the current user account '${os.userInfo().username}. ` +
-        `Original error: ${e.message}`,
-    );
+function determineAppiumHomeSource(appiumHomeFromArgs) {
+  if (!_.isNil(appiumHomeFromArgs)) {
+    return 'appiumHome config value';
+  } else if (process.env.APPIUM_HOME) {
+    return 'APPIUM_HOME environment variable';
   }
-  return appiumHome;
+  return 'autodetected Appium home path';
 }
 
 /**
@@ -212,13 +175,10 @@ async function prepareAppiumHome(name, appiumHome) {
  */
 async function init(args) {
   const appiumHome = args?.appiumHome ?? (await resolveAppiumHome());
-  let appiumHomeSourceName = 'autodetected appium home path';
-  if (!_.isNil(args?.appiumHome)) {
-    appiumHomeSourceName = 'appiumHome config value';
-  } else if (process.env.APPIUM_HOME) {
-    appiumHomeSourceName = 'APPIUM_HOME environment variable';
-  }
-  await prepareAppiumHome(appiumHomeSourceName, appiumHome);
+  const appiumHomeSourceName = determineAppiumHomeSource(args?.appiumHome);
+  // We verify the writeability later based on requested server arguments
+  // Here we just need to make sure the path exists and is a folder
+  await requireDir(appiumHome, false, appiumHomeSourceName);
 
   adjustNodePath();
 
@@ -295,6 +255,10 @@ async function init(args) {
       }
     }
 
+    if (!serverArgs.noPermsCheck) {
+      await requireDir(appiumHome, true, appiumHomeSourceName);
+    }
+
     const appiumDriver = new AppiumDriver(
       /** @type {import('@appium/types').DriverOpts<import('./appium').AppiumDriverConstraints>} */ (
         serverArgs
@@ -309,8 +273,10 @@ async function init(args) {
       parsedArgs: serverArgs,
       driverConfig,
       pluginConfig,
+      appiumHome,
     });
   } else {
+    await requireDir(appiumHome, true, appiumHomeSourceName);
     if (isExtensionCommandArgs(preConfigArgs)) {
       // if the user has requested the 'driver' CLI, don't run the normal server,
       // but instead pass control to the driver CLI
@@ -340,7 +306,7 @@ function logServerAddress(url) {
   }
 
   const interfaces = fetchInterfaces(urlObj.hostname === V4_BROADCAST_IP ? 4 : 6);
-  const toLabel = (/** @type {os.NetworkInterfaceInfo} */ iface) => {
+  const toLabel = (/** @type {import('node:os').NetworkInterfaceInfo} */ iface) => {
     const href = urlObj.href.replace(urlObj.hostname, iface.address);
     return iface.internal ? `${href} (only accessible from the same host)` : href;
   };
@@ -370,17 +336,25 @@ async function main(args) {
     );
   }
 
-  const {appiumDriver, pluginConfig, driverConfig, parsedArgs} =
+  const {appiumDriver, pluginConfig, driverConfig, parsedArgs, appiumHome} =
     /** @type {InitResult<ServerCommand>} */ (initResult);
 
-  const pluginClasses = getActivePlugins(pluginConfig, parsedArgs.usePlugins);
+  const pluginClasses = await getActivePlugins(
+    pluginConfig, parsedArgs.pluginsImportChunkSize, parsedArgs.usePlugins
+  );
   // set the active plugins on the umbrella driver so it can use them for commands
   appiumDriver.pluginClasses = pluginClasses;
 
   await logStartupInfo(parsedArgs);
+
+  const appiumHomeSourceName = determineAppiumHomeSource(args?.appiumHome);
+  logger.debug(`The ${appiumHomeSourceName}: ${appiumHome}`);
+
   let routeConfiguringFunction = makeRouter(appiumDriver);
 
-  const driverClasses = getActiveDrivers(driverConfig, parsedArgs.useDrivers);
+  const driverClasses = await getActiveDrivers(
+    driverConfig, parsedArgs.driversImportChunkSize, parsedArgs.useDrivers
+  );
   const serverUpdaters = getServerUpdaters(driverClasses, pluginClasses);
   const extraMethodMap = getExtraMethodMap(driverClasses, pluginClasses);
 
@@ -498,6 +472,7 @@ export {main, init, resolveAppiumHome};
  * @typedef ServerInitData
  * @property {import('./appium').AppiumDriver} appiumDriver - The Appium driver
  * @property {import('appium/types').ParsedArgs} parsedArgs - The parsed arguments
+ * @property {string} appiumHome - The full path to the Appium home folder
  */
 
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appium",
-  "version": "2.2.2",
+  "version": "2.3.0",
   "description": "Automation for Apps.",
   "keywords": [
     "automation",
@@ -60,25 +60,25 @@
     "test:unit": "mocha \"./test/unit/**/*.spec.js\""
   },
   "dependencies": {
-    "@appium/base-driver": "^9.4.2",
-    "@appium/base-plugin": "^2.2.23",
-    "@appium/docutils": "^0.4.12",
-    "@appium/schema": "^0.4.2",
-    "@appium/support": "^4.1.9",
-    "@appium/types": "^0.14.2",
-    "@sidvind/better-ajv-errors": "2.1.0",
-    "@types/argparse": "2.0.13",
+    "@appium/base-driver": "^9.4.4",
+    "@appium/base-plugin": "^2.2.25",
+    "@appium/docutils": "^1.0.1",
+    "@appium/schema": "^0.5.0",
+    "@appium/support": "^4.1.11",
+    "@appium/types": "^0.15.0",
+    "@sidvind/better-ajv-errors": "2.1.3",
+    "@types/argparse": "2.0.14",
     "@types/bluebird": "3.5.42",
     "@types/fancy-log": "2.0.2",
-    "@types/semver": "7.5.5",
-    "@types/teen_process": "2.0.3",
+    "@types/semver": "7.5.6",
+    "@types/teen_process": "2.0.4",
     "@types/wrap-ansi": "3.0.0",
     "ajv": "8.12.0",
     "ajv-formats": "2.1.1",
     "argparse": "2.0.1",
     "async-lock": "1.4.0",
     "asyncbox": "3.0.0",
-    "axios": "1.6.1",
+    "axios": "1.6.2",
     "bluebird": "3.7.2",
     "cross-env": "7.0.3",
     "find-up": "5.0.0",
@@ -90,8 +90,8 @@
     "resolve-from": "5.0.0",
     "semver": "7.5.4",
     "source-map-support": "0.5.21",
-    "teen_process": "2.0.84",
-    "type-fest": "3.13.1",
+    "teen_process": "2.1.1",
+    "type-fest": "4.8.3",
     "winston": "3.11.0",
     "wrap-ansi": "7.0.0",
     "yaml": "2.3.4"
@@ -103,8 +103,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "717ec38d8cb63330ac1901eda8ef4489d256678b",
-  "typedoc": {
-    "entryPoint": "./lib/main.js"
-  }
+  "gitHead": "5c1d20517cfc8773cd5ffb0f8bb996668d71116b"
 }