appium-webdriveragent 16.2.0 → 16.2.1

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [16.2.1](https://github.com/appium/WebDriverAgent/compare/v16.2.0...v16.2.1) (2026-08-17)
+
+### Bug Fixes
+
+* sign the runner by certificate hash instead of display name ([#1211](https://github.com/appium/WebDriverAgent/issues/1211)) ([59e95a7](https://github.com/appium/WebDriverAgent/commit/59e95a73986a91c90c951608d7744a032997810b))
+
 ## [16.2.0](https://github.com/appium/WebDriverAgent/compare/v16.1.7...v16.2.0) (2026-08-13)
 
 ### Features

package/Scripts/embed-runner-icon.sh

@@ -36,12 +36,32 @@ if [ ${#ICONS[@]} -eq 0 ]; then
     exit 0
 fi
 
-cp -f "${ICONS[@]}" "$RUNNER_APP/"
+PLIST="$RUNNER_APP/Info.plist"
+
+# Everything below mutates a bundle Xcode already signed, so keep enough state
+# to undo it: a failed re-sign must not leave an uninstallable runner behind.
+PLIST_BACKUP=$(mktemp)
+CERT_DIR=$(mktemp -d)
+trap 'rm -rf "$PLIST_BACKUP" "$CERT_DIR"' EXIT
+cp "$PLIST" "$PLIST_BACKUP"
+ADDED_FILES=()
+
+restore_bundle() {
+    cp -f "$PLIST_BACKUP" "$PLIST"
+    if [ ${#ADDED_FILES[@]} -gt 0 ]; then
+        rm -f "${ADDED_FILES[@]}"
+    fi
+}
+
+for icon in "${ICONS[@]}"; do
+    dest="$RUNNER_APP/$(basename "$icon")"
+    [ -e "$dest" ] || ADDED_FILES+=("$dest")
+    cp -f "$icon" "$dest"
+done
 if [ -f "$XCTEST/Assets.car" ]; then
+    [ -e "$RUNNER_APP/Assets.car" ] || ADDED_FILES+=("$RUNNER_APP/Assets.car")
     cp -f "$XCTEST/Assets.car" "$RUNNER_APP/"
 fi
-
-PLIST="$RUNNER_APP/Info.plist"
 /usr/libexec/PlistBuddy -c "Delete :CFBundleIcons" "$PLIST" 2>/dev/null || true
 /usr/libexec/PlistBuddy -c "Delete :CFBundleIcons~ipad" "$PLIST" 2>/dev/null || true
 
@@ -58,29 +78,40 @@ PLIST="$RUNNER_APP/Info.plist"
 /usr/libexec/PlistBuddy -c "Add :CFBundleIcons~ipad:CFBundlePrimaryIcon:CFBundleIconFiles:0 string AppIcon60x60" "$PLIST"
 /usr/libexec/PlistBuddy -c "Add :CFBundleIcons~ipad:CFBundlePrimaryIcon:CFBundleIconFiles:1 string AppIcon76x76" "$PLIST"
 
-# Re-codesign since we modified the bundle after Xcode signed it.
-# In a scheme post-action context Xcode's CODE_SIGN_* env vars are not exposed,
-# so discover the existing signing identity from the already-signed bundle.
+# Re-codesign since we modified the bundle after Xcode signed it. Scheme
+# post-actions never receive EXPANDED_CODE_SIGN_IDENTITY, so the signer has to
+# be recovered from the already-signed bundle.
 if [ -d "$RUNNER_APP/_CodeSignature" ]; then
     # Capture the signature info once. Piping codesign straight into
     # `awk ... exit` makes awk close the pipe early, killing codesign with
     # SIGPIPE -- which `set -o pipefail` turns into a fatal error. That trips
     # only when an Authority line exists, i.e. on every real-device build.
     SIGN_INFO=$(codesign -dvv "$RUNNER_APP" 2>&1 || true)
-    EXISTING_IDENT="${EXPANDED_CODE_SIGN_IDENTITY:-}"
-    if [ -z "$EXISTING_IDENT" ]; then
-        EXISTING_IDENT=$(awk -F'=' '/^Authority/ {print $2; exit}' <<< "$SIGN_INFO")
-    fi
-    # Simulator builds are ad-hoc signed: there is no Authority line, but the
-    # bundle can still be re-signed ad-hoc with an identity of "-".
-    if [ -z "$EXISTING_IDENT" ] && grep -q '^Signature=adhoc' <<< "$SIGN_INFO"; then
+
+    if grep -q '^Signature=adhoc' <<< "$SIGN_INFO"; then
+        # Simulator builds are ad-hoc signed; re-sign them ad-hoc.
         EXISTING_IDENT="-"
-    fi
-    if [ -n "$EXISTING_IDENT" ]; then
-        codesign --force --sign "$EXISTING_IDENT" \
-                 --preserve-metadata=identifier,entitlements "$RUNNER_APP"
     else
-        echo "warning: bundle is signed but no identity discovered; signature will be invalid"
+        # Identify the signer by leaf-certificate SHA-1, never by Authority
+        # display name: duplicate identities can share a name, and codesign
+        # then rejects the name as ambiguous (Apple TN3161).
+        EXISTING_IDENT=""
+        if codesign -d --extract-certificates="$CERT_DIR/leaf" "$RUNNER_APP" 2>/dev/null \
+                && [ -f "$CERT_DIR/leaf0" ]; then
+            EXISTING_IDENT=$(shasum -a 1 "$CERT_DIR/leaf0" | awk '{print toupper($1)}')
+        fi
+        if [ -z "$EXISTING_IDENT" ]; then
+            EXISTING_IDENT=$(awk -F'=' '/^Authority/ {print $2; exit}' <<< "$SIGN_INFO")
+        fi
+    fi
+
+    if [ -z "$EXISTING_IDENT" ] || ! codesign --force --sign "$EXISTING_IDENT" \
+            --preserve-metadata=identifier,entitlements "$RUNNER_APP"; then
+        # A modified-but-stale-signed bundle fails to install, which would break
+        # the session over a cosmetic icon. Undo instead.
+        restore_bundle
+        echo "warning: could not re-sign $RUNNER_APP; skipped icon embed"
+        exit 0
     fi
 fi
 

package/WebDriverAgentLib/Info.plist

@@ -15,11 +15,11 @@
     <key>CFBundlePackageType</key>
     <string>FMWK</string>
     <key>CFBundleShortVersionString</key>
-    <string>16.2.0</string>
+    <string>16.2.1</string>
     <key>CFBundleSignature</key>
     <string>????</string>
     <key>CFBundleVersion</key>
-    <string>16.2.0</string>
+    <string>16.2.1</string>
     <key>NSPrincipalClass</key>
     <string/>
   </dict>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appium-webdriveragent",
-  "version": "16.2.0",
+  "version": "16.2.1",
   "description": "Package bundling WebDriverAgent",
   "keywords": [
     "Appium",