appium-ios-remotexpc 0.5.0 → 0.5.1

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.5.1](https://github.com/appium/appium-ios-remotexpc/compare/v0.5.0...v0.5.1) (2025-10-04)
+
+### Bug Fixes
+
+* **plist:** enforce strict length‑prefixed framing in `LengthBasedSplitter` ([#75](https://github.com/appium/appium-ios-remotexpc/issues/75)) ([e3d1ba2](https://github.com/appium/appium-ios-remotexpc/commit/e3d1ba26bc0553a82e56e8af429dd1c1d1637e88))
+
 ## [0.5.0](https://github.com/appium/appium-ios-remotexpc/compare/v0.4.2...v0.5.0) (2025-09-29)
 
 ### Features

package/build/src/lib/plist/length-based-splitter.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"length-based-splitter.d.ts","sourceRoot":"","sources":["../../../../src/lib/plist/length-based-splitter.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,SAAS,EAAE,KAAK,iBAAiB,EAAE,MAAM,QAAQ,CAAC;AA0B3D;;GAEG;AACH,MAAM,WAAW,0BAA0B;IACzC,cAAc,CAAC,EAAE,MAAM,CAAC,cAAc,CAAC;IACvC,YAAY,CAAC,EAAE,OAAO,CAAC;IACvB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,gBAAgB,CAAC,EAAE,MAAM,CAAC;CAC3B;AAED;;GAEG;AACH,qBAAa,mBAAoB,SAAQ,SAAS;IAChD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAU;IACvC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAS;IACxC,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAAS;IAC3C,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAAS;IAC3C,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAS;IAC1C,OAAO,CAAC,SAAS,CAAkB;IAEnC;;;OAGG;gBACS,OAAO,GAAE,0BAA+B;IAkBpD;;OAEG;IACH,QAAQ,IAAI,IAAI;IAUhB,UAAU,CACR,KAAK,EAAE,MAAM,EACb,QAAQ,EAAE,cAAc,EACxB,QAAQ,EAAE,iBAAiB,GAC1B,IAAI;IAuDP;;OAEG;IACH,OAAO,CAAC,cAAc;IA+CtB;;OAEG;IACH,OAAO,CAAC,iBAAiB;CA+H1B"}
+{"version":3,"file":"length-based-splitter.d.ts","sourceRoot":"","sources":["../../../../src/lib/plist/length-based-splitter.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,SAAS,EAAE,KAAK,iBAAiB,EAAE,MAAM,QAAQ,CAAC;AA0B3D;;GAEG;AACH,MAAM,WAAW,0BAA0B;IACzC,cAAc,CAAC,EAAE,MAAM,CAAC,cAAc,CAAC;IACvC,YAAY,CAAC,EAAE,OAAO,CAAC;IACvB,cAAc,CAAC,EAAE,MAAM,CAAC;IACxB,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,iBAAiB,CAAC,EAAE,MAAM,CAAC;IAC3B,gBAAgB,CAAC,EAAE,MAAM,CAAC;CAC3B;AAED;;GAEG;AACH,qBAAa,mBAAoB,SAAQ,SAAS;IAChD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAU;IACvC,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAS;IACxC,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAAS;IAC3C,OAAO,CAAC,QAAQ,CAAC,iBAAiB,CAAS;IAC3C,OAAO,CAAC,QAAQ,CAAC,gBAAgB,CAAS;IAC1C,OAAO,CAAC,SAAS,CAAkB;IAEnC;;;OAGG;gBACS,OAAO,GAAE,0BAA+B;IAkBpD;;OAEG;IACH,QAAQ,IAAI,IAAI;IAUhB,UAAU,CACR,KAAK,EAAE,MAAM,EACb,QAAQ,EAAE,cAAc,EACxB,QAAQ,EAAE,iBAAiB,GAC1B,IAAI;IA6CP;;OAEG;IACH,OAAO,CAAC,cAAc;IA+CtB;;OAEG;IACH,OAAO,CAAC,iBAAiB;CAsG1B"}

package/build/src/lib/plist/length-based-splitter.js

@@ -57,29 +57,16 @@ export class LengthBasedSplitter extends Transform {
             this.buffer = Buffer.concat([this.buffer, chunk]);
             // Check if this is XML data or binary plist before doing any other processing
             const bufferString = this.buffer.toString(UTF8_ENCODING, 0, Math.min(MAX_PREVIEW_LENGTH, this.buffer.length));
-            // Check for XML format
-            if (isXmlPlistContent(bufferString) || this.isXmlMode) {
-                // This is XML data, set XML mode
-                this.isXmlMode = true;
-                this.processXmlData(callback);
-                return;
-            }
             // Check for binary plist format (bplist00 or Ibplist00)
             if (this.buffer.length >= BINARY_PLIST_HEADER_LENGTH) {
                 const possibleBplistHeader = this.buffer.toString(UTF8_ENCODING, 0, BINARY_PLIST_HEADER_LENGTH);
                 if (possibleBplistHeader === BINARY_PLIST_MAGIC ||
                     possibleBplistHeader.includes(BINARY_PLIST_MAGIC)) {
-                    log.debug('Detected standard binary plist format');
-                    this.push(this.buffer);
-                    this.buffer = Buffer.alloc(0);
-                    return callback();
+                    log.debug('Detected standard binary plist format; proceeding with length-prefixed frame parsing');
                 }
                 if (possibleBplistHeader === IBINARY_PLIST_MAGIC ||
                     possibleBplistHeader.includes(IBINARY_PLIST_MAGIC)) {
-                    log.debug('Detected non-standard Ibplist00 format');
-                    this.push(this.buffer);
-                    this.buffer = Buffer.alloc(0);
-                    return callback();
+                    log.debug('Detected non-standard Ibplist00 format; proceeding with length-prefixed frame parsing');
                 }
             }
             // Process as many complete messages as possible for binary data
@@ -172,11 +159,6 @@ export class LengthBasedSplitter extends Transform {
                     else {
                         // If length is still invalid, check if this might actually be XML
                         const suspiciousData = this.buffer.toString(UTF8_ENCODING, 0, Math.min(MAX_PREVIEW_LENGTH, this.buffer.length));
-                        if (isXmlPlistContent(suspiciousData)) {
-                            this.isXmlMode = true;
-                            // Process as XML on next iteration
-                            return callback();
-                        }
                         // Invalid length - skip one byte and try again
                         this.buffer = this.buffer.slice(1);
                         continue;
@@ -186,11 +168,6 @@ export class LengthBasedSplitter extends Transform {
                     // For non-4-byte length fields, just use the original approach
                     // If length is invalid, check if this might actually be XML
                     const suspiciousData = this.buffer.toString(UTF8_ENCODING, 0, Math.min(MAX_PREVIEW_LENGTH, this.buffer.length));
-                    if (isXmlPlistContent(suspiciousData)) {
-                        this.isXmlMode = true;
-                        // Process as XML on next iteration
-                        return callback();
-                    }
                     // Invalid length - skip one byte and try again
                     this.buffer = this.buffer.slice(1);
                     continue;
@@ -206,14 +183,7 @@ export class LengthBasedSplitter extends Transform {
             try {
                 // Extract the complete message
                 const message = this.buffer.slice(0, totalLength);
-                // Check if this message is actually XML
-                const messageStart = message.toString(UTF8_ENCODING, 0, Math.min(MAX_PREVIEW_LENGTH, message.length));
-                if (isXmlPlistContent(messageStart)) {
-                    // Switch to XML mode
-                    this.isXmlMode = true;
-                    return callback();
-                }
-                // Push the message
+                // Push the message (header + payload)
                 this.push(message);
                 // Remove the processed message from the buffer
                 this.buffer = this.buffer.slice(totalLength);

package/build/src/lib/plist/plist-decoder.js

@@ -1,7 +1,7 @@
 import { logger } from '@appium/support';
 import { Transform } from 'stream';
 import { UTF8_ENCODING } from './constants.js';
-import { parsePlist } from './plist-parser.js';
+import { parsePlist } from './unified-plist-parser.js';
 import { ensureString, findFirstReplacementCharacter, fixMultipleXmlDeclarations, hasUnicodeReplacementCharacter, } from './utils.js';
 const log = logger.getLogger('Plist');
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appium-ios-remotexpc",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "main": "build/src/index.js",
   "types": "build/src/index.d.ts",
   "type": "module",

package/src/lib/plist/length-based-splitter.ts

@@ -100,14 +100,6 @@ export class LengthBasedSplitter extends Transform {
         Math.min(MAX_PREVIEW_LENGTH, this.buffer.length),
       );
 
-      // Check for XML format
-      if (isXmlPlistContent(bufferString) || this.isXmlMode) {
-        // This is XML data, set XML mode
-        this.isXmlMode = true;
-        this.processXmlData(callback);
-        return;
-      }
-
       // Check for binary plist format (bplist00 or Ibplist00)
       if (this.buffer.length >= BINARY_PLIST_HEADER_LENGTH) {
         const possibleBplistHeader = this.buffer.toString(
@@ -120,20 +112,18 @@ export class LengthBasedSplitter extends Transform {
           possibleBplistHeader === BINARY_PLIST_MAGIC ||
           possibleBplistHeader.includes(BINARY_PLIST_MAGIC)
         ) {
-          log.debug('Detected standard binary plist format');
-          this.push(this.buffer);
-          this.buffer = Buffer.alloc(0);
-          return callback();
+          log.debug(
+            'Detected standard binary plist format; proceeding with length-prefixed frame parsing',
+          );
         }
 
         if (
           possibleBplistHeader === IBINARY_PLIST_MAGIC ||
           possibleBplistHeader.includes(IBINARY_PLIST_MAGIC)
         ) {
-          log.debug('Detected non-standard Ibplist00 format');
-          this.push(this.buffer);
-          this.buffer = Buffer.alloc(0);
-          return callback();
+          log.debug(
+            'Detected non-standard Ibplist00 format; proceeding with length-prefixed frame parsing',
+          );
         }
       }
       // Process as many complete messages as possible for binary data
@@ -253,12 +243,6 @@ export class LengthBasedSplitter extends Transform {
               Math.min(MAX_PREVIEW_LENGTH, this.buffer.length),
             );
 
-            if (isXmlPlistContent(suspiciousData)) {
-              this.isXmlMode = true;
-              // Process as XML on next iteration
-              return callback();
-            }
-
             // Invalid length - skip one byte and try again
             this.buffer = this.buffer.slice(1);
             continue;
@@ -272,12 +256,6 @@ export class LengthBasedSplitter extends Transform {
             Math.min(MAX_PREVIEW_LENGTH, this.buffer.length),
           );
 
-          if (isXmlPlistContent(suspiciousData)) {
-            this.isXmlMode = true;
-            // Process as XML on next iteration
-            return callback();
-          }
-
           // Invalid length - skip one byte and try again
           this.buffer = this.buffer.slice(1);
           continue;
@@ -298,20 +276,7 @@ export class LengthBasedSplitter extends Transform {
         // Extract the complete message
         const message = this.buffer.slice(0, totalLength);
 
-        // Check if this message is actually XML
-        const messageStart = message.toString(
-          UTF8_ENCODING,
-          0,
-          Math.min(MAX_PREVIEW_LENGTH, message.length),
-        );
-
-        if (isXmlPlistContent(messageStart)) {
-          // Switch to XML mode
-          this.isXmlMode = true;
-          return callback();
-        }
-
-        // Push the message
+        // Push the message (header + payload)
         this.push(message);
 
         // Remove the processed message from the buffer

package/src/lib/plist/plist-decoder.ts

@@ -2,7 +2,7 @@ import { logger } from '@appium/support';
 import { Transform, type TransformCallback } from 'stream';
 
 import { UTF8_ENCODING } from './constants.js';
-import { parsePlist } from './plist-parser.js';
+import { parsePlist } from './unified-plist-parser.js';
 import {
   ensureString,
   findFirstReplacementCharacter,