apostrophe 4.4.0 → 4.4.2

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 4.4.2 (2024-06-14)
+
+### Fixes
+
+* Hotfix: the new `_parent` property of pieces, which refers to the same piece page as `_parentUrl`, is now a carefully pruned
+subset to avoid the risk of infinite recursion when the piece page has a relationship to a piece. Those who want `_parent`
+to be more complete can extend the new `pruneParent` method of the relevant piece page module. This regression was
+introduced in version 4.4.0.
+
+## 4.4.1 (2024-06-12)
+
+### Fixes
+
+* Depend on `stylelint-config-apostrophe` properly via npm, not github.
+
 ## 4.4.0 (2024-06-12)
 
 ### Adds

package/modules/@apostrophecms/piece-page-type/index.js

@@ -250,13 +250,36 @@ module.exports = {
           const parentPage = self.chooseParentPage(req.aposParentPageCache[pieceName], piece);
           if (parentPage) {
             piece._url = self.buildUrl(req, parentPage, piece);
-            piece._parent = parentPage;
+            piece._parent = self.pruneParent(parentPage);
             piece._parentUrl = parentPage._url;
             piece._parentSlug = parentPage.slug;
           }
         });
       },
 
+      // The _parent property of a piece is useful for
+      // breadcrumb navigation but we don't want it to lead
+      // to runaway recursion etc., so make a shallow clone
+      // of relevant properties only. Use extendMethods
+      // if you want to return more (or less)
+      pruneParent(parent) {
+        return {
+          _id: parent._id,
+          aposDocId: parent.aposDocId,
+          aposLocale: parent.aposLocale,
+          aposMode: parent.aposMode,
+          path: parent.path,
+          level: parent.level,
+          type: parent.type,
+          title: parent.title,
+          slug: parent.slug,
+          // These are already pruned projections and
+          // necessary for various types of navigation
+          _ancestors: parent._ancestors,
+          _children: parent._children
+        };
+      },
+
       // Returns a query suitable for finding pieces-page-type for the
       // purposes of assigning URLs to pieces based on the best match.
       //

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "apostrophe",
-  "version": "4.4.0",
+  "version": "4.4.2",
   "description": "The Apostrophe Content Management System.",
   "main": "index.js",
   "scripts": {
@@ -140,7 +140,7 @@
     "nyc": "^15.1.0",
     "replace-in-file": "^6.1.0",
     "stylelint": "^16.5.0",
-    "stylelint-config-apostrophe": "github:apostrophecms/stylelint-config-apostrophe",
+    "stylelint-config-apostrophe": "4.1.0",
     "vue-eslint-parser": "^7.1.1",
     "vue-template-compiler": "^2.7.14"
   },

package/test/search.js

@@ -75,6 +75,8 @@ describe('Search', function() {
   it('should carry the _ancestors property', async function() {
     const response1 = await apos.http.get('/search?q=event');
     const [ piece ] = JSON.parse(response1);
+    assert(piece._parent.title === 'Events');
+    assert(piece._parent.type === 'event-page');
     assert(piece._parent.slug === '/events');
     assert(piece._parent._ancestors[0].slug === '/');
     assert(piece._parent._ancestors[0]._ancestors.length === 0);