apostrophe 3.42.0 → 3.44.0

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # Changelog
 
+## 3.44.0 (2023-04-13)
+
+### Adds
+
+* `checkboxes` fields now support a new `style: 'combobox'` option for a better multiple-select experience when there
+are many choices.
+* If the new `guestApiAccess` option is set to `true` for a piece type or for `@apostrophecms/page`,
+Apostrophe will allow all logged-in users to access the GET-method REST APIs of that
+module, not just users with editing privileges, even if `publicApiProjection` is not set.
+This is useful when the goal is to allow REST API access to "guest" users who have
+project-specific reasons to fetch access content via REST APIs.
+* `test-lib/utils.js` has new `createUser` and `loginAs` methods for the convenience of
+those writing mocha tests of Apostrophe modules.
+
+## 3.43.0 (2023-03-29)
+
+### Adds
+
+* Add the possibility to override the default "Add Item" button label by setting the `itemLabel` option of an `array` field.
+* Adds `touch` task for every piece type. This task invokes `update` on each piece, which will execute all of the same event handlers that normally execute when a piece of that type is updated. Example usage: `node app article:touch`.
+
+### Fixes
+
+* Hide the suggestion help from the relationship input list when the user starts typing a search term.
+* Hide the suggestion hint from the relationship input list when the user starts typing a search term except when there are no matches to display.
+* Disable context menu for related items when their `relationship` field has no sub-[`fields`](https://v3.docs.apostrophecms.org/guide/relationships.html#providing-context-with-fields) configured.
+
 ## 3.42.0 (2023-03-16)
 
 ### Adds
@@ -31,17 +58,18 @@ current selection. Currently this works best with newly inserted documents.
 * Localized strings in the admin UI can now use `$t(key)` to localize a string inside
 an interpolated variable. This was accomplished by setting `skipOnVariables` to false
 for i18next, solely on the front end for admin UI purposes.
-* The syntax of the method defined for dynamic `choices` now accepts a module prefix to get the method from, and the `()` suffix.  
+* The syntax of the method defined for dynamic `choices` now accepts a module prefix to get the method from, and the `()` suffix.
 This has been done for consistency with the external conditions syntax shipped in the previous release. See the documentation for more information.
 * Added the `viewPermission` property of schema fields, and renamed `permission` to `editPermission` (with backwards
 compatibility) for clarity. You can now decide if a schema field requires permissions to be visible or editable.
 See the documentation for more information.
+* Display the right environment label on login page. By default, based on `NODE_ENV`, overriden by `environmentLabel` option in `@apostrophecms/login` module. The environment variable `APOS_ENV_LABEL` will override this. Note that `NODE_ENV` should generally only be set to `development` (the default) or `production` as many Node.js modules opt into optimizations suitable for all deployed environments when it is set to `production`. This is why we offer the separate `APOS_ENV_LABEL` variable.
 
-### Fixes 
+### Fixes
 
 * Do not log unnecessary "required" errors for hidden fields.
 * Fixed a bug that prevented "Text Align" from working properly in the rich text editor in certain cases.
-* Fix typo in `@apostrophecms/doc-type` and `@apostrophecms/submitted-drafts` where we were using `canCreate` instead of `showCreate` to display the `Create New` button or showing the `Copy` button in `Manager` modals. 
+* Fix typo in `@apostrophecms/doc-type` and `@apostrophecms/submitted-drafts` where we were using `canCreate` instead of `showCreate` to display the `Create New` button or showing the `Copy` button in `Manager` modals.
 * Send external condition results in an object so that numbers are supported as returned values.
 
 ## 3.41.1 (2023-03-07)
@@ -52,7 +80,7 @@ No changes. Publishing to make sure 3.x is tagged `latest` in npm, rather than 2
 
 ### Adds
 
-* Handle external conditions to display fields according to the result of a module method, or multiple methods from different modules.  
+* Handle external conditions to display fields according to the result of a module method, or multiple methods from different modules.
 This can be useful for displaying fields according to the result of an external API or any business logic run on the server. See the documentation for more information.
 
 ### Fixes

package/force-deploy

@@ -0,0 +1 @@
+4

package/modules/@apostrophecms/admin-bar/ui/apos/components/TheAposContextBar.vue

@@ -79,10 +79,11 @@ export default {
   },
   computed: {
     contextBarActive() {
-      return window.apos.adminBar.contextBar && this.canEdit;
+      return window.apos.adminBar.contextBar && (this.canEdit || this.moduleOptions.canLocalize);
     },
     canEdit() {
-      return this.context._edit || ((this.context.aposLocale && this.context.aposLocale.endsWith(':published')) && this.draftIsEditable);
+      return this.context._edit || ((this.context.aposLocale && this.context.aposLocale.endsWith(':published')) &&
+        this.draftIsEditable);
     },
     classes() {
       if (!this.contextBarActive) {

package/modules/@apostrophecms/doc-type/index.js

@@ -763,6 +763,11 @@ module.exports = {
       async findOneForCopying(req, criteria) {
         return self.findOneForEditing(req, criteria);
       },
+      // Identical to findOneForEditing by default, but could be
+      // overridden usefully in subclasses.
+      async findOneForLocalizing(req, criteria) {
+        return self.findOneForEditing(req, criteria);
+      },
       // Submit the current draft for review. The identity
       // of `req.user` is associated with the submission.
       // Returns the `submitted` object, with `by`, `byId`,
@@ -1424,8 +1429,13 @@ module.exports = {
           label,
           pluralLabel,
           relatedDocument: self.options.relatedDocument,
+          canEdit: self.apos.permission.can(req, 'edit', self.name, 'draft'),
           canPublish: self.apos.permission.can(req, 'publish', self.name)
         };
+        browserOptions.canLocalize = browserOptions.canEdit &&
+          self.options.localized &&
+          Object.keys(self.apos.i18n.locales).length > 1 &&
+          Object.values(self.apos.i18n.locales).some(locale => locale._edit);
         browserOptions.action = self.action;
         browserOptions.schema = self.allowedSchema(req);
         browserOptions.localized = self.isLocalized();

package/modules/@apostrophecms/doc-type/ui/apos/components/AposDocContextMenu.vue

@@ -181,6 +181,10 @@ export default {
       return menu;
     },
     customMenusByContext() {
+      if (!this.canEdit) {
+        return [];
+      }
+
       const menus = this.customOperationsByContext
         .map(op => ({
           label: op.label,
@@ -233,7 +237,7 @@ export default {
       }
     },
     canDismissSubmission() {
-      return this.context.submitted && (this.canPublish || (this.context.submitted.byId === apos.login.user._id));
+      return this.canEdit && this.context.submitted && (this.canPublish || (this.context.submitted.byId === apos.login.user._id));
     },
     canDiscardDraft() {
       if (!this.manuallyPublished) {
@@ -242,6 +246,9 @@ export default {
       if (!this.context._id) {
         return false;
       }
+      if (!this.canEdit) {
+        return false;
+      }
       return (
         (!this.context.lastPublishedAt) &&
         !this.moduleOptions.singleton
@@ -251,10 +258,12 @@ export default {
       );
     },
     canLocalize() {
-      return (Object.keys(apos.i18n.locales).length > 1) && this.moduleOptions.localized && this.context._id;
+      return this.moduleOptions.canLocalize &&
+        this.context._id;
     },
     canArchive() {
       return (
+        this.canEdit &&
         this.context._id &&
         !this.moduleOptions.singleton &&
         !this.context.archived &&
@@ -264,6 +273,7 @@ export default {
     },
     canUnpublish() {
       return (
+        this.canEdit &&
         !this.context.parked &&
         this.moduleOptions.canPublish &&
         this.context.lastPublishedAt &&
@@ -271,10 +281,14 @@ export default {
       );
     },
     canCopy() {
-      return this.canEdit && !this.moduleOptions.singleton && this.context._id;
+      return this.canEdit &&
+        this.moduleOptions.canEdit &&
+        !this.moduleOptions.singleton &&
+        this.context._id;
     },
     canRestore() {
       return (
+        this.canEdit &&
         this.context._id &&
         this.context.archived &&
         ((this.moduleOptions.canPublish && this.context.lastPublishedAt) || !this.manuallyPublished)

package/modules/@apostrophecms/doc-type/ui/apos/components/AposDocEditor.vue

@@ -162,6 +162,7 @@ export default {
         ref: null
       },
       published: null,
+      readOnly: false,
       restoreOnly: false,
       saveMenu: null,
       generation: 0
@@ -174,14 +175,24 @@ export default {
     followingUtils() {
       return this.followingValues('utility');
     },
+    canEdit() {
+      if (this.original && this.original._id) {
+        return this.original._edit || this.moduleOptions.canEdit;
+      }
+
+      return this.moduleOptions.canEdit;
+    },
     canPublish() {
       if (this.original && this.original._id) {
-        return this.original._publish;
+        return this.original._publish || this.moduleOptions.canPublish;
       }
 
       return this.moduleOptions.canPublish;
     },
     saveDisabled() {
+      if (!this.canEdit) {
+        return true;
+      }
       if (this.restoreOnly) {
         // Can always restore if it's a read-only view of the archive
         return false;
@@ -421,10 +432,6 @@ export default {
     async loadDoc() {
       let docData;
       try {
-        if (!await this.lock(this.getOnePath, this.docId)) {
-          await this.lockNotAvailable();
-          return;
-        }
         docData = await apos.http.get(this.getOnePath, {
           busy: true,
           qs: {
@@ -438,6 +445,12 @@ export default {
         } else {
           this.restoreOnly = false;
         }
+        const canEdit = docData._edit || this.moduleOptions.canEdit;
+        this.readOnly = canEdit === false;
+        if (canEdit && !await this.lock(this.getOnePath, this.docId)) {
+          await this.lockNotAvailable();
+          return;
+        }
       } catch {
         await apos.notify('apostrophe:loadDocFailed', {
           type: 'warning',

package/modules/@apostrophecms/i18n/i18n/de.json

@@ -4,6 +4,7 @@
   "addWidgetType": "{{ label }} hinzufügen",
   "admin": "Administrator",
   "affirmativeLabel": "Ja, fortsetzen.",
+  "allSelected": "Alle ausgewählt",
   "altText": "Alternativtext",
   "altTextHelp": "Bildbeschreibung oder alternativer Text, der für Bildschirmleser verwendet wird.",
   "any": "Irgendwas",

package/modules/@apostrophecms/i18n/i18n/en.json

@@ -5,9 +5,11 @@
   "addItem": "Add Item",
   "addRowAfter": "Add Row After",
   "addRowBefore": "Add Row Before",
+  "addType": "Add {{ type }}",
   "addWidgetType": "Add {{ label }}",
   "admin": "Admin",
   "affirmativeLabel": "Yes, continue.",
+  "allSelected": "All Selected",
   "altText": "Alt Text",
   "altTextHelp": "Image description used for accessibility",
   "anchorId": "Anchor ID",

package/modules/@apostrophecms/i18n/i18n/es.json

@@ -3,6 +3,7 @@
   "addItem": "Añadir Elemento",
   "addWidgetType": "Añadir {{ label }}",
   "admin": "Administrador",
+  "allSelected": "Todo seleccionado",
   "altText": "Texto Alternativo",
   "altTextHelp": "Descripción de imagen utilizada para accesibilidad",
   "any": "Cualquiera",

package/modules/@apostrophecms/i18n/i18n/fr.json

@@ -3,6 +3,7 @@
   "addItem": "Ajouter un élément",
   "addWidgetType": "Ajouter {{ label }}",
   "affirmativeLabel": "Oui, continuer.",
+  "allSelected": "Tout Selectionné",
   "altText": "Texte alternatif",
   "altTextHelp": "Description d'image utilisée pour l'accessibilité",
   "any": "Quelconque",

package/modules/@apostrophecms/i18n/i18n/pt-BR.json

@@ -3,6 +3,7 @@
   "addItem": "Adicionar Item",
   "addWidgetType": "Adicionar {{ label }}",
   "admin": "Admin",
+  "allSelected": "Tudo Selecionado",
   "altText": "Texto Alternativo",
   "altTextHelp": "Descrição da imagem usada para acessibilidade",
   "any": "Qualquer",

package/modules/@apostrophecms/i18n/i18n/sk.json

@@ -4,6 +4,7 @@
   "addWidgetType": "Pridať {{ label }}",
   "admin": "Admin",
   "affirmativeLabel": "Áno, pokračovať.",
+  "allSelected": "Všetky Vybrané",
   "altText": "Alternatívny text",
   "altTextHelp": "Alternatívny popis obrázkov pre zlepšenú prístupnosť",
   "any": "ľubovoľný",

package/modules/@apostrophecms/i18n/index.js

@@ -584,6 +584,9 @@ module.exports = {
             label: 'English'
           }
         };
+        for (const locale in locales) {
+          locales[locale]._edit = true;
+        }
         verifyLocales(locales, self.apos.options.baseUrl);
         return locales;
       },

package/modules/@apostrophecms/i18n/ui/apos/components/AposI18nLocalize.vue

@@ -278,7 +278,8 @@ export default {
         ([ locale, options ]) => {
           return {
             name: locale,
-            label: options.label || locale
+            label: options.label || locale,
+            _edit: options._edit
           };
         }
       ),
@@ -382,12 +383,12 @@ export default {
         : apos.modules[this.doc.type].action;
     },
     filteredLocales() {
-      return this.locales.filter(({ name, label }) => {
-        const matches = term =>
-          term
-            .toLowerCase()
-            .includes(this.wizard.sections.selectLocales.filter.toLowerCase());
+      const matches = term =>
+        term
+          .toLowerCase()
+          .includes(this.wizard.sections.selectLocales.filter.toLowerCase());
 
+      return this.locales.filter(({ name, label }) => {
         return matches(name) || matches(label);
       });
     },
@@ -395,7 +396,7 @@ export default {
       return this.wizard.values.toLocales.data;
     },
     allSelected() {
-      return this.selectedLocales.length === this.locales.filter(locale => !this.isCurrentLocale(locale)).length;
+      return this.selectedLocales.length === this.locales.filter(locale => !this.isCurrentLocale(locale) && this.canEditLocale(locale)).length;
     },
     relatedDocTypes() {
       const types = {};
@@ -532,6 +533,9 @@ export default {
     isCurrentLocale(locale) {
       return window.apos.i18n.locale === locale.name;
     },
+    canEditLocale(locale) {
+      return !!locale._edit;
+    },
     isSelected(locale) {
       return this.wizard.values.toLocales.data.some(
         ({ name }) => name === locale.name
@@ -541,13 +545,13 @@ export default {
       return !!this.localized[locale.name];
     },
     selectAll() {
-      this.wizard.values.toLocales.data = this.locales.filter(locale => !this.isCurrentLocale(locale));
+      this.wizard.values.toLocales.data = this.locales.filter(locale => !this.isCurrentLocale(locale) && this.canEditLocale(locale));
     },
     deselectAll() {
       this.wizard.values.toLocales.data = [];
     },
     toggleLocale(locale) {
-      if (!this.isSelected(locale) && !this.isCurrentLocale(locale)) {
+      if (!this.isSelected(locale) && !this.isCurrentLocale(locale) && this.canEditLocale(locale)) {
         this.wizard.values.toLocales.data.push(locale);
       } else if (this.isSelected(locale)) {
         this.wizard.values.toLocales.data = this.wizard.values.toLocales.data.filter(l => l !== locale);
@@ -590,6 +594,9 @@ export default {
       if (this.isCurrentLocale(locale)) {
         classes['apos-current-locale'] = true;
       }
+      if (!this.canEditLocale(locale)) {
+        classes['apos-disabled-locale'] = true;
+      }
       return classes;
     },
     // Singular type name for label (returns an i18next key)
@@ -948,15 +955,18 @@ export default {
   line-height: 1;
   border-radius: var(--a-border-radius);
 
-  &:not(.apos-current-locale) {
+  &:not(.apos-current-locale),
+  &:not(.apos-disabled-locale) {
     cursor: pointer;
   }
 
-  &:not(.apos-current-locale):hover {
+  &:not(.apos-current-locale):hover,
+  &:not(.apos-disabled-locale):hover {
     background-color: var(--a-base-10);
   }
 
-  &:not(.apos-current-locale):active {
+  &:not(.apos-current-locale):active,
+  &:not(.apos-disabled-locale):active {
     background-color: var(--a-base-9);
   }
 
@@ -974,11 +984,13 @@ export default {
   }
 
   &.apos-current-locale,
+  &.apos-disabled-locale,
   .apos-current-locale-icon {
     color: var(--a-base-5);
   }
 
-  &.apos-current-locale {
+  &.apos-current-locale,
+  &.apos-disabled-locale {
     font-style: italic;
   }
 

package/modules/@apostrophecms/image/ui/apos/components/AposMediaManagerEditor.vue

@@ -158,7 +158,7 @@ export default {
       return window.apos.modules[this.activeMedia.type] || {};
     },
     canLocalize() {
-      return (Object.keys(apos.i18n.locales).length > 1) && this.moduleOptions.localized && this.activeMedia._id;
+      return this.moduleOptions.canLocalize && this.activeMedia._id;
     },
     moreMenu() {
       const menu = [ {

package/modules/@apostrophecms/login/index.js

@@ -382,8 +382,9 @@ module.exports = {
             }
           }
         }
+
         return {
-          env: process.env.NODE_ENV || 'development',
+          env: process.env.APOS_ENV_LABEL || self.options.environmentLabel || process.env.NODE_ENV || 'development',
           name: (process.env.npm_package_name && process.env.npm_package_name.replace(/-/g, ' ')) || 'Apostrophe',
           version: aposPackage.version || '3',
           requirementProps

package/modules/@apostrophecms/login/ui/apos/components/TheAposLoginHeader.vue

@@ -110,7 +110,7 @@ export default {
       background: var(--a-danger);
     }
 
-    &--success {
+    &--success, &--staging {
       background: var(--a-warning);
     }
   }

package/modules/@apostrophecms/modal/ui/apos/mixins/AposEditorMixin.js

@@ -24,6 +24,7 @@ export default {
       },
       serverErrors: null,
       restoreOnly: false,
+      readOnly: false,
       changed: [],
       externalConditionsResults: {}
     };
@@ -32,7 +33,7 @@ export default {
   computed: {
     schema() {
       let schema = (this.moduleOptions.schema || []).filter(field => apos.schema.components.fields[field.type]);
-      if (this.restoreOnly) {
+      if (this.restoreOnly || this.readOnly) {
         schema = klona(schema);
         for (const field of schema) {
           field.readOnly = true;

package/modules/@apostrophecms/modal/ui/apos/mixins/AposModalTabsMixin.js

@@ -48,10 +48,11 @@ export default {
         if (key !== 'utility') {
           tabs.push({
             name: key,
-            label: this.groups[key].label
+            label: this.groups[key].label,
+            fields: this.groups[key].fields
           });
         }
-      };
+      }
 
       return tabs;
     }

package/modules/@apostrophecms/module/index.js

@@ -802,6 +802,17 @@ module.exports = {
         }
       },
 
+      // Modules that have REST APIs use this method
+      // to determine if a request is qualified to access
+      // it without restriction to the `publicApiProjection`
+      canAccessApi(req) {
+        if (self.options.guestApiAccess) {
+          return !!req.user;
+        } else {
+          return self.apos.permission.can(req, 'view-draft');
+        }
+      },
+
       // Merge in the event emitter / responder capabilities
       ...require('./lib/events.js')(self)
     };

package/modules/@apostrophecms/page/index.js

@@ -133,7 +133,7 @@ module.exports = {
           const autocomplete = self.apos.launder.string(req.query.autocomplete);
 
           if (autocomplete.length) {
-            if (!self.apos.permission.can(req, 'edit', '@apostrophecms/any-page-type')) {
+            if (!self.apos.permission.can(req, 'view', '@apostrophecms/any-page-type')) {
               throw self.apos.error('forbidden');
             }
             return {
@@ -145,7 +145,7 @@ module.exports = {
           }
 
           if (all) {
-            if (!self.apos.permission.can(req, 'edit', '@apostrophecms/any-page-type')) {
+            if (!self.apos.permission.can(req, 'view', '@apostrophecms/any-page-type')) {
               throw self.apos.error('forbidden');
             }
             const page = await self.getRestQuery(req).permission(false).and({ level: 0 }).children({
@@ -418,7 +418,7 @@ module.exports = {
         },
         ':_id/localize': async (req) => {
           const _id = self.inferIdLocaleAndMode(req, req.params._id);
-          const draft = await self.findOneForEditing(req.clone({
+          const draft = await self.findOneForLocalizing(req.clone({
             mode: 'draft'
           }), {
             aposDocId: _id.split(':')[0]
@@ -819,6 +819,11 @@ database.`);
         // A list of all valid page types, including parked pages etc. This is
         // not a menu of choices for creating a page manually
         browserOptions.validPageTypes = self.apos.instancesOf('@apostrophecms/page-type').map(module => module.__meta.name);
+        browserOptions.canEdit = self.apos.permission.can(req, 'edit', '@apostrophecms/any-page-type', 'draft');
+        browserOptions.canLocalize = browserOptions.canEdit &&
+          browserOptions.localized &&
+          Object.keys(self.apos.i18n.locales).length > 1 &&
+          Object.values(self.apos.i18n.locales).some(locale => locale._edit);
         return browserOptions;
       },
       // Returns a query that finds pages the current user can edit
@@ -2212,7 +2217,7 @@ database.`);
           .applyBuildersSafely(req.query);
         // Minimum standard for a REST query without a public projection
         // is being allowed to view drafts on the site
-        if (!self.apos.permission.can(req, 'view-draft')) {
+        if (!self.canAccessApi(req)) {
           if (!self.options.publicApiProjection) {
             // Shouldn't be needed thanks to publicApiCheck, but be sure
             query.and({
@@ -2243,6 +2248,9 @@ database.`);
       async findOneForEditing(req, criteria, builders) {
         return self.findForEditing(req, criteria, builders).toObject();
       },
+      async findOneForLocalizing(req, criteria, builders) {
+        return self.findForEditing(req, criteria, builders).toObject();
+      },
       // Throws a `notfound` exception if a public API projection is
       // not specified and the user does not have the `view-draft` permission,
       // which all roles capable of editing the site at all will have. This is needed because
@@ -2250,7 +2258,7 @@ database.`);
       // we also want to flunk all public access to REST APIs if not specifically configured.
       publicApiCheck(req) {
         if (!self.options.publicApiProjection) {
-          if (!self.apos.permission.can(req, 'view-draft')) {
+          if (!self.canAccessApi(req)) {
             throw self.apos.error('notfound');
           }
         }

package/modules/@apostrophecms/piece-type/index.js

@@ -408,7 +408,7 @@ module.exports = {
         },
         ':_id/localize': async (req) => {
           const _id = self.inferIdLocaleAndMode(req, req.params._id);
-          const draft = await self.findOneForEditing(req.clone({
+          const draft = await self.findOneForLocalizing(req.clone({
             mode: 'draft'
           }), {
             aposDocId: _id.split(':')[0]
@@ -1002,7 +1002,7 @@ module.exports = {
       getRestQuery(req) {
         const query = self.find(req).attachments(true);
         query.applyBuildersSafely(req.query);
-        if (!self.apos.permission.can(req, 'view-draft')) {
+        if (!self.canAccessApi(req)) {
           if (!self.options.publicApiProjection) {
             // Shouldn't be needed thanks to publicApiCheck, but be sure
             query.and({
@@ -1024,7 +1024,7 @@ module.exports = {
       // we also want to flunk all public access to REST APIs if not specifically configured.
       publicApiCheck(req) {
         if (!self.options.publicApiProjection) {
-          if (!self.apos.permission.can(req, 'view-draft')) {
+          if (!self.canAccessApi(req)) {
             throw self.apos.error('notfound');
           }
         }
@@ -1206,6 +1206,53 @@ module.exports = {
 
           console.log(`Done unlocalizing module ${self.name}`);
         }
+      },
+
+      touch: {
+        usage: 'Invoke this task to touch (update without any change) all docs of this type.',
+        async task(argv) {
+          const req = self.apos.task.getAdminReq();
+          let errCount = 0;
+          let count = 0;
+          let cursor;
+          const criteria = self.options.autopublish
+            ? { aposMode: 'draft' }
+            : {};
+
+          try {
+            // We have 30 minutes (by default) for each iteration.
+            // https://www.mongodb.com/docs/manual/reference/method/cursor.noCursorTimeout/#session-idle-timeout-overrides-nocursortimeout
+            cursor = (await self.find(req, criteria)
+              .locale(null)
+              .limit(0)
+              .toMongo())
+              .addCursorFlag('noCursorTimeout', true);
+
+            for await (const doc of cursor) {
+              try {
+                await self.update(req, doc);
+                count++;
+              } catch (e) {
+                errCount++;
+                self.apos.util.error(e);
+              }
+            }
+          } catch (error) {
+            self.apos.util.error(error);
+          } finally {
+            if (cursor) {
+              await cursor.close();
+            }
+          }
+          console.log(`Touched ${count} doc(s) with ${errCount} error(s)`);
+
+          // Return, useful for tests and internal API's
+          // It's in effect only when invoked via apos.task.invoke().
+          return {
+            touched: count,
+            errors: errCount
+          };
+        }
       }
     };
   }

package/modules/@apostrophecms/piece-type/ui/apos/components/AposDocsManager.vue

@@ -52,7 +52,7 @@
             @input="setCheckedDocs"
             @item-clicked="editRelationship"
             :value="checkedDocs"
-            :has-relationship-schema="!!(relationshipField && relationshipField.schema)"
+            :relationship-schema="relationshipField?.schema"
           />
         </div>
       </AposModalRail>