apify-test-tools 0.10.1 → 0.10.2-beta.1

package/lib/extend-expect.ts

@@ -53,7 +53,7 @@ export const extendExpect = (expect: ExpectStatic): ExpectStatic => {
             };
         },
         toBeNonEmptyObject: (actual) => {
-            const isObject = typeof actual === 'object' && !Array.isArray(actual);
+            const isObject = typeof actual === 'object' && !Array.isArray(actual) && actual !== null;
             const isNonEmpty = Object.entries(actual).length > 0;
             const pass = isObject && isNonEmpty;
             return {
@@ -62,7 +62,7 @@ export const extendExpect = (expect: ExpectStatic): ExpectStatic => {
             };
         },
         toBeObject: (actual) => {
-            const pass = typeof actual === 'object' && !Array.isArray(actual);
+            const pass = typeof actual === 'object' && !Array.isArray(actual) && actual !== null;
             return {
                 pass,
                 message: () => `Expected "${actual}" to be an object`,

package/package.json

@@ -1,67 +1,69 @@
 {
-    "name": "apify-test-tools",
-    "version": "0.10.1",
-    "type": "module",
-    "description": "TBD",
-    "repository": {
-        "type": "git",
-        "url": "https://github.com/apify/apify-test-tools.git"
-    },
-    "engines": {
-        "node": ">=18.0.0"
-    },
-    "bin": {
-        "apify-test-tools": "dist/bin/main.js"
-    },
-    "types": "./dist/index.d.ts",
-    "main": "./dist/lib/lib.js",
-    "dependencies": {
-        "@apify/consts": "^3.0.1",
-        "@slack/web-api": "^8.2.0",
-        "adm-zip": "^0.6.1",
-        "apify-client": "^2.25.0",
-        "ignore": "^7.0.5",
-        "yargs": "^18.0.0",
-        "zod": "^4.6.5"
-    },
-    "devDependencies": {
-        "@apify/eslint-config": "^1.0.0",
-        "@apify/tsconfig": "^0.1.1",
-        "@types/adm-zip": "^0.5.8",
-        "@types/node": "^24.0.0",
-        "@types/yargs": "^17.0.33",
-        "eslint": "^9.29.0",
-        "eslint-config-prettier": "^10.1.5",
-        "globals": "^17.0.0",
-        "husky": "^9.0.11",
-        "knip": "^5.65.0",
-        "lint-staged": "^15.2.2",
-        "prettier": "^3.5.3",
-        "tsx": "^4.20.3",
-        "typescript": "^5.9.3",
-        "typescript-eslint": "^8.34.1",
-        "vitest": "^3.2.4"
-    },
-    "peerDependencies": {
-        "vitest": ">=3.2.4"
-    },
-    "scripts": {
-        "start": "npm run dist/bin/main.js",
-        "start:dev": "cd local-clone && tsx ../bin/main.ts",
-        "build": "tsc && chmod +x ./dist/bin/main.js",
-        "lint": "eslint",
-        "lint:fix": "eslint --fix",
-        "format": "prettier --write .",
-        "format:check": "prettier --check .",
-        "type-check": "tsc --noEmit",
-        "test": "vitest run",
-        "check-unused": "npx knip",
-        "prepare": "husky .husky || true"
-    },
-    "lint-staged": {
-        "*.js": "eslint",
-        "*.ts": "eslint"
-    },
-    "author": "oklinov",
-    "license": "ISC"
+  "name": "apify-test-tools",
+  "version": "0.10.2-beta.1",
+  "type": "module",
+  "description": "TBD",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/apify/apify-test-tools.git"
+  },
+  "engines": {
+    "node": ">=18.0.0"
+  },
+  "bin": {
+    "apify-test-tools": "dist/bin/main.js"
+  },
+  "types": "./dist/index.d.ts",
+  "main": "./dist/lib/lib.js",
+  "dependencies": {
+    "@apify/consts": "^3.0.1",
+    "@slack/web-api": "^8.2.0",
+    "adm-zip": "^0.6.1",
+    "apify-client": "^2.25.0",
+    "ignore": "^7.0.5",
+    "picomatch": "^4.0.7",
+    "yargs": "^18.0.0",
+    "zod": "^4.6.5"
+  },
+  "devDependencies": {
+    "@apify/eslint-config": "^1.0.0",
+    "@apify/tsconfig": "^0.1.1",
+    "@types/adm-zip": "^0.5.8",
+    "@types/node": "^24.0.0",
+    "@types/picomatch": "^4.0.3",
+    "@types/yargs": "^17.0.33",
+    "eslint": "^9.29.0",
+    "eslint-config-prettier": "^10.1.5",
+    "globals": "^17.0.0",
+    "husky": "^9.0.11",
+    "knip": "^5.65.0",
+    "lint-staged": "^15.2.2",
+    "prettier": "^3.5.3",
+    "tsx": "^4.20.3",
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.34.1",
+    "vitest": "^3.2.4"
+  },
+  "peerDependencies": {
+    "vitest": ">=3.2.4"
+  },
+  "scripts": {
+    "start": "npm run dist/bin/main.js",
+    "start:dev": "cd local-clone && tsx ../bin/main.ts",
+    "build": "tsc && chmod +x ./dist/bin/main.js",
+    "lint": "eslint",
+    "lint:fix": "eslint --fix",
+    "format": "prettier --write .",
+    "format:check": "prettier --check .",
+    "type-check": "tsc --noEmit",
+    "test": "vitest run",
+    "check-unused": "npx knip",
+    "prepare": "husky .husky || true"
+  },
+  "lint-staged": {
+    "*.js": "eslint",
+    "*.ts": "eslint"
+  },
+  "author": "oklinov",
+  "license": "ISC"
 }

package/test/unit/bin/diff-changes.test.ts

@@ -63,6 +63,7 @@ const commits = [{ sha: 'Commit1', author: '', date: '', message: '' }];
 
 describe('getChangedActors', () => {
     beforeEach(() => {
+        vi.restoreAllMocks();
         vi.spyOn(DiffJsonSchema, 'isCosmeticOnlyJsonSchemaChange').mockResolvedValue(false);
     });
 
@@ -393,6 +394,72 @@ describe('getChangedActors', () => {
         expect(result).toEqual([miniActor]);
     });
 
+    it('test file listed in .dockerignore triggers a build when it matches the test files glob', async () => {
+        vi.spyOn(Dockerignore, 'loadDockerIgnore').mockReturnValue((filePath) => filePath.startsWith('test/'));
+        const result = await getChangedActors({
+            filepathsChanged: ['test/platform/daily/foo.test.ts'],
+            actorConfigs: [miniActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+        expect(result).toEqual([miniActor]);
+    });
+
+    it('test file listed in .dockerignore stays ignored without a test files glob', async () => {
+        vi.spyOn(Dockerignore, 'loadDockerIgnore').mockReturnValue((filePath) => filePath.startsWith('test/'));
+        const result = await getChangedActors({
+            filepathsChanged: ['test/platform/daily/foo.test.ts'],
+            actorConfigs: [miniActor],
+            commits,
+        });
+        expect(result).toEqual([]);
+    });
+
+    it('test files glob matches case-insensitively and does not bypass .dockerignore for other files', async () => {
+        vi.spyOn(Dockerignore, 'loadDockerIgnore').mockReturnValue(() => true);
+        const result = await getChangedActors({
+            filepathsChanged: ['Test/Platform/Foo.test.ts'],
+            actorConfigs: [miniActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+        expect(result).toEqual([miniActor]);
+        expect(
+            await getChangedActors({
+                filepathsChanged: ['actors/foo_bar/node_modules/foo.js'],
+                actorConfigs: [miniActor],
+                commits,
+                testFilesGlob: 'test/platform/**',
+            }),
+        ).toEqual([]);
+    });
+
+    it('test file outside an actor context still does not trigger it', async () => {
+        vi.spyOn(Dockerignore, 'loadDockerIgnore').mockReturnValue(() => true);
+        const result = await getChangedActors({
+            filepathsChanged: ['test/platform/daily/foo.test.ts'],
+            actorConfigs: [standaloneActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+        expect(result).toEqual([]);
+    });
+
+    it('test file listed in .dockerignore triggers an actor whose overrideActorContext includes it', async () => {
+        vi.spyOn(Dockerignore, 'loadDockerIgnore').mockReturnValue(() => true);
+        const actorWithTests = {
+            ...standaloneActor,
+            contextPaths: [...standaloneActor.contextPaths, new RelativeDir('test')],
+        };
+        const result = await getChangedActors({
+            filepathsChanged: ['test/platform/standalone.test.ts'],
+            actorConfigs: [actorWithTests],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+        expect(result).toEqual([actorWithTests]);
+    });
+
     it('JSON file in context but outside actor folder is functional (not checked for cosmetic)', async () => {
         const result = await getChangedActors({
             filepathsChanged: ['lib/config.json'],
@@ -473,6 +540,7 @@ describe('getChangedActors logging', () => {
     beforeEach(() => {
         vi.spyOn(DiffJsonSchema, 'isCosmeticOnlyJsonSchemaChange').mockResolvedValue(false);
         vi.spyOn(logger, 'info').mockImplementation(() => undefined);
+        vi.spyOn(logger, 'warn').mockImplementation(() => undefined);
     });
 
     it('logs a single "specific" group for a single actor with one functional file', async () => {
@@ -525,6 +593,44 @@ describe('getChangedActors logging', () => {
         ]);
     });
 
+    const outsideContextWarning = (testFile: string) =>
+        `[DIFF]: Test file ${testFile} is outside every Actor's context, so changing only it builds and tests nothing. ` +
+        'Add its folder to "overrideActorContext" of the Actors it tests.';
+
+    it('warns about a changed test file outside every Actor context', async () => {
+        await getChangedActors({
+            filepathsChanged: ['test/platform/standalone.test.ts'],
+            actorConfigs: [standaloneActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+
+        expect(logger.warn).toHaveBeenCalledWith(outsideContextWarning('test/platform/standalone.test.ts'));
+    });
+
+    it('still warns when the same push also rebuilds an Actor', async () => {
+        const result = await getChangedActors({
+            filepathsChanged: ['test/platform/standalone.test.ts', 'standalone-actors/standalone/src/main.ts'],
+            actorConfigs: [standaloneActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+
+        expect(result).toEqual([standaloneActor]);
+        expect(logger.warn).toHaveBeenCalledWith(outsideContextWarning('test/platform/standalone.test.ts'));
+    });
+
+    it('does not warn about test files inside an Actor context, even cosmetic ones', async () => {
+        await getChangedActors({
+            filepathsChanged: ['test/platform/foo.test.ts', 'test/platform/README.md', 'test/platform/CHANGELOG.md'],
+            actorConfigs: [miniActor],
+            commits,
+            testFilesGlob: 'test/platform/**',
+        });
+
+        expect(logger.warn).not.toHaveBeenCalled();
+    });
+
     it('logs no group lines when zero actors changed', async () => {
         await getChangedActors({
             filepathsChanged: ['.gitignore', '.prettierrc'],