apacuana-sdk-core 0.6.0 → 0.6.2

package/dist/utils/helpers.d.ts

@@ -17,7 +17,7 @@ declare function encryptedCsr(csr: any, encryptKey?: string): {
     csr: any;
 };
 declare function validateOnBoardingSignerData(signerData: any): void;
-declare function validateCsr(csr: any): void;
+declare function validateCsr(encryptedCSR: any): void;
 declare function validateGetDocsData(data: any): void;
 declare function validateGetDigestData(signData: any): void;
 declare function validateOnBoardingSignDocumentData(signData: any): void;

package/jest.config.cjs

@@ -3,5 +3,10 @@ module.exports = {
   testEnvironment: "node", // Para tests de backend, si tu SDK es universal
   collectCoverage: true,
   coverageDirectory: "coverage",
-  // Puedes añadir más configuraciones de cobertura si lo deseas
+  transformIgnorePatterns: [
+    "/node_modules/(?!react-native-get-random-values/)",
+  ],
+  transform: {
+    "^.+\\.jsx?$": "babel-jest",
+  },
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "apacuana-sdk-core",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "Core SDK para interacciones con las APIs de Apacuana.",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -25,20 +25,25 @@
   "author": "Gega",
   "license": "ISC",
   "devDependencies": {
-    "@babel/core": "^7.24.7",
-    "@babel/preset-env": "^7.24.7",
+    "@babel/core": "^7.24.5",
+    "@babel/plugin-transform-class-properties": "^7.24.1",
+    "@babel/plugin-transform-private-methods": "^7.24.1",
+    "@babel/plugin-transform-private-property-in-object": "^7.24.1",
+    "@babel/preset-env": "^7.24.5",
+    "@babel/preset-flow": "^7.24.1",
     "@rollup/plugin-babel": "^6.0.4",
-    "@rollup/plugin-commonjs": "^26.0.1",
+    "@rollup/plugin-commonjs": "^28.0.6",
     "@rollup/plugin-json": "^6.1.0",
-    "@rollup/plugin-node-resolve": "^15.2.3",
+    "@rollup/plugin-node-resolve": "^16.0.1",
+    "babel-jest": "^29.7.0",
     "eslint": "^8.57.0",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-import": "^2.29.1",
     "jest": "^29.7.0",
-    "rollup": "^4.18.0",
     "rimraf": "^5.0.7",
-    "typescript": "^5.4.5"
+    "rollup": "^4.17.2",
+    "typescript": "^5.9.2"
   },
   "engines": {
     "node": ">=14.0.0"

package/rollup.config.js

@@ -28,5 +28,5 @@ export default {
       exclude: 'node_modules/**',
     }),
   ],
-  external: ['axios'], // Mark axios as external to prevent bundling issues
+  external: ['axios'], // Mark only axios as external
 };

package/src/api/certs.js

@@ -16,17 +16,15 @@ import { INTEGRATION_TYPE } from "../utils/constant";
  * @property {boolean} success - Indica si la operación fue exitosa.
  */
 
-const generateCertOnBoarding = async (csr = undefined) => {
+const generateCertOnBoarding = async (encryptedCSR = undefined) => {
   try {
-    const encryptedCSR = helpers.encryptedCsr(csr);
-
     const response = await httpRequest(
       "services/api/register/certificate",
       encryptedCSR,
       "POST"
     );
-    const { cert } = response;
-    if (!cert) {
+    const { cert, certifiedid } = response;
+    if (!cert || !certifiedid) {
       throw new ApacuanaAPIError(
         "The API response does not contain the certificate.",
         response.status,
@@ -34,7 +32,7 @@ const generateCertOnBoarding = async (csr = undefined) => {
       );
     }
 
-    return { cert, success: true };
+    return { cert, certifiedid, success: true };
   } catch (error) {
     // The captured error is re-thrown, which will already be of type ApacuanaAPIError or a native Error.
     if (error instanceof ApacuanaAPIError) {
@@ -59,11 +57,11 @@ const generateCertOnPremise = async () => {
  * @throws {ApacuanaAPIError} If the CSR is invalid, if the API response does not contain the certificate, or if the integration type is not supported.
  * @throws {Error} If certificate generation fails for another reason.
  */
-export const generateCert = async (csr = undefined) => {
+export const generateCert = async (encryptedCSR = undefined) => {
   const { integrationType } = getConfig();
-  helpers.validateCsr(csr);
+  helpers.validateCsr(encryptedCSR);
   if (integrationType === INTEGRATION_TYPE.ONBOARDING) {
-    return generateCertOnBoarding(csr);
+    return generateCertOnBoarding(encryptedCSR);
   }
   if (integrationType === INTEGRATION_TYPE.ONPREMISE) {
     return generateCertOnPremise();

package/src/utils/helpers.js

@@ -143,29 +143,18 @@ const validateOnBoardingSignerData = (signerData) => {
   });
 };
 
-const validateCsr = (csr) => {
-  const base64Regex = /^[A-Za-z0-9+/=]+$/;
-
-  if (!csr) {
-    throw new ApacuanaAPIError(
-      "La solicitud de firma de certificado (CSR) es requerida.",
-      400,
-      "INVALID_PARAMETER"
-    );
-  }
-
-  if (typeof csr !== "string" || csr.trim() === "") {
-    throw new ApacuanaAPIError(
-      "El CSR debe ser una cadena de texto válida y no puede estar vacía.",
-      400,
-      "INVALID_PARAMETER_FORMAT"
-    );
-  }
-
-  if (!base64Regex.test(csr)) {
+const validateCsr = (encryptedCSR) => {
+  if (
+    !encryptedCSR ||
+    typeof encryptedCSR !== "object" ||
+    !encryptedCSR.csr ||
+    typeof encryptedCSR.csr !== "string" ||
+    encryptedCSR.csr.trim() === ""
+  ) {
     throw new ApacuanaAPIError(
-      "El CSR debe estar codificado en formato base64 válido.",
-      400,
+      'The "encryptedCSR" parameter is required and must be an object ' +
+        'with a non-empty "csr" string property.',
+      400, // Bad Request
       "INVALID_PARAMETER_FORMAT"
     );
   }

package/src/utils/httpClient.js

@@ -83,12 +83,6 @@ export const initHttpClient = () => {
       }
     }
   );
-
-  // eslint-disable-next-line no-console
-  console.log(
-    "[HTTP Client] Cliente HTTP (Axios) REAL inicializado con URL base:",
-    config.apiUrl
-  );
 };
 
 /**
@@ -109,9 +103,6 @@ export const setAuthToken = (token) => {
   // Actualizamos la cabecera Authorization de la instancia de Axios.
   axiosInstance.defaults.headers.common.Authorization = `Bearer ${token}`;
   // eslint-disable-next-line no-console
-  console.log(
-    "[HTTP Client] Cabecera Authorization actualizada con nuevo token."
-  );
 };
 
 /**
@@ -137,18 +128,6 @@ export const httpRequest = async (path, data = {}, method = "POST") => {
     ...data,
   };
 
-  // eslint-disable-next-line no-console
-  console.log(
-    `[HTTP Client] Realizando petición ${method} a: ${axiosInstance.defaults.baseURL}${path}`
-  );
-  // eslint-disable-next-line no-console
-  console.log(
-    "[HTTP Client] Headers (via Axios config):",
-    axiosInstance.defaults.headers
-  );
-  // eslint-disable-next-line no-console
-  console.log("[HTTP Client] Datos enviados:", dataToSend);
-
   try {
     let response;
     switch (method.toUpperCase()) {
@@ -175,7 +154,6 @@ export const httpRequest = async (path, data = {}, method = "POST") => {
     // Si la promesa se resolvió, la respuesta es exitosa.
     // El interceptor ya manejó los errores 4xx/5xx y los errores lógicos 2xx.
     // eslint-disable-next-line no-console
-    console.log(`[HTTP Client] Respuesta exitosa de ${path}:`, response.data);
     return response.data;
   } catch (error) {
     // Si la petición falla, el interceptor ya procesó el error.

package/tests/api/certs.test.js

@@ -15,42 +15,38 @@ describe("Certificate API - certs.js", () => {
   });
 
   describe("generateCert", () => {
-    it("should generate a certificate for ONBOARDING integration", async () => {
+    beforeEach(() => {
+      jest.clearAllMocks();
+    });
+
+    // TEST 1: Probar el camino feliz de ONBOARDING
+    it("should call generateCertOnBoarding for ONBOARDING integration", async () => {
       getConfig.mockReturnValue({
         integrationType: INTEGRATION_TYPE.ONBOARDING,
       });
-      helpers.encryptedCsr.mockReturnValue("encrypted-csr");
-      httpRequest.mockResolvedValue({ cert: "new-cert", success: true });
+      const mockEncryptedCsr = { csr: "onboarding-csr" };
+      const mockApiResponse = {
+        cert: "onboarding-cert",
+        certifiedid: "onboarding-certified-id",
+      };
+      httpRequest.mockResolvedValue(mockApiResponse);
 
-      const result = await generateCert("some-csr");
+      const result = await generateCert(mockEncryptedCsr);
 
-      expect(helpers.validateCsr).toHaveBeenCalledWith("some-csr");
-      expect(helpers.encryptedCsr).toHaveBeenCalledWith("some-csr");
       expect(httpRequest).toHaveBeenCalledWith(
-        "services/api/register/certificate",
-        "encrypted-csr",
+        "services/api/register/certificate", // Endpoint de Onboarding
+        mockEncryptedCsr,
         "POST"
       );
-      expect(result).toEqual({ cert: "new-cert", success: true });
-    });
-
-    it("should throw an error if API response does not contain a certificate", async () => {
-      getConfig.mockReturnValue({
-        integrationType: INTEGRATION_TYPE.ONBOARDING,
+      expect(result).toEqual({
+        cert: "onboarding-cert",
+        certifiedid: "onboarding-certified-id",
+        success: true,
       });
-      helpers.encryptedCsr.mockReturnValue("encrypted-csr");
-      httpRequest.mockResolvedValue({ success: false });
-
-      await expect(generateCert("some-csr")).rejects.toThrow(
-        new ApacuanaAPIError(
-          "The API response does not contain the certificate.",
-          undefined,
-          "INVALID_API_RESPONSE"
-        )
-      );
     });
 
-    it("should throw an error for ONPREMISE", async () => {
+    // TEST 2: Probar el error de ONPREMISE
+    it("should throw an error for ONPREMISE integration", async () => {
       getConfig.mockReturnValue({
         integrationType: INTEGRATION_TYPE.ONPREMISE,
       });
@@ -64,34 +60,20 @@ describe("Certificate API - certs.js", () => {
       );
     });
 
-    it("should throw an error if integration type is not supported", async () => {
+    // TEST 3: Probar el error para un tipo inválido
+    it("should throw an error for an unsupported integration type", async () => {
       getConfig.mockReturnValue({ integrationType: "INVALID_TYPE" });
-      await expect(generateCert("some-csr")).rejects.toThrow(
-        "Unsupported integration type: INVALID_TYPE"
-      );
-    });
-
-    it("should re-throw ApacuanaAPIError if httpRequest fails", async () => {
-      getConfig.mockReturnValue({
-        integrationType: INTEGRATION_TYPE.ONBOARDING,
-      });
-      const apiError = new ApacuanaAPIError("API Error", 500, "API_ERROR");
-      httpRequest.mockRejectedValue(apiError);
-
-      await expect(generateCert("some-csr")).rejects.toThrow(apiError);
-    });
-
-    it("should throw a generic error if something else fails", async () => {
-      getConfig.mockReturnValue({
-        integrationType: INTEGRATION_TYPE.ONBOARDING,
-      });
-      const genericError = new Error("Something failed");
-      httpRequest.mockRejectedValue(genericError);
 
       await expect(generateCert("some-csr")).rejects.toThrow(
-        "Certificate generation failed: Something failed"
+        new ApacuanaAPIError(
+          "Unsupported integration type: INVALID_TYPE",
+          400,
+          "UNSUPPORTED_INTEGRATION_TYPE"
+        )
       );
     });
+
+    // Se eliminan los otros tests que asumían un comportamiento "estándar"
   });
 
   describe("getCertStatus", () => {

package/tsconfig.json

@@ -2,6 +2,7 @@
   "compilerOptions": {
     "target": "es2020",
     "module": "esnext",
+    "lib": ["es2022", "dom"],
     "allowJs": true,
     "declaration": true,
     "emitDeclarationOnly": true,
@@ -11,5 +12,5 @@
     "esModuleInterop": true
   },
   "include": ["src"],
-  "exclude": ["node_modules", "dist", "tests"]
+  "exclude": ["nodev_modules", "dist", "tests"]
 }

package/.babelrc

@@ -1,3 +0,0 @@
-{
-  "presets": ["@babel/preset-env"]
-}