anyone-can-architect 0.3.0 → 0.4.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CONTEXT.md +2 -2
- package/README.md +2 -2
- package/SSOT.md +5 -0
- package/VERSION +1 -1
- package/axioms/writing.md +2 -0
- package/dist/antigravity/aca/SKILL.md +1 -1
- package/dist/antigravity/aca-design/SKILL.md +11 -5
- package/dist/antigravity/aca-implement/SKILL.md +14 -7
- package/dist/antigravity/aca-release/SKILL.md +9 -17
- package/dist/antigravity/aca-repo-audit/SKILL.md +2 -0
- package/dist/antigravity/aca-review/SKILL.md +103 -138
- package/dist/antigravity/aca-test/SKILL.md +7 -5
- package/dist/antigravity/aca-walkthrough/SKILL.md +17 -13
- package/dist/antigravity-cli/aca/SKILL.md +1 -1
- package/dist/antigravity-cli/aca-design/SKILL.md +11 -5
- package/dist/antigravity-cli/aca-implement/SKILL.md +14 -7
- package/dist/antigravity-cli/aca-release/SKILL.md +9 -17
- package/dist/antigravity-cli/aca-repo-audit/SKILL.md +2 -0
- package/dist/antigravity-cli/aca-review/SKILL.md +103 -138
- package/dist/antigravity-cli/aca-test/SKILL.md +7 -5
- package/dist/antigravity-cli/aca-walkthrough/SKILL.md +17 -13
- package/dist/codex/aca/SKILL.md +1 -1
- package/dist/codex/aca-design/SKILL.md +11 -5
- package/dist/codex/aca-implement/SKILL.md +14 -7
- package/dist/codex/aca-release/SKILL.md +9 -17
- package/dist/codex/aca-repo-audit/SKILL.md +2 -0
- package/dist/codex/aca-review/SKILL.md +103 -138
- package/dist/codex/aca-test/SKILL.md +7 -5
- package/dist/codex/aca-walkthrough/SKILL.md +17 -13
- package/dist/cursor/aca/SKILL.md +1 -1
- package/dist/cursor/aca-design/SKILL.md +11 -5
- package/dist/cursor/aca-implement/SKILL.md +14 -7
- package/dist/cursor/aca-release/SKILL.md +9 -17
- package/dist/cursor/aca-repo-audit/SKILL.md +2 -0
- package/dist/cursor/aca-review/SKILL.md +103 -138
- package/dist/cursor/aca-test/SKILL.md +7 -5
- package/dist/cursor/aca-walkthrough/SKILL.md +17 -13
- package/dist/grok/aca/SKILL.md +1 -1
- package/dist/grok/aca-design/SKILL.md +11 -5
- package/dist/grok/aca-implement/SKILL.md +14 -7
- package/dist/grok/aca-release/SKILL.md +9 -17
- package/dist/grok/aca-repo-audit/SKILL.md +2 -0
- package/dist/grok/aca-review/SKILL.md +103 -138
- package/dist/grok/aca-test/SKILL.md +7 -5
- package/dist/grok/aca-walkthrough/SKILL.md +17 -13
- package/doc-design/document-sets/ops-guide.md +25 -27
- package/doc-design/documents/instrumentation.md +3 -2
- package/doc-design/documents/interaction.md +516 -143
- package/doc-design/documents/interface.md +12 -7
- package/doc-design/documents/release.md +135 -105
- package/doc-design/patterns/interface.md +135 -14
- package/doc-design/repo-types/client-sdk.md +3 -3
- package/doc-design/repo-types/web-app.md +11 -5
- package/meta-skills/aca/SKILL.md +1 -1
- package/meta-skills/aca/SKILL.md.tmpl +1 -1
- package/package.json +1 -1
- package/skills/aca-design/SKILL.md +11 -5
- package/skills/aca-design/SKILL.md.tmpl +9 -5
- package/skills/aca-implement/SKILL.md +14 -7
- package/skills/aca-implement/SKILL.md.tmpl +14 -7
- package/skills/aca-release/SKILL.md +9 -17
- package/skills/aca-release/SKILL.md.tmpl +9 -17
- package/skills/aca-repo-audit/SKILL.md +2 -0
- package/skills/aca-review/SKILL.md +103 -138
- package/skills/aca-review/SKILL.md.tmpl +101 -138
- package/skills/aca-test/SKILL.md +7 -5
- package/skills/aca-test/SKILL.md.tmpl +7 -5
- package/skills/aca-walkthrough/SKILL.md +17 -13
- package/skills/aca-walkthrough/SKILL.md.tmpl +15 -13
- package/zh-CN/CONTEXT.md +2 -2
- package/zh-CN/SSOT.md +5 -0
- package/zh-CN/axioms/writing.md +2 -0
- package/zh-CN/dist/antigravity/aca/SKILL.md +1 -1
- package/zh-CN/dist/antigravity/aca-design/SKILL.md +11 -5
- package/zh-CN/dist/antigravity/aca-implement/SKILL.md +14 -7
- package/zh-CN/dist/antigravity/aca-release/SKILL.md +9 -17
- package/zh-CN/dist/antigravity/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/dist/antigravity/aca-review/SKILL.md +103 -138
- package/zh-CN/dist/antigravity/aca-test/SKILL.md +7 -5
- package/zh-CN/dist/antigravity/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/dist/antigravity-cli/aca/SKILL.md +1 -1
- package/zh-CN/dist/antigravity-cli/aca-design/SKILL.md +11 -5
- package/zh-CN/dist/antigravity-cli/aca-implement/SKILL.md +14 -7
- package/zh-CN/dist/antigravity-cli/aca-release/SKILL.md +9 -17
- package/zh-CN/dist/antigravity-cli/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/dist/antigravity-cli/aca-review/SKILL.md +103 -138
- package/zh-CN/dist/antigravity-cli/aca-test/SKILL.md +7 -5
- package/zh-CN/dist/antigravity-cli/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/dist/codex/aca/SKILL.md +1 -1
- package/zh-CN/dist/codex/aca-design/SKILL.md +11 -5
- package/zh-CN/dist/codex/aca-implement/SKILL.md +14 -7
- package/zh-CN/dist/codex/aca-release/SKILL.md +9 -17
- package/zh-CN/dist/codex/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/dist/codex/aca-review/SKILL.md +103 -138
- package/zh-CN/dist/codex/aca-test/SKILL.md +7 -5
- package/zh-CN/dist/codex/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/dist/cursor/aca/SKILL.md +1 -1
- package/zh-CN/dist/cursor/aca-design/SKILL.md +11 -5
- package/zh-CN/dist/cursor/aca-implement/SKILL.md +14 -7
- package/zh-CN/dist/cursor/aca-release/SKILL.md +9 -17
- package/zh-CN/dist/cursor/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/dist/cursor/aca-review/SKILL.md +103 -138
- package/zh-CN/dist/cursor/aca-test/SKILL.md +7 -5
- package/zh-CN/dist/cursor/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/dist/grok/aca/SKILL.md +1 -1
- package/zh-CN/dist/grok/aca-design/SKILL.md +11 -5
- package/zh-CN/dist/grok/aca-implement/SKILL.md +14 -7
- package/zh-CN/dist/grok/aca-release/SKILL.md +9 -17
- package/zh-CN/dist/grok/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/dist/grok/aca-review/SKILL.md +103 -138
- package/zh-CN/dist/grok/aca-test/SKILL.md +7 -5
- package/zh-CN/dist/grok/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/doc-design/document-sets/ops-guide.md +25 -27
- package/zh-CN/doc-design/documents/instrumentation.md +3 -2
- package/zh-CN/doc-design/documents/interaction.md +516 -143
- package/zh-CN/doc-design/documents/interface.md +12 -7
- package/zh-CN/doc-design/documents/release.md +135 -105
- package/zh-CN/doc-design/patterns/interface.md +135 -14
- package/zh-CN/doc-design/repo-types/client-sdk.md +3 -3
- package/zh-CN/doc-design/repo-types/web-app.md +11 -5
- package/zh-CN/meta-skills/aca/SKILL.md +1 -1
- package/zh-CN/meta-skills/aca/SKILL.md.tmpl +1 -1
- package/zh-CN/skills/aca-design/SKILL.md +11 -5
- package/zh-CN/skills/aca-design/SKILL.md.tmpl +9 -5
- package/zh-CN/skills/aca-implement/SKILL.md +14 -7
- package/zh-CN/skills/aca-implement/SKILL.md.tmpl +14 -7
- package/zh-CN/skills/aca-release/SKILL.md +9 -17
- package/zh-CN/skills/aca-release/SKILL.md.tmpl +9 -17
- package/zh-CN/skills/aca-repo-audit/SKILL.md +2 -0
- package/zh-CN/skills/aca-review/SKILL.md +103 -138
- package/zh-CN/skills/aca-review/SKILL.md.tmpl +101 -138
- package/zh-CN/skills/aca-test/SKILL.md +7 -5
- package/zh-CN/skills/aca-test/SKILL.md.tmpl +7 -5
- package/zh-CN/skills/aca-walkthrough/SKILL.md +17 -13
- package/zh-CN/skills/aca-walkthrough/SKILL.md.tmpl +15 -13
package/CONTEXT.md
CHANGED
|
@@ -72,7 +72,7 @@ _Avoid_: "subsection", "second-level heading", "clause"
|
|
|
72
72
|
### subsection
|
|
73
73
|
|
|
74
74
|
Subsection
|
|
75
|
-
`#### N.N.N Title`, the third level of division below a section and the deepest level,
|
|
75
|
+
`#### N.N.N Title`, the third level of division below a section and the deepest level, used at positions specified by a doc design or pattern
|
|
76
76
|
_Avoid_: "third-level heading"
|
|
77
77
|
|
|
78
78
|
### drill-down
|
|
@@ -97,7 +97,7 @@ _Avoid_: "imprint", "marker", "version block"
|
|
|
97
97
|
- [doc-design](#doc-design) references the guiding principles for drill-down and specifies which parts to [drill-down](#drill-down) into
|
|
98
98
|
- [module](#module) uses the module [document-set](#document-set), with [repo-type-spec](#repo-type-spec) determining when to use it
|
|
99
99
|
- [aca-footer](#aca-footer) determines the project's [repo-type](#repo-type)
|
|
100
|
-
- [chapter](#chapter) contains many [section](#section), [section](#section) contains many [subsection](#subsection)
|
|
100
|
+
- [chapter](#chapter) contains many [section](#section), [section](#section) contains many [subsection](#subsection)
|
|
101
101
|
|
|
102
102
|
## Flagged ambiguities
|
|
103
103
|
|
package/README.md
CHANGED
|
@@ -106,5 +106,5 @@ Run `bash tests/run-tests.sh` before opening a pull request
|
|
|
106
106
|
|
|
107
107
|
---
|
|
108
108
|
|
|
109
|
-
> 📦 **Anyone Can Architect v0.
|
|
110
|
-
> 🤝 Powered by [Anyone Can Architect](https://github.com/ruozi/anyone-can-architect) v0.
|
|
109
|
+
> 📦 **Anyone Can Architect v0.4.0**
|
|
110
|
+
> 🤝 Powered by [Anyone Can Architect](https://github.com/ruozi/anyone-can-architect) v0.4.0 · Repo-Type: `guideline`
|
package/SSOT.md
CHANGED
|
@@ -32,6 +32,11 @@
|
|
|
32
32
|
|
|
33
33
|
- [RFC 9110 (HTTP Semantics)](https://www.rfc-editor.org/rfc/rfc9110): Defines HTTP semantics, including methods, status codes, fields, safety, and idempotency
|
|
34
34
|
- [OWASP API Security Top 10](https://owasp.org/API-Security/): Summarizes common API security risks, including authorization, authentication, resource consumption, and configuration issues
|
|
35
|
+
- [Socket.IO Event Types](https://socket.io/docs/v4/typescript/): Defines how to declare client and server events by direction, with type declarations and runtime validation taking separate responsibilities
|
|
36
|
+
- [Socket.IO Events and Acknowledgements](https://socket.io/docs/v4/emitting-events/): Defines bidirectional events, acknowledgements, and timeouts
|
|
37
|
+
- [Socket.IO Client Options](https://socket.io/docs/v4/client-options/) and [Namespaces](https://socket.io/docs/v4/namespaces/): Define the connection path, namespaces, and how clients connect
|
|
38
|
+
- [Socket.IO Connection Authentication](https://socket.io/docs/v4/middlewares/): Defines how auth credentials are passed and how connection rejections are reported
|
|
39
|
+
- [Socket.IO Delivery Guarantees](https://socket.io/docs/v4/delivery-guarantees/): Defines the default message delivery guarantees and where the application must add its own guarantees
|
|
35
40
|
|
|
36
41
|
## 7 Platforms and Tools
|
|
37
42
|
|
package/VERSION
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
0.
|
|
1
|
+
0.4.0
|
package/axioms/writing.md
CHANGED
|
@@ -26,6 +26,8 @@
|
|
|
26
26
|
- Remove content that adds no information and does not help understanding
|
|
27
27
|
- Write one sentence per line, with only one fact per sentence
|
|
28
28
|
- State actions directly in operational steps
|
|
29
|
+
- If a specific practice fully expresses a constraint, write the practice directly
|
|
30
|
+
- Keep prohibitions that no specific practice can fully express
|
|
29
31
|
- Write sequential actions as separate items
|
|
30
32
|
- Make the actor, the object of the action, and the referents clear
|
|
31
33
|
- Do not repeat actors, objects of actions, or referents already clear from context
|
|
@@ -43,7 +43,7 @@ flowchart TD
|
|
|
43
43
|
| `/aca-specify` | Reason through new requirements or improve existing designs, then proceed to Design after confirming the solution |
|
|
44
44
|
| `/aca-design` | Write and check design docs within the current scope, then determine the next scope or complete the overall closeout |
|
|
45
45
|
| `/aca-walkthrough` | Walk through design docs in business language, confirm design decisions unit by unit, and correct identified issues on the spot after confirmation |
|
|
46
|
-
| `/aca-review` | Determine the review subject and scope, statically review the design or
|
|
46
|
+
| `/aca-review` | Determine the review subject and scope, statically review the design or the overall code structure, without modifying the docs or code under review or running code |
|
|
47
47
|
| `/aca-implement` | Plan the file structure based on the design, then write production code and test code according to module dependencies |
|
|
48
48
|
| `/aca-test` | Select and run minimal tests based on the current implementation scope or the design boundary crossed by changes, testing only without modifying files |
|
|
49
49
|
| `/aca-repo-audit` | Check repository documentation and verify the implementation as needed, with read-only access and no changes |
|
|
@@ -41,6 +41,8 @@ Change only documentation, not code
|
|
|
41
41
|
- Remove content that adds no information and does not help understanding
|
|
42
42
|
- Write one sentence per line, with only one fact per sentence
|
|
43
43
|
- State actions directly in operational steps
|
|
44
|
+
- If a specific practice fully expresses a constraint, write the practice directly
|
|
45
|
+
- Keep prohibitions that no specific practice can fully express
|
|
44
46
|
- Write sequential actions as separate items
|
|
45
47
|
- Make the actor, the object of the action, and the referents clear
|
|
46
48
|
- Do not repeat actors, objects of actions, or referents already clear from context
|
|
@@ -167,11 +169,13 @@ If neither the repo-type spec nor the document set specifies an order, arrange w
|
|
|
167
169
|
Keep plain text in headings, code blocks, Mermaid labels, and product copy
|
|
168
170
|
4. Synchronize affected test designs
|
|
169
171
|
- Identify affected black-box and white-box test designs based on contracts, flows, and internal mechanisms added, revised, or deleted in this round
|
|
172
|
+
- Against the confirmed design, check the affected existing test code, fixtures, and the behavior they actually verify
|
|
170
173
|
- Update test designs in sequence according to the corresponding doc designs and [test cases](~/.gemini/config/skills/aca/doc-design/patterns/testcase.md)
|
|
171
174
|
1. Update fixtures
|
|
172
175
|
2. Update test scenarios and their references to design rationale
|
|
173
176
|
3. Update test cases based on the scenarios
|
|
174
177
|
Add missing cases, revise changed cases, and delete or replace invalid cases
|
|
178
|
+
- Leave actual changes to test code and fixtures to `/aca-implement`
|
|
175
179
|
- If only wording is revised and verified behavior has not changed, check that test designs and references remain valid
|
|
176
180
|
- If solution decisions or as-is evidence required for test design are missing, handle them under §3
|
|
177
181
|
- If affected docs are outside the current scope, record their locations and the content that needs synchronization
|
|
@@ -256,8 +260,10 @@ Perform the following steps after writing and scope checks are complete for all
|
|
|
256
260
|
After all applicable checks pass, commit only actual closeout changes, then push to the remote
|
|
257
261
|
If there are no actual changes, do not create an empty commit, and push existing commits from this round
|
|
258
262
|
If committing or pushing is not possible, record completed work, incomplete actions, and the resumption point, and report incomplete under §8
|
|
259
|
-
5.
|
|
260
|
-
After all closeout requirements are complete, the
|
|
263
|
+
5. Determine whether design review is needed and continue
|
|
264
|
+
After all closeout requirements are complete, check whether the design in this round is cross-module (involving multiple modules, the project-level architecture, the module division, or cross-module interfaces and collaboration contracts)
|
|
265
|
+
- Cross-module: the next step is `/aca-review` for a design review
|
|
266
|
+
- Not cross-module (only changes inside a single module or local design changes): skip design review and go directly to the next step (`/aca-implement` when this round needs code, or `/aca-release` according to the confirmed version progression plan when this round changes only design docs)
|
|
261
267
|
|
|
262
268
|
## 8 Output
|
|
263
269
|
|
|
@@ -275,16 +281,16 @@ Perform the following steps after writing and scope checks are complete for all
|
|
|
275
281
|
|
|
276
282
|
| Item | Result |
|
|
277
283
|
| --- | --- |
|
|
278
|
-
| Scope | <current scope
|
|
284
|
+
| Scope | <current scope, progress in this round, and whether it is cross-module> |
|
|
279
285
|
| Inputs | <solution or as-is state and actual sources> |
|
|
280
286
|
| Docs | <files added, revised, moved, or deleted / none> |
|
|
281
287
|
| Checks | <actual results, basis for reuse, and unverified items> |
|
|
282
288
|
| Commits | <commit and push results / not committed> |
|
|
283
289
|
| Pending | <incomplete items, reasons, and resumption point / none> |
|
|
284
|
-
| Next step |
|
|
290
|
+
| Next step | </aca-review after cross-module closeout, /aca-implement or /aca-release directly after non-cross-module closeout, or fill corresponding gaps> |
|
|
285
291
|
```
|
|
286
292
|
|
|
287
293
|
3. Determine the next step
|
|
288
|
-
After this round is fully closed out,
|
|
294
|
+
After this round is fully closed out, continue to `/aca-review`, `/aca-implement`, or `/aca-release` according to whether the design is cross-module, as in step 5 of 7.2
|
|
289
295
|
If the current scope is complete but another scope remains, determine the next path under 7.1
|
|
290
296
|
If work is incomplete, fill the corresponding gaps, and do not judge Design complete solely because files have been written
|
|
@@ -54,6 +54,8 @@ Preserve existing changes outside the scope of this implementation
|
|
|
54
54
|
- List deliverables and their completion criteria based on the confirmed design and implementation scope
|
|
55
55
|
2. **Compile the code and test change list**
|
|
56
56
|
- Compare delivery requirements with existing code and tests, and list what to reuse, modify, add, or remove
|
|
57
|
+
- Correct or remove outdated or wrong test cases and fixtures according to the confirmed design
|
|
58
|
+
- When changing test expectations, base the change on the confirmed design or a verified test error
|
|
57
59
|
3. **Orchestrate the corresponding test scope**
|
|
58
60
|
- List the test cases and fixtures to write or update in this run based on the black-box and white-box test designs
|
|
59
61
|
- Record the units under test and test case scope corresponding to the current implementation scope for direct execution by `/aca-test`
|
|
@@ -141,12 +143,16 @@ Preserve existing changes outside the scope of this implementation
|
|
|
141
143
|
|
|
142
144
|
## 6 Output
|
|
143
145
|
|
|
144
|
-
|
|
145
|
-
|
|
146
|
-
|
|
147
|
-
|
|
148
|
-
|
|
149
|
-
|
|
146
|
+
1. **Update the task status**
|
|
147
|
+
- All completion criteria for the current scope are satisfied: mark the goal and task status as complete
|
|
148
|
+
- Completion criteria are not satisfied: report remaining work, reasons for blockers, and actions to resume
|
|
149
|
+
2. **Check for module and code structure changes and determine the next step**
|
|
150
|
+
- Check whether the changes are cross-module or change a module's overall code structure (module structure, overall code distribution, function construction)
|
|
151
|
+
- Cross-module or the module's overall code structure changed: use `/aca-review` to run an implementation review on this scope, then go to `/aca-test` after the review passes
|
|
152
|
+
- Only inside a module, with no change to the module's overall code structure (such as internal module logic, local function implementation, or test details): skip implementation review and go directly to `/aca-test`
|
|
153
|
+
- Provide the following `/aca-review` or `/aca-test` with the overall goal, corresponding design, implementation scope, orchestrated test scope, and comparison baseline, and identify the commits and uncommitted changes in this run
|
|
154
|
+
3. **Output the implementation report**
|
|
155
|
+
Use the following format for the final report, filling in the title and results according to the actual status
|
|
150
156
|
|
|
151
157
|
```markdown
|
|
152
158
|
# 🛠️ Implement: <complete / incomplete>
|
|
@@ -156,9 +162,10 @@ Use the following format for the final report, filling in the title and results
|
|
|
156
162
|
| Goal | <overall goal and completion criteria satisfaction> |
|
|
157
163
|
| Scope | <implementation scope and module progress> |
|
|
158
164
|
| Changes | <main production code and test code changes> |
|
|
165
|
+
| Structural change | <yes (cross-module or module's overall code structure changed) / no (only internal module logic or local changes)> |
|
|
159
166
|
| Test scope | <units under test and test case scope orchestrated for /aca-test> |
|
|
160
167
|
| Commits | <commit records / uncommitted> |
|
|
161
168
|
| Blockers | <blockers and reasons / none> |
|
|
162
169
|
| Recommendations | <extension recommendations / none> |
|
|
163
|
-
| Next step |
|
|
170
|
+
| Next step | </aca-review when there is a structural change, /aca-test directly when changes are only inside a module with no structural change> |
|
|
164
171
|
```
|
|
@@ -97,14 +97,10 @@ If execution cannot continue in Chapters 4 through 7, report completed facts, th
|
|
|
97
97
|
1. Run `bash ~/.gemini/config/skills/aca/bin/aca-release-notify-check .` to check the announcement configuration
|
|
98
98
|
Record the check result and the corresponding configuration location
|
|
99
99
|
2. Act on the check result
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
| `NOTIFY_WIRED` | Record the platform and consumer point and continue the release |
|
|
105
|
-
| `NOTIFY_UNWIRED` | Stop and report that the announcement does not use `aca-tag-notify-extract <tag>` to extract content, then check again after the configuration is corrected |
|
|
106
|
-
| Unable to complete the check | Stop and report the reason and resume conditions |
|
|
107
|
-
|
|
100
|
+
- `NOTIFY_NONE`: record that no transport is configured and continue the release
|
|
101
|
+
- `NOTIFY_WIRED`: record the platform and consumer point and continue the release
|
|
102
|
+
- `NOTIFY_UNWIRED`: stop and report that the announcement does not use `aca-tag-notify-extract <tag>` to extract content, then check again after the configuration is corrected
|
|
103
|
+
- Unable to complete the check: stop and report the reason and resume conditions
|
|
108
104
|
3. Use the configuration check result for the [Announcement Cross-Check](#72-cross-check-the-release-announcement)
|
|
109
105
|
Check again after the configuration is corrected
|
|
110
106
|
The configuration check confirms that the summary is integrated
|
|
@@ -305,15 +301,11 @@ Release announcements are generated from the NOTIFY block in the annotated Tag
|
|
|
305
301
|
1. Locate the delivery results
|
|
306
302
|
Use the [announcement configuration](#33-announcement-configuration) and the repository release workflow to find tasks, logs, or delivery receipts for this Tag
|
|
307
303
|
2. Record the delivery status based on evidence
|
|
308
|
-
|
|
309
|
-
|
|
310
|
-
|
|
311
|
-
|
|
312
|
-
|
|
313
|
-
| Delivery failed | An explicit failure result |
|
|
314
|
-
| Unconfirmed | Insufficient evidence to determine the delivery status |
|
|
315
|
-
| Transport not configured | Configuration checks confirm that no delivery mechanism is configured |
|
|
316
|
-
|
|
304
|
+
- Evidence of successful delivery for this Tag exists: mark as sent
|
|
305
|
+
- The task is confirmed to still be waiting or in progress: mark as pending delivery
|
|
306
|
+
- An explicit delivery failure result exists: mark as delivery failed
|
|
307
|
+
- Evidence is insufficient to determine the delivery status: mark as unconfirmed
|
|
308
|
+
- Configuration checks confirm that no delivery mechanism is configured: mark as transport not configured
|
|
317
309
|
3. Handle follow-up actions
|
|
318
310
|
If delivery fails, recover or resend according to repository conventions
|
|
319
311
|
If the status is unconfirmed, report the missing evidence
|
|
@@ -53,6 +53,8 @@ Use `/aca-review` when you need to judge whether business goals and design solut
|
|
|
53
53
|
- Remove content that adds no information and does not help understanding
|
|
54
54
|
- Write one sentence per line, with only one fact per sentence
|
|
55
55
|
- State actions directly in operational steps
|
|
56
|
+
- If a specific practice fully expresses a constraint, write the practice directly
|
|
57
|
+
- Keep prohibitions that no specific practice can fully express
|
|
56
58
|
- Write sequential actions as separate items
|
|
57
59
|
- Make the actor, the object of the action, and the referents clear
|
|
58
60
|
- Do not repeat actors, objects of actions, or referents already clear from context
|
|
@@ -1,13 +1,13 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: aca-review
|
|
3
|
-
description: Review the design docs or code
|
|
3
|
+
description: Review the design docs or code structure in the current scope, determine pass, needs changes, or incomplete, and do not modify the docs or code under review
|
|
4
4
|
---
|
|
5
5
|
<!-- AUTO-GENERATED from SKILL.md.tmpl — do not edit directly -->
|
|
6
6
|
<!-- Regenerate: bash scripts/build-skills.sh --host antigravity -->
|
|
7
7
|
|
|
8
8
|
# aca-review
|
|
9
9
|
|
|
10
|
-
Review the design docs or code
|
|
10
|
+
Review the design docs or code structure in the current scope and determine pass, needs changes, or incomplete
|
|
11
11
|
Do not modify design docs, project source code, or test code, and do not run the code or tests under review
|
|
12
12
|
Use `/aca-repo-audit` for the repository-wide audit before release
|
|
13
13
|
|
|
@@ -17,11 +17,11 @@ Use `/aca-repo-audit` for the repository-wide audit before release
|
|
|
17
17
|
|
|
18
18
|
1. **Source-driven review**
|
|
19
19
|
Review the design against confirmed requirements and applicable rules
|
|
20
|
-
Review the
|
|
20
|
+
Review the modularity and overall structure of the code against the confirmed design
|
|
21
21
|
2. **Independent judgment**
|
|
22
|
-
Form conclusions independently for each review
|
|
22
|
+
Form conclusions independently for each review dimension
|
|
23
23
|
3. **Evidence-based verdict**
|
|
24
|
-
Determine issues and review conclusions from
|
|
24
|
+
Determine issues and review conclusions from facts in the code structure and docs
|
|
25
25
|
4. **Scope constraints**
|
|
26
26
|
Limit review conclusions to the current scope
|
|
27
27
|
|
|
@@ -55,6 +55,8 @@ The writing axiom applies to reviews of design doc prose and the wording of revi
|
|
|
55
55
|
- Remove content that adds no information and does not help understanding
|
|
56
56
|
- Write one sentence per line, with only one fact per sentence
|
|
57
57
|
- State actions directly in operational steps
|
|
58
|
+
- If a specific practice fully expresses a constraint, write the practice directly
|
|
59
|
+
- Keep prohibitions that no specific practice can fully express
|
|
58
60
|
- Write sequential actions as separate items
|
|
59
61
|
- Make the actor, the object of the action, and the referents clear
|
|
60
62
|
- Do not repeat actors, objects of actions, or referents already clear from context
|
|
@@ -81,11 +83,11 @@ Reference: [ASD-STE100](~/.gemini/config/skills/aca/SSOT.md#1-writing-rules)
|
|
|
81
83
|
flowchart TD
|
|
82
84
|
Start([Receive review request]) --> Scope["Confirm review scope and execution models · §3"]
|
|
83
85
|
Scope --> Check["Determine review type and prepare sources · §4"]
|
|
84
|
-
Check --> Audit["
|
|
85
|
-
Audit --> Verify["Recheck and
|
|
86
|
-
Verify --> Issues{"Confirmed must-fix items exist · §
|
|
87
|
-
Issues -- Yes, needs changes --> Report(["Output and next step · §
|
|
88
|
-
Issues -- No --> Complete{"All pass criteria are met · §
|
|
86
|
+
Check --> Audit["Run independent reviews by review type · §5"]
|
|
87
|
+
Audit --> Verify["Recheck and determine the verdict · §6"]
|
|
88
|
+
Verify --> Issues{"Confirmed must-fix items exist · §6.2"}
|
|
89
|
+
Issues -- Yes, needs changes --> Report(["Output and next step · §7"])
|
|
90
|
+
Issues -- No --> Complete{"All pass criteria are met · §6.2"}
|
|
89
91
|
Complete -- Yes, pass --> Report
|
|
90
92
|
Complete -- No, incomplete --> Report
|
|
91
93
|
```
|
|
@@ -115,23 +117,17 @@ flowchart TD
|
|
|
115
117
|
|
|
116
118
|
### 3.2 Agent and Model Selection
|
|
117
119
|
|
|
118
|
-
1. **
|
|
119
|
-
-
|
|
120
|
-
-
|
|
121
|
-
|
|
122
|
-
-
|
|
123
|
-
|
|
124
|
-
-
|
|
125
|
-
|
|
126
|
-
-
|
|
127
|
-
3. **Confirm execution combinations**
|
|
128
|
-
- Show each candidate's Agent, model, availability, invocation method, and differences from the main agent
|
|
129
|
-
- Explain the recommendation and available alternative combinations, and ask the developer to confirm before running the review
|
|
130
|
-
- Reuse the existing confirmation if the confirmed selection and availability conditions have not changed
|
|
131
|
-
4. **Handle execution fallback**
|
|
132
|
-
- Use the confirmed execution combinations for [Model and Task Orchestration](#53-model-and-task-orchestration)
|
|
120
|
+
1. **Reuse the confirmed model first**
|
|
121
|
+
- Developer has specified an Agent environment or model: run with that specification
|
|
122
|
+
- A review model has already been confirmed and its availability conditions have not changed: reuse the last confirmed Agent environment and model by default, and skip the environment scan and confirmation
|
|
123
|
+
2. **Scan and confirm the model on the first review**
|
|
124
|
+
- On the first review with no model specified, scan the current AI Agent environment and other AI Agent environments on this machine, and the models that can be invoked
|
|
125
|
+
- Prefer recommending a callable flagship model that differs from the main agent; if no other suitable and callable candidate is available, propose using the current model
|
|
126
|
+
- Show each candidate's Agent environment, model, availability, and the reason for the recommendation, and ask the developer to confirm before running the review; later reviews reuse this confirmation by default
|
|
127
|
+
3. **Handle execution fallback**
|
|
128
|
+
- Use the confirmed or reused execution combination for [Task Orchestration and Execution](#53-task-orchestration-and-execution)
|
|
133
129
|
- If the selected combination cannot be invoked, use a confirmed alternative, or report the change and ask the developer to confirm a new combination if no alternative has been confirmed
|
|
134
|
-
- Record the
|
|
130
|
+
- Record the Agent environment and model actually used, whether they were reused, and the reasons for any fallback in the [Review Report](#71-review-report)
|
|
135
131
|
|
|
136
132
|
## 4 Read Source Material and Run Checks
|
|
137
133
|
|
|
@@ -139,9 +135,8 @@ flowchart TD
|
|
|
139
135
|
flowchart TD
|
|
140
136
|
Kind["Determine review type · §4.1"] -- Design review --> Design["Design review preparation and mechanical checks · §4.2"]
|
|
141
137
|
Kind -- Implementation review --> Implementation["Implementation review source preparation · §4.3"]
|
|
142
|
-
Design -->
|
|
143
|
-
Implementation --> Next
|
|
144
|
-
Results --> Next
|
|
138
|
+
Design --> Next(["Proceed to independent review · §5"])
|
|
139
|
+
Implementation --> Next
|
|
145
140
|
```
|
|
146
141
|
|
|
147
142
|
### 4.1 Determine Review Type
|
|
@@ -149,23 +144,24 @@ flowchart TD
|
|
|
149
144
|
1. **Determine the review type for this run**
|
|
150
145
|
- Developer has specified the review type: follow that specification first
|
|
151
146
|
- Developer has not specified it: use the review type already specified by the caller
|
|
152
|
-
- Review type is not specified: determine it from the subject under review and the actual changes (run a design review for design docs, run an implementation review for code,
|
|
147
|
+
- Review type is not specified: determine it from the subject under review and the actual changes (run a design review for design docs, run an implementation review for code, and run both review types separately when both are involved)
|
|
153
148
|
- Review type still cannot be determined: ask the developer to specify it
|
|
154
149
|
|
|
155
150
|
Run both branches when both review types are selected
|
|
156
151
|
|
|
157
152
|
### 4.2 Design Review
|
|
158
153
|
|
|
154
|
+
By default, design review applies to cross-module design changes (involving multiple modules, the project-level architecture, the module division, or cross-module interfaces and collaboration contracts), or to a design review the developer explicitly requests
|
|
155
|
+
|
|
159
156
|
1. **Extract applicable checklist items**
|
|
160
157
|
- Read the document set, Doc Design, and Patterns actually used for the current scope
|
|
161
|
-
- Extract their applicable checklist items as the basis for
|
|
162
|
-
2. **
|
|
163
|
-
-
|
|
164
|
-
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
168
|
-
- If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths determined in step 2 and run them
|
|
158
|
+
- Extract their applicable checklist items as the basis for verification in the design review
|
|
159
|
+
2. **Reuse or run mechanical checks**
|
|
160
|
+
- Existing mechanical check results from this session can be reused directly if they cover the same scope and the relevant files, check rules, and tools have not changed, stating the original results and the basis for reuse in the report
|
|
161
|
+
- If the reuse conditions are not met, replace the placeholder paths in the following commands with the actual paths of the docs under review and run them
|
|
162
|
+
- Prose checks cover all docs under review, including project-level records within the review scope
|
|
163
|
+
- For the doc graph check, select a doc tree that includes the docs under review and has a README entry
|
|
164
|
+
- Mechanical checks for Context verify structure and formatting
|
|
169
165
|
|
|
170
166
|
```bash
|
|
171
167
|
bash ~/.gemini/config/skills/aca/bin/aca-doc-graph-check <doc directory>
|
|
@@ -173,109 +169,90 @@ Run both branches when both review types are selected
|
|
|
173
169
|
bash ~/.gemini/config/skills/aca/bin/aca-prose-check <paths to all docs under review>
|
|
174
170
|
```
|
|
175
171
|
|
|
176
|
-
|
|
177
|
-
|
|
178
|
-
1. **Read design and implementation conventions**
|
|
179
|
-
- Read the confirmed design, test design, and repository implementation conventions for the current scope
|
|
180
|
-
2. **Read code and tests under review**
|
|
181
|
-
- Read the current diff and changed files against the established comparison baseline
|
|
182
|
-
- Read affected callers and dependency code
|
|
183
|
-
- Read the functions, classes, test files, and related call chains containing the changes to understand their execution context
|
|
184
|
-
3. **Map design to implementation**
|
|
185
|
-
- Map the production code implementation and test code implementation to the design conventions and test scenarios respectively for item-by-item static review in Chapter 5
|
|
186
|
-
- Implementation review does not run code, tests, or builds directly, and runtime verification is executed by `/aca-test` after the review passes
|
|
187
|
-
|
|
188
|
-
### 4.4 Handle Check Results
|
|
189
|
-
|
|
190
|
-
Handle mechanical checks for design reviews as specified in this section
|
|
172
|
+
3. **Handle mechanical check results**
|
|
191
173
|
|
|
192
174
|
| Check status | Action |
|
|
193
175
|
| --- | --- |
|
|
194
|
-
| Pass | Record the results and verification evidence |
|
|
176
|
+
| Pass, or reuse conditions met | Record the results and the verification or reuse evidence |
|
|
195
177
|
| Failure returned | Check the diagnostics and list confirmed issues as must fix |
|
|
196
178
|
| Cannot run or diagnostics cannot be verified | Mark the corresponding check or issue verification as incomplete and state the reason |
|
|
197
179
|
|
|
180
|
+
### 4.3 Implementation Review
|
|
181
|
+
|
|
182
|
+
1. **Read the structural design and organization conventions**
|
|
183
|
+
- Read the architecture design, module boundaries, interface definitions, internal composition, and repository code organization conventions for the current scope
|
|
184
|
+
2. **Read the overall structure of the code under review**
|
|
185
|
+
- Against the established comparison baseline, read the directory and file distribution, module dependencies, function and class definitions, and cross-module assembly wiring involved in the changes
|
|
186
|
+
3. **Define the review boundary**
|
|
187
|
+
- By default, implementation review applies to cross-module changes or changes to a module's overall code structure (changes that stay inside a module and do not change its overall code structure skip implementation review and go directly to `/aca-test`)
|
|
188
|
+
- Implementation review checks only the overall structure (module structure, overall code distribution, and function construction), and does not check specific code details or implementation logic
|
|
189
|
+
- Implementation review does not run code, tests, or builds directly, and runtime verification is executed by `/aca-test` after the review passes
|
|
190
|
+
|
|
198
191
|
## 5 Review Orchestration and Execution
|
|
199
192
|
|
|
200
193
|
### 5.1 Design Review Dimensions
|
|
201
194
|
|
|
202
|
-
|
|
195
|
+
Design review is one overall review task that checks the design docs under review against the following four items
|
|
196
|
+
|
|
197
|
+
1. **Requirements and scope coverage**
|
|
203
198
|
Check whether the design fully addresses the confirmed problems, goals, and scope
|
|
204
|
-
2. **
|
|
205
|
-
Check whether the division of responsibilities and boundaries
|
|
206
|
-
Check whether the collaboration and processing mechanisms
|
|
207
|
-
If user interaction is involved, check whether
|
|
208
|
-
Check whether
|
|
209
|
-
3. **
|
|
210
|
-
Check whether module dependencies and interface conventions are sufficient to guide module collaboration
|
|
211
|
-
Check whether data, state changes, error handling, and boundary behavior are sufficient to guide detailed implementation
|
|
199
|
+
2. **Responsibility boundaries and collaboration mechanisms**
|
|
200
|
+
Check whether the division of responsibilities and boundaries, module dependencies, and interface conventions match the division of business work and are sufficient to guide module collaboration
|
|
201
|
+
Check whether the collaboration and processing mechanisms, data and state changes, error handling, and boundary behavior are sufficient to guide detailed implementation
|
|
202
|
+
If user interaction is involved, check whether the interaction flow, each interaction state, and each success and failure path provide clear feedback and action guidance
|
|
203
|
+
Check whether the design contains ambiguities that would lead to different business behavior, and whether additional design decisions are still needed before implementation
|
|
204
|
+
3. **Completeness of the verification design**
|
|
212
205
|
Check whether the test design specifies fixtures, scenarios, execution methods, and expected results
|
|
213
206
|
Check whether test results can determine if the corresponding acceptance criteria are met
|
|
214
|
-
|
|
215
|
-
Check whether additional design decisions are still needed before implementation
|
|
216
|
-
4. **Overall perspective**
|
|
207
|
+
4. **Cross-doc consistency and writing rules**
|
|
217
208
|
Check whether the documentation entry and references accurately locate the current design and its dependencies
|
|
218
209
|
Check related docs for design omissions, conflicting conventions, duplicate definitions, or inconsistent terminology
|
|
210
|
+
Check whether the checklist items of the applicable document set, Doc Design, and Patterns are met
|
|
219
211
|
|
|
220
212
|
### 5.2 Implementation Review Dimensions
|
|
221
213
|
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
1. **
|
|
225
|
-
Check whether the division of modules and
|
|
226
|
-
2. **
|
|
227
|
-
Check whether
|
|
228
|
-
|
|
229
|
-
Check whether
|
|
230
|
-
|
|
231
|
-
3
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
238
|
-
-
|
|
239
|
-
- For implementation reviews, assign independent sub-agents to structural setup, detailed logic implementation, and overall structural implementation
|
|
240
|
-
- Each sub-agent forms conclusions independently without reading other sub-agents' review results beforehand
|
|
241
|
-
2. **Arrange execution models**
|
|
242
|
-
- Arrange execution using the combinations confirmed in [Agent and Model Selection](#32-agent-and-model-selection)
|
|
243
|
-
- Keep review tasks independent even when using the current model
|
|
244
|
-
3. **Provide task context**
|
|
245
|
-
- Assigned review items and applicable checklist items
|
|
214
|
+
Implementation review is one overall review task that uses the confirmed design docs as its basis, checks only the modularity and overall structure of the code, and does not check specific code details or implementation logic
|
|
215
|
+
|
|
216
|
+
1. **Module structure**
|
|
217
|
+
Check whether the division of modules and submodules, responsibility assignments, interface boundaries, dependencies, and cross-module assembly wiring conform to the design
|
|
218
|
+
2. **Overall code distribution**
|
|
219
|
+
Check whether the directory and file organization conforms to the design, whether each file has a single responsibility and clear ownership, and whether responsibilities are mixed or layers are coupled across boundaries
|
|
220
|
+
3. **Function construction**
|
|
221
|
+
Check whether the responsibility split, signature design, granularity, and level of abstraction of functions and classes are clear and reasonable
|
|
222
|
+
|
|
223
|
+
### 5.3 Task Orchestration and Execution
|
|
224
|
+
|
|
225
|
+
1. **Dispatch independent review tasks by review type**
|
|
226
|
+
- When only a design review or only an implementation review runs, create 1 independent sub-agent task to complete all check items of that dimension
|
|
227
|
+
- When both design and implementation reviews run, create 1 independent sub-agent task for the design review and 1 for the implementation review
|
|
228
|
+
- Run each review task according to [Agent and Model Selection](#32-agent-and-model-selection), and form conclusions independently
|
|
229
|
+
2. **Provide task context**
|
|
230
|
+
- The assigned review type, its check items, and applicable checklist items
|
|
246
231
|
- Review subject, scope, and comparison baseline, including commits under review and uncommitted changes included in the review
|
|
247
232
|
- Locations of the content under review and the corresponding design source material
|
|
248
|
-
-
|
|
249
|
-
-
|
|
250
|
-
|
|
251
|
-
|
|
252
|
-
|
|
253
|
-
|
|
254
|
-
-
|
|
255
|
-
|
|
256
|
-
|
|
257
|
-
|
|
258
|
-
|
|
259
|
-
|
|
260
|
-
|
|
261
|
-
|
|
262
|
-
## 6 Recheck and Summarize
|
|
263
|
-
|
|
264
|
-
1. **Read sub-agent check records**
|
|
265
|
-
- The main agent reads each sub-agent's check records and checks whether the check evidence corresponds to the current content under review
|
|
266
|
-
2. **Recheck and merge issues**
|
|
267
|
-
- Check the files and evidence for each issue and include it in the report only after confirming it
|
|
233
|
+
- For design review, the mechanical check results and evidence from Chapter 4
|
|
234
|
+
- For implementation review, the directory and file structure, changed files, module dependencies, and repository code organization conventions
|
|
235
|
+
3. **Run an issue-oriented review**
|
|
236
|
+
- The sub-agent verifies each check item and applicable checklist item of its dimension
|
|
237
|
+
- When it finds an issue, it records the file location, problem, impact, and recommended change using the issue format in the [Review Report](#71-review-report)
|
|
238
|
+
- When a check item cannot be completed, it records the incomplete item and the reason
|
|
239
|
+
- Pass and not-applicable items are not itemized; the sub-agent returns the list of issues found, incomplete items, and its review conclusion to the main agent
|
|
240
|
+
|
|
241
|
+
## 6 Recheck and Verdict
|
|
242
|
+
|
|
243
|
+
### 6.1 Recheck and Merge
|
|
244
|
+
|
|
245
|
+
1. **Recheck issue evidence**
|
|
246
|
+
- The main agent checks the files and evidence for each issue returned by the sub-agents and includes it in the report only after confirming it
|
|
268
247
|
- Exclude disproven issues and mark issues with insufficient evidence as incomplete verification
|
|
269
248
|
- The main agent can add issues it finds independently after applying the same evidence verification
|
|
270
249
|
- Merge duplicate issues while retaining their locations, evidence, and impact
|
|
271
|
-
|
|
272
|
-
-
|
|
273
|
-
- If a sub-agent did not cover its assigned scope
|
|
274
|
-
- Mark review
|
|
275
|
-
4. **Form the basis for the verdict**
|
|
276
|
-
- Summarize confirmed issues and check completion status as the basis for the verdict
|
|
250
|
+
2. **Check review coverage**
|
|
251
|
+
- Confirm that the selected review dimensions and their check items have all been verified
|
|
252
|
+
- If a sub-agent did not cover its assigned scope or omitted check items, check the corresponding content and recheck the results
|
|
253
|
+
- Mark review dimensions or checks that still cannot be completed as incomplete and state the reasons
|
|
277
254
|
|
|
278
|
-
|
|
255
|
+
### 6.2 Verdict
|
|
279
256
|
|
|
280
257
|
| Verdict | Criteria |
|
|
281
258
|
| --- | --- |
|
|
@@ -287,9 +264,9 @@ If must-fix items and incomplete checks both exist, the verdict is needs changes
|
|
|
287
264
|
Optional improvements do not affect a pass
|
|
288
265
|
After the content under review changes, review the affected scope again and update the corresponding conclusions
|
|
289
266
|
|
|
290
|
-
##
|
|
267
|
+
## 7 Output and Next Step
|
|
291
268
|
|
|
292
|
-
###
|
|
269
|
+
### 7.1 Review Report
|
|
293
270
|
|
|
294
271
|
Output the review results in the current conversation using the following template without writing to project files
|
|
295
272
|
|
|
@@ -298,12 +275,13 @@ Output the review results in the current conversation using the following templa
|
|
|
298
275
|
|
|
299
276
|
| Item | Result |
|
|
300
277
|
| --- | --- |
|
|
301
|
-
| Subject | <design docs / code
|
|
278
|
+
| Subject | <design docs / code structure / both> |
|
|
302
279
|
| Scope | <modules, files, or changes under review> |
|
|
303
280
|
| Baseline | <comparison baseline, commits under review, and uncommitted changes> |
|
|
281
|
+
| Execution model | <Agent environment and model actually used, reuse status, and fallback reasons> |
|
|
304
282
|
| Verdict basis | <how pass criteria are met, or issues and incomplete checks preventing a pass> |
|
|
305
283
|
| Must fix | <issue count and main impact / none> |
|
|
306
|
-
| Tool checks | <pass, failure, and incomplete status of design review mechanical checks / not applicable for implementation review> |
|
|
284
|
+
| Tool checks | <pass, reuse, failure, and incomplete status of design review mechanical checks / not applicable for implementation review> |
|
|
307
285
|
| Incomplete | <incomplete review tasks and checks within the current scope, and reasons / none> |
|
|
308
286
|
| Next step | <one immediately actionable step> |
|
|
309
287
|
|
|
@@ -311,28 +289,15 @@ Output the review results in the current conversation using the following templa
|
|
|
311
289
|
|
|
312
290
|
- <doc section link / code file link and line number>
|
|
313
291
|
- Problem: <actual content, design conventions or checklist items violated, and specific deviations>
|
|
314
|
-
- Impact: <impact on design understanding, implementation, or
|
|
292
|
+
- Impact: <impact on design understanding, implementation, or maintenance of the code structure, and conditions under which it occurs>
|
|
315
293
|
- Change: <content to correct or confirm, and conventions or checklist items to satisfy after correction>
|
|
316
294
|
|
|
317
295
|
## Optional Improvements
|
|
318
296
|
|
|
319
297
|
- <suggested improvements that do not affect a pass, corresponding locations, and expected benefits>
|
|
320
|
-
|
|
321
|
-
## Check Scope
|
|
322
|
-
|
|
323
|
-
- Read: <files actually read in this review>
|
|
324
|
-
- Checklist: <criteria and sources, item-by-item verification results, basis for non-applicability, and reasons for incomplete checks>
|
|
325
|
-
- Tools: <mechanical check commands actually run and their results, or original results reused and basis for reuse / not applicable for implementation review>
|
|
326
|
-
|
|
327
|
-
| Review item | Agent environment | Model | Completion status | Notes |
|
|
328
|
-
| --- | --- | --- | --- | --- |
|
|
329
|
-
| <design review perspective / implementation review item> | <actual Agent environment> | <actual model and verifiable version> | <complete / incomplete> | <reason for fallback or incomplete status / none> |
|
|
330
298
|
```
|
|
331
299
|
|
|
332
|
-
|
|
333
|
-
For implementation reviews, list the three items: structural setup, detailed logic implementation, and overall structural implementation
|
|
334
|
-
|
|
335
|
-
### 8.2 Follow-Up Actions
|
|
300
|
+
### 7.2 Follow-Up Actions
|
|
336
301
|
|
|
337
302
|
Select the next step based on the review verdict and progress in the current round
|
|
338
303
|
|
|
@@ -341,9 +306,9 @@ Select the next step based on the review verdict and progress in the current rou
|
|
|
341
306
|
| Incomplete | Inputs or verification conditions are missing | Report the conditions for resuming and continue this review through `/aca-review` once they are met |
|
|
342
307
|
| Needs changes | The design solution still needs reasoning or decisions | `/aca-specify` Extend or revise the solution |
|
|
343
308
|
| Needs changes | The solution is clear and only design docs need revision | `/aca-design` Revise the docs |
|
|
344
|
-
| Needs changes | Code
|
|
309
|
+
| Needs changes | Code structure issues | `/aca-implement` Adjust the code structure |
|
|
345
310
|
| Pass | Design review passed and code implementation is needed in this round | `/aca-implement` |
|
|
346
311
|
| Pass | Design review passed and only design docs are changed in this round | Proceed to `/aca-release` according to the confirmed version progression plan |
|
|
347
312
|
| Pass | Implementation review passed | `/aca-test` Run test verification for the current scope |
|
|
348
313
|
|
|
349
|
-
After design or
|
|
314
|
+
After design or code structure corrections, review the affected scope again through `/aca-review`
|