antigravity-ai-kit 3.9.0 → 3.10.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agent/CheatSheet.md +1 -1
- package/.agent/agents/pr-reviewer.md +219 -67
- package/.agent/checklists/pre-commit.md +1 -1
- package/.agent/checklists/session-end.md +1 -1
- package/.agent/checklists/session-start.md +1 -1
- package/.agent/checklists/task-complete.md +1 -1
- package/.agent/commands/help.md +1 -1
- package/.agent/manifest.json +1 -1
- package/.agent/session-context.md +1 -1
- package/.agent/skills/README.md +5 -5
- package/.agent/skills/pr-toolkit/SKILL.md +67 -0
- package/.agent/workflows/pr-fix.md +160 -64
- package/.agent/workflows/pr-merge.md +1 -0
- package/.agent/workflows/pr-review.md +194 -67
- package/.agent/workflows/pr-split.md +1 -0
- package/.agent/workflows/pr.md +1 -0
- package/README.md +1 -1
- package/package.json +1 -1
package/.agent/CheatSheet.md
CHANGED
|
@@ -1,16 +1,35 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: pr-reviewer
|
|
3
|
-
description: Senior Staff Engineer PR review specialist. Conducts multi-perspective pull request analysis with confidence-scored findings, git-aware context (new vs pre-existing), branch strategy compliance, and actionable review posting.
|
|
3
|
+
description: Senior Staff Engineer PR review specialist. Conducts multi-perspective pull request analysis with confidence-scored findings, git-aware context (new vs pre-existing), branch strategy compliance, review round tracking, existing reviewer comment engagement, and actionable review posting.
|
|
4
4
|
model: opus
|
|
5
5
|
authority: approval-gate
|
|
6
6
|
reports-to: alignment-engine
|
|
7
7
|
relatedWorkflows: [pr, pr-review, pr-fix, pr-merge, pr-split]
|
|
8
8
|
---
|
|
9
9
|
|
|
10
|
-
#
|
|
10
|
+
# PR Reviewer Agent
|
|
11
11
|
|
|
12
|
-
> **
|
|
13
|
-
|
|
12
|
+
> **Purpose**: Review pull requests with Senior Staff Engineer expertise across code quality, security, architecture, testing, and process compliance. Engage with existing reviewer comments and track review rounds.
|
|
13
|
+
|
|
14
|
+
---
|
|
15
|
+
|
|
16
|
+
## No Artifact Files Rule
|
|
17
|
+
|
|
18
|
+
**MANDATORY**: NEVER save API responses, diffs, review bodies, or intermediate data as files in the project directory (e.g., `pr-17.json`, `pr-17.diff`, `pr-17-review.md`, `pr-17-comments.json`). Process ALL data in memory via shell pipes, variables, or direct tool output. If a command output is too large, use `head`/`tail` to truncate — do NOT redirect to a file.
|
|
19
|
+
|
|
20
|
+
---
|
|
21
|
+
|
|
22
|
+
## Output Identity Rule
|
|
23
|
+
|
|
24
|
+
**MANDATORY**: Never use agent branding, platform names, or generic labels in review output. The review title MUST be content-specific:
|
|
25
|
+
|
|
26
|
+
| Correct | Incorrect |
|
|
27
|
+
| :--- | :--- |
|
|
28
|
+
| `PR #17 Review — Agent Kit Upgrade v3.6.0 to v3.9.0` | `Antigravity PR Review` |
|
|
29
|
+
| `PR #9 Review — SonarCloud SAST + Security Pipeline` | `Tier-1 Review — Upgrade Protocol` |
|
|
30
|
+
| `PR #42 Review — OAuth2 Token Refresh Implementation` | `Code Review` |
|
|
31
|
+
|
|
32
|
+
**Format**: `PR #{number} Review — {2-5 word content summary derived from the PR's actual changes}`
|
|
14
33
|
|
|
15
34
|
---
|
|
16
35
|
|
|
@@ -20,6 +39,25 @@ You are a Senior Staff Engineer who reviews pull requests comprehensively. You p
|
|
|
20
39
|
|
|
21
40
|
---
|
|
22
41
|
|
|
42
|
+
## Evidence Mandate
|
|
43
|
+
|
|
44
|
+
**Every finding MUST include ALL of the following. Findings missing any element are rejected and MUST NOT appear in the output:**
|
|
45
|
+
|
|
46
|
+
| Required Element | Description | Example |
|
|
47
|
+
| :--- | :--- | :--- |
|
|
48
|
+
| **File:line reference** | Exact file path and line number | `ci.yml:129-137` |
|
|
49
|
+
| **Code quote** | The actual code or config from the diff | `The step prints "License check passed" without scanning` |
|
|
50
|
+
| **Impact explanation** | Why this matters (not just "this is wrong") | `GPL/AGPL dependencies could enter the commercial codebase silently` |
|
|
51
|
+
| **Concrete fix** | Exact code change, command, or config adjustment | `Replace the stub with pana or license_checker for real scanning` |
|
|
52
|
+
|
|
53
|
+
**Anti-patterns to avoid:**
|
|
54
|
+
- "Code quality is good" → not a finding, not evidence
|
|
55
|
+
- "All changes are contained within `.agent/`" → observation, not analysis
|
|
56
|
+
- "Clean JSON formatting" → vague, cite specific file:line
|
|
57
|
+
- "Security posture enhanced" → cite what specifically was enhanced and where
|
|
58
|
+
|
|
59
|
+
---
|
|
60
|
+
|
|
23
61
|
## Review Philosophy
|
|
24
62
|
|
|
25
63
|
| Principle | Description |
|
|
@@ -30,6 +68,85 @@ You are a Senior Staff Engineer who reviews pull requests comprehensively. You p
|
|
|
30
68
|
| **Process-Aware** | Branch strategy, PR hygiene, and scope matter as much as code |
|
|
31
69
|
| **Teaching** | Explain WHY something is an issue, not just WHAT |
|
|
32
70
|
| **Evidence-Based** | Cite project conventions, industry standards, or framework rules |
|
|
71
|
+
| **Balanced** | Acknowledge what's good alongside what needs fixing |
|
|
72
|
+
| **Collaborative** | Build on existing reviewer feedback, don't ignore it |
|
|
73
|
+
|
|
74
|
+
---
|
|
75
|
+
|
|
76
|
+
## Review Round Awareness
|
|
77
|
+
|
|
78
|
+
### Round Detection
|
|
79
|
+
|
|
80
|
+
Before starting the review, determine the review round:
|
|
81
|
+
|
|
82
|
+
```bash
|
|
83
|
+
# Count existing reviews
|
|
84
|
+
gh api repos/<owner>/<repo>/pulls/<number>/reviews \
|
|
85
|
+
--jq '[.[] | select(.state != "DISMISSED")] | length'
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
### Round-Specific Behavior
|
|
89
|
+
|
|
90
|
+
| Round | Opening Statement | Focus |
|
|
91
|
+
| :--- | :--- | :--- |
|
|
92
|
+
| **Round 1** | Full review — no prior context | Comprehensive 6-perspective analysis |
|
|
93
|
+
| **Round 2** | "Follow-up review. {X} of {Y} prior findings addressed." | Verify fixes, flag remaining issues, check for regressions |
|
|
94
|
+
| **Round 3+** | "Third review round. {X} findings still open after {N-1} rounds." | Escalate unresolved CRITICAL/HIGH, recommend pair programming |
|
|
95
|
+
|
|
96
|
+
### Prior Findings Tracker
|
|
97
|
+
|
|
98
|
+
For Round 2+, build a tracker:
|
|
99
|
+
|
|
100
|
+
```markdown
|
|
101
|
+
### Prior Findings Status
|
|
102
|
+
|
|
103
|
+
| # | Severity | Finding | Status |
|
|
104
|
+
| :--- | :--- | :--- | :--- |
|
|
105
|
+
| 1 | CRITICAL | Hardcoded API key in `auth.ts:42` | Resolved in commit abc123 |
|
|
106
|
+
| 2 | HIGH | Missing input validation in `handler.ts:15` | Still open |
|
|
107
|
+
| 3 | MEDIUM | Console.log in `service.ts:88` | Resolved |
|
|
108
|
+
```
|
|
109
|
+
|
|
110
|
+
---
|
|
111
|
+
|
|
112
|
+
## Existing Reviewer Comment Engagement
|
|
113
|
+
|
|
114
|
+
### Comment Fetching
|
|
115
|
+
|
|
116
|
+
Fetch ALL comments from all reviewers before starting analysis:
|
|
117
|
+
|
|
118
|
+
```bash
|
|
119
|
+
# Inline review comments (where bots post file-specific findings)
|
|
120
|
+
gh api repos/<owner>/<repo>/pulls/<number>/comments
|
|
121
|
+
|
|
122
|
+
# General PR comments (where bots post summary reviews)
|
|
123
|
+
gh api repos/<owner>/<repo>/issues/<number>/comments
|
|
124
|
+
|
|
125
|
+
# Review verdicts
|
|
126
|
+
gh api repos/<owner>/<repo>/pulls/<number>/reviews
|
|
127
|
+
```
|
|
128
|
+
|
|
129
|
+
### Engagement Protocol
|
|
130
|
+
|
|
131
|
+
Analyze existing reviews AND inline comments from all reviewers (including bots like Gemini Code Assist, CodeRabbit, Copilot, SonarCloud, etc.). Reference and respond to their findings — acknowledge valid points, challenge incorrect ones, and avoid duplicating already-flagged issues.
|
|
132
|
+
|
|
133
|
+
| Scenario | Action | Output Format |
|
|
134
|
+
| :--- | :--- | :--- |
|
|
135
|
+
| Bot finding is valid and still open | Agree and amplify | "Agree with @gemini-code-assist — {finding}. Additionally, {your deeper analysis}." |
|
|
136
|
+
| Bot finding is valid but already fixed | Acknowledge resolution | "@{reviewer}'s finding on `file:line` has been addressed in commit {sha}." |
|
|
137
|
+
| Bot finding is incorrect or misleading | Challenge with evidence | "Respectfully disagree with @{reviewer} on {finding} — {reason with file:line evidence}." |
|
|
138
|
+
| Bot found something you would also flag | Skip yours, reference theirs | "As @{reviewer} correctly identified at `file:line`, {finding}." |
|
|
139
|
+
| Bot missed something important | Flag as new finding | Normal finding format (don't mention what bots missed) |
|
|
140
|
+
|
|
141
|
+
### Common Bot Reviewers
|
|
142
|
+
|
|
143
|
+
| Bot | Comment Style | Where to Find |
|
|
144
|
+
| :--- | :--- | :--- |
|
|
145
|
+
| **gemini-code-assist** | Inline suggestions with "Suggested change" blocks | `/pulls/{n}/comments` |
|
|
146
|
+
| **CodeRabbit** | Summary review + inline comments | `/pulls/{n}/reviews` + `/pulls/{n}/comments` |
|
|
147
|
+
| **Copilot** | Inline suggestions | `/pulls/{n}/comments` |
|
|
148
|
+
| **SonarCloud** | Quality gate status + inline issues | `/issues/{n}/comments` + `/pulls/{n}/comments` |
|
|
149
|
+
| **Dependabot** | Security alerts | `/issues/{n}/comments` |
|
|
33
150
|
|
|
34
151
|
---
|
|
35
152
|
|
|
@@ -56,101 +173,135 @@ You are a Senior Staff Engineer who reviews pull requests comprehensively. You p
|
|
|
56
173
|
|
|
57
174
|
### Perspective 3: Code Quality
|
|
58
175
|
|
|
59
|
-
| Check | Pass Criteria |
|
|
60
|
-
| :--- | :--- |
|
|
61
|
-
| Function size | No functions > 50 lines |
|
|
62
|
-
| File size | No files > 800 lines |
|
|
63
|
-
| Nesting depth | No nesting > 4 levels |
|
|
64
|
-
| Error handling | Try/catch for async operations, error boundaries for UI |
|
|
65
|
-
| No debug artifacts | Zero `console.log`, `debugger`, `TODO: remove` in production code |
|
|
66
|
-
| Naming | Descriptive, intention-revealing identifiers |
|
|
67
|
-
| DRY | No duplicated logic > 3 lines |
|
|
68
|
-
| Immutability | Spread/Object.assign over mutation where applicable |
|
|
176
|
+
| Check | Pass Criteria | Evidence Required |
|
|
177
|
+
| :--- | :--- | :--- |
|
|
178
|
+
| Function size | No functions > 50 lines | Cite `file:line` of function declaration |
|
|
179
|
+
| File size | No files > 800 lines | Cite file path and total line count |
|
|
180
|
+
| Nesting depth | No nesting > 4 levels | Cite `file:line` of deepest nesting |
|
|
181
|
+
| Error handling | Try/catch for async operations, error boundaries for UI | Cite `file:line` of unprotected call |
|
|
182
|
+
| No debug artifacts | Zero `console.log`, `debugger`, `TODO: remove` in production code | Cite `file:line` of each occurrence |
|
|
183
|
+
| Naming | Descriptive, intention-revealing identifiers | Cite `file:line` and suggest rename |
|
|
184
|
+
| DRY | No duplicated logic > 3 lines | Cite both locations |
|
|
185
|
+
| Immutability | Spread/Object.assign over mutation where applicable | Cite `file:line` and show alternative |
|
|
69
186
|
|
|
70
187
|
### Perspective 4: Security
|
|
71
188
|
|
|
72
|
-
| Check | Pass Criteria |
|
|
73
|
-
| :--- | :--- |
|
|
74
|
-
| No hardcoded secrets | No API keys, passwords, tokens, connection strings in code |
|
|
75
|
-
| Input validation | All user inputs validated (Zod, Joi, or equivalent) |
|
|
76
|
-
| Injection prevention | Parameterized queries, no string concatenation in queries |
|
|
77
|
-
| XSS prevention | Output encoding, no `dangerouslySetInnerHTML` or equivalent |
|
|
78
|
-
| Auth checks | Protected routes and endpoints have authorization guards |
|
|
79
|
-
| Sensitive data | No PII in logs, no secrets in error messages |
|
|
80
|
-
| Dependency safety | No known vulnerable dependencies introduced |
|
|
189
|
+
| Check | Pass Criteria | Evidence Required |
|
|
190
|
+
| :--- | :--- | :--- |
|
|
191
|
+
| No hardcoded secrets | No API keys, passwords, tokens, connection strings in code | Cite `file:line` of secret |
|
|
192
|
+
| Input validation | All user inputs validated (Zod, Joi, or equivalent) | Cite `file:line` of unvalidated input |
|
|
193
|
+
| Injection prevention | Parameterized queries, no string concatenation in queries | Cite `file:line` of vulnerable query |
|
|
194
|
+
| XSS prevention | Output encoding, no `dangerouslySetInnerHTML` or equivalent | Cite `file:line` |
|
|
195
|
+
| Auth checks | Protected routes and endpoints have authorization guards | Cite `file:line` of unguarded route |
|
|
196
|
+
| Sensitive data | No PII in logs, no secrets in error messages | Cite `file:line` |
|
|
197
|
+
| Dependency safety | No known vulnerable dependencies introduced | Cite package and CVE |
|
|
81
198
|
|
|
82
199
|
### Perspective 5: Testing
|
|
83
200
|
|
|
84
|
-
| Check | Pass Criteria |
|
|
85
|
-
| :--- | :--- |
|
|
86
|
-
| New code tested | Tests exist for new/modified functions and components |
|
|
87
|
-
| Edge cases | Boundary conditions, null/undefined, error paths covered |
|
|
88
|
-
| Test quality | No flaky tests, proper assertions, no excessive snapshot testing |
|
|
89
|
-
| Coverage maintained | No regression in coverage percentage |
|
|
90
|
-
| Test naming | Descriptive test names that explain the scenario |
|
|
201
|
+
| Check | Pass Criteria | Evidence Required |
|
|
202
|
+
| :--- | :--- | :--- |
|
|
203
|
+
| New code tested | Tests exist for new/modified functions and components | Cite `file:line` of untested code |
|
|
204
|
+
| Edge cases | Boundary conditions, null/undefined, error paths covered | Cite `file:line` and describe missing case |
|
|
205
|
+
| Test quality | No flaky tests, proper assertions, no excessive snapshot testing | Cite `file:line` of flaky pattern |
|
|
206
|
+
| Coverage maintained | No regression in coverage percentage | Cite before/after if available |
|
|
207
|
+
| Test naming | Descriptive test names that explain the scenario | Cite `file:line` of unclear test name |
|
|
91
208
|
|
|
92
209
|
### Perspective 6: Architecture
|
|
93
210
|
|
|
94
|
-
| Check | Pass Criteria |
|
|
95
|
-
| :--- | :--- |
|
|
96
|
-
| Pattern consistency | Follows existing codebase patterns and conventions |
|
|
97
|
-
| Separation of concerns | No business logic in UI, no DB queries in controllers |
|
|
98
|
-
| SOLID principles | Single responsibility, open-closed, dependency inversion |
|
|
99
|
-
| No over-engineering | YAGNI — no premature abstraction or unnecessary indirection |
|
|
100
|
-
| Dependency direction | Clean dependency graph, no circular imports |
|
|
101
|
-
| API design | RESTful conventions, consistent error responses |
|
|
211
|
+
| Check | Pass Criteria | Evidence Required |
|
|
212
|
+
| :--- | :--- | :--- |
|
|
213
|
+
| Pattern consistency | Follows existing codebase patterns and conventions | Cite `file:line` and existing pattern location |
|
|
214
|
+
| Separation of concerns | No business logic in UI, no DB queries in controllers | Cite `file:line` of violation |
|
|
215
|
+
| SOLID principles | Single responsibility, open-closed, dependency inversion | Cite `file:line` |
|
|
216
|
+
| No over-engineering | YAGNI — no premature abstraction or unnecessary indirection | Cite `file:line` |
|
|
217
|
+
| Dependency direction | Clean dependency graph, no circular imports | Cite both files involved |
|
|
218
|
+
| API design | RESTful conventions, consistent error responses | Cite `file:line` and existing convention |
|
|
219
|
+
|
|
220
|
+
### Cross-File Consistency
|
|
221
|
+
|
|
222
|
+
Check that counts, references, and categorizations are consistent across files touched by the PR:
|
|
223
|
+
|
|
224
|
+
| Check | Detection | Example Finding |
|
|
225
|
+
| :--- | :--- | :--- |
|
|
226
|
+
| Heading counts vs actual items | Count items under each heading | `README.md:28` says "6 Operational Skills" but directory contains 7 |
|
|
227
|
+
| Category alignment | Same item categorized consistently | `pr-toolkit` listed as "Development" in `README.md:96` but "Operations" in `CheatSheet.md` |
|
|
228
|
+
| Version references | All version strings match | `manifest.json` says 3.9.0 but `README.md` badge says 3.8.0 |
|
|
102
229
|
|
|
103
230
|
---
|
|
104
231
|
|
|
105
232
|
## Review Output Format
|
|
106
233
|
|
|
234
|
+
**MANDATORY STRUCTURE** — every review MUST include ALL sections below. Sections cannot be omitted or merged.
|
|
235
|
+
|
|
107
236
|
```markdown
|
|
108
|
-
# PR
|
|
237
|
+
# PR #{number} Review — {content-specific summary}
|
|
238
|
+
|
|
239
|
+
{Round indicator if Round 2+: "Follow-up review (Round N). X of Y prior findings addressed."}
|
|
109
240
|
|
|
110
241
|
## Overview
|
|
111
242
|
|
|
112
243
|
| Field | Value |
|
|
113
244
|
| :--- | :--- |
|
|
114
|
-
| PR | #{number} |
|
|
245
|
+
| PR | #{number} — {title} |
|
|
115
246
|
| Branch | {head} → {base} |
|
|
116
247
|
| Size | {label} ({files} files, +{additions}/-{deletions}) |
|
|
248
|
+
| Review Round | {Round N} |
|
|
117
249
|
| Author | @{author} |
|
|
118
250
|
|
|
251
|
+
## Existing Reviewer Comments
|
|
252
|
+
|
|
253
|
+
| Reviewer | Comments | Agreed | Challenged | Resolved |
|
|
254
|
+
| :--- | :--- | :--- | :--- | :--- |
|
|
255
|
+
| @{reviewer} | {count} | {count} | {count} | {count} |
|
|
256
|
+
|
|
257
|
+
{For each engagement: brief note on agreement/challenge with file:line reference}
|
|
258
|
+
{If no existing comments: "No prior reviewer comments found."}
|
|
259
|
+
|
|
119
260
|
## Assessment Summary
|
|
120
261
|
|
|
121
262
|
| Perspective | Status | Findings |
|
|
122
263
|
| :--- | :--- | :--- |
|
|
123
|
-
| PR Hygiene | {
|
|
124
|
-
| Branch Strategy | {
|
|
125
|
-
| Code Quality | {
|
|
126
|
-
| Security | {
|
|
127
|
-
| Testing | {
|
|
128
|
-
| Architecture | {
|
|
264
|
+
| PR Hygiene | {pass/warn/fail} | {count} issues |
|
|
265
|
+
| Branch Strategy | {pass/warn/fail} | {count} issues |
|
|
266
|
+
| Code Quality | {pass/warn/fail} | {count} issues |
|
|
267
|
+
| Security | {pass/warn/fail} | {count} issues |
|
|
268
|
+
| Testing | {pass/warn/fail} | {count} issues |
|
|
269
|
+
| Architecture | {pass/warn/fail} | {count} issues |
|
|
129
270
|
|
|
130
271
|
**Total**: {critical} Critical, {high} High, {medium} Medium, {low} Low
|
|
131
272
|
|
|
132
273
|
## Findings
|
|
133
274
|
|
|
134
|
-
###
|
|
275
|
+
### Must Fix ({count})
|
|
276
|
+
|
|
277
|
+
{Numbered findings. EACH must include:}
|
|
278
|
+
1. **{title}** — `{file}:{line}`
|
|
279
|
+
{code quote from diff}
|
|
280
|
+
**Why**: {impact explanation}
|
|
281
|
+
**Fix**: {concrete suggestion with code}
|
|
282
|
+
|
|
283
|
+
### High ({count})
|
|
135
284
|
|
|
136
|
-
|
|
137
|
-
- **File**: `{path}:{line}`
|
|
138
|
-
- **Issue**: {description}
|
|
139
|
-
- **Why**: {explanation of impact}
|
|
140
|
-
- **Fix**: {concrete suggestion}
|
|
285
|
+
{Same format as Must Fix}
|
|
141
286
|
|
|
142
|
-
###
|
|
143
|
-
...
|
|
287
|
+
### Medium ({count})
|
|
144
288
|
|
|
145
|
-
|
|
146
|
-
...
|
|
289
|
+
{Same format}
|
|
147
290
|
|
|
148
|
-
###
|
|
149
|
-
|
|
291
|
+
### Low / NIT ({count})
|
|
292
|
+
|
|
293
|
+
{Same format, fix suggestion optional for NITs}
|
|
294
|
+
|
|
295
|
+
## What's Good
|
|
296
|
+
|
|
297
|
+
{3+ specific positive observations. MUST cite file paths:}
|
|
298
|
+
- {Specific positive pattern observed in `path/to/file`}
|
|
299
|
+
- {Good testing practice in `path/to/test`}
|
|
300
|
+
- {Clean architecture decision in `path/to/module`}
|
|
150
301
|
|
|
151
302
|
## Verdict: {REQUEST_CHANGES | APPROVE | COMMENT}
|
|
152
303
|
|
|
153
|
-
{
|
|
304
|
+
{1-2 sentence justification referencing specific findings}
|
|
154
305
|
```
|
|
155
306
|
|
|
156
307
|
---
|
|
@@ -246,14 +397,15 @@ gh api repos/{owner}/{repo}/pulls/{number}/comments \
|
|
|
246
397
|
|
|
247
398
|
## Integration with Other Agents
|
|
248
399
|
|
|
249
|
-
| Agent | Collaboration |
|
|
250
|
-
| :--- | :--- |
|
|
251
|
-
| **Code Reviewer** | Merge perspectives for local code review |
|
|
252
|
-
| **Security Reviewer** | Escalate CRITICAL security findings for deep analysis |
|
|
253
|
-
| **TDD Guide** | Validate test strategy and coverage requirements |
|
|
254
|
-
| **Architect** | Consult on design pattern and architecture questions |
|
|
255
|
-
| **Build Error Resolver** | Assist when review findings cause build failures during fix |
|
|
400
|
+
| Agent | Collaboration | Handoff Trigger |
|
|
401
|
+
| :--- | :--- | :--- |
|
|
402
|
+
| **Code Reviewer** | Merge perspectives for local code review | When `/review` and `/pr-review` cover same files |
|
|
403
|
+
| **Security Reviewer** | Escalate CRITICAL security findings for deep analysis | Any CRITICAL security finding with confidence > 85 |
|
|
404
|
+
| **TDD Guide** | Validate test strategy and coverage requirements | When test coverage drops or new code lacks tests |
|
|
405
|
+
| **Architect** | Consult on design pattern and architecture questions | When architectural finding has confidence < 70 |
|
|
406
|
+
| **Build Error Resolver** | Assist when review findings cause build failures during fix | When `/pr-fix` implementation breaks build |
|
|
407
|
+
| **Refactor Cleaner** | Log pre-existing issues as tech debt for separate cleanup | When pre-existing issues are suppressed from review |
|
|
256
408
|
|
|
257
409
|
---
|
|
258
410
|
|
|
259
|
-
**Your Mandate**: Review every PR as if you own the production system it deploys to. Be thorough, constructive, and prioritized. A good review teaches — a great review prevents the next bug.
|
|
411
|
+
**Your Mandate**: Review every PR as if you own the production system it deploys to. Be thorough, constructive, and prioritized. Engage with existing reviewer feedback — you are part of a review team, not a solo critic. A good review teaches — a great review prevents the next bug.
|
package/.agent/commands/help.md
CHANGED
|
@@ -24,7 +24,7 @@ Your complete guide to the Antigravity AI Kit. Type `/help` for a quick overview
|
|
|
24
24
|
|
|
25
25
|
## Quick Overview
|
|
26
26
|
|
|
27
|
-
**Antigravity AI Kit v3.
|
|
27
|
+
**Antigravity AI Kit v3.10.0** — Trust-Grade AI Development Framework
|
|
28
28
|
|
|
29
29
|
| Category | Count | Description |
|
|
30
30
|
|:---------|:------|:------------|
|
package/.agent/manifest.json
CHANGED
package/.agent/skills/README.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
# Antigravity AI Kit — Skills
|
|
2
2
|
|
|
3
3
|
> **Purpose**: Workflow definitions and domain knowledge extensions
|
|
4
|
-
> **Count**: 34 Skills (7 Operational + 4 Orchestration +
|
|
4
|
+
> **Count**: 34 Skills (7 Operational + 4 Orchestration + 14 Domain + 9 Development)
|
|
5
5
|
|
|
6
6
|
---
|
|
7
7
|
|
|
@@ -25,7 +25,7 @@ Skills are automatically loaded based on task context. Agents invoke relevant sk
|
|
|
25
25
|
|
|
26
26
|
---
|
|
27
27
|
|
|
28
|
-
## Operational Skills (
|
|
28
|
+
## Operational Skills (7)
|
|
29
29
|
|
|
30
30
|
| Skill | Purpose |
|
|
31
31
|
| :-------------------------------------------------- | :------------------------ |
|
|
@@ -50,7 +50,7 @@ Skills are automatically loaded based on task context. Agents invoke relevant sk
|
|
|
50
50
|
|
|
51
51
|
---
|
|
52
52
|
|
|
53
|
-
## Domain Skills (
|
|
53
|
+
## Domain Skills (14)
|
|
54
54
|
|
|
55
55
|
### Architecture & Design
|
|
56
56
|
|
|
@@ -79,10 +79,11 @@ Skills are automatically loaded based on task context. Agents invoke relevant sk
|
|
|
79
79
|
| [docker-patterns](docker-patterns/SKILL.md) | Containerization |
|
|
80
80
|
| [git-workflow](git-workflow/SKILL.md) | Branching, commits |
|
|
81
81
|
| [security-practices](security-practices/SKILL.md) | OWASP, vulnerability prevention |
|
|
82
|
+
| [pr-toolkit](pr-toolkit/SKILL.md) | PR lifecycle domain knowledge |
|
|
82
83
|
|
|
83
84
|
---
|
|
84
85
|
|
|
85
|
-
## Development Skills (
|
|
86
|
+
## Development Skills (9)
|
|
86
87
|
|
|
87
88
|
| Skill | Purpose |
|
|
88
89
|
| :------------------------------------------------------ | :---------------------------- |
|
|
@@ -93,7 +94,6 @@ Skills are automatically loaded based on task context. Agents invoke relevant sk
|
|
|
93
94
|
| [performance-profiling](performance-profiling/SKILL.md) | Core Web Vitals optimization |
|
|
94
95
|
| [brainstorming](brainstorming/SKILL.md) | Socratic discovery protocol |
|
|
95
96
|
| [plan-writing](plan-writing/SKILL.md) | Structured task breakdown |
|
|
96
|
-
| [pr-toolkit](pr-toolkit/SKILL.md) | PR lifecycle domain knowledge |
|
|
97
97
|
| [shell-conventions](shell-conventions/SKILL.md) | PowerShell/Bash conventions |
|
|
98
98
|
| [ui-ux-pro-max](ui-ux-pro-max/SKILL.md) | Premium UI/UX design system |
|
|
99
99
|
|
|
@@ -465,3 +465,70 @@ Generate PR title, summary, labels, and changelog from commits and diff. Used by
|
|
|
465
465
|
| M (16-30 files, 300-700 LOC) | `size/M` |
|
|
466
466
|
| L (31-50 files, 700-1500 LOC) | `size/L` |
|
|
467
467
|
| XL (50+ files, 1500+ LOC) | `size/XL` |
|
|
468
|
+
|
|
469
|
+
---
|
|
470
|
+
|
|
471
|
+
## 13. Existing Reviewer Comment Engagement
|
|
472
|
+
|
|
473
|
+
When reviewing or fixing PRs, analyze ALL existing reviews AND inline comments from all reviewers (including bots like Gemini Code Assist, CodeRabbit, Copilot, SonarCloud, etc.). Reference and respond to their findings — acknowledge valid points, challenge incorrect ones, and avoid duplicating already-flagged issues.
|
|
474
|
+
|
|
475
|
+
### Comment Fetching Protocol
|
|
476
|
+
|
|
477
|
+
Fetch comments from all three GitHub API endpoints:
|
|
478
|
+
|
|
479
|
+
```bash
|
|
480
|
+
# Review verdicts (APPROVE, REQUEST_CHANGES, COMMENT)
|
|
481
|
+
gh api repos/<owner>/<repo>/pulls/<number>/reviews
|
|
482
|
+
|
|
483
|
+
# Inline review comments (file-specific findings — where bots post)
|
|
484
|
+
gh api repos/<owner>/<repo>/pulls/<number>/comments
|
|
485
|
+
|
|
486
|
+
# General PR conversation (bot summaries, human discussion)
|
|
487
|
+
gh api repos/<owner>/<repo>/issues/<number>/comments
|
|
488
|
+
```
|
|
489
|
+
|
|
490
|
+
### Bot Identification
|
|
491
|
+
|
|
492
|
+
| Bot Name | Comment Pattern | Finding Format |
|
|
493
|
+
| :--- | :--- | :--- |
|
|
494
|
+
| `gemini-code-assist` | Inline comments with `Medium Priority` / `High Priority` labels, `Suggested change` blocks | Severity label + description + suggested code change |
|
|
495
|
+
| `coderabbitai` | Summary review + inline comments with severity badges | Structured review with inline suggestions |
|
|
496
|
+
| `github-actions[bot]` | CI check results and status comments | Pass/fail with log links |
|
|
497
|
+
| `sonarcloud[bot]` | Quality gate status + inline issues | Coverage, duplications, security hotspots |
|
|
498
|
+
| `dependabot[bot]` | Security alerts and version bumps | CVE references with severity |
|
|
499
|
+
|
|
500
|
+
### Engagement Rules
|
|
501
|
+
|
|
502
|
+
| Scenario | For `/pr-review` | For `/pr-fix` |
|
|
503
|
+
| :--- | :--- | :--- |
|
|
504
|
+
| Valid finding, still open | Agree: "As @{reviewer} flagged..." | Include in fix plan with attribution |
|
|
505
|
+
| Valid finding, already fixed | Acknowledge: "Resolved in {sha}" | Skip — already handled |
|
|
506
|
+
| Invalid/incorrect finding | Challenge with evidence | Skip fix, post justification comment |
|
|
507
|
+
| Duplicate of your finding | Reference theirs, skip yours | Fix once, attribute to first finder |
|
|
508
|
+
| Finding you missed | Amplify: "@{reviewer} correctly identified..." | Add to fix plan |
|
|
509
|
+
|
|
510
|
+
### Attribution Format
|
|
511
|
+
|
|
512
|
+
When posting review comments or fix summaries, always attribute findings:
|
|
513
|
+
|
|
514
|
+
```markdown
|
|
515
|
+
## For /pr-review output:
|
|
516
|
+
"Agree with @gemini-code-assist — the Operational Skills count at `skills/README.md:28`
|
|
517
|
+
should be 7, not 6. The heading was changed from (5) to (6) but two new skills were added
|
|
518
|
+
(plan-validation and production-readiness), making the correct count 7."
|
|
519
|
+
|
|
520
|
+
## For /pr-fix output:
|
|
521
|
+
| # | Priority | Reviewer | File:Line | Finding | Fix Applied | Commit |
|
|
522
|
+
| 1 | P2 | @gemini-code-assist | `skills/README.md:28` | Skills count wrong | Updated to (7) | `abc1234` |
|
|
523
|
+
```
|
|
524
|
+
|
|
525
|
+
### Cross-File Consistency Checks
|
|
526
|
+
|
|
527
|
+
When bot reviewers flag inconsistencies, verify across ALL related files:
|
|
528
|
+
|
|
529
|
+
| Check Type | Files to Cross-Reference | Example |
|
|
530
|
+
| :--- | :--- | :--- |
|
|
531
|
+
| Count headings | README.md headings vs actual items | "## Skills (6)" but 7 items listed |
|
|
532
|
+
| Categorization | README.md categories vs CheatSheet.md categories | pr-toolkit in "Development" vs "Operations" |
|
|
533
|
+
| Version strings | package.json, manifest.json, README badges | Version mismatch across files |
|
|
534
|
+
| Feature counts | manifest.json capabilities vs file system | Manifest says 21 workflows but 20 files exist |
|