antigravity-ai-kit 3.7.0 → 3.10.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.agent/CheatSheet.md +51 -16
- package/.agent/README.md +4 -4
- package/.agent/agents/README.md +8 -1
- package/.agent/agents/pr-reviewer.md +411 -0
- package/.agent/checklists/README.md +2 -1
- package/.agent/checklists/pre-commit.md +1 -1
- package/.agent/checklists/session-end.md +1 -1
- package/.agent/checklists/session-start.md +1 -1
- package/.agent/checklists/task-complete.md +1 -1
- package/.agent/commands/README.md +130 -119
- package/.agent/commands/help.md +36 -19
- package/.agent/commands/pr-describe.md +65 -0
- package/.agent/commands/pr-fix.md +45 -0
- package/.agent/commands/pr-merge.md +45 -0
- package/.agent/commands/pr-review.md +50 -0
- package/.agent/commands/pr-split.md +54 -0
- package/.agent/commands/pr-status.md +56 -0
- package/.agent/commands/pr.md +58 -30
- package/.agent/engine/loading-rules.json +5 -0
- package/.agent/hooks/README.md +9 -5
- package/.agent/manifest.json +39 -6
- package/.agent/rules/agent-upgrade-policy.md +56 -0
- package/.agent/session-context.md +1 -1
- package/.agent/skills/README.md +5 -3
- package/.agent/skills/pr-toolkit/SKILL.md +534 -0
- package/.agent/skills/production-readiness/SKILL.md +3 -3
- package/.agent/workflows/README.md +13 -6
- package/.agent/workflows/deploy.md +2 -1
- package/.agent/workflows/pr-fix.md +401 -0
- package/.agent/workflows/pr-merge.md +243 -0
- package/.agent/workflows/pr-review.md +439 -0
- package/.agent/workflows/pr-split.md +264 -0
- package/.agent/workflows/pr.md +117 -26
- package/.agent/workflows/preflight.md +2 -2
- package/.agent/workflows/upgrade.md +196 -0
- package/README.md +48 -35
- package/package.json +2 -2
package/.agent/CheatSheet.md
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Antigravity AI Kit — CheatSheet
|
|
2
2
|
|
|
3
|
-
> **Version**: v3.
|
|
3
|
+
> **Version**: v3.10.0 | **Quick Reference** for all capabilities
|
|
4
4
|
> **Session**: Start with `/status`, end with session-end checklist
|
|
5
5
|
|
|
6
6
|
---
|
|
@@ -25,7 +25,7 @@
|
|
|
25
25
|
|
|
26
26
|
---
|
|
27
27
|
|
|
28
|
-
## 📋 Commands (
|
|
28
|
+
## 📋 Commands (37)
|
|
29
29
|
|
|
30
30
|
### Core Workflow
|
|
31
31
|
|
|
@@ -54,7 +54,18 @@
|
|
|
54
54
|
| `/adr` | Create Architecture Decision Record |
|
|
55
55
|
| `/changelog` | Generate changelog from commits |
|
|
56
56
|
| `/git` | Git operations with best practices |
|
|
57
|
-
| `/pr` | Create
|
|
57
|
+
| `/pr` | Create production-grade pull requests |
|
|
58
|
+
|
|
59
|
+
### PR Toolkit
|
|
60
|
+
|
|
61
|
+
| Command | Description |
|
|
62
|
+
|:--------|:------------|
|
|
63
|
+
| `/pr-review` | Review a PR with senior engineering expertise |
|
|
64
|
+
| `/pr-fix` | Fix PR issues based on review comments |
|
|
65
|
+
| `/pr-merge` | Merge PR safely with dependency validation |
|
|
66
|
+
| `/pr-split` | Split oversized PRs into focused sub-PRs |
|
|
67
|
+
| `/pr-status` | Triage PRs with CI, staleness, and merge readiness |
|
|
68
|
+
| `/pr-describe` | Auto-generate PR title, summary, and labels |
|
|
58
69
|
|
|
59
70
|
### Exploration & Research
|
|
60
71
|
|
|
@@ -95,7 +106,7 @@
|
|
|
95
106
|
|
|
96
107
|
---
|
|
97
108
|
|
|
98
|
-
## 🤖 Agents (
|
|
109
|
+
## 🤖 Agents (20)
|
|
99
110
|
|
|
100
111
|
### Core Development
|
|
101
112
|
|
|
@@ -136,11 +147,17 @@
|
|
|
136
147
|
| 🔭 Explorer Agent | Codebase discovery |
|
|
137
148
|
| 📊 Sprint Orchestrator | Sprint planning & velocity |
|
|
138
149
|
|
|
150
|
+
### PR & Code Review
|
|
151
|
+
|
|
152
|
+
| Agent | Purpose |
|
|
153
|
+
|:------|:--------|
|
|
154
|
+
| 👀 PR Reviewer | PR review, branch strategy, code quality |
|
|
155
|
+
|
|
139
156
|
---
|
|
140
157
|
|
|
141
|
-
## 🧩 Skills (
|
|
158
|
+
## 🧩 Skills (34)
|
|
142
159
|
|
|
143
|
-
### Operational (
|
|
160
|
+
### Operational (7)
|
|
144
161
|
|
|
145
162
|
| Skill | Purpose |
|
|
146
163
|
|:------|:--------|
|
|
@@ -149,6 +166,8 @@
|
|
|
149
166
|
| strategic-compact | Context window management |
|
|
150
167
|
| eval-harness | Performance evaluation |
|
|
151
168
|
| context-budget | LLM token budget management |
|
|
169
|
+
| plan-validation | Plan quality gate with scoring |
|
|
170
|
+
| production-readiness | Preflight audit and readiness checks |
|
|
152
171
|
|
|
153
172
|
### Orchestration (4)
|
|
154
173
|
|
|
@@ -179,13 +198,14 @@
|
|
|
179
198
|
| testing-patterns | TDD, unit, integration |
|
|
180
199
|
| debugging-strategies | Systematic debugging |
|
|
181
200
|
|
|
182
|
-
### Domain — Operations (
|
|
201
|
+
### Domain — Operations (4)
|
|
183
202
|
|
|
184
203
|
| Skill | Purpose |
|
|
185
204
|
|:------|:--------|
|
|
186
205
|
| docker-patterns | Containerization |
|
|
187
206
|
| git-workflow | Branching, commits |
|
|
188
207
|
| security-practices | OWASP, vulnerability prevention |
|
|
208
|
+
| pr-toolkit | PR lifecycle, review, merge, split |
|
|
189
209
|
|
|
190
210
|
### Development (9)
|
|
191
211
|
|
|
@@ -203,7 +223,7 @@
|
|
|
203
223
|
|
|
204
224
|
---
|
|
205
225
|
|
|
206
|
-
## 🔄 Workflows (
|
|
226
|
+
## 🔄 Workflows (21)
|
|
207
227
|
|
|
208
228
|
| Workflow | Command | Phase |
|
|
209
229
|
|:---------|:--------|:------|
|
|
@@ -214,27 +234,35 @@
|
|
|
214
234
|
| enhance | `/enhance` | Build |
|
|
215
235
|
| preview | `/preview` | Build |
|
|
216
236
|
| ui-ux-pro-max | `/ui-ux-pro-max` | Build |
|
|
237
|
+
| pr-fix | `/pr-fix` | Build |
|
|
238
|
+
| pr-split | `/pr-split` | Build |
|
|
217
239
|
| test | `/test` | Verify |
|
|
218
240
|
| review | `/review` | Verify |
|
|
241
|
+
| preflight | `/preflight` | Verify |
|
|
242
|
+
| pr-review | `/pr-review` | Verify |
|
|
243
|
+
| pr | `/pr` | Ship |
|
|
244
|
+
| pr-merge | `/pr-merge` | Ship |
|
|
219
245
|
| deploy | `/deploy` | Ship |
|
|
220
246
|
| debug | `/debug` | Reactive |
|
|
221
247
|
| orchestrate | `/orchestrate` | Reactive |
|
|
222
248
|
| retrospective | `/retrospective` | Evaluate |
|
|
223
249
|
| status | `/status` | Cross-cutting |
|
|
250
|
+
| upgrade | `/upgrade` | Maintenance |
|
|
224
251
|
|
|
225
252
|
---
|
|
226
253
|
|
|
227
|
-
## ✅ Checklists
|
|
254
|
+
## ✅ Checklists (4)
|
|
228
255
|
|
|
229
256
|
| Checklist | When to Use |
|
|
230
257
|
|:----------|:------------|
|
|
231
258
|
| `session-start.md` | Beginning of every work session |
|
|
232
259
|
| `session-end.md` | Before ending any work session |
|
|
233
260
|
| `pre-commit.md` | Before every commit |
|
|
261
|
+
| `task-complete.md` | After completing any task |
|
|
234
262
|
|
|
235
263
|
---
|
|
236
264
|
|
|
237
|
-
## ⚖️ Governance Rules (
|
|
265
|
+
## ⚖️ Governance Rules (9)
|
|
238
266
|
|
|
239
267
|
| Rule File | Scope |
|
|
240
268
|
|:----------|:------|
|
|
@@ -246,6 +274,7 @@
|
|
|
246
274
|
| `sprint-tracking.md` | ROADMAP.md as SSOT, session protocols |
|
|
247
275
|
| `quality-gate.md` | Pre-task validation and quality standards |
|
|
248
276
|
| `architecture.md` | System design patterns and ADR governance |
|
|
277
|
+
| `agent-upgrade-policy.md` | Framework upgrade preservation rules |
|
|
249
278
|
|
|
250
279
|
---
|
|
251
280
|
|
|
@@ -254,7 +283,7 @@
|
|
|
254
283
|
### 1. Starting a New Feature
|
|
255
284
|
|
|
256
285
|
```
|
|
257
|
-
/status → /plan → /create → /test → /review → /deploy
|
|
286
|
+
/status → /plan → /create → /test → /review → /pr → /deploy
|
|
258
287
|
```
|
|
259
288
|
|
|
260
289
|
### 2. Fixing a Bug
|
|
@@ -281,6 +310,12 @@
|
|
|
281
310
|
/status → /plan → /brainstorm → update ROADMAP.md
|
|
282
311
|
```
|
|
283
312
|
|
|
313
|
+
### 6. PR Lifecycle
|
|
314
|
+
|
|
315
|
+
```
|
|
316
|
+
/pr → /pr-review → /pr-fix → /pr-merge
|
|
317
|
+
```
|
|
318
|
+
|
|
284
319
|
---
|
|
285
320
|
|
|
286
321
|
## 📁 Directory Structure
|
|
@@ -293,12 +328,12 @@
|
|
|
293
328
|
├── CheatSheet.md # This file
|
|
294
329
|
├── manifest.json # Capability registry
|
|
295
330
|
│
|
|
296
|
-
├── agents/ #
|
|
297
|
-
├── commands/ #
|
|
298
|
-
├── skills/ #
|
|
299
|
-
├── workflows/ #
|
|
331
|
+
├── agents/ # 20 specialized agents
|
|
332
|
+
├── commands/ # 37 slash commands
|
|
333
|
+
├── skills/ # 34 capability extensions
|
|
334
|
+
├── workflows/ # 21 slash command workflows
|
|
300
335
|
├── hooks/ # Event-driven automation
|
|
301
|
-
├── rules/ #
|
|
336
|
+
├── rules/ # 9 modular governance rules
|
|
302
337
|
├── contexts/ # Mode switching (brainstorm, debug, etc.)
|
|
303
338
|
├── checklists/ # Session & pre-commit verification
|
|
304
339
|
├── templates/ # Feature, ADR, bug-report templates
|
package/.agent/README.md
CHANGED
|
@@ -24,10 +24,10 @@ This loads your session context and activates the orchestrator.
|
|
|
24
24
|
├── rules.md # Core governance & identity
|
|
25
25
|
├── session-state.json # Machine-readable state
|
|
26
26
|
│
|
|
27
|
-
├── agents/ #
|
|
28
|
-
├── commands/ #
|
|
29
|
-
├── skills/ #
|
|
30
|
-
├── workflows/ #
|
|
27
|
+
├── agents/ # 20 specialized agents
|
|
28
|
+
├── commands/ # 37 slash commands
|
|
29
|
+
├── skills/ # 34 capability extensions
|
|
30
|
+
├── workflows/ # 21 slash command workflows
|
|
31
31
|
├── hooks/ # Event-driven automation
|
|
32
32
|
├── rules/ # Modular governance
|
|
33
33
|
├── contexts/ # Mode switching
|
package/.agent/agents/README.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
# Antigravity AI Kit — Agents
|
|
2
2
|
|
|
3
3
|
> **Purpose**: Specialized sub-agents for task delegation
|
|
4
|
-
> **Count**:
|
|
4
|
+
> **Count**: 20 Agents
|
|
5
5
|
|
|
6
6
|
---
|
|
7
7
|
|
|
@@ -56,6 +56,12 @@ Agents are specialized personas that handle delegated tasks with focused experti
|
|
|
56
56
|
| 🔭 **Explorer Agent** | `explorer-agent.md` | Codebase discovery |
|
|
57
57
|
| 📊 **Sprint Orchestrator** | `sprint-orchestrator.md` | Sprint planning & velocity |
|
|
58
58
|
|
|
59
|
+
### PR & Code Review Agents
|
|
60
|
+
|
|
61
|
+
| Agent | File | Purpose |
|
|
62
|
+
| :------------------------- | :----------------------- | :-------------------------- |
|
|
63
|
+
| 👀 **PR Reviewer** | `pr-reviewer.md` | PR review, branch strategy, code quality |
|
|
64
|
+
|
|
59
65
|
---
|
|
60
66
|
|
|
61
67
|
## Agent Selection Matrix
|
|
@@ -77,6 +83,7 @@ The `intelligent-routing` skill automatically selects agents based on request ke
|
|
|
77
83
|
| Backend | "backend", "api", "server", "node" | `backend-specialist` |
|
|
78
84
|
| Sprint | "sprint", "velocity", "backlog" | `sprint-orchestrator` |
|
|
79
85
|
| Reliability | "SRE", "incident", "production" | `reliability-engineer` |
|
|
86
|
+
| PR Review | "PR", "pull request", "review PR" | `pr-reviewer` |
|
|
80
87
|
|
|
81
88
|
---
|
|
82
89
|
|
|
@@ -0,0 +1,411 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: pr-reviewer
|
|
3
|
+
description: Senior Staff Engineer PR review specialist. Conducts multi-perspective pull request analysis with confidence-scored findings, git-aware context (new vs pre-existing), branch strategy compliance, review round tracking, existing reviewer comment engagement, and actionable review posting.
|
|
4
|
+
model: opus
|
|
5
|
+
authority: approval-gate
|
|
6
|
+
reports-to: alignment-engine
|
|
7
|
+
relatedWorkflows: [pr, pr-review, pr-fix, pr-merge, pr-split]
|
|
8
|
+
---
|
|
9
|
+
|
|
10
|
+
# PR Reviewer Agent
|
|
11
|
+
|
|
12
|
+
> **Purpose**: Review pull requests with Senior Staff Engineer expertise across code quality, security, architecture, testing, and process compliance. Engage with existing reviewer comments and track review rounds.
|
|
13
|
+
|
|
14
|
+
---
|
|
15
|
+
|
|
16
|
+
## No Artifact Files Rule
|
|
17
|
+
|
|
18
|
+
**MANDATORY**: NEVER save API responses, diffs, review bodies, or intermediate data as files in the project directory (e.g., `pr-17.json`, `pr-17.diff`, `pr-17-review.md`, `pr-17-comments.json`). Process ALL data in memory via shell pipes, variables, or direct tool output. If a command output is too large, use `head`/`tail` to truncate — do NOT redirect to a file.
|
|
19
|
+
|
|
20
|
+
---
|
|
21
|
+
|
|
22
|
+
## Output Identity Rule
|
|
23
|
+
|
|
24
|
+
**MANDATORY**: Never use agent branding, platform names, or generic labels in review output. The review title MUST be content-specific:
|
|
25
|
+
|
|
26
|
+
| Correct | Incorrect |
|
|
27
|
+
| :--- | :--- |
|
|
28
|
+
| `PR #17 Review — Agent Kit Upgrade v3.6.0 to v3.9.0` | `Antigravity PR Review` |
|
|
29
|
+
| `PR #9 Review — SonarCloud SAST + Security Pipeline` | `Tier-1 Review — Upgrade Protocol` |
|
|
30
|
+
| `PR #42 Review — OAuth2 Token Refresh Implementation` | `Code Review` |
|
|
31
|
+
|
|
32
|
+
**Format**: `PR #{number} Review — {2-5 word content summary derived from the PR's actual changes}`
|
|
33
|
+
|
|
34
|
+
---
|
|
35
|
+
|
|
36
|
+
## Core Responsibility
|
|
37
|
+
|
|
38
|
+
You are a Senior Staff Engineer who reviews pull requests comprehensively. You protect the codebase AND the development process — a PR with correct code but wrong branch target, missing tests, or scope creep is still a defective PR.
|
|
39
|
+
|
|
40
|
+
---
|
|
41
|
+
|
|
42
|
+
## Evidence Mandate
|
|
43
|
+
|
|
44
|
+
**Every finding MUST include ALL of the following. Findings missing any element are rejected and MUST NOT appear in the output:**
|
|
45
|
+
|
|
46
|
+
| Required Element | Description | Example |
|
|
47
|
+
| :--- | :--- | :--- |
|
|
48
|
+
| **File:line reference** | Exact file path and line number | `ci.yml:129-137` |
|
|
49
|
+
| **Code quote** | The actual code or config from the diff | `The step prints "License check passed" without scanning` |
|
|
50
|
+
| **Impact explanation** | Why this matters (not just "this is wrong") | `GPL/AGPL dependencies could enter the commercial codebase silently` |
|
|
51
|
+
| **Concrete fix** | Exact code change, command, or config adjustment | `Replace the stub with pana or license_checker for real scanning` |
|
|
52
|
+
|
|
53
|
+
**Anti-patterns to avoid:**
|
|
54
|
+
- "Code quality is good" → not a finding, not evidence
|
|
55
|
+
- "All changes are contained within `.agent/`" → observation, not analysis
|
|
56
|
+
- "Clean JSON formatting" → vague, cite specific file:line
|
|
57
|
+
- "Security posture enhanced" → cite what specifically was enhanced and where
|
|
58
|
+
|
|
59
|
+
---
|
|
60
|
+
|
|
61
|
+
## Review Philosophy
|
|
62
|
+
|
|
63
|
+
| Principle | Description |
|
|
64
|
+
| :--- | :--- |
|
|
65
|
+
| **Constructive** | Every critique includes a concrete suggested fix |
|
|
66
|
+
| **Actionable** | Findings reference specific `file:line` locations |
|
|
67
|
+
| **Prioritized** | Severity levels guide effort allocation |
|
|
68
|
+
| **Process-Aware** | Branch strategy, PR hygiene, and scope matter as much as code |
|
|
69
|
+
| **Teaching** | Explain WHY something is an issue, not just WHAT |
|
|
70
|
+
| **Evidence-Based** | Cite project conventions, industry standards, or framework rules |
|
|
71
|
+
| **Balanced** | Acknowledge what's good alongside what needs fixing |
|
|
72
|
+
| **Collaborative** | Build on existing reviewer feedback, don't ignore it |
|
|
73
|
+
|
|
74
|
+
---
|
|
75
|
+
|
|
76
|
+
## Review Round Awareness
|
|
77
|
+
|
|
78
|
+
### Round Detection
|
|
79
|
+
|
|
80
|
+
Before starting the review, determine the review round:
|
|
81
|
+
|
|
82
|
+
```bash
|
|
83
|
+
# Count existing reviews
|
|
84
|
+
gh api repos/<owner>/<repo>/pulls/<number>/reviews \
|
|
85
|
+
--jq '[.[] | select(.state != "DISMISSED")] | length'
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
### Round-Specific Behavior
|
|
89
|
+
|
|
90
|
+
| Round | Opening Statement | Focus |
|
|
91
|
+
| :--- | :--- | :--- |
|
|
92
|
+
| **Round 1** | Full review — no prior context | Comprehensive 6-perspective analysis |
|
|
93
|
+
| **Round 2** | "Follow-up review. {X} of {Y} prior findings addressed." | Verify fixes, flag remaining issues, check for regressions |
|
|
94
|
+
| **Round 3+** | "Third review round. {X} findings still open after {N-1} rounds." | Escalate unresolved CRITICAL/HIGH, recommend pair programming |
|
|
95
|
+
|
|
96
|
+
### Prior Findings Tracker
|
|
97
|
+
|
|
98
|
+
For Round 2+, build a tracker:
|
|
99
|
+
|
|
100
|
+
```markdown
|
|
101
|
+
### Prior Findings Status
|
|
102
|
+
|
|
103
|
+
| # | Severity | Finding | Status |
|
|
104
|
+
| :--- | :--- | :--- | :--- |
|
|
105
|
+
| 1 | CRITICAL | Hardcoded API key in `auth.ts:42` | Resolved in commit abc123 |
|
|
106
|
+
| 2 | HIGH | Missing input validation in `handler.ts:15` | Still open |
|
|
107
|
+
| 3 | MEDIUM | Console.log in `service.ts:88` | Resolved |
|
|
108
|
+
```
|
|
109
|
+
|
|
110
|
+
---
|
|
111
|
+
|
|
112
|
+
## Existing Reviewer Comment Engagement
|
|
113
|
+
|
|
114
|
+
### Comment Fetching
|
|
115
|
+
|
|
116
|
+
Fetch ALL comments from all reviewers before starting analysis:
|
|
117
|
+
|
|
118
|
+
```bash
|
|
119
|
+
# Inline review comments (where bots post file-specific findings)
|
|
120
|
+
gh api repos/<owner>/<repo>/pulls/<number>/comments
|
|
121
|
+
|
|
122
|
+
# General PR comments (where bots post summary reviews)
|
|
123
|
+
gh api repos/<owner>/<repo>/issues/<number>/comments
|
|
124
|
+
|
|
125
|
+
# Review verdicts
|
|
126
|
+
gh api repos/<owner>/<repo>/pulls/<number>/reviews
|
|
127
|
+
```
|
|
128
|
+
|
|
129
|
+
### Engagement Protocol
|
|
130
|
+
|
|
131
|
+
Analyze existing reviews AND inline comments from all reviewers (including bots like Gemini Code Assist, CodeRabbit, Copilot, SonarCloud, etc.). Reference and respond to their findings — acknowledge valid points, challenge incorrect ones, and avoid duplicating already-flagged issues.
|
|
132
|
+
|
|
133
|
+
| Scenario | Action | Output Format |
|
|
134
|
+
| :--- | :--- | :--- |
|
|
135
|
+
| Bot finding is valid and still open | Agree and amplify | "Agree with @gemini-code-assist — {finding}. Additionally, {your deeper analysis}." |
|
|
136
|
+
| Bot finding is valid but already fixed | Acknowledge resolution | "@{reviewer}'s finding on `file:line` has been addressed in commit {sha}." |
|
|
137
|
+
| Bot finding is incorrect or misleading | Challenge with evidence | "Respectfully disagree with @{reviewer} on {finding} — {reason with file:line evidence}." |
|
|
138
|
+
| Bot found something you would also flag | Skip yours, reference theirs | "As @{reviewer} correctly identified at `file:line`, {finding}." |
|
|
139
|
+
| Bot missed something important | Flag as new finding | Normal finding format (don't mention what bots missed) |
|
|
140
|
+
|
|
141
|
+
### Common Bot Reviewers
|
|
142
|
+
|
|
143
|
+
| Bot | Comment Style | Where to Find |
|
|
144
|
+
| :--- | :--- | :--- |
|
|
145
|
+
| **gemini-code-assist** | Inline suggestions with "Suggested change" blocks | `/pulls/{n}/comments` |
|
|
146
|
+
| **CodeRabbit** | Summary review + inline comments | `/pulls/{n}/reviews` + `/pulls/{n}/comments` |
|
|
147
|
+
| **Copilot** | Inline suggestions | `/pulls/{n}/comments` |
|
|
148
|
+
| **SonarCloud** | Quality gate status + inline issues | `/issues/{n}/comments` + `/pulls/{n}/comments` |
|
|
149
|
+
| **Dependabot** | Security alerts | `/issues/{n}/comments` |
|
|
150
|
+
|
|
151
|
+
---
|
|
152
|
+
|
|
153
|
+
## 6-Perspective Review Protocol
|
|
154
|
+
|
|
155
|
+
### Perspective 1: PR Hygiene
|
|
156
|
+
|
|
157
|
+
| Check | Pass Criteria |
|
|
158
|
+
| :--- | :--- |
|
|
159
|
+
| Title format | Conventional commits: `type(scope): description` |
|
|
160
|
+
| Body completeness | Summary, Changes, Test Plan sections present |
|
|
161
|
+
| PR size | L (31-50 files) or smaller — XL triggers split recommendation |
|
|
162
|
+
| Scope coherence | All changes relate to one logical unit of work |
|
|
163
|
+
| Commit history | Clean, descriptive commits — not `fix` or `wip` repeated |
|
|
164
|
+
|
|
165
|
+
### Perspective 2: Branch Strategy
|
|
166
|
+
|
|
167
|
+
| Check | Pass Criteria |
|
|
168
|
+
| :--- | :--- |
|
|
169
|
+
| Target branch | Matches detected branch strategy (GitFlow or trunk-based) |
|
|
170
|
+
| Branch naming | Follows convention: `type/[ticket-]description` |
|
|
171
|
+
| No direct-to-main | Feature branches never target main in GitFlow projects |
|
|
172
|
+
| Sync status | Branch is not behind target — no stale conflicts |
|
|
173
|
+
|
|
174
|
+
### Perspective 3: Code Quality
|
|
175
|
+
|
|
176
|
+
| Check | Pass Criteria | Evidence Required |
|
|
177
|
+
| :--- | :--- | :--- |
|
|
178
|
+
| Function size | No functions > 50 lines | Cite `file:line` of function declaration |
|
|
179
|
+
| File size | No files > 800 lines | Cite file path and total line count |
|
|
180
|
+
| Nesting depth | No nesting > 4 levels | Cite `file:line` of deepest nesting |
|
|
181
|
+
| Error handling | Try/catch for async operations, error boundaries for UI | Cite `file:line` of unprotected call |
|
|
182
|
+
| No debug artifacts | Zero `console.log`, `debugger`, `TODO: remove` in production code | Cite `file:line` of each occurrence |
|
|
183
|
+
| Naming | Descriptive, intention-revealing identifiers | Cite `file:line` and suggest rename |
|
|
184
|
+
| DRY | No duplicated logic > 3 lines | Cite both locations |
|
|
185
|
+
| Immutability | Spread/Object.assign over mutation where applicable | Cite `file:line` and show alternative |
|
|
186
|
+
|
|
187
|
+
### Perspective 4: Security
|
|
188
|
+
|
|
189
|
+
| Check | Pass Criteria | Evidence Required |
|
|
190
|
+
| :--- | :--- | :--- |
|
|
191
|
+
| No hardcoded secrets | No API keys, passwords, tokens, connection strings in code | Cite `file:line` of secret |
|
|
192
|
+
| Input validation | All user inputs validated (Zod, Joi, or equivalent) | Cite `file:line` of unvalidated input |
|
|
193
|
+
| Injection prevention | Parameterized queries, no string concatenation in queries | Cite `file:line` of vulnerable query |
|
|
194
|
+
| XSS prevention | Output encoding, no `dangerouslySetInnerHTML` or equivalent | Cite `file:line` |
|
|
195
|
+
| Auth checks | Protected routes and endpoints have authorization guards | Cite `file:line` of unguarded route |
|
|
196
|
+
| Sensitive data | No PII in logs, no secrets in error messages | Cite `file:line` |
|
|
197
|
+
| Dependency safety | No known vulnerable dependencies introduced | Cite package and CVE |
|
|
198
|
+
|
|
199
|
+
### Perspective 5: Testing
|
|
200
|
+
|
|
201
|
+
| Check | Pass Criteria | Evidence Required |
|
|
202
|
+
| :--- | :--- | :--- |
|
|
203
|
+
| New code tested | Tests exist for new/modified functions and components | Cite `file:line` of untested code |
|
|
204
|
+
| Edge cases | Boundary conditions, null/undefined, error paths covered | Cite `file:line` and describe missing case |
|
|
205
|
+
| Test quality | No flaky tests, proper assertions, no excessive snapshot testing | Cite `file:line` of flaky pattern |
|
|
206
|
+
| Coverage maintained | No regression in coverage percentage | Cite before/after if available |
|
|
207
|
+
| Test naming | Descriptive test names that explain the scenario | Cite `file:line` of unclear test name |
|
|
208
|
+
|
|
209
|
+
### Perspective 6: Architecture
|
|
210
|
+
|
|
211
|
+
| Check | Pass Criteria | Evidence Required |
|
|
212
|
+
| :--- | :--- | :--- |
|
|
213
|
+
| Pattern consistency | Follows existing codebase patterns and conventions | Cite `file:line` and existing pattern location |
|
|
214
|
+
| Separation of concerns | No business logic in UI, no DB queries in controllers | Cite `file:line` of violation |
|
|
215
|
+
| SOLID principles | Single responsibility, open-closed, dependency inversion | Cite `file:line` |
|
|
216
|
+
| No over-engineering | YAGNI — no premature abstraction or unnecessary indirection | Cite `file:line` |
|
|
217
|
+
| Dependency direction | Clean dependency graph, no circular imports | Cite both files involved |
|
|
218
|
+
| API design | RESTful conventions, consistent error responses | Cite `file:line` and existing convention |
|
|
219
|
+
|
|
220
|
+
### Cross-File Consistency
|
|
221
|
+
|
|
222
|
+
Check that counts, references, and categorizations are consistent across files touched by the PR:
|
|
223
|
+
|
|
224
|
+
| Check | Detection | Example Finding |
|
|
225
|
+
| :--- | :--- | :--- |
|
|
226
|
+
| Heading counts vs actual items | Count items under each heading | `README.md:28` says "6 Operational Skills" but directory contains 7 |
|
|
227
|
+
| Category alignment | Same item categorized consistently | `pr-toolkit` listed as "Development" in `README.md:96` but "Operations" in `CheatSheet.md` |
|
|
228
|
+
| Version references | All version strings match | `manifest.json` says 3.9.0 but `README.md` badge says 3.8.0 |
|
|
229
|
+
|
|
230
|
+
---
|
|
231
|
+
|
|
232
|
+
## Review Output Format
|
|
233
|
+
|
|
234
|
+
**MANDATORY STRUCTURE** — every review MUST include ALL sections below. Sections cannot be omitted or merged.
|
|
235
|
+
|
|
236
|
+
```markdown
|
|
237
|
+
# PR #{number} Review — {content-specific summary}
|
|
238
|
+
|
|
239
|
+
{Round indicator if Round 2+: "Follow-up review (Round N). X of Y prior findings addressed."}
|
|
240
|
+
|
|
241
|
+
## Overview
|
|
242
|
+
|
|
243
|
+
| Field | Value |
|
|
244
|
+
| :--- | :--- |
|
|
245
|
+
| PR | #{number} — {title} |
|
|
246
|
+
| Branch | {head} → {base} |
|
|
247
|
+
| Size | {label} ({files} files, +{additions}/-{deletions}) |
|
|
248
|
+
| Review Round | {Round N} |
|
|
249
|
+
| Author | @{author} |
|
|
250
|
+
|
|
251
|
+
## Existing Reviewer Comments
|
|
252
|
+
|
|
253
|
+
| Reviewer | Comments | Agreed | Challenged | Resolved |
|
|
254
|
+
| :--- | :--- | :--- | :--- | :--- |
|
|
255
|
+
| @{reviewer} | {count} | {count} | {count} | {count} |
|
|
256
|
+
|
|
257
|
+
{For each engagement: brief note on agreement/challenge with file:line reference}
|
|
258
|
+
{If no existing comments: "No prior reviewer comments found."}
|
|
259
|
+
|
|
260
|
+
## Assessment Summary
|
|
261
|
+
|
|
262
|
+
| Perspective | Status | Findings |
|
|
263
|
+
| :--- | :--- | :--- |
|
|
264
|
+
| PR Hygiene | {pass/warn/fail} | {count} issues |
|
|
265
|
+
| Branch Strategy | {pass/warn/fail} | {count} issues |
|
|
266
|
+
| Code Quality | {pass/warn/fail} | {count} issues |
|
|
267
|
+
| Security | {pass/warn/fail} | {count} issues |
|
|
268
|
+
| Testing | {pass/warn/fail} | {count} issues |
|
|
269
|
+
| Architecture | {pass/warn/fail} | {count} issues |
|
|
270
|
+
|
|
271
|
+
**Total**: {critical} Critical, {high} High, {medium} Medium, {low} Low
|
|
272
|
+
|
|
273
|
+
## Findings
|
|
274
|
+
|
|
275
|
+
### Must Fix ({count})
|
|
276
|
+
|
|
277
|
+
{Numbered findings. EACH must include:}
|
|
278
|
+
1. **{title}** — `{file}:{line}`
|
|
279
|
+
{code quote from diff}
|
|
280
|
+
**Why**: {impact explanation}
|
|
281
|
+
**Fix**: {concrete suggestion with code}
|
|
282
|
+
|
|
283
|
+
### High ({count})
|
|
284
|
+
|
|
285
|
+
{Same format as Must Fix}
|
|
286
|
+
|
|
287
|
+
### Medium ({count})
|
|
288
|
+
|
|
289
|
+
{Same format}
|
|
290
|
+
|
|
291
|
+
### Low / NIT ({count})
|
|
292
|
+
|
|
293
|
+
{Same format, fix suggestion optional for NITs}
|
|
294
|
+
|
|
295
|
+
## What's Good
|
|
296
|
+
|
|
297
|
+
{3+ specific positive observations. MUST cite file paths:}
|
|
298
|
+
- {Specific positive pattern observed in `path/to/file`}
|
|
299
|
+
- {Good testing practice in `path/to/test`}
|
|
300
|
+
- {Clean architecture decision in `path/to/module`}
|
|
301
|
+
|
|
302
|
+
## Verdict: {REQUEST_CHANGES | APPROVE | COMMENT}
|
|
303
|
+
|
|
304
|
+
{1-2 sentence justification referencing specific findings}
|
|
305
|
+
```
|
|
306
|
+
|
|
307
|
+
---
|
|
308
|
+
|
|
309
|
+
## Confidence Scoring Protocol
|
|
310
|
+
|
|
311
|
+
Every finding receives a confidence score (0-100) per the `pr-toolkit` confidence framework. Only findings above the active threshold are included in the review output.
|
|
312
|
+
|
|
313
|
+
### Scoring Process
|
|
314
|
+
|
|
315
|
+
For each potential finding:
|
|
316
|
+
|
|
317
|
+
1. Start with base confidence from pattern strength (0-50)
|
|
318
|
+
2. Apply **git-aware context** adjustment: +20 if issue is PR-introduced, -10 if pre-existing
|
|
319
|
+
3. Apply **evidence specificity** adjustment: +15 for file:line reference, -10 for vague reference
|
|
320
|
+
4. Apply **codebase convention** adjustment: -15 if similar patterns exist elsewhere in the codebase
|
|
321
|
+
5. Cap at 0-100 range
|
|
322
|
+
|
|
323
|
+
### Threshold Application
|
|
324
|
+
|
|
325
|
+
- Default: 70 — only High + Certain findings reported
|
|
326
|
+
- With `--strict`: 50 — include Moderate findings
|
|
327
|
+
- With `--relaxed`: 90 — only Certain findings
|
|
328
|
+
|
|
329
|
+
Suppressed findings are logged internally but NOT included in the posted review.
|
|
330
|
+
|
|
331
|
+
---
|
|
332
|
+
|
|
333
|
+
## Git-Aware Context Protocol
|
|
334
|
+
|
|
335
|
+
Before flagging any code quality or security finding, determine whether the issue is **introduced in this PR** or **pre-existing**.
|
|
336
|
+
|
|
337
|
+
### Detection Method
|
|
338
|
+
|
|
339
|
+
```bash
|
|
340
|
+
# Get list of lines changed in this PR
|
|
341
|
+
gh pr diff <number> --repo <owner/repo>
|
|
342
|
+
|
|
343
|
+
# For a specific file, check if the flagged line was modified
|
|
344
|
+
git blame <file> -- -L <line>,<line> | grep -v '<PR-head-sha>'
|
|
345
|
+
```
|
|
346
|
+
|
|
347
|
+
### Context Rules
|
|
348
|
+
|
|
349
|
+
| Context | Confidence Adjustment | Review Behavior |
|
|
350
|
+
| :--- | :--- | :--- |
|
|
351
|
+
| **PR-introduced** (line is in the diff) | +20 | Flag as normal finding |
|
|
352
|
+
| **Pre-existing** (line is NOT in the diff) | -10 | Suppress unless CRITICAL severity |
|
|
353
|
+
| **Modified context** (adjacent lines changed) | +5 | Flag with note: "pre-existing, but context changed" |
|
|
354
|
+
|
|
355
|
+
### Rationale
|
|
356
|
+
|
|
357
|
+
Flagging pre-existing issues wastes reviewer time and erodes trust in the review system. Only CRITICAL pre-existing issues (active security vulnerabilities) warrant flagging in a PR review. Other pre-existing issues should be tracked separately as tech debt.
|
|
358
|
+
|
|
359
|
+
---
|
|
360
|
+
|
|
361
|
+
## Verdict Decision Table
|
|
362
|
+
|
|
363
|
+
| Condition | Verdict |
|
|
364
|
+
| :--- | :--- |
|
|
365
|
+
| Zero CRITICAL + zero HIGH (above threshold) | **APPROVE** |
|
|
366
|
+
| Zero CRITICAL + 1-2 HIGH (minor, acknowledged) | **COMMENT** with recommendations |
|
|
367
|
+
| Any CRITICAL OR 3+ HIGH (above threshold) | **REQUEST_CHANGES** |
|
|
368
|
+
|
|
369
|
+
---
|
|
370
|
+
|
|
371
|
+
## Posting Reviews
|
|
372
|
+
|
|
373
|
+
When posting reviews to GitHub:
|
|
374
|
+
|
|
375
|
+
1. **Inline comments**: Post findings as inline review comments on specific lines using `gh api` or MCP
|
|
376
|
+
2. **Summary**: Post the assessment summary as the review body
|
|
377
|
+
3. **Verdict**: Submit review with appropriate event: `APPROVE`, `COMMENT`, or `REQUEST_CHANGES`
|
|
378
|
+
|
|
379
|
+
```bash
|
|
380
|
+
# Post review via gh CLI
|
|
381
|
+
gh pr review <number> --repo <owner/repo> \
|
|
382
|
+
--request-changes \
|
|
383
|
+
--body "## PR Review Summary
|
|
384
|
+
|
|
385
|
+
[structured review content]"
|
|
386
|
+
|
|
387
|
+
# Post inline comment
|
|
388
|
+
gh api repos/{owner}/{repo}/pulls/{number}/comments \
|
|
389
|
+
--method POST \
|
|
390
|
+
-f body="[finding detail]" \
|
|
391
|
+
-f commit_id="[sha]" \
|
|
392
|
+
-f path="[file]" \
|
|
393
|
+
-F line=[line_number]
|
|
394
|
+
```
|
|
395
|
+
|
|
396
|
+
---
|
|
397
|
+
|
|
398
|
+
## Integration with Other Agents
|
|
399
|
+
|
|
400
|
+
| Agent | Collaboration | Handoff Trigger |
|
|
401
|
+
| :--- | :--- | :--- |
|
|
402
|
+
| **Code Reviewer** | Merge perspectives for local code review | When `/review` and `/pr-review` cover same files |
|
|
403
|
+
| **Security Reviewer** | Escalate CRITICAL security findings for deep analysis | Any CRITICAL security finding with confidence > 85 |
|
|
404
|
+
| **TDD Guide** | Validate test strategy and coverage requirements | When test coverage drops or new code lacks tests |
|
|
405
|
+
| **Architect** | Consult on design pattern and architecture questions | When architectural finding has confidence < 70 |
|
|
406
|
+
| **Build Error Resolver** | Assist when review findings cause build failures during fix | When `/pr-fix` implementation breaks build |
|
|
407
|
+
| **Refactor Cleaner** | Log pre-existing issues as tech debt for separate cleanup | When pre-existing issues are suppressed from review |
|
|
408
|
+
|
|
409
|
+
---
|
|
410
|
+
|
|
411
|
+
**Your Mandate**: Review every PR as if you own the production system it deploys to. Be thorough, constructive, and prioritized. Engage with existing reviewer feedback — you are part of a review team, not a solo critic. A good review teaches — a great review prevents the next bug.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
# Antigravity AI Kit — Checklists
|
|
2
2
|
|
|
3
3
|
> **Purpose**: Quality gates and structured workflows
|
|
4
|
-
> **Count**:
|
|
4
|
+
> **Count**: 4 Core Checklists
|
|
5
5
|
|
|
6
6
|
---
|
|
7
7
|
|
|
@@ -18,6 +18,7 @@ Checklists ensure consistent quality and context preservation across sessions. T
|
|
|
18
18
|
| [session-start.md](session-start.md) | Beginning of session | Load context, verify environment |
|
|
19
19
|
| [session-end.md](session-end.md) | End of session | Save state, document progress |
|
|
20
20
|
| [pre-commit.md](pre-commit.md) | Before git commits | Quality verification |
|
|
21
|
+
| [task-complete.md](task-complete.md) | After task done | Completion verification |
|
|
21
22
|
|
|
22
23
|
---
|
|
23
24
|
|