npm - angular-multiselect3 - Versions diffs - 11.0.4 → 11.0.5 - Mend

angular-multiselect3 11.0.4 → 11.0.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/esm2022/lib/multiselect.component.mjs +13 -18
package/fesm2022/angular-multiselect3.mjs +12 -17
package/fesm2022/angular-multiselect3.mjs.map +1 -1
package/package.json +1 -1

package/fesm2022/angular-multiselect3.mjs CHANGED Viewed

@@ -1939,18 +1939,13 @@ class AngularMultiSelect {
         return item[this.settings.primaryKey];
     }
     isSelected(clickedItem) {
-        if (clickedItem.disabled) {
+        if (clickedItem.disabled ||
+            !this.selectedItems ||
+            this.selectedItems.length === 0) {
             return false;
         }
-        let found = false;
-        this.selectedItems &&
-            this.selectedItems.forEach((item) => {
-                if (clickedItem[this.settings.primaryKey] ===
-                    item[this.settings.primaryKey]) {
-                    found = true;
-                }
-            });
-        return found;
+        return this.selectedItems.some((item) => clickedItem[this.settings.primaryKey] ===
+            item[this.settings.primaryKey]);
     }
     addSelected(item) {
         if (item.disabled) {
@@ -1967,13 +1962,13 @@ class AngularMultiSelect {
         this.onTouchedCallback(this.selectedItems);
     }
     removeSelected(clickedItem) {
-        this.selectedItems &&
-            this.selectedItems.forEach((item) => {
-                if (clickedItem[this.settings.primaryKey] ===
-                    item[this.settings.primaryKey]) {
-                    this.selectedItems.splice(this.selectedItems.indexOf(item), 1);
-                }
-            });
+        if (this.selectedItems) {
+            const position = this.selectedItems.findIndex((item) => clickedItem[this.settings.primaryKey] ===
+                item[this.settings.primaryKey]);
+            if (position !== -1) {
+                this.selectedItems.splice(position, 1);
+            }
+        }
         this.onChangeCallback(this.selectedItems);
         this.onTouchedCallback(this.selectedItems);
     }