angular-eslint-zoneless 1.2.0 → 1.2.2

package/index.d.ts

@@ -2,7 +2,7 @@ import type { ConfigObject } from "@eslint/core";
 declare const plugin: {
     configs: {
         readonly recommended: ConfigObject<import("@eslint/core").RulesConfig>;
-        readonly all: ConfigObject<import("@eslint/core").RulesConfig>;
+        readonly strict: ConfigObject<import("@eslint/core").RulesConfig>;
     };
     meta: {
         name: string;

package/index.js

@@ -61,8 +61,8 @@ const plugin = {
         get recommended() {
             return recommended;
         },
-        get all() {
-            return all;
+        get strict() {
+            return strict;
         }
     },
     meta: { name, version },
@@ -116,7 +116,7 @@ const recommended = {
         [`${name}/${noZonejsTestingFunctions.ruleName}`]: "error",
     },
 };
-const all = {
+const strict = {
     plugins: {
         [name]: plugin
     },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-eslint-zoneless",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "Angular zoneless lint rules for ESLint",
   "keywords": [
     "angular",

package/rules/no-changedetectorref.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
+const is_import_identifier_1 = require("../utils/is-import-identifier");
 exports.ruleName = "no-changedetectorref";
 const messageId = "noChangedetectorref";
 exports.ruleDefinition = {
@@ -17,8 +18,9 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Identifier(node) {
-                if (node.name === 'ChangeDetectorRef') {
+            "Identifier[name='ChangeDetectorRef']"(node) {
+                /* Ignore the import identifier, otherwise the rule reports twice */
+                if (!(0, is_import_identifier_1.isImportIdentifier)(node)) {
                     context.report({
                         node,
                         messageId,

package/rules/no-content-decorator.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-content-decorator";
 const messageId = "noContentDecorator";
 exports.ruleDefinition = {
@@ -19,16 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Decorator(node) {
-                if (node.expression.type === utils_1.AST_NODE_TYPES.CallExpression &&
-                    node.expression.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    (node.expression.callee.name === "ContentChild" ||
-                        node.expression.callee.name === "ContentChildren")) {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "Decorator > CallExpression[callee.type='Identifier'][callee.name=/^(ContentChild|ContentChildren)$/]"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-detectchanges-testing.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 const angular_class_decorator_1 = require("../utils/angular-class-decorator");
 exports.ruleName = "no-detectchanges-testing";
 const messageId = "noDetectchangesTesting";
@@ -19,12 +18,10 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            CallExpression(node) {
-                if (node.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
-                    node.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.callee.property.name === "detectChanges" &&
-                    // Report only in tests, otherwise it will report on `ChangeDetectorRef.detectChanges()`
-                    !(0, angular_class_decorator_1.isInAngularClass)(node, ["Component", "Directive"])) {
+            "CallExpression > MemberExpression[property.type='Identifier'][property.name='detectChanges'][computed=false]"(node) {
+                if (
+                // Report only in tests, otherwise it will report on `ChangeDetectorRef.detectChanges()`
+                !(0, angular_class_decorator_1.isInAngularClass)(node, ["Component", "Directive"])) {
                     context.report({
                         node,
                         messageId,

package/rules/no-eager-change-detection.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-eager-change-detection";
 const messageId = "noEagerChangeDetection";
 exports.ruleDefinition = {
@@ -19,16 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MemberExpression(node) {
-                if (node.object.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.object.name === "ChangeDetectionStrategy" &&
-                    node.property.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    (node.property.name === "Eager" || node.property.name === "Default")) {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MemberExpression[object.type='Identifier'][object.name='ChangeDetectionStrategy'][property.type='Identifier'][property.name=/^(Eager|Default)$/]"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-input-decorator.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-input-decorator";
 const messageId = "noInputDecorator";
 exports.ruleDefinition = {
@@ -19,15 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Decorator(node) {
-                if (node.expression.type === utils_1.AST_NODE_TYPES.CallExpression &&
-                    node.expression.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.expression.callee.name === "Input") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "Decorator > CallExpression[callee.type='Identifier'][callee.name='Input']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngaftercontentchecked.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngaftercontentchecked";
 const messageId = "noNgaftercontentchecked";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngAfterContentChecked") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngAfterContentChecked']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngaftercontentinit.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngaftercontentinit";
 const messageId = "noNgaftercontentinit";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngAfterContentInit") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngAfterContentInit']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngafterviewchecked.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngafterviewchecked";
 const messageId = "noNgafterviewchecked";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngAfterViewChecked") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngAfterViewChecked']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngafterviewinit.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngafterviewinit";
 const messageId = "noNgafterviewinit";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngAfterViewInit") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngAfterViewInit']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngdocheck.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngdocheck";
 const messageId = "noNgdocheck";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngDoCheck") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngDoCheck']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngonchanges.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngonchanges";
 const messageId = "noNgonchanges";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngOnChanges") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngOnChanges']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngondestroy.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngondestroy";
 const messageId = "noNgondestroy";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngOnDestroy") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngOnDestroy']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngoninit.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngoninit";
 const messageId = "noNgoninit";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MethodDefinition(node) {
-                if (node.key.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.key.name === "ngOnInit") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MethodDefinition[key.type='Identifier'][key.name='ngOnInit']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngzone-testing.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-ngzone-testing";
 const messageId = "noNgzoneTesting";
 exports.ruleDefinition = {
@@ -18,14 +17,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            MemberExpression(node) {
-                if (node.property.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.property.name === "ngZone") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "MemberExpression[property.type='Identifier'][property.name='ngZone'][computed=false]"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-ngzone.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
+const is_import_identifier_1 = require("../utils/is-import-identifier");
 exports.ruleName = "no-ngzone";
 const messageId = "noNgzone";
 exports.ruleDefinition = {
@@ -18,8 +19,8 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Identifier(node) {
-                if (node.name === 'NgZone') {
+            "Identifier[name='NgZone']"(node) {
+                if (!(0, is_import_identifier_1.isImportIdentifier)(node)) {
                     context.report({
                         node,
                         messageId,

package/rules/no-output-decorator.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-output-decorator";
 const messageId = "noOutputDecorator";
 exports.ruleDefinition = {
@@ -19,15 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Decorator(node) {
-                if (node.expression.type === utils_1.AST_NODE_TYPES.CallExpression &&
-                    node.expression.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.expression.callee.name === "Output") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "Decorator > CallExpression[callee.type='Identifier'][callee.name='Output']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-providezonechangedetection.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-providezonechangedetection";
 const messageId = "noProvidezonechangedetection";
 exports.ruleDefinition = {
@@ -19,14 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            CallExpression(node) {
-                if (node.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.callee.name === "provideZoneChangeDetection") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "CallExpression[callee.type='Identifier'][callee.name='provideZoneChangeDetection']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-subscribe-in-component-constructor.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 const in_constructor_1 = require("../utils/in-constructor");
 exports.ruleName = "no-subscribe-in-component-constructor";
 const messageId = "noSubscribeInComponentConstructor";
@@ -19,11 +18,8 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            CallExpression(node) {
-                if (node.callee.type === utils_1.AST_NODE_TYPES.MemberExpression &&
-                    node.callee.property.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    node.callee.property.name === 'subscribe' &&
-                    (0, in_constructor_1.isInAngularComponentConstructor)(node)) {
+            "CallExpression > MemberExpression[property.type='Identifier'][property.name='subscribe'][computed=false]"(node) {
+                if ((0, in_constructor_1.isInAngularComponentConstructor)(node)) {
                     context.report({
                         node,
                         messageId,

package/rules/no-view-decorator.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-view-decorator";
 const messageId = "noViewDecorator";
 exports.ruleDefinition = {
@@ -19,16 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            Decorator(node) {
-                if (node.expression.type === utils_1.AST_NODE_TYPES.CallExpression &&
-                    node.expression.callee.type === utils_1.AST_NODE_TYPES.Identifier &&
-                    (node.expression.callee.name === "ViewChild" ||
-                        node.expression.callee.name === "ViewChildren")) {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "Decorator > CallExpression[callee.type='Identifier'][callee.name=/^(ViewChild|ViewChildren)$/]"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-zonejs-import.js

@@ -18,13 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            ImportDeclaration(node) {
-                if (node.source.value === "zone.js") {
-                    context.report({
-                        node,
-                        messageId,
-                    });
-                }
+            "ImportDeclaration[source.value='zone.js']"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/rules/no-zonejs-testing-functions.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ruleDefinition = exports.ruleName = void 0;
-const utils_1 = require("@typescript-eslint/utils");
 exports.ruleName = "no-zonejs-testing-functions";
 const messageId = "noZonejsTestingFunctions";
 exports.ruleDefinition = {
@@ -19,24 +18,11 @@ exports.ruleDefinition = {
     },
     create(context) {
         return {
-            CallExpression(node) {
-                if (node.callee.type === utils_1.AST_NODE_TYPES.Identifier) {
-                    const testingFunctions = new Set([
-                        "fakeAsync",
-                        "discardPeriodicTasks",
-                        "flush",
-                        "flushMicrotasks",
-                        "resetFakeAsyncZone",
-                        "tick",
-                        "waitForAsync",
-                    ]);
-                    if (testingFunctions.has(node.callee.name)) {
-                        context.report({
-                            node,
-                            messageId,
-                        });
-                    }
-                }
+            "CallExpression[callee.type='Identifier'][callee.name=/^(fakeAsync|discardPeriodicTasks|flush|flushMicrotasks|resetFakeAsyncZone|tick|waitForAsync)$/]"(node) {
+                context.report({
+                    node,
+                    messageId,
+                });
             },
         };
     },

package/utils/is-import-identifier.d.ts

@@ -0,0 +1,2 @@
+import { type TSESTree } from "@typescript-eslint/utils";
+export declare function isImportIdentifier(node: TSESTree.Identifier): boolean;

package/utils/is-import-identifier.js

@@ -0,0 +1,7 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isImportIdentifier = isImportIdentifier;
+const utils_1 = require("@typescript-eslint/utils");
+function isImportIdentifier(node) {
+    return node.parent.type === utils_1.AST_NODE_TYPES.ImportSpecifier;
+}