anbaric-state-machine 1.9.0 → 1.11.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "anbaric-state-machine",
-  "version": "1.9.0",
+  "version": "1.11.0",
   "description": "This is the state machine library that one can use to add state management to an application. It will, by default, be locally runnable but can deployed to the Anbaric Cloud via the CLI",
   "license": "MIT",
   "author": "chris@anbaric.ai",
@@ -15,8 +15,8 @@
     "typescript": "^7.0.2"
   },
   "dependencies": {
-    "anbaric-impl-cloud": "^1.9.0",
-    "anbaric-tsapi": "^1.9.0"
+    "anbaric-impl-cloud": "^1.11.0",
+    "anbaric-tsapi": "^1.11.0"
   },
   "files": [
     "src"

package/src/StateMachine.ts

@@ -15,10 +15,11 @@ import {Code} from "./actors/Code";
 
 class StateMachine {
 
-    private workflowId: string;
-    private states: Map<string, State>;
-    private startState: string;
-    private dataSchema: Map<string, PropertyDefinition>;
+    readonly workflowId: string;
+    readonly states: Map<string, State>;
+    readonly startState: string;
+    readonly dataSchema: Map<string, PropertyDefinition>;
+
     private persistence: JobPersistence;
     private queue: Queue;
     private consumer: Consumer;
@@ -87,8 +88,7 @@ class StateMachine {
 
     private validateProperties(properties : Map<string, any>, isNew : boolean) : boolean {
         for (const [key, value] of properties) {
-            const definition = this.dataSchema.get(key);
-            if (! definition || ! definition.validation(value)) return false;
+            if (this.propertyProblem(key, value)) return false;
         }
 
         if (! isNew) return true;
@@ -100,6 +100,13 @@ class StateMachine {
         return true;
     }
 
+    private propertyProblem(key : string, value : any) : string | undefined {
+        const definition = this.dataSchema.get(key);
+        if (! definition) return "is not declared in the data schema";
+        if (! definition.validation(value)) return "failed its validation";
+        return undefined;
+    }
+
     private async progressJob(jobId : string) : Promise<void> {
         let pristine = true;
 
@@ -114,14 +121,19 @@ class StateMachine {
 
             const newProperties = await action.run(job);
 
-            if (! this.validateProperties(newProperties, false)) continue;
-
-            involvedActors.push(action.actor);
-
-            newProperties.forEach((value, key) => {
-                pristine = false;
+            let applied = false;
+            for (const [key, value] of newProperties) {
+                const problem = this.propertyProblem(key, value);
+                if (problem) {
+                    console.warn(`[${this.workflowId}] action "${action.name}" set "${key}", which ${problem}, on job ${job.id} — skipping that property.`);
+                    continue;
+                }
                 job.properties.set(key, value);
-            });
+                pristine = false;
+                applied = true;
+            }
+
+            if (applied) involvedActors.push(action.actor);
         }
 
         let newState : string | undefined = undefined;