analyzthis_design 1.15.0 → 1.18.0

package/.github/ISSUE_TEMPLATE/persona-feedback.yml

@@ -0,0 +1,75 @@
+name: Persona feedback
+description: Report when a design persona got it wrong or you had to correct it
+title: "[feedback] "
+labels: ["persona-feedback"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Help improve analyzthis_design personas. Prefer CLI submit when possible:
+        `npx analyzthis_design feedback record ...` then `npx analyzthis_design feedback submit --yes`
+
+  - type: dropdown
+    id: persona
+    attributes:
+      label: Persona
+      options:
+        - arjun
+        - meera
+        - priya
+        - zara
+        - raj
+        - noor
+        - anuj
+        - design-director
+        - other
+    validations:
+      required: true
+
+  - type: dropdown
+    id: rating
+    attributes:
+      label: How happy were you with the output?
+      options:
+        - "1 — very unhappy"
+        - "2 — unhappy"
+        - "3 — okay"
+        - "4 — good"
+        - "5 — great"
+    validations:
+      required: true
+
+  - type: checkboxes
+    id: tags
+    attributes:
+      label: What went wrong?
+      options:
+        - label: wrong_hierarchy
+        - label: invented_tokens
+        - label: missed_ds
+        - label: too_verbose
+        - label: bad_ia
+        - label: off_brief
+        - label: other
+
+  - type: textarea
+    id: comment
+    attributes:
+      label: What was wrong?
+      placeholder: The persona suggested colors that aren't in our design system...
+    validations:
+      required: true
+
+  - type: textarea
+    id: correction
+    attributes:
+      label: What did you want instead? (how you corrected it)
+      placeholder: Use --color-primary from tokens.css; primary CTA should be top-right...
+    validations:
+      required: true
+
+  - type: input
+    id: version
+    attributes:
+      label: Package version (optional)
+      placeholder: "1.17.0"

package/README.md

@@ -37,8 +37,8 @@ npx analyzthis_design --target all --force
 | Cursor | `~/.cursor/skills/<name>/SKILL.md` | `/getting-started` |
 | Claude Code | `~/.claude/skills/<name>/SKILL.md` (+ legacy `~/.claude/commands/`) | `/getting-started` |
 | Codex CLI | `~/.codex/skills/<name>/SKILL.md` | skill name / AGENTS.md |
-| Grok Build | `~/.grok/skills/<name>/SKILL.md` | `/collect-knowledge` |
-| Windsurf Cascade | `~/.codeium/windsurf/skills/<name>/SKILL.md` | `@collect-knowledge` |
+| Grok Build | `~/.grok/skills/<name>/SKILL.md` | `/kavi` |
+| Windsurf Cascade | `~/.codeium/windsurf/skills/<name>/SKILL.md` | `@kavi` |
 | Cross-agent | `~/.agents/skills/<name>/SKILL.md` | discovered by multiple hosts |
 
 All skills use the **Agent Skills** `SKILL.md` standard — same files work across Cursor, Claude, Grok, Windsurf, and Codex. The CLI (`collect`, `run`, `sync`) is host-agnostic; only *where skills are discovered* differs.
@@ -62,18 +62,18 @@ All skills use the **Agent Skills** `SKILL.md` standard — same files work acro
 
 | Command | What it does |
 |---|---|
-| `/collect-knowledge` | **Kavi — Knowledge Archivist.** Scans the codebase, builds an Obsidian vault, LLM-enriches notes, syncs into the knowledge bank. Run once per project before critiques. |
+| `/kavi` | **Kavi — Knowledge Archivist.** Scans the codebase, builds an Obsidian vault, LLM-enriches notes, syncs into the knowledge bank. Run once per project before critiques. _(Alias: `/collect-knowledge`)_ |
 | `/persona-orchestrator` | **Agentic critique entry point** (not for wireframes). MoE router + session state, ux-story-gate intake, persona chain, DS / hierarchy / verify gates → SHIP/REVISE/BLOCK |
 | `/ux-story-gate` | Task-first gate: PRDs, DS/Figma discovery, MoE routing, browser verify, assess-only mode |
 | `/design-critic` | 4-persona critique → Composite Score + Information Hierarchy Gate |
 
 ### 8 Personas
 
-Invoke critique personas for targeted, already-grounded questions. For **wireframes**, use `/ux-ideator`, `/noor`, or `/anuj`. For full screen **critique**, prefer `/persona-orchestrator` or `/ux-story-gate`. Run `/collect-knowledge` first so they have project context.
+Invoke critique personas for targeted, already-grounded questions. For **wireframes**, use `/ux-ideator`, `/noor`, or `/anuj`. For full screen **critique**, prefer `/persona-orchestrator` or `/ux-story-gate`. Run **`/kavi`** first so they have project context.
 
 | Command | Persona | What they evaluate |
 |---|---|---|
-| `/collect-knowledge` | Kavi — Knowledge Archivist | Scan repo → Obsidian vault → enrich → sync knowledge bank (producer, not a critic) |
+| `/kavi` | Kavi — Knowledge Archivist | Scan repo → Obsidian vault → enrich → sync knowledge bank (producer, not a critic) |
 | `/arjun` | UX + Visual Design | UX Honeycomb + Visual Design Audit (hierarchy, color, type, spacing, components, style fit, micro-interactions) |
 | `/meera` | Business Agent | Retention, ARR, GTM lever, adoption risk; hierarchy vs north-star check |
 | `/priya` | Feasibility Agent | Engineering effort (T-shirt sizing, 2-axis model), state machine traps |
@@ -282,11 +282,70 @@ analyzthis_design is a design **critique** layer, not a design generator. The pe
 **LoRA readiness (export hook only — no training in this release):**
 
 ```bash
-npx analyzthis_design session accept --persona arjun     # mark the last output as a good example
+# Good examples (positive pairs)
+npx analyzthis_design session accept --persona arjun
 npx analyzthis_design export-training --persona arjun --all
+
+# Bad output + how you corrected it (negative / DPO pairs) — v1.16
+npx analyzthis_design session accept --persona arjun --reject \
+  --comment "Invented tokens not in our DS" \
+  --correction "Use --color-primary and spacing-4 from tokens.css" \
+  --rating 2 --tags invented_tokens,missed_ds
+
+npx analyzthis_design feedback record --persona arjun --rating 2 \
+  --comment "Hierarchy wrong — CTA buried" \
+  --correction "Primary action should be top-right, above the fold"
+
+npx analyzthis_design feedback list
+npx analyzthis_design feedback export --persona arjun --all
+```
+
+Writes `{ system_card, digest, user, assistant }` JSONL pairs to `~/.analyzthis_design/training/<persona>.jsonl` from every session where that persona's output was explicitly accepted.
+
+**Correction export** writes `{ assistant_rejected, assistant_preferred, user_comment, tags }` to `~/.analyzthis_design/feedback/<persona>-corrections.jsonl` — useful when users were unhappy or had to rewrite persona output. Every entry is also appended to a global `corrections.jsonl` across projects.
+
+Once a persona accumulates ~100–300 accepted pairs (and optionally correction pairs), that data is ready for a future fine-tuning pass on an open model — not part of this package yet.
+
+---
+
+## Persona feedback — corrections & unhappiness (v1.16)
+
+When a persona gets it wrong, you can record **what was wrong** and **how you fixed it**. This feeds future fine-tuning (negative / DPO pairs) alongside the existing positive `export-training` path.
+
+| Command | Purpose |
+|---------|---------|
+| `feedback record` | Log rating, comment, correction, tags for a persona's last output |
+| `feedback list` | See all feedback for this project (or `--all`) |
+| `feedback export` | Write `{ assistant_rejected, assistant_preferred, … }` JSONL |
+| `session accept --reject --comment …` | Reject + record in one step |
+
+Suggested tags: `wrong_hierarchy`, `invented_tokens`, `missed_ds`, `too_verbose`, `bad_ia`, `off_brief`.
+
+Stored in `session-state.json` → `feedback_log` and appended globally to `~/.analyzthis_design/feedback/corrections.jsonl`.
+
+### Community collection (v1.17) — opt-in submit
+
+For **open-source contributors**, share anonymized corrections with maintainers:
+
+```bash
+npx analyzthis_design feedback record --persona arjun --rating 2 --comment "..." --correction "..."
+npx analyzthis_design feedback submit --dry-run    # preview redacted payload
+npx analyzthis_design feedback submit --all --yes  # send unsent entries (asks consent once)
+npx analyzthis_design feedback status
 ```
 
-Writes `{ system_card, digest, user, assistant }` JSONL pairs to `~/.analyzthis_design/training/<persona>.jsonl` from every session where that persona's output was explicitly accepted. Once a persona accumulates ~100–300 accepted pairs, that data is ready for a future fine-tuning pass on an open model — not part of this package yet.
+**What gets sent:** persona, rating, tags, comment, correction, redacted output snippets, anonymous install id, package version.
+
+**What does NOT get sent:** project paths, repo names, emails, API keys, full source trees.
+
+**Maintainer setup (Supabase):**
+
+1. Create a Supabase project
+2. Run `supabase/migrations/001_persona_feedback.sql` in the SQL editor
+3. Copy `supabase/feedback-config.example.json` into `~/.analyzthis_design/config.json` under `"feedback"` (or set env vars `ANALYZTHIS_FEEDBACK_URL` + `ANALYZTHIS_FEEDBACK_ANON_KEY`)
+4. View submissions in Supabase Table Editor → `persona_feedback`
+
+Users can also file GitHub issues via **Persona feedback** template if they prefer not to use CLI submit.
 
 ---
 
@@ -345,7 +404,7 @@ Schema: `agents/design-spec-schema.json`. Producer orchestration: `/design-direc
 Kavi is a **producer** persona (not a critic). One command scans the current repo, **discovers Obsidian vaults and knowledge graphs**, **fetches external URLs**, writes an Obsidian vault with dynamic `Sources/*.md` manifests, optionally enriches notes, then auto-connects and syncs everything into the knowledge bank.
 
 ```
-/collect-knowledge  (or  npx analyzthis_design collect)
+/kavi  (or  npx analyzthis_design collect)
         ↓
   Scan codebase → draft Obsidian notes
         ↓
@@ -443,7 +502,15 @@ npx analyzthis_design status
 
 # Session (agentic)
 npx analyzthis_design session init|show|reset [--project id] [--all]
-npx analyzthis_design session accept --persona <id> [--reject]
+npx analyzthis_design session accept --persona <id> [--reject] [--comment "..."] [--correction "..."] [--rating 1-5] [--tags a,b]
+
+# Persona feedback (v1.16)
+npx analyzthis_design feedback record --persona <id> [--rating 1-5] [--comment "..."] [--correction "..."] [--tags a,b]
+npx analyzthis_design feedback list [--all]
+npx analyzthis_design feedback export [--persona <id>] [--all] [--output path] [--include-positive]
+npx analyzthis_design feedback submit [--persona <id>] [--all] [--yes] [--dry-run]
+npx analyzthis_design feedback status
+npx analyzthis_design feedback revoke
 
 # Research
 npx analyzthis_design research --url <url>
@@ -460,6 +527,7 @@ npx analyzthis_design run --task "..." [--lite | --full] [--experts a,b]
 npx analyzthis_design metrics [--project id] [--all]
 npx analyzthis_design cost [--project id] [--all]
 npx analyzthis_design export-training --persona <id> [--project id] [--all] [--output path]
+npx analyzthis_design feedback export [--persona <id>] [--project id] [--all] [--output path]
 ```
 
 ---
@@ -481,11 +549,14 @@ lib/
   retrieve.js           Filtered, citation-ready CSV row retrieval
   cache.js              On-disk cache for retrieve/kb slices
   export.js             LoRA training-pair export hook
+  feedback.js           Persona unhappiness + correction logging (session + global JSONL)
+  feedback-submit.js    Opt-in anonymized submit to Supabase (community feedback)
   cost.js               $-cost report from metrics × config.pricing
   orchestrator/run.js   Standalone LLM runtime (v2) — MoE, effort-graded tiers, caps, cache-aware
 scripts/obfuscate.js    Build step → dist/
 skills/
-  collect-knowledge/    Kavi — Knowledge Archivist
+  kavi/                 Kavi — Knowledge Archivist (/kavi)
+  collect-knowledge/    Alias for Kavi (backward compatible)
   persona-orchestrator/ Agentic critique entry point
   ux-story-gate/        Task-first gate + DS/MoE/verify/assess phases
   design-critic/        4-persona critique + hierarchy gate

package/agents/cards/kavi.md

@@ -23,4 +23,4 @@ Knowledge bank: [synced count] → [targets]
 Next: run /persona-orchestrator or any critique persona — they read this bank first.
 ```
 
-Consult `skills/collect-knowledge/SKILL.md` for the host workflow. Prefer running `npx analyzthis_design collect` over re-scanning files in chat.
+Consult `skills/kavi/SKILL.md` for the host workflow. Prefer running `npx analyzthis_design collect` over re-scanning files in chat. Invoke as **`/kavi`** (alias: `/collect-knowledge`).

package/agents/manifests/kavi.json

@@ -1,7 +1,7 @@
 {
   "id": "kavi",
   "role": "knowledge_archivist",
-  "system_skill": "skills/collect-knowledge/SKILL.md",
+  "system_skill": "skills/kavi/SKILL.md",
   "system_card": "agents/cards/kavi.md",
   "tier": "structured",
   "max_output_tokens": 4000,

package/agents/router.json

@@ -76,10 +76,10 @@
     },
     {
       "problem_type": "collect_knowledge",
-      "signals": ["collect knowledge", "scan codebase", "build vault", "knowledge archivist", "collect-knowledge"],
+      "signals": ["kavi", "/kavi", "collect knowledge", "scan codebase", "build vault", "knowledge archivist", "collect-knowledge"],
       "route_to": ["kavi"],
       "never_route_to": ["design-critic_chain", "zara", "arjun", "meera", "priya"],
-      "notes": "Producer only — run /collect-knowledge or `npx analyzthis_design collect`. Never part of a critique chain."
+      "notes": "Producer only — run /kavi or `npx analyzthis_design collect`. Never part of a critique chain."
     }
   ]
 }

package/agents/session-schema.json

@@ -52,6 +52,21 @@
       "spec_verdict": "object — arjun_visual, ds_gate, hierarchy_gate, notes",
       "updated_at": "ISO 8601"
     },
+    "feedback_log": [
+      {
+        "id": "string — unique feedback entry id",
+        "at": "ISO 8601",
+        "persona": "string — persona id",
+        "satisfied": "boolean — true if user was happy",
+        "rating": "number | null — 1 (very unhappy) to 5 (very happy)",
+        "comment": "string — what was wrong or what they liked",
+        "correction": "string — how the user corrected or what they wanted instead",
+        "tags": ["string — e.g. wrong_hierarchy, invented_tokens, off_brief"],
+        "original_output": "string — snapshot of persona output at feedback time",
+        "submitted_at": "ISO 8601 | omitted — set when feedback submit succeeds",
+        "context": "object — task_map_summary, problem_type, mode"
+      }
+    ],
     "vault_path": "string — Obsidian vault written by Kavi collect (empty until first collect)",
     "last_collect_at": "ISO 8601 timestamp — last successful collect run",
     "digest": {