amsd-pipeline 1.22.0 → 1.24.0

package/install.sh

@@ -920,15 +920,26 @@ fi
 # the install has already failed, where a second wall of red helps nobody.
 if [ "$CHECK_ONLY" != "1" ] && [ "$FAILED" != "1" ] && [ -f "$INSTALLER_DIR/pipeline-health.sh" ]; then
     _head "Post-install health check"
-    if bash "$INSTALLER_DIR/pipeline-health.sh" 2>&1 | sed 's/^/  /'; then
+    # --dest "$ROOT": the tree that was INSTALLED, never the installer's own location. Under
+    # `npx amsd-pipeline` install.sh runs from a temp clone, so without this the check inspects
+    # /tmp/tmp.XXXX and reports failures about a directory nobody installed into.
+    if bash "$INSTALLER_DIR/pipeline-health.sh" --dest "$ROOT" 2>&1 | sed 's/^/  /'; then
         _ok "health check passed"
     else
-        _warn "health check reported problems above — the install itself completed, but this machine is not ready to launch"
-        _warn "re-run it any time: bash orchestrations-installer/pipeline-health.sh"
+        # THE FINAL WORD MUST NOT CONTRADICT THE CHECK ABOVE IT. Printing "not healthy" and then
+        # "✓ ready" two lines later leaves an operator to guess which one to believe; the whole
+        # point of running the probe here is that its answer is the install's answer.
+        HEALTH_FAILED=1
+        _warn "health check reported problems above — the install completed, but this machine is not ready to launch"
+        _warn "re-run it any time: bash orchestrations-installer/pipeline-health.sh --dest \"$ROOT\""
     fi
 fi
 
 _head "Result"
+if [ "$FAILED" != "1" ] && [ "${HEALTH_FAILED:-0}" = "1" ]; then
+    _warn "installed, but NOT ready to launch — see the health check above"
+    exit 1
+fi
 if [ "$FAILED" = "1" ]; then
     _bad "install incomplete — fix the items marked ✗ above"
     exit 1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline",
-  "version": "1.22.0",
+  "version": "1.24.0",
   "description": "Installer for the amsd-pipeline orchestration stack. Clones, packages and provisions the full stack with one command — no separate git clone step.",
   "bin": {
     "amsd-pipeline": "bin/amsd-pipeline.js"