amsd-pipeline-workflow 0.1.29 → 0.1.31

package/driver/run.js

@@ -469,8 +469,17 @@ async function phaseRunner(ctx, lane, laneEnv, { prd, phase, args, tag, lineSlug
   // reviewed, locked (operator, 2026-10-20); an approved one is locked and not touched
   const toReview = env.EPAM_RESUME_RUN ? ((p.implementationOrder || {})[phase] || []).map((id) => p.stories.find((s) => s.id === id))
     .filter((s) => s && s.completed === true && s.status !== 'deprecated' && s.agentRole !== 'review-agent')
-    .filter((s) => { const rec = reviewRecord(ctx, lane, env, s.id, lineSlug); return !(rec && rec.verdict === 'approved'); }) : [];
-  for (const s of toReview) log(`[driver] ${s.id}: committed but never reviewed — its review judges the committed change; nothing is rewritten`);
+    .filter((s) => {
+      const rec = reviewRecord(ctx, lane, env, s.id, lineSlug); if (!(rec && rec.verdict === 'approved')) return true;
+      // THE OPERATOR LIFTS THE LOCK (2026-10-21: "yes rewrite it is not good code"): approved work is judged again by the current
+      // reviewer; a rejection sends it back to the writer with the findings, as any rejection does
+      if (env.EPAM_REREVIEW_APPROVED === '1') { s.rereview = rec.from; return true; }
+      return false;
+    }) : [];
+  for (const s of toReview) {
+    log(s.rereview ? `[driver] ${s.id}: approved earlier — judged again by the current reviewer (EPAM_REREVIEW_APPROVED=1, ${s.rereview}); a rejection goes back to the writer`
+      : `[driver] ${s.id}: committed but never reviewed — its review judges the committed change; nothing is rewritten`);
+  }
   if (order.length && env.EPAM_BROWNFIELD === '1') bash(env, 'ensure_story_branch', [lane.wt, order[0].id, env.JIRA_BASELINE_BRANCH || ''], { log });
   // RAO:2653–2654 — THE LANE'S PHASE BASELINE (lib/qa-gate-evidence.sh qa_record_phase_baseline: the fork point from the
   // base branch) in the lane's log, where the release lines read the main line's change from (lib/release-lines.sh:69–74)

package/generator/generate.js

@@ -313,6 +313,16 @@ function main(a) {
   // retry budget plus one more per review cycle (lib/review-cycle.sh), each on every model the ladder can reach — has its
   // own copy of the writer, the failure analyst and the rung-entry step runner, identical but for the values their hooks
   // are given (the copy's retry; the writer's model; the model the previous attempt ran on).
+  // THE MODEL THE REVIEW RUNS ON: the shared policy (config/reviewer-policy.json), read by the SAME reader the bash reviewer calls (lib/reviewer-model.js in the install —
+  // team-lead-review.sh reviewer_model_for), so the two pipelines cannot differ. null = the writer's rung model (policy 'writer-rung', or an install without the policy).
+  // Run 11 (2026-10-21): on the writer's Sonnet rung the reviewer rated a thin and a rich delivery alike (9, 9); on Opus it separated them (6, 7.5).
+  const reviewerModel = (() => {
+    const lib = path.join(a.install, 'orchestrations', 'scripts', 'lib', 'reviewer-model.js');
+    if (!fs.existsSync(lib)) return null;
+    const r = spawnSync(process.execPath, [lib, ''], { encoding: 'utf8', env: { ...process.env, ...launchValues(a.launchEnv || {}), EPAM_PROVIDER_SET: a.set || 'claude' } });
+    if (r.status !== 0) { process.stderr.write(`[generate] the reviewer's model policy could not be read — reviewing on the writer's model: ${(r.stderr || '').trim()}\n`); return null; }
+    return r.stdout.trim() || null;
+  })();
   const reviewMaxCycles = maxRetries + 3;
   const lastAttempt = maxRetries + reviewMaxCycles;
   const models = [...new Set([lad.start.model, ...Object.values(lad.steps).map((v) => v.model)])];
@@ -562,6 +572,7 @@ function main(a) {
       where: "this workflow run's journal (it records the full prompt of every attempt)" },
     // lib/review-cycle.sh: REVIEW_MAX_CYCLES defaults to EPAM_MAX_RETRIES + 3.
     reviewMaxCycles,
+    reviewerModel,
     prompts: {
       'writer.first': fs.readFileSync(path.join(a.out, 'prompts', 'writer.first.md'), 'utf8'),
       'writer.retry': fs.readFileSync(path.join(a.out, 'prompts', 'writer.retry.md'), 'utf8'),

package/generator/writer-workflow.js

@@ -972,8 +972,8 @@ for (; attempt <= budget; attempt++) {
   for (;;) {
     r = await agentCall(fill(PLAN.prompts.reviewer, { ...base, story_acs: noTrail(criteriaBlock(state.acs, 'ACCEPTANCE CRITERIA:')),
       prior_review: priorReviews(), story_diff: checks.storyDiff, test_files: checks.testFiles, uncovered_vc_block: uncoveredVc !== null ? uncoveredVc : checks.uncoveredVc }),
-      // team-lead-review.sh: on the writer's model (the rung that produced this work); effort stays the reviewer's own.
-      { agentType: PLAN.agents.reviewer, model: rung.model, schema: SCHEMAS.review, label: \`review #\${reviews.length + 1}\`, phase: 'Review' })
+      // team-lead-review.sh reviewer_model_for: the shared policy's model (PLAN.reviewerModel — the reader the bash reviewer calls), else the writer's model (the rung that produced this work); effort stays the reviewer's own.
+      { agentType: PLAN.agents.reviewer, model: PLAN.reviewerModel || rung.model, schema: SCHEMAS.review, label: \`review #\${reviews.length + 1}\`, phase: 'Review' })
     if (r !== null) { noVerdict = 0; reviews.push({ verdict: r.verdict, issues: r.issues || [] }); break }
     reviews.push({ reviewIncomplete: true })
     noVerdict++

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-workflow",
-  "version": "0.1.29",
+  "version": "0.1.31",
   "description": "The AMSD pipeline as Claude workflows. Installed by the amsd-pipeline installer: install.sh --workflows",
   "license": "UNLICENSED",
   "bin": {