amsd-pipeline-workflow 0.1.27 → 0.1.29

package/doctor/profile.json

@@ -34,6 +34,9 @@
       "\u2139 fail 0",
       "\u2714 (?!\\S+\\.js \\()"
     ],
+    "fixtures": [
+      "state"
+    ],
     "failedPattern": "\u2139 fail [1-9]"
   },
   "install": {

package/generator/writer-workflow.js

@@ -372,7 +372,7 @@ let reviewedTree = null, prevBlocker = false, retiredThisCycle = 0, reReview = n
 let reproDone = false, repro = null, gate = null, uit = null, coverage = null, uncoveredVc = null
 async function reproStep(prep) {
   const at = prep.findingMode ? 'review test findings' : '3.54'
-  if (prep.skip) { log(\`\${at}: \${prep.skip}\`); return { committed: false, reason: prep.skip } }
+  if (prep.skip) { log(\`\${at}: \${prep.skip}\`); return { committed: false, reason: prep.skip, noFix: !!prep.noFix } }
   if (prep.error) { log(\`\${at}: the test writer cannot run — \${prep.error}\${prep.findingMode ? '' : ' (Step 3.55 will block)'}\`); return { committed: false, reason: prep.error } }
   let source = null
   if (prep.targetQuestion) {
@@ -572,6 +572,14 @@ async function implementedSteps(checks, attempt) {
   const end = (r) => ({ end: done(r) })
   if (!reproDone && checks.repro) {
     reproDone = true; repro = await reproStep(checks.repro)
+    // NOTHING TO GATE (repro.noFix, hooks/repro-prep.sh): no fix file is in the diff at all, so Step 3.55's gate has no
+    // change to ask about. Run 11, metrolinx, AMSD-2974: the plan correctly gave this codeline no change (every fix site
+    // NO EDIT REQUIRED, the detective's structured analysis), the writer made no change either, and the real Step 3.55
+    // gate still ran and blocked it ("no test file accompanies the change") because its own no-change bypass does not
+    // know this workflow's structured-analysis fallback (generator/plan-no-change-structured.js). This workflow's own
+    // Step 3.54 preparation already answered the only question the gate would ask — asking it again cannot do anything
+    // but repeat a question already answered, so it is not asked.
+    if (repro.noFix) return { checks }
     // STEP 3.545 — tests the fix legitimately invalidated (update-invalidated-tests.sh): the step runner checks the whole suite;
     // when it is red, the agent (its write fence: only tests that existed before the story) updates them or reports a
     // regression, and its judge decides. An unresolved RED suite blocks after the reproduction gate (below).

package/hooks/repro-prep.sh

@@ -54,7 +54,15 @@ if [ -n "$_FINDING_FILE" ]; then
 else
 # :164–165 (no gate finding: a test that accompanies the change is enough)
 [ "${#TEST_FILES[@]}" -gt 0 ] && say --arg t "${TEST_FILES[0]}" '{skip: ("a test already accompanies the change (" + $t + ") — nothing to write")}'
-[ "${#FIX_FILES[@]}" -gt 0 ] || say '{skip: "no fix files in the diff — nothing to test"}'
+# noFix: true — a machine-readable mark, distinct from the "a test already accompanies it" skip above: there is no fix at
+# all to reproduce, so nothing downstream (Step 3.545, Step 3.55's gate) has anything to ask about. Run 11, metrolinx,
+# AMSD-2974: the story's plan correctly gave this codeline no change (every fix site NO EDIT REQUIRED, confirmed by the
+# detective's structured analysis — generator/plan-no-change-structured.js), yet the real Step 3.55 gate still ran and
+# blocked it for shipping no test, because its own no-change bypass (brownfield-repro-test-gate.sh:93-99) only recognizes
+# the pipeline's prose check (plan-gives-no-change.js), not the structured-analysis fallback this workflow also honours.
+# Reported, not patched there (orchestrations/ is the bash pipeline); this flag lets the workflow stop asking the gate
+# a question that has already been answered, here, correctly.
+[ "${#FIX_FILES[@]}" -gt 0 ] || say '{skip: "no fix files in the diff — nothing to test", noFix: true}'
 fi
 
 # :195–216 — testable source, asked of the codeline

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-workflow",
-  "version": "0.1.27",
+  "version": "0.1.29",
   "description": "The AMSD pipeline as Claude workflows. Installed by the amsd-pipeline installer: install.sh --workflows",
   "license": "UNLICENSED",
   "bin": {