amsd-pipeline-workflow 0.1.17 → 0.1.18
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/driver/release-lines.js +4 -6
- package/package.json +1 -1
package/driver/release-lines.js
CHANGED
|
@@ -114,13 +114,11 @@ function completeLineByCommit(env, wt, lineLog, linePrd, branch, log) {
|
|
|
114
114
|
if (git(wt, 'rev-parse', '--verify', '--quiet', branch).status !== 0) return;
|
|
115
115
|
if (git(wt, 'checkout', '-q', branch).status !== 0) { log(`[orch] could not check out ${branch} to read its committed work`); return; }
|
|
116
116
|
bash({ ...env, PROJECT_ROOT: wt }, 'story_resume_completed_by_commit', [wt, lineLog, linePrd], { log });
|
|
117
|
-
//
|
|
118
|
-
//
|
|
119
|
-
// A Writer-completed story carries both; this one does too.
|
|
117
|
+
// B78 (RS-5): the shared function sets `completed` AND `status` (a Writer-completed story carries both), which the line's done test reads. The driver used to
|
|
118
|
+
// patch `status` itself, behind the pipeline's back; it now only CHECKS, and an install whose function predates the fix is said — never worked around silently.
|
|
120
119
|
const p = JSON.parse(fs.readFileSync(linePrd, 'utf8'));
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
if (changed) fs.writeFileSync(linePrd, JSON.stringify(p, null, 2));
|
|
120
|
+
const half = (p.stories || []).filter((s) => s.completed === true && s.status !== 'completed' && s.status !== 'deprecated');
|
|
121
|
+
if (half.length) throw new Error(`the install's story_resume_completed_by_commit marked ${half.map((s) => s.id).join(', ')} completed without a status — it predates the fix (needs amsd-pipeline-shared >= 0.5.3: amsd-pipeline-shared install --into <install>)`);
|
|
124
122
|
}
|
|
125
123
|
|
|
126
124
|
/** A line whose every story is completed — the pipeline's own test (lib/release-lines.sh:96). */
|
package/package.json
CHANGED