amsd-pipeline-workflow 0.1.16 → 0.1.18

package/driver/release-lines.js

@@ -46,13 +46,13 @@ async function runReleaseLines(ctx, lane, clPrd, laneLog, laneEnv, canonical, ph
       // A RESUMED LINE'S COMMITTED WORK IS NOT REWRITTEN (operator, 2026-10-20): its story completed by its commit, as a lane's is
       if (env.EPAM_RESUME_RUN && fs.existsSync(linePrd)) {
         const id = (JSON.parse(fs.readFileSync(linePrd, 'utf8')).stories[0] || {}).id;
-        if (id) completeLineByCommit(env, wt, lineLog, linePrd, `${env.EPAM_BRANCH_PREFIX || ''}AI-${id}-${slug}`, log);
+        if (id) completeLineByCommit(env, wt, lineLog, linePrd, lineBranch(env, id, slug), log);
       }
       const done = lineIsDone(linePrd);
       if (bash(env, 'resume_preserves', ['completed-stories']).status === 0 && done
         && !handler(env, 'spec-predates-plan', [linePrd, canonical || clPrd]).stdout.trim()) {        // :96–106
         rerun = [];
-        const lb = `${env.EPAM_BRANCH_PREFIX || ''}AI-${JSON.parse(fs.readFileSync(linePrd, 'utf8')).stories[0].id}-${slug}`;
+        const lb = lineBranch(env, JSON.parse(fs.readFileSync(linePrd, 'utf8')).stories[0].id, slug);
         if (git(wt, 'checkout', '-q', lb).status !== 0) log(`[orch] Codeline '${cl}': could not check out ${lb} for its review`);
         handler(env, 'carry-plan', [linePrd, canonical || clPrd], { log });
         log(`[orch] Codeline '${cl}' — release line ${line} completed in this run — its reviewer judges it again against the story's plan`);
@@ -94,6 +94,16 @@ async function runReleaseLines(ctx, lane, clPrd, laneLog, laneEnv, canonical, ph
   }
 }
 
+/**
+ * A RELEASE LINE'S BRANCH NAME — the shared run-state core's ONE rule (story_branch_name, lib/git-ops.sh; backlog B75, finding RS-10), asked of the install's own
+ * function: the driver keeps no second copy of the rule. An install that predates it is said, loudly.
+ */
+function lineBranch(env, id, slug) {
+  const r = bash(env, 'story_branch_name', [id, `-${slug}`]);
+  if (r.status !== 0 || !r.stdout.trim()) throw new Error(`the install's lib/git-ops.sh has no story_branch_name (exit ${r.status}) — it needs amsd-pipeline-shared >= 0.5.2 (amsd-pipeline-shared install --into <install>)`);
+  return r.stdout.trim();
+}
+
 /**
  * A RESUMED RELEASE LINE (LIVE-AMSD-2974-11): the line's branch checked out and the pipeline's own
  * story_resume_completed_by_commit run on the line's log and PRD. The pipeline applies it to lanes only, so a line whose
@@ -104,13 +114,11 @@ function completeLineByCommit(env, wt, lineLog, linePrd, branch, log) {
   if (git(wt, 'rev-parse', '--verify', '--quiet', branch).status !== 0) return;
   if (git(wt, 'checkout', '-q', branch).status !== 0) { log(`[orch] could not check out ${branch} to read its committed work`); return; }
   bash({ ...env, PROJECT_ROOT: wt }, 'story_resume_completed_by_commit', [wt, lineLog, linePrd], { log });
-  // THE PIPELINE'S FUNCTION SETS completed ONLY; the line's done test reads status (lib/release-lines.sh:96), so a line
-  // completed by its commit read as not done, took the --reset path and was rewritten (LIVE-AMSD-2974-11, 2026-10-20).
-  // A Writer-completed story carries both; this one does too.
+  // B78 (RS-5): the shared function sets `completed` AND `status` (a Writer-completed story carries both), which the line's done test reads. The driver used to
+  // patch `status` itself, behind the pipeline's back; it now only CHECKS, and an install whose function predates the fix is said — never worked around silently.
   const p = JSON.parse(fs.readFileSync(linePrd, 'utf8'));
-  let changed = false;
-  for (const s of p.stories || []) if (s.completed === true && s.status !== 'completed' && s.status !== 'deprecated') { s.status = 'completed'; changed = true; }
-  if (changed) fs.writeFileSync(linePrd, JSON.stringify(p, null, 2));
+  const half = (p.stories || []).filter((s) => s.completed === true && s.status !== 'completed' && s.status !== 'deprecated');
+  if (half.length) throw new Error(`the install's story_resume_completed_by_commit marked ${half.map((s) => s.id).join(', ')} completed without a status — it predates the fix (needs amsd-pipeline-shared >= 0.5.3: amsd-pipeline-shared install --into <install>)`);
 }
 
 /** A line whose every story is completed — the pipeline's own test (lib/release-lines.sh:96). */
@@ -120,4 +128,4 @@ function lineIsDone(linePrd) {
   return (p.stories || []).length > 0 && p.stories.every((s) => s.status === 'completed');
 }
 
-module.exports = { runReleaseLines, completeLineByCommit, lineIsDone };
+module.exports = { runReleaseLines, completeLineByCommit, lineIsDone, lineBranch };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-workflow",
-  "version": "0.1.16",
+  "version": "0.1.18",
   "description": "The AMSD pipeline as Claude workflows. Installed by the amsd-pipeline installer: install.sh --workflows",
   "license": "UNLICENSED",
   "bin": {