amsd-pipeline-workflow 0.1.12 → 0.1.13

package/driver/run.js

@@ -404,6 +404,24 @@ function provisionCodeline(ctx, cl, wt) {
   if (fs.existsSync(ap)) { fs.mkdirSync(epam, { recursive: true }); fs.copyFileSync(ap, path.join(epam, 'anti-patterns.json')); }
 }
 
+/** A story's newest review record: the lane log's review-verdict-<story>.json, else (a run from before that record) the
+ *  newest review-feedback.json any of this lane's Writers left; null when there is none. */
+function reviewRecord(ctx, lane, env, id) {
+  const read = (f) => { try { return JSON.parse(fs.readFileSync(f, 'utf8')); } catch { return null; } };
+  const v = env.LOG_DIR && read(path.join(env.LOG_DIR, `review-verdict-${id}.json`));
+  if (v) return { verdict: v.verdict, from: `review-verdict-${id}.json` };
+  const base = path.join(ctx.runDir, 'workflows', lane.cl);
+  const found = [];
+  for (const line of (fs.existsSync(base) ? fs.readdirSync(base) : [])) for (const tag of (fs.existsSync(path.join(base, line)) ? fs.readdirSync(path.join(base, line)) : [])) {
+    const f = path.join(base, line, tag, 'writer', id, 'checks', 'runs', 'review-feedback.json');
+    if (fs.existsSync(f)) found.push({ f, t: fs.statSync(f).mtimeMs });
+  }
+  if (!found.length) return null;
+  const newest = found.sort((a, b) => b.t - a.t)[0];
+  const fb = read(newest.f);
+  return fb ? { verdict: fb.verdict, from: path.relative(ctx.runDir, newest.f) } : null;
+}
+
 // ── ONE PHASE OF ONE LANE: what `bash run-agent-orchestration.sh` does for it, around the two workflows ─────────────
 // Returns the phase's exit code (lib/phase-exit.sh).
 async function phaseRunner(ctx, lane, laneEnv, { prd, phase, args, tag, lineSlug }) {
@@ -425,6 +443,14 @@ async function phaseRunner(ctx, lane, laneEnv, { prd, phase, args, tag, lineSlug
     const p = JSON.parse(fs.readFileSync(prd, 'utf8'));
     const rq = (s) => ((s.status === 'failed' || s.status === 'blocked') && !(s.completed) ? { ...s, status: 'pending' } : s);
     p.stories = (p.stories || []).map(rq);
+    // ONCE REVIEWED, LOCKED (operator, 2026-10-20): a completed story whose newest review record is an approval is neither
+    // rewritten nor re-reviewed; an "escalated" stamp an EARLIER attempt left is cleared as the pipeline clears it on
+    // approval (lib/review-cycle.sh ~:180–195) — the stale stamp would otherwise fail Step 5 on work already approved
+    for (const s of p.stories) {
+      if (!(s.completed === true && s.reviewStatus === 'escalated')) continue;
+      const rec = reviewRecord(ctx, lane, env, s.id);
+      if (rec && rec.verdict === 'approved') { s.reviewStatus = null; log(`[driver] ${s.id}: locked — reviewed and approved (${rec.from}); its earlier escalated stamp is cleared, nothing is rewritten or re-reviewed`); }
+    }
     fs.writeFileSync(prd, JSON.stringify(p, null, 2));
   }
   // RAO:1112–1123 — the spec pass, unless the lane resumed with its spec done
@@ -471,6 +497,13 @@ async function phaseRunner(ctx, lane, laneEnv, { prd, phase, args, tag, lineSlug
     }
     // what Steps 3.545 and 3.55 stamp on the story, so a retry inherits the finding (driver/writer-stamps.js)
     if (st) applyGateStamps(st, res);
+    // THE LOCK, RECORDED where a later Writer cannot wipe it (the lane's log; its out dir is rebuilt each leg, B64): a Writer
+    // that ends 'done' ended on an approved review
+    if (res.status === 'done') {
+      const head = spawnSync('git', ['-C', lane.wt, 'rev-parse', 'HEAD'], { encoding: 'utf8' });
+      fs.mkdirSync(env.LOG_DIR, { recursive: true });
+      fs.writeFileSync(path.join(env.LOG_DIR, `review-verdict-${s.id}.json`), `${JSON.stringify({ verdict: 'approved', head: head.status === 0 ? head.stdout.trim() : null, at: new Date().toISOString() })}\n`);
+    }
     fs.writeFileSync(prd, JSON.stringify(cur, null, 2));
     // lib/prd-state.sh update_story_status (the pipeline's), on the lane's PRD
     bash({ ...env, MAIN_PRD_FILE: prd, PRD_FILE: prd }, 'update_story_status', [s.id, res.exit === 0 ? 'completed' : 'failed'], { log });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-workflow",
-  "version": "0.1.12",
+  "version": "0.1.13",
   "description": "The AMSD pipeline as Claude workflows. Installed by the amsd-pipeline installer: install.sh --workflows",
   "license": "UNLICENSED",
   "bin": {