amsd-pipeline-shared 0.5.9 → 0.5.10

package/orchestrations/scripts/lib/doctor/handle.js

@@ -91,7 +91,7 @@ async function handle(a) {
     if (git(wt, 'status', '--porcelain', '--untracked-files=no').stdout.trim()) return stop('uncommitted', 'the agent left changes to tracked files uncommitted');
 
     const layer = r.answer.layer;
-    const v = verifyRepair({ repo, base, branch, profile, layer, abortKind: c.kind });
+    const v = verifyRepair({ repo, base, branch, profile, layer, abortKind: c.kind, install });
     fs.writeFileSync(path.join(A, 'red.txt'), v.red || ''); fs.writeFileSync(path.join(A, 'green.txt'), v.green || '');
     fs.writeFileSync(path.join(A, 'patch.diff'), git(repo, 'diff', `${base}..${branch}`).stdout);
     if (!v.ok) { d.event('repair-rejected', { why: v.why }, attempt.n); return stop('rejected', v.why); }

package/orchestrations/scripts/lib/doctor/profile.js

@@ -58,6 +58,9 @@ function validate(input) {
     if (need('test', t, 'envUnset')) out.test.envUnset = strs('test.envUnset', t.envUnset, { nonEmpty: false });
     if (need('test', t, 'greenPatterns')) { if (Array.isArray(t.greenPatterns) && !t.greenPatterns.length) bad('test.greenPatterns', 'at least one pattern is required'); out.test.greenPatterns = rxs('test.greenPatterns', t.greenPatterns); }
     if (need('test', t, 'failedPattern')) out.test.failedPattern = rx('test.failedPattern', t.failedPattern);
+    // OPTIONAL: environment variables the test run needs (name -> value, {install} filled in): a test that reads the pipeline install it runs against
+    out.test.env = {};
+    if (has(t, 'env')) { if (!t.env || typeof t.env !== 'object' || Array.isArray(t.env)) bad('test.env', 'must be an object of name: value strings'); else for (const [k, v] of Object.entries(t.env)) { if (typeof v !== 'string') bad(`test.env.${k}`, 'must be a string'); else out.test.env[k] = v; } }
     // OPTIONAL: repository paths that git ignores and the tests read (a codeline copy, generated data) — linked into every throwaway worktree the verification runs its tests in
     out.test.fixtures = has(t, 'fixtures') ? (strs('test.fixtures', t.fixtures, { nonEmpty: false }) || []) : [];
     out.test.fixtures.forEach((d, i) => rel(`test.fixtures[${i}]`, d));

package/orchestrations/scripts/lib/doctor/repair.js

@@ -25,11 +25,16 @@ function expand(command, vars) {
 }
 
 /** The component's tests in a work tree; the output is the evidence. */
-function runTests(wt, files, profile) {
+function runTests(wt, files, profile, install) {
   const c = [...hostWrap(), ...expand(profile.test.command, { node: process.execPath, files })];
   // a test run started inside another test run inherits that runner's context and then reports "passed" whatever happened: the run under
   // judgement gets the environment the profile names it needs clean, so its exit code is its own
   const env = { ...process.env }; for (const k of profile.test.envUnset) delete env[k];
+  // the variables the profile gives the test run ({install} filled in: a test may read the pipeline install it runs against)
+  for (const [k, v] of Object.entries(profile.test.env || {})) {
+    if (v.includes('{install}') && !install) throw new Error(`test.env.${k} uses {install}, and no install was given to the verification`);
+    env[k] = v.replace(/\{install\}/g, install);
+  }
   const r = spawnSync(c[0], c.slice(1), { cwd: wt, env, encoding: 'utf8', maxBuffer: 64 * 1024 * 1024 });
   return { status: r.status, out: `${r.stdout || ''}${r.stderr || ''}` };
 }
@@ -55,7 +60,7 @@ function worktree(repo, rev, fixtures = []) {
 }
 const drop = (repo, wt) => { git(repo, 'worktree', 'remove', '--force', wt); git(repo, 'worktree', 'prune'); fs.rmSync(wt, { recursive: true, force: true }); };
 
-function verifyRepair({ repo, base, branch, profile, layer, abortKind }) {
+function verifyRepair({ repo, base, branch, profile, layer, abortKind, install }) {
   // the layer the agent says it repaired and how the abort was classified: both required, neither defaulted
   if (!['code', 'agentic'].includes(layer)) throw new Error(`verifyRepair needs layer 'code' or 'agentic', got ${JSON.stringify(layer)}`);
   if (typeof abortKind !== 'string' || !abortKind) throw new Error('verifyRepair needs abortKind (how the abort was classified)');
@@ -86,11 +91,11 @@ function verifyRepair({ repo, base, branch, profile, layer, abortKind }) {
     wtBase = worktree(repo, base, profile.test.fixtures);
     const co = git(wtBase, 'checkout', branch, '--', ...tests);
     if (co.status !== 0) return bad(`cannot place the tests on the base: ${co.stderr.trim()}`, { files });
-    const red = runTests(wtBase, tests, profile);
+    const red = runTests(wtBase, tests, profile, install);
     if (red.status === 0) return bad('the test passes without the fix: it is not RED, so it proves nothing', { files, red: red.out });
     // GREEN: the branch's tip
     wtTip = worktree(repo, branch, profile.test.fixtures);
-    const green = runTests(wtTip, tests, profile);
+    const green = runTests(wtTip, tests, profile, install);
     if (green.status !== 0 || !profile.test.greenPatterns.every((r) => r.test(green.out))) return bad('the test fails with the fix: not GREEN', { files, red: red.out, green: green.out });
     return { ok: true, why: 'RED on the base, GREEN with the fix', files, tests, red: red.out, green: green.out };
   } finally { if (wtBase) drop(repo, wtBase); if (wtTip) drop(repo, wtTip); }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-shared",
-  "version": "0.5.9",
+  "version": "0.5.10",
   "description": "The AMSD pipeline's shared components, one source for the bash pipeline and its Claude workflows: the model-call gateway (llm-handler.sh — retry, ladder, self-heal, cost) and the libraries it runs.",
   "license": "UNLICENSED",
   "bin": {