amsd-pipeline-shared 0.5.38 → 0.5.39

package/orchestrations/scripts/lib/prelaunch.js

@@ -375,7 +375,8 @@ function setFidelityJudge({ install, env = process.env, logDir }) {
   return async ({ prompt, schema, codeline }) => {
     const seamEnv = seamInvocationEnv('prompt-review', path.join(orchOf(install), 'agents'));
     if (seamEnv.EPAM_ALLOWED_TOOLS) seamEnv.AI_GATE_ALLOW_TOOLS = '1';
-    seamEnv.EPAM_AGENT_NAME = 'set-fidelity';
+    // the call runs AS the prompt-review seam (llm-handler resolves the seam by agent name); the ledger names the check
+    seamEnv.EPAM_AGENT_NAME = 'prompt-review';
     seamEnv.EPAM_RESPONSE_SCHEMA = spec.schemaEnv({ name: 'set_fidelity', description: 'what is geared to the ticket', parameters: schema });
     const text = await spec.runClaude(promptExec, prompt, path.join(logDir || os.tmpdir(), `set-fidelity-${codeline}.log`), seamEnv, { costAgent: 'set-fidelity' });
     const m = String(text || '').match(/\{[\s\S]*\}/);

package/orchestrations/scripts/spec-mode-runner.js

@@ -4470,13 +4470,29 @@ const TOOL_ROSTER_REVIEW = {
     'checked with your tools. Do not answer in prose.',
   parameters: {
     type: 'object',
-    required: ['verdict', 'findings'],
+    required: ['verdict', 'findings', 'roles'],
     properties: {
       verdict: {
         type: 'string',
         enum: ['sound', 'defects_found', 'nothing_to_review'],
         description: 'sound = every checkable claim held. defects_found = at least one did not.',
       },
+      // A ROLE OUTLIVES THE TICKET (operator, 2026-10-24): the roster is kept with its codelines and reused for every later story, so
+      // every minted role is answered for, one by one — the rule in prose alone was answered "sound" on a roster whose every agent was
+      // named after the ticket. A role that does not outlive the ticket becomes a blocking finding (rolesOutliveTicketFindings).
+      roles: {
+        type: 'array',
+        description: 'One entry for EVERY minted role reviewed.',
+        items: {
+          type: 'object',
+          required: ['name', 'outlivesTicket', 'why'],
+          properties: {
+            name: { type: 'string', description: 'The minted role, named exactly as in the roster.' },
+            outlivesTicket: { type: 'boolean', description: 'true only when this role — its name and its brief — would serve a story on this codeline about something OTHER than the current ticket: named for the kind of engineer/investigator and the codeline, briefed on the codeline, not on this ticket\'s subject, components or files (except as marked examples).' },
+            why: { type: 'string', description: 'Quote the words that gear the role to the ticket, or say what makes it the codeline\'s.' },
+          },
+        },
+      },
       findings: {
         type: 'array',
         items: {
@@ -4885,6 +4901,19 @@ function _readJsonOrNull(f) {
  * Extracted and exported because it could not be tested otherwise: it sat inside the async function
  * that also does the batching and makes the model calls, so exercising it meant paying for a run.
  */
+/** A ROLE THAT DOES NOT OUTLIVE THE TICKET IS A BLOCKING FINDING (operator, 2026-10-24): the review answers for every minted role
+ *  (TOOL_ROSTER_REVIEW.roles); one it marks outlivesTicket:false — named or briefed for the ticket in scope rather than the codeline —
+ *  is turned into the finding the mint's correction loop acts on. The reviewer's own words are the claim. */
+function rolesOutliveTicketFindings(part) {
+  const roles = part && Array.isArray(part.roles) ? part.roles : [];
+  return roles.filter((r) => r && r.name && r.outlivesTicket === false).map((r) => ({
+    agent: String(r.name), severity: 'blocking', claim: String(r.why || '(the reviewer gave no words)'),
+    checked: 'whether this role, as named and briefed, would serve a story on its codeline about something other than the current ticket',
+    found: 'minted for the ticket in scope, not for the codeline it is kept with',
+    remedy: 'a role named for its kind of work and its codeline, briefed on the codeline — its stack, conventions and how to verify there — naming the current ticket only as a marked example',
+  }));
+}
+
 function aggregateRosterReview(results, legalVerdicts) {
   const legal = Array.isArray(legalVerdicts) ? legalVerdicts : [];
   const rows = Array.isArray(results) ? results : [];
@@ -4892,7 +4921,9 @@ function aggregateRosterReview(results, legalVerdicts) {
   const unexamined = rows.filter((r) => !r || !r.part || typeof r.part !== 'object'
     || r.part.verdict === 'nothing_to_review' || !r.part.verdict || illegal(r.part.verdict));
   const examined = rows.filter((r) => !unexamined.includes(r));
-  const findings = rows.flatMap((r) => (r && r.part && Array.isArray(r.part.findings) ? r.part.findings : []));
+  // a role an examined batch says does not outlive the ticket is a finding of that batch, whatever verdict it gave
+  const roleFindings = examined.flatMap((r) => rolesOutliveTicketFindings(r.part));
+  const findings = rows.flatMap((r) => (r && r.part && Array.isArray(r.part.findings) ? r.part.findings : [])).concat(roleFindings);
 
   if (!examined.length) {
     return {
@@ -4903,7 +4934,7 @@ function aggregateRosterReview(results, legalVerdicts) {
     };
   }
 
-  const verdict = examined.some((r) => r.part.verdict === 'defects_found') ? 'defects_found' : 'sound';
+  const verdict = (examined.some((r) => r.part.verdict === 'defects_found') || roleFindings.length) ? 'defects_found' : 'sound';
   return {
     verdict,
     findings,
@@ -11107,7 +11138,7 @@ module.exports = {
   storyAcsBlock,
   specAgentContract,
   rosterReviewVerdict,
-  aggregateRosterReview,
+  aggregateRosterReview, rolesOutliveTicketFindings,
   reviewOutcomeKeepsChange,
   // Exported so the brief lookup can be asserted without a run.
   profilesWithProjectBriefs,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-shared",
-  "version": "0.5.38",
+  "version": "0.5.39",
   "description": "The AMSD pipeline's shared components, one source for the bash pipeline and its Claude workflows: the model-call gateway (llm-handler.sh — retry, ladder, self-heal, cost) and the libraries it runs.",
   "license": "UNLICENSED",
   "bin": {