amsd-pipeline-shared 0.5.20 → 0.5.21

package/orchestrations/scripts/lib/doctor/repair.js

@@ -97,10 +97,32 @@ function verifyRepair({ repo, base, branch, profile, layer, abortKind, install }
     wtTip = worktree(repo, branch, profile.test.fixtures);
     const green = runTests(wtTip, tests, profile, install);
     if (green.status !== 0 || !profile.test.greenPatterns.every((r) => r.test(green.out))) return bad('the test fails with the fix: not GREEN', { files, red: red.out, green: green.out });
-    return { ok: true, why: 'RED on the base, GREEN with the fix', files, tests, red: red.out, green: green.out };
+    // NOTHING THAT USES THE CHANGED FILE IS BROKEN (LIVE-AMSD-2974-11, 2026-10-22: a RED/GREEN fix broke the test that reads the record
+    // listing every changed file, and the doctor never ran it): each existing user is run on the fix; one that passed on the base fails it
+    const regression = usersOf(repo, branch, src, tests, profile);
+    const broken = regression.filter((t) => runTests(wtTip, [t], profile, install).status !== 0 && runTests(wtBase, [t], profile, install).status === 0);
+    if (broken.length) return bad(`the fix breaks ${broken.join(', ')}, which passed on the base: an existing user of the changed file`, { files, red: red.out, green: green.out, regression });
+    return { ok: true, why: 'RED on the base, GREEN with the fix, and every existing user of the changed file still passes', files, tests, regression, red: red.out, green: green.out };
   } finally { if (wtBase) drop(repo, wtBase); if (wtTip) drop(repo, wtTip); }
 }
 
+/**
+ * The component's existing tests that use a changed file: a test that names it, or names a file of the component that names it (a record
+ * listing it, a script calling it). The repair's own tests and the profile's forbidden (monolithic) tests are not among them.
+ */
+function usersOf(repo, rev, src, own, profile) {
+  const { repairDirs, testDirs, testFile, forbiddenTests } = profile.scope;
+  const named = (names, dirs) => {
+    if (!names.length) return [];
+    const r = git(repo, 'grep', '-l', '-F', ...names.flatMap((n) => ['-e', n]), rev, '--', ...dirs);
+    return r.status === 0 ? r.stdout.split('\n').filter(Boolean).map((l) => l.slice(rev.length + 1)) : [];
+  };
+  const base = (fs_) => [...new Set(fs_.map((f) => path.posix.basename(f)))];
+  const referrers = named(base(src), repairDirs).filter((f) => !src.includes(f));
+  return named(base([...src, ...referrers]), testDirs)
+    .filter((f) => testFile.test(f) && !own.includes(f) && !forbiddenTests.some((r) => r.test(f))).sort();
+}
+
 // ── the reinstall: the component's own installer, then every packaged file compared byte for byte ─────────────────────
 const show = (repo, rev, rel) => spawnSync('git', ['-C', repo, 'show', `${rev}:${rel}`], { encoding: 'buffer', maxBuffer: 64 * 1024 * 1024 });
 

package/orchestrations/scripts/lib/handlers/stories-lacking-spec.js

@@ -21,12 +21,19 @@ const fs = require('fs');
  * A STORY THAT SPANS CODELINES IS SPECIFIED PER CODELINE. In a lane's PRD (story.codeline = the lane)
  * the spec mark from another lane is not this lane's spec: AMSD-2974's three site lanes skipped their
  * spec pass on a resume because cxshared's spec had stamped the story (2026-10-01). The lane's own
- * fix-site entry is the mark that this codeline was investigated.
+ * fix-site entry is the mark that this codeline was investigated — but only when specification.codeline
+ * is itself unknown. Once it names a lane, that name is definite: AMSD-2974 run 11 attempt 5 had it
+ * naming cxshared on every consumer lane's own PRD copy, and the fixSiteAnalysisPerCodeline fallback
+ * (populated once, for every codeline together, by the cross-codeline detective pass) wrongly read each
+ * consumer's own entry there as proof its OWN coordinator review had run, when it never had.
  */
 function lacksOwnLane(s) {
   if (!Array.isArray(s.codelines) || s.codelines.length < 2 || !s.codeline) return false;
+  const specCodeline = s.specification && s.specification.runId ? s.specification.codeline : undefined;
   // This lane's own spec pass stamped its codeline on the spec (spec-mode-runner.js stampSpecification).
-  if (s.specification && s.specification.runId && s.specification.codeline === s.codeline) return false;
+  if (specCodeline === s.codeline) return false;
+  // A KNOWN different lane is a definite mismatch — never excused by the legacy fallback below.
+  if (specCodeline) return true;
   const own = s.fixSiteAnalysisPerCodeline;
   return !(own && Object.prototype.hasOwnProperty.call(own, s.codeline));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amsd-pipeline-shared",
-  "version": "0.5.20",
+  "version": "0.5.21",
   "description": "The AMSD pipeline's shared components, one source for the bash pipeline and its Claude workflows: the model-call gateway (llm-handler.sh — retry, ladder, self-heal, cost) and the libraries it runs.",
   "license": "UNLICENSED",
   "bin": {