amqplib 1.0.2 → 1.0.3

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change log for amqplib
 
+## v1.0.3
+- Fix AssertionError crash when backpressure occurs while draining newStreams in Mux (fixes #841)
+
 ## v1.0.2
 - Replace url-parse with WHATWG URL API
 

package/lib/mux.js

@@ -40,14 +40,13 @@ class Mux {
     // Try to read a chunk from each stream in turn, until all streams
     // are empty, or we exhaust our ability to accept chunks.
     function roundrobin(streams) {
-      let stream = streams.shift();
-      while (accepting && stream) {
+      while (accepting && streams.length > 0) {
+        const stream = streams.shift();
         const chunk = stream.read();
         if (chunk !== null) {
           accepting = out.write(chunk);
           streams.push(stream);
         }
-        stream = streams.shift();
       }
     }
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "amqplib",
   "homepage": "http://amqp-node.github.io/amqplib/",
   "main": "./channel_api.js",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "An AMQP 0-9-1 (e.g., RabbitMQ) library and client.",
   "repository": {
     "type": "git",

package/test/mux.test.js

@@ -184,6 +184,49 @@ describe('mux', () => {
     });
   });
 
+  it('backpressure does not crash when newStreams is drained', () => {
+    // Regression test: out.write() returns false (backpressure) while
+    // draining newStreams. The buggy code does an unconditional shift at the
+    // bottom of the loop, so if the next stream reads null (empty) it gets
+    // discarded without being pushed back, leaving newStreams empty and
+    // triggering assert(this.newStreams.length > 0) in the else-branch.
+    //
+    // Scenario: newStreams = [input1, input2], input1 has data, input2 empty.
+    // - shift input1, read 1, write → backpressure (false), push input1 back
+    // - (buggy) unconditional shift takes input2, loop condition false → exit
+    // - newStreams = [input1], length > 0, assert passes  ← not the bug path
+    //
+    // The crash path requires backpressure AND the shifted stream reading null
+    // with no other streams remaining. Use a single stream that has data, then
+    // engineer a second read() on the same stream returning null after the
+    // write so the stream is not pushed back, emptying newStreams entirely.
+    const input1 = stream();
+    const output = stream();
+    const mux = new Mux(output);
+
+    mux.newStreams.push(input1);
+    input1.write(1);
+
+    // After the first write (which triggers backpressure), wrap read() so
+    // the stream appears empty on the next call — simulating a stream that
+    // had one item buffered and is now drained within the same roundrobin pass.
+    const originalRead = input1.read.bind(input1);
+    let readCount = 0;
+    input1.read = (size) => {
+      readCount++;
+      if (readCount > 1) return null; // appear empty after first read
+      return originalRead(size);
+    };
+
+    const originalWrite = output.write.bind(output);
+    output.write = (...args) => {
+      originalWrite(...args);
+      return false; // signal backpressure immediately
+    };
+
+    assert.doesNotThrow(() => mux._readIncoming());
+  });
+
   it('roundrobin', (_t, done) => {
     const input1 = stream();
     const input2 = stream();

package/.claude/settings.local.json

@@ -1,16 +0,0 @@
-{
-  "permissions": {
-    "allow": [
-      "Bash(npx oxlint:*)",
-      "Bash(npm t)",
-      "Bash(git add:*)",
-      "Bash(git commit:*)",
-      "Bash(npm run lint:*)",
-      "Bash(git checkout:*)",
-      "Bash(npx biome lint:*)",
-      "Bash(node:*)"
-    ],
-    "deny": [],
-    "ask": []
-  }
-}