amqplib 1.0.0 → 1.0.1

package/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Change log for amqplib
 
+## v1.0.1
+- Fix TLS connection failure when connecting to an AMQPS broker using an IP address (IPv4 or IPv6) — setting servername to an IP is not permitted by TLS SNI and throws ERR_INVALID_ARG_VALUE in Node.js 25+
+
 ## v1.0.0
 - **BREAKING**: Update minimum Node.js requirement to v18
 - Introduce Biome formatter for consistent code formatting

package/README.md

@@ -9,11 +9,6 @@ A library for making AMQP 0-9-1 clients for Node.JS, and an AMQP 0-9-1 client fo
 
     npm install amqplib
 
-## ❤️ Help Support Jack
-One of my close friends, Jack, was recently diagnosed with terminal brain cancer (grade 4 astrocytoma). He’s a young father facing an unimaginably tough road with remarkable courage. Thanks to chemotherapy, radiotherapy, and your support, two of his tumours have stopped showing activity. Donations help Jack continue accessing promising complementary therapies, attend hospital appointments, and spend meaningful time with his children.
-
-If you’ve benefited from amqplib, please consider supporting Jack’s journey through his [J Crushing Cancer](https://www.gofundme.com/f/j-crushing-cancer) gofundme page. Thank you - @cressie176
-
 ## RabbitMQ Compatibility
 
 Only `0.10.7` and later versions of this library are compatible with RabbitMQ 4.1.0 (and later releases).

package/lib/connect.js

@@ -1,5 +1,7 @@
 const URL = require('url-parse');
 const QS = require('node:querystring');
+const net = require('node:net');
+const tls = require('node:tls');
 const Connection = require('./connection').Connection;
 const fmt = require('node:util').format;
 const credentials = require('./credentials');
@@ -98,7 +100,7 @@ function connect(url, socketOptions, openCallback) {
   if (typeof url === 'object') {
     protocol = `${url.protocol || 'amqp'}:`;
     sockopts.host = url.hostname;
-    sockopts.servername = sockopts.servername || url.hostname;
+    if (!sockopts.servername && !net.isIP(url.hostname)) sockopts.servername = url.hostname;
     sockopts.port = url.port || (protocol === 'amqp:' ? 5672 : 5671);
 
     let user;
@@ -126,7 +128,7 @@ function connect(url, socketOptions, openCallback) {
     const host = parts.hostname.replace(/^\[|\]$/g, '');
     protocol = parts.protocol;
     sockopts.host = host;
-    sockopts.servername = sockopts.servername || host;
+    if (!sockopts.servername && !net.isIP(host)) sockopts.servername = host;
     sockopts.port = parseInt(parts.port, 10) || (protocol === 'amqp:' ? 5672 : 5671);
     const vhost = parts.pathname ? parts.pathname.substr(1) : null;
     fields = openFrames(vhost, parts.query, sockopts.credentials || credentialsFromUrl(parts), extraClientProperties);
@@ -157,9 +159,9 @@ function connect(url, socketOptions, openCallback) {
   }
 
   if (protocol === 'amqp:') {
-    sock = require('node:net').connect(sockopts, onConnect);
+    sock = net.connect(sockopts, onConnect);
   } else if (protocol === 'amqps:') {
-    sock = require('node:tls').connect(sockopts, onConnect);
+    sock = tls.connect(sockopts, onConnect);
   } else {
     throw new Error(`Expected amqp: or amqps: as the protocol; got ${protocol}`);
   }

package/package.json

@@ -2,7 +2,7 @@
   "name": "amqplib",
   "homepage": "http://amqp-node.github.io/amqplib/",
   "main": "./channel_api.js",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "An AMQP 0-9-1 (e.g., RabbitMQ) library and client.",
   "repository": {
     "type": "git",