amqplib 0.10.3 → 0.10.5

package/.github/ISSUE_TEMPLATE/bug_report.md

@@ -23,15 +23,18 @@ Before reporting a bug or requesting support please...
    - https://www.cloudamqp.com/blog/part1-rabbitmq-for-beginners-what-is-rabbitmq.html
    - https://www.rabbitmq.com/tutorials/amqp-concepts.html
 
-If the above does not help, please provide the following information...
+If the above does not help, please provide as much of the following information as is relevant...
 
-  - A clear and concise description of what the bug is.
+  - A clear and concise description of the problem
   - RabbitMQ version
   - amqplib version
+  - Node.js version
+  - The simplest possible code snippet that demonstrates the problem
+  - A stack trace
 
-If you include code snippets, please format them so they are easier to read
+Please format code snippets and/or stack traces using GitHub Markdown
 
-- https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks
+  - https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks).
 
 Thank you
 

package/.github/workflows/publish.yml

@@ -0,0 +1,59 @@
+name: Publish
+
+on:
+  release:
+    types: [created]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    services:
+      rabbitmq:
+        image: rabbitmq:3-alpine
+        ports:
+          - 5672:5672
+
+    strategy:
+      matrix:
+        node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
+        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: "npm"
+
+      - run: npm ci
+
+      - run: |
+          n=0
+          while :
+          do
+            sleep 5
+            echo 'HELO\n\n\n\n' | nc localhost 5672 | grep AMQP
+            [[ $? = 0 ]] && break || ((n++))
+            (( n >= 5 )) && break
+          done
+
+      - run: echo 'HELO\n\n\n\n' | nc localhost 5672 | grep AMQP
+
+      - run: make test
+
+  publish:
+    needs: build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: '20.x'
+          cache: "npm"
+          registry-url: https://registry.npmjs.org/
+      - run: npm ci
+      - run: npm publish --dry-run
+        env:
+          NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

package/.github/workflows/test.yml

@@ -14,13 +14,13 @@ jobs:
     runs-on: ubuntu-latest
     services:
       rabbitmq:
-        image: rabbitmq
+        image: rabbitmq:3.12-alpine
         ports:
           - 5672:5672
 
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x, 16.x, 18.x]
+        node-version: [10.x, 12.x, 14.x, 16.x, 18.x, 20.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:
@@ -34,5 +34,18 @@ jobs:
       # Install all prerequisites
       - run: npm ci
 
+      # Ensure RabbitMQ is available before continuing
+      - run: |
+          n=0
+          while :
+          do
+            sleep 5
+            echo 'HELO\n\n\n\n' | nc localhost 5672 | grep AMQP
+            [[ $? = 0 ]] && break || ((n++))
+            (( n >= 5 )) && break
+          done
+
+      - run: echo 'HELO\n\n\n\n' | nc localhost 5672 | grep AMQP
+
       # Run the tests
       - run: make test

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Change log for amqplib
 
+## Changes in v0.10.5
+
+    git log v0.10.4..v0.10.5
+
+- Removed readable stream - See https://github.com/amqp-node/amqplib/issues/729
+- Added support for unsigned integers - See https://github.com/amqp-node/amqplib/pull/773
+- Committed protocol definitions - See https://github.com/amqp-node/amqplib/commit/0a87ee480311633cff41e43350a90cb3c1221506
+
+## Changes in v0.10.4
+
+- Improve stream example as per https://github.com/amqp-node/amqplib/issues/722
+- Added support for RabbitMQ's connection update-secret operation. See https://github.com/amqp-node/amqplib/issues/755
+
 ## Changes in v0.10.3
 
     git log v0.10.2..v0.10.3
@@ -18,7 +31,7 @@
 
     git log v0.10.0..v0.10.1
 
- * Allow servername to be specified via socket options as discussed in as discussed in
+ * Allow servername to be specified via socket options as discussed in
    [issue 697](https://github.com/squaremo/amqp.node/issues/697)
 
 ## Changes in v0.10.0

package/Makefile

@@ -1,42 +1,44 @@
-RABBITMQ_SRC_VERSION=rabbitmq_v3_2_1
+RABBITMQ_SRC_VERSION=v3.12.13
 JSON=amqp-rabbitmq-0.9.1.json
-RABBITMQ_CODEGEN=https://raw.githubusercontent.com/rabbitmq/rabbitmq-codegen
-AMQP_JSON=$(RABBITMQ_CODEGEN)/$(RABBITMQ_SRC_VERSION)/$(JSON)
+AMQP_JSON=https://raw.githubusercontent.com/rabbitmq/rabbitmq-server/$(RABBITMQ_SRC_VERSION)/deps/rabbitmq_codegen/$(JSON)
 
-NODEJS_VERSIONS='10.21' '11.15' '12.18' '13.14' '14.5' '15.8' '16.3.0' '18.1.0'
+NODEJS_VERSIONS='10.21' '11.15' '12.18' '13.14' '14.5' '15.8' '16.3.0' '18.1.0' '20.10.0'
 
 MOCHA=./node_modules/.bin/mocha
 _MOCHA=./node_modules/.bin/_mocha
 UGLIFY=./node_modules/.bin/uglifyjs
 NYC=./node_modules/.bin/nyc
 
-.PHONY: test test-all-nodejs all clean coverage
+.PHONY: test test-all-nodejs coverage lib/defs.js
 
-all: lib/defs.js
+error:
+	@echo "Please choose one of the following targets: test, test-all-nodejs, coverage, lib/defs.js"
+	@exit 1
 
-clean:
-	rm lib/defs.js bin/amqp-rabbitmq-0.9.1.json
-	rm -rf ./coverage
-
-lib/defs.js: $(UGLIFY) bin/generate-defs.js bin/amqp-rabbitmq-0.9.1.json
-	(cd bin; node ./generate-defs.js > ../lib/defs.js)
-	$(UGLIFY) ./lib/defs.js -o ./lib/defs.js \
-		-c 'sequences=false' --comments \
-		-b 'indent-level=2' 2>&1 | (grep -v 'WARN' || true)
-
-test: lib/defs.js
+test:
 	$(MOCHA) --check-leaks -u tdd --exit test/
 
-test-all-nodejs: lib/defs.js
+test-all-nodejs:
 	for v in $(NODEJS_VERSIONS); \
 		do echo "-- Node version $$v --"; \
 		nave use $$v $(MOCHA) -u tdd --exit -R progress test; \
 		done
 
-coverage: $(NYC) lib/defs.js
-	$(NYC) --reporter=lcov --reporter=text $(_MOCHA) -u tdd -R progress test/
+coverage: $(NYC)
+	$(NYC) --clean --reporter=lcov --reporter=text $(_MOCHA) -u tdd --exit -R progress test/
 	@echo "HTML report at file://$$(pwd)/coverage/lcov-report/index.html"
 
+lib/defs.js: clean bin/generate-defs test
+
+clean:
+	rm -f lib/defs.js bin/amqp-rabbitmq-0.9.1.json
+
+bin/generate-defs: $(UGLIFY) bin/generate-defs.js bin/amqp-rabbitmq-0.9.1.json
+	(cd bin; node ./generate-defs.js > ../lib/defs.js)
+	$(UGLIFY) ./lib/defs.js -o ./lib/defs.js \
+		-c 'sequences=false' --comments \
+		-b 'indent-level=2' 2>&1 | (grep -v 'WARN' || true)
+
 bin/amqp-rabbitmq-0.9.1.json:
 	curl -L $(AMQP_JSON) > $@
 

package/README.md

@@ -13,7 +13,6 @@
  * [Troubleshooting][gh-pages-trouble]
  * [Examples from RabbitMQ tutorials][tutes]
 
-
 A library for making AMQP 0-9-1 clients for Node.JS, and an AMQP 0-9-1 client for Node.JS v10+.
 
 This library does not implement [AMQP
@@ -87,7 +86,7 @@ const amqplib = require('amqplib');
   // Listener
   ch1.consume(queue, (msg) => {
     if (msg !== null) {
-      console.log('Recieved:', msg.content.toString());
+      console.log('Received:', msg.content.toString());
       ch1.ack(msg);
     } else {
       console.log('Consumer cancelled by server');