amqplib 0.10.0 → 0.10.3

package/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,38 @@
+---
+name: Bug report / Support request
+about: Report a bug or ask for help
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+Before reporting a bug or requesting support please... 
+
+1. Read the troubleshooting guide
+
+   - https://amqp-node.github.io/amqplib/#troubleshooting
+
+2. Search for existing open and closed issues
+
+   - https://github.com/amqp-node/amqplib/issues?q=is%3Aissue+TYPE+YOUR+KEYWORDS+HERE
+
+3. Ensure you are familiar with the amqplib Channel API and RabbitMQ basics
+
+   - https://amqp-node.github.io/amqplib/channel_api.html
+   - https://www.cloudamqp.com/blog/part1-rabbitmq-for-beginners-what-is-rabbitmq.html
+   - https://www.rabbitmq.com/tutorials/amqp-concepts.html
+
+If the above does not help, please provide the following information...
+
+  - A clear and concise description of what the bug is.
+  - RabbitMQ version
+  - amqplib version
+
+If you include code snippets, please format them so they are easier to read
+
+- https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks
+
+Thank you
+
+

package/CHANGELOG.md

@@ -1,6 +1,30 @@
 # Change log for amqplib
 
-## Chagnes in v0.10.0
+## Changes in v0.10.3
+
+    git log v0.10.2..v0.10.3
+
+- Use @acuminous/bitsyntax fork. See https://github.com/amqp-node/amqplib/issues/453
+
+## Changes in v0.10.2
+
+    git log v0.10.1..v0.10.2
+
+- Use Buffer.allocUnsafe when sending messages to improve performance ([PR
+  695](https://github.com/amqp-node/amqplib/pull/695), thank you
+  @chkimes and @Uzlopak)
+
+## Changes in v0.10.1
+
+    git log v0.10.0..v0.10.1
+
+ * Allow servername to be specified via socket options as discussed in as discussed in
+   [issue 697](https://github.com/squaremo/amqp.node/issues/697)
+
+## Changes in v0.10.0
+
+    git log v0.9.1..v0.10.0
+
  * Use Native promises ([PR
    689](https://github.com/amqp-node/amqplib/pull/689), thank you
    @mohd-akram and @kibertoad)

package/lib/connect.js

@@ -106,7 +106,7 @@ function connect(url, socketOptions, openCallback) {
   if (typeof url === 'object') {
     protocol = (url.protocol || 'amqp') + ':';
     sockopts.host = url.hostname;
-    sockopts.servername = url.hostname;
+    sockopts.servername = sockopts.servername || url.hostname;
     sockopts.port = url.port || ((protocol === 'amqp:') ? 5672 : 5671);
 
     var user, pass;
@@ -131,7 +131,7 @@ function connect(url, socketOptions, openCallback) {
     var parts = URL(url, true); // yes, parse the query string
     protocol = parts.protocol;
     sockopts.host = parts.hostname;
-    sockopts.servername = parts.hostname;
+    sockopts.servername = sockopts.servername || parts.hostname;
     sockopts.port = parseInt(parts.port) || ((protocol === 'amqp:') ? 5672 : 5671);
     var vhost = parts.pathname ? parts.pathname.substr(1) : null;
     fields = openFrames(vhost, parts.query, sockopts.credentials || credentialsFromUrl(parts), extraClientProperties);

package/lib/connection.js

@@ -560,7 +560,11 @@ C.sendMessage = function(channel,
   var allLen = methodHeaderLen + bodyLen;
 
   if (allLen < SINGLE_CHUNK_THRESHOLD) {
-    var all = Buffer.alloc(allLen);
+    // Use `allocUnsafe` to avoid excessive allocations and CPU usage
+    // from zeroing. The returned Buffer is not zeroed and so must be
+    // completely filled to be used safely.
+    // See https://github.com/amqp-node/amqplib/pull/695
+    var all = Buffer.allocUnsafe(allLen);
     var offset = mframe.copy(all, 0);
     offset += pframe.copy(all, offset);
 
@@ -570,7 +574,11 @@ C.sendMessage = function(channel,
   }
   else {
     if (methodHeaderLen < SINGLE_CHUNK_THRESHOLD) {
-      var both = Buffer.alloc(methodHeaderLen);
+      // Use `allocUnsafe` to avoid excessive allocations and CPU usage
+      // from zeroing. The returned Buffer is not zeroed and so must be
+      // completely filled to be used safely.
+      // See https://github.com/amqp-node/amqplib/pull/695
+      var both = Buffer.allocUnsafe(methodHeaderLen);
       var offset = mframe.copy(both, 0);
       pframe.copy(both, offset);
       buffer.write(both);

package/lib/frame.js

@@ -8,7 +8,7 @@ var defs = require('./defs');
 var constants = defs.constants;
 var decode = defs.decode;
 
-var Bits = require('bitsyntax');
+var Bits = require('@acuminous/bitsyntax');
 
 module.exports.PROTOCOL_HEADER = "AMQP" + String.fromCharCode(0, 0, 9, 1);
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "amqplib",
   "homepage": "http://amqp-node.github.io/amqplib/",
   "main": "./channel_api.js",
-  "version": "0.10.0",
+  "version": "0.10.3",
   "description": "An AMQP 0-9-1 (e.g., RabbitMQ) library and client.",
   "repository": {
     "type": "git",
@@ -12,7 +12,7 @@
     "node": ">=10"
   },
   "dependencies": {
-    "bitsyntax": "~0.1.0",
+    "@acuminous/bitsyntax": "^0.1.2",
     "buffer-more-ints": "~1.0.0",
     "readable-stream": "1.x >=1.1.9",
     "url-parse": "~1.5.10"