amphora 8.3.0 → 8.4.1-dev.0

package/lib/render.js

@@ -1,6 +1,6 @@
 'use strict';
 
-var uriRoutes, renderers,
+var uriRoutes, renderers, errorHandler,
   db = require('./services/db'),
   log = require('./services/logger').setup({
     file: __filename,
@@ -264,6 +264,16 @@ function logTime(hrStart, uri) {
   };
 }
 
+/**
+ * Passes page error handling back to the site.
+ *
+* @param {Function} handler - (error, response, next) => {}
+*/
+function registerErrorHandler(handler) {
+  errorHandler = handler;
+}
+
+
 /**
  * Run composer by translating url to a "page" by base64ing it.  Errors are handled by Express.
  *
@@ -276,17 +286,25 @@ function renderExpressRoute(req, res, next) {
   var hrStart = process.hrtime(),
     site = res.locals.site,
     prefix = `${getExpressRoutePrefix(site)}/_uris/`,
-    pageReference = `${prefix}${buf.encode(req.hostname + req.baseUrl + req.path)}`;
+    // We're using decodeURIComponent to match any encoded value that might be sent by the browser.
+    // An example of this is a smart quote ’ -- That value is going to be encoded to `%E2%80%99`.
+    // We store the actual symbol in our database, not the encoded value, so, when decoding it, we ensure we can get the direct symbol
+    // and, in consequence, the page we're looking for.
+    pageReference = `${prefix}${buf.encode(req.hostname + req.baseUrl + decodeURIComponent(req.path))}`;
 
   return module.exports.renderUri(pageReference, req, res, hrStart)
     .catch((error) => {
-      if (error.name === 'NotFoundError') {
-        log('info', `could not find resource ${req.uri}`, {
-          message: error.message
-        });
-        next();
+      if (errorHandler) {
+        errorHandler(error, res, next);
       } else {
-        next(error);
+        if (error.name === 'NotFoundError') {
+          log('info', `could not find resource ${req.uri}`, {
+            message: error.message
+          });
+          next();
+        } else {
+          next(error);
+        }
       }
     });
 }
@@ -373,6 +391,7 @@ module.exports.findRenderer = findRenderer;
 // Setup
 module.exports.renderers = {}; // Overriden when a user registers a render object
 module.exports.registerRenderers = registerRenderers;
+module.exports.registerErrorHandler = registerErrorHandler;
 
 // For Testing
 module.exports.resetUriRouteHandlers = resetUriRouteHandlers;

package/lib/setup.js

@@ -35,6 +35,7 @@ module.exports = function (options = {}) {
       providers = [],
       sessionStore,
       renderers,
+      errorHandler,
       plugins = [],
       bootstrap = true,
       storage = false,
@@ -58,6 +59,10 @@ module.exports = function (options = {}) {
     render.registerRenderers(renderers);
   }
 
+  if (errorHandler) {
+    render.registerErrorHandler(errorHandler);
+  }
+
   // Make sure the storage module is run, then bootstrap
   // all the default data and finally return the router
   return storage.setup()

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "amphora",
-  "version": "8.3.0",
+  "version": "8.4.1-dev.0",
   "description": "An API mixin for Express that saves, publishes and composes data with the key-value store of your choice.",
   "main": "index.js",
   "scripts": {