amicus 4.8.0 → 4.9.0

package/src/workspace/live-normalize.js

@@ -50,7 +50,8 @@ function seatOf(leg) {
     model: leg.model || null,
     modelInput: leg.modelInput || null,
     role: leg.role || null,
-    // ⚠️ v4.8 R5: the leg's seat id, and the reason live-dead-seats.js:209's
+    // ⚠️ v4.8 R5: the leg's seat id, and the reason live-dead-seats.js ::
+    // deadSeats' `if (s.seat)` suppression arm's
     // `if (s.seat)` arm is reachable at all. Null on a unique-alias bench, so the
     // guard there stays load-bearing — see the comment at that line.
     seat: leg.seat || null,

package/src/workspace/matrix-model.js

@@ -15,7 +15,8 @@
  * unconditionally (src/council/tally.js :: tally) — it is never a real source for
  * either the override badge or the post-override tier. Only `buildVerdict`
  * materializes `{from,to,reason}` and rewrites `tier` to `tierOverride.to`
- * (src/council/verdict.js:122-126). So both fields are joined in from
+ * (src/council/verdict.js :: buildVerdict's `findings` map — re-anchored BY SYMBOL at v4.9 W9,
+ * which shifted the old `:128-132`). So both fields are joined in from
  * verdict.findings[] by `id`; when verdict is absent/unparseable (caller
  * passes null/undefined, or a finding has no verdict-side counterpart) the
  * row falls back to tally's own (pre-override) tier and renders no badge.
@@ -183,7 +184,10 @@ function buildMatrixModel(tally, labelMap, verdict) {
       // ⚠️ DE-ROT (F29): v4.1 decorates tally.json findings in place with
       // `debate: {action, previousTier}` (src/council/debate.js :: decorateRecord; action ∈
       // defended|amended|withdrawn|no-response) and verdict.json carries it through
-      // (src/council/verdict.js:43). Consumed by electron/workspace-ui/workspace-matrix.js's
+      // (src/council/verdict.js :: buildVerdict's `if (f.debate)` carry-through — the old
+      // `:43` was ALREADY rotted onto summarizeSeatLoss, which has since left verdict.js
+      // altogether; re-anchored by symbol, not re-numbered). Consumed by
+      // electron/workspace-ui/workspace-matrix.js's
       // renderMatrix, which renders a `.debate-badge` in the tier cell (alongside the
       // thin/tierOverride badges) so a withdrawn/amended/defended/no-response finding never
       // renders as an ordinary live row. Absent on non-debate runs, hence `|| null`.

package/src/workspace/run-detail.js

@@ -124,13 +124,13 @@ function costPanel(run, tally) {
 
 // ⚠️ PRE-FLIGHT (P3): F04's correction is implemented here rather than left as prose.
 // VERIFIED on shipped main (Task 0): `finalize(exitCode, error)` writes `error: error || null`
-// (src/council/run.js:98-100), and `return finalize(degraded.value ? 2 : 0)` (:293) is the ONLY
+// (run-finalize.js :: writeRunTerminal), and `return finalize(degraded.value ? 2 : 0)` (run.js:294) is the ONLY
 // exit-2 path — it passes NO error. Every error-bearing call is `finalize(1, …)`. So on a
 // `status:'partial'` run — precisely the run this panel exists to explain — `run.error` is
 // GUARANTEED null, and the old one-line formula rendered "undefined: undefined".
 // Name the stage instead. Stage status is a closed set (DE-ROT F19): running / complete /
-// skipped / error, and `run-chair.js:114` writes 'error' for a chair that failed after retry +
-// fallback promotion, 'skipped' (:89) for one the cost ceiling skipped.
+// skipped / error, and `run-chair.js :: chairStatus` writes 'error' for a chair that failed after retry +
+// fallback promotion, 'skipped' (run-chair.js :: skippedForCost) for one the cost ceiling skipped.
 function degradedReason(run) {
   // exit-1 path: the engine wrote a structured {code, message}.
   if (run.error && run.error.code) { return `${run.error.code}: ${run.error.message}`; }
@@ -142,13 +142,32 @@ function degradedReason(run) {
   return null;
 }
 
+// v4.9 W8 T-B: `intent` rides this payload so the renderer can label a task run's
+// chip `ANSWER:` (electron/workspace-ui/workspace-matrix.js :: renderVerdict is a
+// plain browser script and cannot require() src/, so a fork key it cannot read is
+// a fork it cannot make). Unlike verdict.json — emit-when-'task' per the W5 ruling,
+// because that artifact has a byte-identity contract — this is an in-memory IPC
+// model whose literal is CLOSED and always materializes every key with a default,
+// so `intent` is materialized both ways and defaults to 'review'. The renderer
+// still treats an ABSENT key as review: pre-v4.9 payloads carry none.
+// ⚠️ v4.9 fix round 2 (council B2): sourced from `run` as well as `verdict`.
+// Reading `verdict.intent` ALONE meant the two panels that exist to explain a
+// broken run could not label it: on the narrow leg where a task run exits before
+// the verdict write — or leaves a truncated one — there is no verdict.intent to
+// read, and the panel defaulted to review, so the Workspace chip said "no chair
+// verdict" about a run that was never on that scale. `run.json` checkpoints
+// `intent: 'task'` at start (run.js :: runCouncil) and `run` is already this
+// function's first parameter, so the honest source costs nothing to reach.
 function verdictPanel(run, verdict) {
   const reason = degradedReason(run);
+  // PR #200 round-5 B3: parens on the whole disjunction — behaviour-identical.
+  const intent = ((verdict && verdict.intent === 'task') || (run && run.intent === 'task')) ? 'task' : 'review';
   if (!verdict || verdict.parseError) {
-    return { present: false, overallVerdict: null, tierCounts: null, streetCred: [], decisions: [], reason };
+    return { present: false, overallVerdict: null, tierCounts: null, streetCred: [], decisions: [], reason, intent };
   }
   return {
     present: true,
+    intent,
     overallVerdict: verdict.overallVerdict === undefined ? null : verdict.overallVerdict,
     tierCounts: verdict.tierCounts || null,
     streetCred: Array.isArray(verdict.streetCred) ? verdict.streetCred : [],
@@ -233,11 +252,18 @@ function getRunDetail(project, runId) {
       // of a copy of the question makes that divergence unrepresentable.
       seatSpace: isSeatTable(run.seats),
       // ⚠️ Fix-wave 3 (council-3 C2): seats[] is PRESENT but unusable, so the run silently
-      // lost per-seat behaviour — two seats on one model become indistinguishable in every
-      // panel. isSeatTable fails WHOLE (one malformed entry drops the entire table), which
-      // is the fail-safe direction but is exactly the correct-but-silent degrade the product
-      // principle rejects. Emitted here, beside the predicate that decides it, rather than
-      // re-derived renderer-side; workspace-app.js's renderBanners is its only consumer.
+      // lost per-seat ARTIFACT NAMING — two seats on one model become indistinguishable in
+      // the reviews/judges/re-vote panels, whose roster this flag sends back to `bench`
+      // (workspace-lazy.js :: roster). isSeatTable fails WHOLE (one malformed entry drops the
+      // entire table), which is the fail-safe direction but is exactly the correct-but-silent
+      // degrade the product principle rejects. Emitted here, beside the predicate that decides
+      // it, rather than re-derived renderer-side; workspace-banners.js is its only consumer.
+      // ⚠️ "in every panel" — what this comment said until v4.9 W9 — was already FALSE when
+      // written, and W9's PR5b-1 measured it: `costPanel` above maps `tally.runStats`, whose
+      // `seat` is stamped from the in-memory seat at assembly (run-stats-entry.js ::
+      // buildRunStatsEntry), so the seats panel keeps one row per seat no matter what
+      // run.seats looks like. Ruling V15 discloses that split in the banner rather than
+      // forcing the seats panel down to `seatSpace` for uniformity.
       // NOT the same as `!seatSpace`: a run with no seats[] at all is a legacy run, not a
       // broken one, and must not be bannered.
       seatTableRejected: Array.isArray(run.seats) && run.seats.length > 0 && !isSeatTable(run.seats),

package/src/workspace/seat-space.js

@@ -75,18 +75,22 @@ function isSeatTable(seats) {
  * bound seat a `rebuttal-` an orphan may have written, re-arming RN-1 in the debate
  * namespace (MEASURED; the one regression this fix wave introduced). The question is:
  * does the note POSITIVELY PROVE the orphan did NOT write this kind? Exactly one such
- * proof exists. `orphanLegNote` has three call sites — run-stages.js:71 and :140 (Stage-1
- * and its retry) and run-stage2.js:110 (the -s2 judge wave) — and `data.waveId` separates
- * them EXACTLY, not heuristically: run-stage2.js:67/69/90 build it as `${runId}-s2` from
+ * proof exists. `orphanLegNote` has three call sites — two in run-stages.js :: runStage1
+ * (Stage-1's own bind and its retry pass; cited `:71 and :140` until the v4.9 W9 fix round
+ * moved a builder out of that function and both numbers rotted — anchored by SYMBOL now, per
+ * the anti-rot rule) and run-stage2.js :: bindStage2Seats (the -s2 judge wave) — and
+ * `data.waveId` separates them EXACTLY, not heuristically: run-stage2.js :: bindStage2Seats
+ * and the launch site in run-stage2.js :: runStage2 both build it as `${runId}-s2` from
  * the runId this run.json carries. A -s2 note says the leg BOUND in Stage 1, so its review
  * landed under a SEAT name: `review-<alias>.md` is provably not its. Nothing else is
  * provable, and the near misses are why:
  *   - a Stage-1 note exonerates NOTHING, not even judge-: that orphan is re-admitted to
- *     Stage 2 under a PLACEHOLDER seat (run-stage2.js:92-97) that `judgeSeatOf` filters out
- *     (:105-107), so its judge leg takes the alias branch too — and emits no -s2 note,
+ *     Stage 2 under a PLACEHOLDER seat that stage1-bind.js :: bindPaddedWave pads in and
+ *     drops from `judgeSeatOf` (called from run-stage2.js :: bindStage2Seats since the
+ *     v4.9 W2 split), so its judge leg takes the alias branch too — and emits no -s2 note,
  *     because it BOUND. Measured: run-stages.test.js :: "M2: the placeholder never becomes…".
  *   - rebuttal-/revote- are never exonerated: a debate leg whose raiser/judge key names no
- *     seat takes materializeDebate's alias branch (run-debate.js :: runDebate;
+ *     seat takes materializeDebate's alias branch (run-debate.js :: runDefenseWave;
  *     run-debate-revote.js :: runRevoteWave, `seat = seatOf.get(leg) || null`). A rebuttal
  *     leg's unbound raiser still has no note recording it. A revote leg's unbound judge
  *     SOMETIMES gets one, since v4.8 T5.1 (channel `seat-unbound`, run-debate-revote.js's